[jira] [Comment Edited] (CALCITE-4118) RexSimplify might remove CAST from RexNode incorrectly

2020-07-09 Thread Shuo Cheng (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17155086#comment-17155086 ] Shuo Cheng edited comment on CALCITE-4118 at 7/10/20, 4:12 AM: ---

[jira] [Commented] (CALCITE-4118) RexSimplify might remove CAST from RexNode incorrectly

2020-07-09 Thread Shuo Cheng (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17155086#comment-17155086 ] Shuo Cheng commented on CALCITE-4118: - [~kgyrtkirk], please have a look. There is a approximate PR

[jira] [Created] (CALCITE-4118) RexSimplify might remove CAST from RexNode incorrectly

2020-07-09 Thread Shuo Cheng (Jira)
Shuo Cheng created CALCITE-4118: --- Summary: RexSimplify might remove CAST from RexNode incorrectly Key: CALCITE-4118 URL: https://issues.apache.org/jira/browse/CALCITE-4118 Project: Calcite

[jira] [Comment Edited] (CALCITE-4115) Improve the prompt of using SQL keywords for sql parser

2020-07-09 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17155050#comment-17155050 ] Danny Chen edited comment on CALCITE-4115 at 7/10/20, 2:33 AM: --- I want

[jira] [Commented] (CALCITE-4115) Improve the prompt of using SQL keywords for sql parser

2020-07-09 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17155050#comment-17155050 ] Danny Chen commented on CALCITE-4115: - I want the message to be only in the contexts where an

[jira] [Commented] (CALCITE-3956) Unify comparison logic for RelOptCost

2020-07-09 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17155008#comment-17155008 ] Julian Hyde commented on CALCITE-3956: -- Reviewing the [latest commit in the

[jira] [Comment Edited] (CALCITE-4099) Unify Strong.Policy and NullPolicy

2020-07-09 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17155005#comment-17155005 ] Julian Hyde edited comment on CALCITE-4099 at 7/10/20, 12:21 AM: - Maybe

[jira] [Commented] (CALCITE-4099) Unify Strong.Policy and NullPolicy

2020-07-09 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17155005#comment-17155005 ] Julian Hyde commented on CALCITE-4099: -- Maybe they should be brought into {{ReturnTypeInference}}.

[jira] [Commented] (CALCITE-4094) Allow SqlOperator of SqlKind#OTHER_FUNCTION to define a Strong.Policy

2020-07-09 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17155003#comment-17155003 ] Julian Hyde commented on CALCITE-4094: -- Also, the doc for UDFs needs to be updated. > Allow

[jira] [Commented] (CALCITE-4094) Allow SqlOperator of SqlKind#OTHER_FUNCTION to define a Strong.Policy

2020-07-09 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17155002#comment-17155002 ] Julian Hyde commented on CALCITE-4094: -- Review comments: * Don't comment out large chunks of code

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-07-09 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154893#comment-17154893 ] Julian Hyde commented on CALCITE-3786: -- I was mistaken. It actually affected multiple {{RelNode}}

[jira] [Commented] (CALCITE-4112) Better judgment "config.forceDecorrelate" in DecorrelateProgram

2020-07-09 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154801#comment-17154801 ] Julian Hyde commented on CALCITE-4112: -- The PR looks good but I don't understand the bug title

[jira] [Comment Edited] (CALCITE-4112) Better judgment "config.forceDecorrelate" in DecorrelateProgram

2020-07-09 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154801#comment-17154801 ] Julian Hyde edited comment on CALCITE-4112 at 7/9/20, 6:51 PM: --- The PR

[jira] [Commented] (CALCITE-4079) Dialect constants in SqlDialect can cause class initialization deadlock

2020-07-09 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154788#comment-17154788 ] Julian Hyde commented on CALCITE-4079: -- CALCITE-4079 is blocked by CALCITE-4117, which means that

[jira] [Commented] (CALCITE-3923) Refactor how planner rules are parameterized

2020-07-09 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154787#comment-17154787 ] Julian Hyde commented on CALCITE-3923: -- CALCITE-3923 is blocked by CALCITE-4117, which means that

[jira] [Created] (CALCITE-4117) Release Calcite 1.24.0

2020-07-09 Thread Julian Hyde (Jira)
Julian Hyde created CALCITE-4117: Summary: Release Calcite 1.24.0 Key: CALCITE-4117 URL: https://issues.apache.org/jira/browse/CALCITE-4117 Project: Calcite Issue Type: Bug

[jira] [Commented] (CALCITE-4115) Improve the prompt of using SQL keywords for sql parser

2020-07-09 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154773#comment-17154773 ] Julian Hyde commented on CALCITE-4115: -- Do you propose to give the improved message only in

[jira] [Resolved] (CALCITE-4096) Change Pair.hashCode() not to use XOR

2020-07-09 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-4096. Resolution: Not A Problem Opened a new JIRA to use FlatList instead of Pair:

[jira] [Commented] (CALCITE-4108) ClassCastException: java.lang.Float cannot be cast to java.lang.Double

2020-07-09 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154481#comment-17154481 ] Feng Zhu commented on CALCITE-4108: --- [~rr111], I have tested both branch-1.23 and master branch.

[jira] [Commented] (CALCITE-4108) ClassCastException: java.lang.Float cannot be cast to java.lang.Double

2020-07-09 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154477#comment-17154477 ] Feng Zhu commented on CALCITE-4108: --- I still cannot reproduce it. Test case1: both *tp* and *o* in

[jira] [Updated] (CALCITE-4115) Improve the prompt of using SQL keywords for sql parser

2020-07-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CALCITE-4115: Labels: pull-request-available (was: ) > Improve the prompt of using SQL keywords for

[jira] [Comment Edited] (CALCITE-4115) Improve the prompt of using SQL keywords for sql parser

2020-07-09 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154398#comment-17154398 ] Danny Chen edited comment on CALCITE-4115 at 7/9/20, 9:45 AM: -- Finally i

[jira] [Commented] (CALCITE-4115) Improve the prompt of using SQL keywords for sql parser

2020-07-09 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154398#comment-17154398 ] Danny Chen commented on CALCITE-4115: - Finally i found it is hard to give a proper fix suggestion,

[jira] [Updated] (CALCITE-4116) Remove unused code for tracking RexNode's nullable state in codegen

2020-07-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CALCITE-4116: Labels: pull-request-available (was: ) > Remove unused code for tracking RexNode's

[jira] [Created] (CALCITE-4116) Remove unused code for tracking RexNode's nullable state in codegen

2020-07-09 Thread Feng Zhu (Jira)
Feng Zhu created CALCITE-4116: - Summary: Remove unused code for tracking RexNode's nullable state in codegen Key: CALCITE-4116 URL: https://issues.apache.org/jira/browse/CALCITE-4116 Project: Calcite

[jira] [Created] (CALCITE-4115) Improve the prompt of using SQL keywords for sql parser

2020-07-09 Thread Danny Chen (Jira)
Danny Chen created CALCITE-4115: --- Summary: Improve the prompt of using SQL keywords for sql parser Key: CALCITE-4115 URL: https://issues.apache.org/jira/browse/CALCITE-4115 Project: Calcite

[jira] [Commented] (CALCITE-4108) ClassCastException: java.lang.Float cannot be cast to java.lang.Double

2020-07-09 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154372#comment-17154372 ] Feng Zhu commented on CALCITE-4108: --- [~rr111], thanks for your feedback, I will make another try.

[jira] [Commented] (CALCITE-4108) ClassCastException: java.lang.Float cannot be cast to java.lang.Double

2020-07-09 Thread Roman Churganov (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154369#comment-17154369 ] Roman Churganov commented on CALCITE-4108: -- tp.o type doesn't matter for this case >

[jira] [Commented] (CALCITE-4108) ClassCastException: java.lang.Float cannot be cast to java.lang.Double

2020-07-09 Thread Roman Churganov (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154368#comment-17154368 ] Roman Churganov commented on CALCITE-4108: -- Are you using a JDBC Data Source? must be JDBC >

[jira] [Resolved] (CALCITE-4094) Allow SqlOperator of SqlKind#OTHER_FUNCTION to define a Strong.Policy

2020-07-09 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruben Q L resolved CALCITE-4094. Resolution: Fixed Done via

[jira] [Commented] (CALCITE-4114) Wrong name in AssertQuery#forceDecorrelate

2020-07-09 Thread Jiatao Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154223#comment-17154223 ] Jiatao Tao commented on CALCITE-4114: - !image-2020-07-09-14-34-52-644.png|width=469,height=178! >

[jira] [Updated] (CALCITE-4114) Wrong name in AssertQuery#forceDecorrelate

2020-07-09 Thread Jiatao Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiatao Tao updated CALCITE-4114: Attachment: image-2020-07-09-14-34-52-644.png > Wrong name in AssertQuery#forceDecorrelate >

[jira] [Created] (CALCITE-4114) Wrong name in AssertQuery#forceDecorrelate

2020-07-09 Thread Jiatao Tao (Jira)
Jiatao Tao created CALCITE-4114: --- Summary: Wrong name in AssertQuery#forceDecorrelate Key: CALCITE-4114 URL: https://issues.apache.org/jira/browse/CALCITE-4114 Project: Calcite Issue Type:

[jira] [Updated] (CALCITE-4112) Better judgment "config.forceDecorrelate" in DecorrelateProgram

2020-07-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CALCITE-4112: Labels: pull-request-available (was: ) > Better judgment "config.forceDecorrelate" in