[jira] [Resolved] (CALCITE-4139) Prevent NPE in ListTransientTable

2020-07-27 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruben Q L resolved CALCITE-4139. Resolution: Fixed Fixed via https://github.com/apache/calcite/commit/b7aad0b9b6b090362b681bf47a1

[jira] [Commented] (CALCITE-3780) SESSION Table-valued Function

2020-07-27 Thread liupengcheng (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17166192#comment-17166192 ] liupengcheng commented on CALCITE-3780: --- +1 for make the keyCol optional, just li

[jira] [Assigned] (CALCITE-4118) RexSimplify might remove CAST from RexNode incorrectly

2020-07-27 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei reassigned CALCITE-4118: Assignee: Chunwei Lei > RexSimplify might remove CAST from RexNode incorrectly > ---

[jira] [Commented] (CALCITE-3780) SESSION Table-valued Function

2020-07-27 Thread duli (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17166179#comment-17166179 ] duli commented on CALCITE-3780: --- If we use window table function with group by clause, an

[jira] [Commented] (CALCITE-4143) Trim fields after XXProjectTransposeRule

2020-07-27 Thread liupengcheng (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17166160#comment-17166160 ] liupengcheng commented on CALCITE-4143: --- [~Aron.tao] Can you give an example? I d

[jira] [Commented] (CALCITE-3780) SESSION Table-valued Function

2020-07-27 Thread Rui Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17166112#comment-17166112 ] Rui Wang commented on CALCITE-3780: --- [~duli] The use cases I have seen are always as

[jira] [Commented] (CALCITE-4118) RexSimplify might remove CAST from RexNode incorrectly

2020-07-27 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17166099#comment-17166099 ] Chunwei Lei commented on CALCITE-4118: -- I opened a PR: [https://github.com/apache/

[jira] [Commented] (CALCITE-4080) Allow character literals as column aliases, if SqlConformance.allowCharLiteralAlias()

2020-07-27 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17166092#comment-17166092 ] Chunwei Lei commented on CALCITE-4080: -- I thought it's an individual issue. Openin

[jira] [Commented] (CALCITE-3780) SESSION Table-valued Function

2020-07-27 Thread duli (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17166086#comment-17166086 ] duli commented on CALCITE-3780: --- Hi, [~amaliujia], the 'keycol' is required, but i think

[jira] [Commented] (CALCITE-4079) Dialect constants in SqlDialect can cause class initialization deadlock

2020-07-27 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17166001#comment-17166001 ] Julian Hyde commented on CALCITE-4079: -- [~zabetak], I appreciate the review. > Di

[jira] [Commented] (CALCITE-4079) Dialect constants in SqlDialect can cause class initialization deadlock

2020-07-27 Thread Stamatis Zampetakis (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165999#comment-17165999 ] Stamatis Zampetakis commented on CALCITE-4079: -- FWIW, I did a pass over 39

[jira] [Comment Edited] (CALCITE-4144) Reduce code generation and class loading overhead when getScalar in JaninoRexCompiler.

2020-07-27 Thread Stamatis Zampetakis (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165996#comment-17165996 ] Stamatis Zampetakis edited comment on CALCITE-4144 at 7/27/20, 10:26 PM:

[jira] [Commented] (CALCITE-4144) Reduce code generation and class loading overhead when getScalar in JaninoRexCompiler.

2020-07-27 Thread Stamatis Zampetakis (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165996#comment-17165996 ] Stamatis Zampetakis commented on CALCITE-4144: -- I think I understand the p

[jira] [Commented] (CALCITE-4137) Checkstyle should ensure that every class has a Javadoc comment

2020-07-27 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165971#comment-17165971 ] Julian Hyde commented on CALCITE-4137: -- [~vladimirsitnikov] The warnings in your e

[jira] [Commented] (CALCITE-4143) Trim fields after XXProjectTransposeRule

2020-07-27 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165908#comment-17165908 ] Julian Hyde commented on CALCITE-4143: -- I don't understand what you are proposing.

[jira] [Commented] (CALCITE-4079) Dialect constants in SqlDialect can cause class initialization deadlock

2020-07-27 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165904#comment-17165904 ] Julian Hyde commented on CALCITE-4079: -- Yeah, but what the hell. {{fieldExps}} is

[jira] [Commented] (CALCITE-4080) Allow character literals as column aliases, if SqlConformance.allowCharLiteralAlias()

2020-07-27 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165869#comment-17165869 ] Julian Hyde commented on CALCITE-4080: -- I've opened https://github.com/apache/calc

[jira] [Commented] (CALCITE-4144) Reduce code generation and class loading overhead when getScalar in JaninoRexCompiler.

2020-07-27 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165866#comment-17165866 ] Julian Hyde commented on CALCITE-4144: -- How many times per second are you executin

[jira] [Updated] (CALCITE-4139) Prevent NPE in ListTransientTable

2020-07-27 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruben Q L updated CALCITE-4139: --- Fix Version/s: 1.25.0 > Prevent NPE in ListTransientTable > - > >

[jira] [Commented] (CALCITE-4034) Implement a MySQL InnoDB adapter

2020-07-27 Thread neoremind (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165816#comment-17165816 ] neoremind commented on CALCITE-4034: [~julianhyde] I have addressed changes we are

[jira] [Commented] (CALCITE-4144) Reduce code generation and class loading overhead when getScalar in JaninoRexCompiler.

2020-07-27 Thread zhangchenghui (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165772#comment-17165772 ] zhangchenghui commented on CALCITE-4144: Since the storage layer in my project

[jira] [Commented] (CALCITE-4144) Reduce code generation and class loading overhead when getScalar in JaninoRexCompiler.

2020-07-27 Thread zhangchenghui (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165760#comment-17165760 ] zhangchenghui commented on CALCITE-4144: I relatively hate adding too much refl

[jira] [Updated] (CALCITE-4144) Reduce code generation and class loading overhead when getScalar in JaninoRexCompiler.

2020-07-27 Thread zhangchenghui (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangchenghui updated CALCITE-4144: --- Description: I used the FilterableTable mode in the project, but I found that the query was

[jira] [Created] (CALCITE-4144) Reduce code generation and class loading overhead when getScalar in JaninoRexCompiler.

2020-07-27 Thread zhangchenghui (Jira)
zhangchenghui created CALCITE-4144: -- Summary: Reduce code generation and class loading overhead when getScalar in JaninoRexCompiler. Key: CALCITE-4144 URL: https://issues.apache.org/jira/browse/CALCITE-4144

[jira] [Commented] (CALCITE-4080) Allow character literals as column aliases, if SqlConformance.allowCharLiteralAlias()

2020-07-27 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165685#comment-17165685 ] Chunwei Lei commented on CALCITE-4080: -- Julian, could you please open a pull reque