[jira] [Commented] (CALCITE-4644) Add PERCENTILE_CONT and PERCENTILE_DISC aggregate functions

2021-06-28 Thread Rafay A (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17371168#comment-17371168 ] Rafay A commented on CALCITE-4644: -- Thanks [~julianhyde] for reviewing and all the fee

[jira] [Commented] (CALCITE-4644) Add PERCENTILE_CONT and PERCENTILE_DISC aggregate functions

2021-06-28 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17371130#comment-17371130 ] Julian Hyde commented on CALCITE-4644: -- You should cherry-pick my commits. ({{git

[jira] [Commented] (CALCITE-4644) Add PERCENTILE_CONT and PERCENTILE_DISC aggregate functions

2021-06-28 Thread Rafay A (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17371128#comment-17371128 ] Rafay A commented on CALCITE-4644: -- [~julianhyde] I get it now. So i was initially on

[jira] [Commented] (CALCITE-4644) Add PERCENTILE_CONT and PERCENTILE_DISC aggregate functions

2021-06-28 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17371059#comment-17371059 ] Julian Hyde commented on CALCITE-4644: -- [~Rafay], Please see [julianhyde/4644-per

[jira] [Commented] (CALCITE-4644) Add PERCENTILE_CONT and PERCENTILE_DISC aggregate functions

2021-06-28 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17371031#comment-17371031 ] Julian Hyde commented on CALCITE-4644: -- Ah, now I understand that you had removed

[jira] [Comment Edited] (CALCITE-4599) Support push-down of "date histogram aggregation" in elastic search adapter

2021-06-28 Thread Jacky Yin (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370444#comment-17370444 ] Jacky Yin edited comment on CALCITE-4599 at 6/29/21, 2:53 AM: ---

[jira] [Comment Edited] (CALCITE-4668) RelBuilder.join should only emit a correlate when a correlate variable is used

2021-06-28 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370963#comment-17370963 ] James Starr edited comment on CALCITE-4668 at 6/29/21, 12:06 AM:

[jira] [Commented] (CALCITE-4668) RelBuilder.join should only emit a correlate when a correlate variable is used

2021-06-28 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370963#comment-17370963 ] James Starr commented on CALCITE-4668: -- [~julianhyde] What if we add another thre

[jira] [Comment Edited] (CALCITE-4669) Allow empty MAP[] constructors

2021-06-28 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370957#comment-17370957 ] Julian Hyde edited comment on CALCITE-4669 at 6/28/21, 11:57 PM:

[jira] [Updated] (CALCITE-4669) Allow empty MAP[] constructors

2021-06-28 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-4669: - Description: Please allow empty MAP expressions: {code:sql} SELECT MAP[] FROM foo; {code} Curre

[jira] [Commented] (CALCITE-4669) Allow empty MAP[] constructors

2021-06-28 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370957#comment-17370957 ] Julian Hyde commented on CALCITE-4669: -- As noted in CALCITE-3504, Calcite's SQL is

[jira] [Commented] (CALCITE-4668) RelBuilder.join should only emit a correlate when a correlate variable is used

2021-06-28 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370955#comment-17370955 ] Julian Hyde commented on CALCITE-4668: -- Could you try changing "e.deptno = d.deptn

[jira] [Commented] (CALCITE-2322) Add fetch size support to connection url and JDBC statement

2021-06-28 Thread Zac (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370948#comment-17370948 ] Zac commented on CALCITE-2322: -- Thanks for the guidance [~julianhyde]! I'll open an update

[jira] [Comment Edited] (CALCITE-2322) Add fetch size support to connection url and JDBC statement

2021-06-28 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370941#comment-17370941 ] Julian Hyde edited comment on CALCITE-2322 at 6/28/21, 11:28 PM:

[jira] [Created] (CALCITE-4671) Allow Avatica connect-string properties in any case (lowerCamel, UPPER_SNAKE, etc.)

2021-06-28 Thread Julian Hyde (Jira)
Julian Hyde created CALCITE-4671: Summary: Allow Avatica connect-string properties in any case (lowerCamel, UPPER_SNAKE, etc.) Key: CALCITE-4671 URL: https://issues.apache.org/jira/browse/CALCITE-4671

[jira] [Commented] (CALCITE-2322) Add fetch size support to connection url and JDBC statement

2021-06-28 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370941#comment-17370941 ] Julian Hyde commented on CALCITE-2322: -- Sorry, cancel that. I didn't read the cont

[jira] [Comment Edited] (CALCITE-4668) RelBuilder.join should only emit a correlate when a correlate variable is used

2021-06-28 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370846#comment-17370846 ] James Starr edited comment on CALCITE-4668 at 6/28/21, 11:06 PM:

[jira] [Comment Edited] (CALCITE-4668) RelBuilder.join should only emit a correlate when a correlate variable is used

2021-06-28 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370846#comment-17370846 ] James Starr edited comment on CALCITE-4668 at 6/28/21, 11:06 PM:

[jira] [Comment Edited] (CALCITE-2322) Add fetch size support to connection url and JDBC statement

2021-06-28 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370933#comment-17370933 ] Julian Hyde edited comment on CALCITE-2322 at 6/28/21, 11:04 PM:

[jira] [Commented] (CALCITE-2322) Add fetch size support to connection url and JDBC statement

2021-06-28 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370933#comment-17370933 ] Julian Hyde commented on CALCITE-2322: -- Properties are defined in [class CalciteC

[jira] [Commented] (CALCITE-2322) Add fetch size support to connection url and JDBC statement

2021-06-28 Thread Zac (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370891#comment-17370891 ] Zac commented on CALCITE-2322: -- Hey all. I'm hoping to help get this PR finished up. It se

[jira] [Created] (CALCITE-4670) Support PERCENTILE_DISC for any sortable type and PERCENTILE_CONT for interval types

2021-06-28 Thread Rafay A (Jira)
Rafay A created CALCITE-4670: Summary: Support PERCENTILE_DISC for any sortable type and PERCENTILE_CONT for interval types Key: CALCITE-4670 URL: https://issues.apache.org/jira/browse/CALCITE-4670 Projec

[jira] [Commented] (CALCITE-4668) RelBuilder.join should only emit a correlate when a correlate variable is used

2021-06-28 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370846#comment-17370846 ] James Starr commented on CALCITE-4668: -- {quote} Where does that scan occur? {quote

[jira] [Updated] (CALCITE-4669) Allow empty MAP[] constructors

2021-06-28 Thread Jiefan Li (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiefan Li updated CALCITE-4669: --- Description: Similar ticket: https://issues.apache.org/jira/browse/CALCITE-3504 Currently a MAP ex

[jira] [Created] (CALCITE-4669) Allow empty MAP[] constructors

2021-06-28 Thread Jiefan Li (Jira)
Jiefan Li created CALCITE-4669: -- Summary: Allow empty MAP[] constructors Key: CALCITE-4669 URL: https://issues.apache.org/jira/browse/CALCITE-4669 Project: Calcite Issue Type: Wish R

[jira] [Commented] (CALCITE-4668) RelBuilder.join should only emit a correlate when a correlate variable is used

2021-06-28 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370828#comment-17370828 ] Julian Hyde commented on CALCITE-4668: -- {quote}If the test wanted to tests a parti

[jira] [Commented] (CALCITE-4668) RelBuilder.join should only emit a correlate when a correlate variable is used

2021-06-28 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370825#comment-17370825 ] Julian Hyde commented on CALCITE-4668: -- {quote}We already scan the entire left sid

[jira] [Commented] (CALCITE-4668) RelBuilder.join should only emit a correlate when a correlate variable is used

2021-06-28 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370775#comment-17370775 ] James Starr commented on CALCITE-4668: -- [~julianhyde] ??James Starr, This seems l

[jira] [Updated] (CALCITE-4668) RelBuilder.join should only emit a correlate when a correlate variable is used

2021-06-28 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Starr updated CALCITE-4668: - Summary: RelBuilder.join should only emit a correlate when a correlate variable is used (was:

[jira] [Commented] (CALCITE-4644) Add PERCENTILE_CONT and PERCENTILE_DISC aggregate functions

2021-06-28 Thread Rafay A (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370727#comment-17370727 ] Rafay A commented on CALCITE-4644: -- [~julianhyde] I'll open a new ticket for tracking

[jira] [Commented] (CALCITE-4644) Add PERCENTILE_CONT and PERCENTILE_DISC aggregate functions

2021-06-28 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370677#comment-17370677 ] Julian Hyde commented on CALCITE-4644: -- I’d remove TODOs. They don’t help maintain

[jira] [Commented] (CALCITE-4668) RelBuilder.join should only emit a correlate when a correlate variable exists

2021-06-28 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370666#comment-17370666 ] Julian Hyde commented on CALCITE-4668: -- [~jamesstarr], This seems like a useful ch