[jira] [Updated] (CALCITE-5537) Slow test case failures in LatticeSuggesterTest

2023-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CALCITE-5537: Labels: pull-request-available (was: ) > Slow test case failures in

[jira] [Assigned] (CALCITE-5537) Slow test case failures in LatticeSuggesterTest

2023-02-21 Thread peng wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peng wang reassigned CALCITE-5537: -- Assignee: peng wang > Slow test case failures in LatticeSuggesterTest >

[jira] [Commented] (CALCITE-5538) SQL parser rejects timestamp literals that end with 0 after the period

2023-02-21 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691864#comment-17691864 ] Julian Hyde commented on CALCITE-5538: -- Negative years might be more complicated than you imagine.

[jira] [Updated] (CALCITE-5538) SQL parser rejects timestamp literals that end with 0 after the period

2023-02-21 Thread Mihai Budiu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mihai Budiu updated CALCITE-5538: - Description: The root cause is that the TimestampString constructor validates a string

[jira] [Commented] (CALCITE-5268) Add QUALIFY clause

2023-02-21 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691855#comment-17691855 ] Julian Hyde commented on CALCITE-5268: -- And thank you for hanging in there and getting this

[jira] [Commented] (CALCITE-5477) Compatibility with Guava < 20.0

2023-02-21 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691852#comment-17691852 ] Julian Hyde commented on CALCITE-5477: -- Great. You are a committer, so feel free to merge a commit

[jira] [Commented] (CALCITE-5538) Calcite rejects timestamp literals that end with 0 after the period

2023-02-21 Thread Mihai Budiu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691850#comment-17691850 ] Mihai Budiu commented on CALCITE-5538: -- In postgres the following is a legal timestamp: TIMESTAMP

[jira] [Updated] (CALCITE-5420) SqlToRel should populate the correlate id of a Project for queries with aggregates

2023-02-21 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-5420: - Summary: SqlToRel should populate the correlate id of a Project for queries with aggregates

[jira] [Commented] (CALCITE-5538) Calcite rejects timestamp literals that end with 0 after the period

2023-02-21 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691848#comment-17691848 ] Julian Hyde commented on CALCITE-5538: -- I agree that disallowing the trailing zero is a bug.

[jira] [Commented] (CALCITE-5538) Calcite rejects timestamp literals that end with 0 after the period

2023-02-21 Thread Mihai Budiu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691791#comment-17691791 ] Mihai Budiu commented on CALCITE-5538: -- BTW: this also rejects timestamps with negative year

[jira] [Created] (CALCITE-5538) Calcite rejects timestamp literals that end with 0 after the period

2023-02-21 Thread Mihai Budiu (Jira)
Mihai Budiu created CALCITE-5538: Summary: Calcite rejects timestamp literals that end with 0 after the period Key: CALCITE-5538 URL: https://issues.apache.org/jira/browse/CALCITE-5538 Project:

[jira] [Commented] (CALCITE-5420) SqlToRel should populate projects corralate id for queries with aggregates.

2023-02-21 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691753#comment-17691753 ] James Starr commented on CALCITE-5420: -- [~libenchao] Could you please look at

[jira] [Commented] (CALCITE-5477) Compatibility with Guava < 20.0

2023-02-21 Thread Gian Merlino (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691732#comment-17691732 ] Gian Merlino commented on CALCITE-5477: --- That sounds fair enough. I will try this approach out,

[jira] [Commented] (CALCITE-5268) Add QUALIFY clause

2023-02-21 Thread Brandon Chong (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691719#comment-17691719 ] Brandon Chong commented on CALCITE-5268: No problem :)  Thank you for the thoughtful reviews

[jira] [Commented] (CALCITE-5510) RelToSqlConverter should use ordinal for ORDER BY if the dialect allows

2023-02-21 Thread peng wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691560#comment-17691560 ] peng wang commented on CALCITE-5510: [~libenchao] If you have time, please review this PR again,

[jira] [Commented] (CALCITE-5510) RelToSqlConverter should use ordinal for ORDER BY if the dialect allows

2023-02-21 Thread peng wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691559#comment-17691559 ] peng wang commented on CALCITE-5510: Log in [https://issues.apache.org/jira/browse/CALCITE-5537].

[jira] [Commented] (CALCITE-5537) Slow test case failures in LatticeSuggesterTest

2023-02-21 Thread peng wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691557#comment-17691557 ] peng wang commented on CALCITE-5537: Found by [https://issues.apache.org/jira/browse/CALCITE-5510]

[jira] [Created] (CALCITE-5537) Slow test case failures in LatticeSuggesterTest

2023-02-21 Thread peng wang (Jira)
peng wang created CALCITE-5537: -- Summary: Slow test case failures in LatticeSuggesterTest Key: CALCITE-5537 URL: https://issues.apache.org/jira/browse/CALCITE-5537 Project: Calcite Issue Type:

[jira] [Commented] (CALCITE-5510) RelToSqlConverter should use ordinal for ORDER BY if the dialect allows

2023-02-21 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691548#comment-17691548 ] Benchao Li commented on CALCITE-5510: - [~peng713128] Would you help to log another Jira, and open a

[jira] [Commented] (CALCITE-5510) RelToSqlConverter should use ordinal for ORDER BY if the dialect allows

2023-02-21 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691547#comment-17691547 ] Benchao Li commented on CALCITE-5510: - [~peng713128] Thanks for your update. If they are not caused

[jira] [Commented] (CALCITE-5510) RelToSqlConverter should use ordinal for ORDER BY if the dialect allows

2023-02-21 Thread peng wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691539#comment-17691539 ] peng wang commented on CALCITE-5510: I fixed the test failure of LatticeTest#testSum. And I found