[jira] [Commented] (CALCITE-2448) AggregateProjectPullUpConstantsRule throws AssertionError

2018-08-06 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16570208#comment-16570208 ] Atri Sharma commented on CALCITE-2448: -- Can you add a patch for the fix? > Aggreg

[jira] [Commented] (CALCITE-2129) RelToSqlConverter incorrectly projects aggregate function from sub-query

2018-05-22 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16484326#comment-16484326 ] Atri Sharma commented on CALCITE-2129: -- [~julianhyde] I am hacking this and figured

[jira] [Issue Comment Deleted] (CALCITE-2129) RelToSqlConverter incorrectly projects aggregate function from sub-query

2018-05-22 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atri Sharma updated CALCITE-2129: - Comment: was deleted (was: PR: [https://github.com/apache/calcite/pull/695]   Please see and l

[jira] [Comment Edited] (CALCITE-2129) RelToSqlConverter incorrectly projects aggregate function from sub-query

2018-05-21 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16482711#comment-16482711 ] Atri Sharma edited comment on CALCITE-2129 at 5/21/18 5:00 PM: ---

[jira] [Assigned] (CALCITE-2129) RelToSqlConverter incorrectly projects aggregate function from sub-query

2018-05-21 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atri Sharma reassigned CALCITE-2129: Assignee: Atri Sharma (was: Julian Hyde) > RelToSqlConverter incorrectly projects aggreg

[jira] [Commented] (CALCITE-2129) RelToSqlConverter incorrectly projects aggregate function from sub-query

2018-05-21 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16482711#comment-16482711 ] Atri Sharma commented on CALCITE-2129: -- [~julianhyde] PR: [https://github.com/apach

[jira] [Commented] (CALCITE-2129) RelToSqlConverter incorrectly projects aggregate function from sub-query

2018-05-20 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16482227#comment-16482227 ] Atri Sharma commented on CALCITE-2129: -- [~julianhyde] I will take a crack at this,

[jira] [Commented] (CALCITE-2130) Converting subquery to join is not always giving equivalent behavior

2018-05-20 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16482226#comment-16482226 ] Atri Sharma commented on CALCITE-2130: -- [~julianhyde] I will like to take a crack a

[jira] [Commented] (CALCITE-500) Ensure EnumerableJoin hashes the smallest input

2018-05-17 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16479139#comment-16479139 ] Atri Sharma commented on CALCITE-500: - Fixed now, please review and let me know > En

[jira] [Commented] (CALCITE-500) Ensure EnumerableJoin hashes the smallest input

2018-05-17 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16479003#comment-16479003 ] Atri Sharma commented on CALCITE-500: - Ignore, somehow the tests did not break locall

[jira] [Commented] (CALCITE-500) Ensure EnumerableJoin hashes the smallest input

2018-05-17 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478903#comment-16478903 ] Atri Sharma commented on CALCITE-500: - PR: [https://github.com/apache/calcite/pull/6

[jira] [Commented] (CALCITE-873) Prevent sort when ORDER BY not necessary due to equality constraints

2018-05-16 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476971#comment-16476971 ] Atri Sharma commented on CALCITE-873: - [~julianhyde] I am reviving this PR with runni

[jira] [Commented] (CALCITE-500) Ensure EnumerableJoin hashes the smallest input

2017-07-13 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16085993#comment-16085993 ] Atri Sharma commented on CALCITE-500: - [~vladimirsitnikov] [~julianhyde] Please updat

[jira] [Commented] (CALCITE-1888) VolcanoPlanner should identify if transformed node and original node are identical

2017-07-12 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16084414#comment-16084414 ] Atri Sharma commented on CALCITE-1888: -- Quoting [~julianhyde]: "Is there a bug in

[jira] [Created] (CALCITE-1888) VolcanoPlanner should identify if transformed node and original node are identical

2017-07-12 Thread Atri Sharma (JIRA)
Atri Sharma created CALCITE-1888: Summary: VolcanoPlanner should identify if transformed node and original node are identical Key: CALCITE-1888 URL: https://issues.apache.org/jira/browse/CALCITE-1888

[jira] [Commented] (CALCITE-873) Prevent sort when ORDER BY not necessary due to equality constraints

2017-07-12 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16084397#comment-16084397 ] Atri Sharma commented on CALCITE-873: - [~julianhyde] Yes, I see no test failures in C

[jira] [Commented] (CALCITE-1345) Streaming GROUP BY

2017-07-12 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16084391#comment-16084391 ] Atri Sharma commented on CALCITE-1345: -- [~julianhyde] Please let me know > Streami

[jira] [Commented] (CALCITE-873) Prevent sort when ORDER BY not necessary due to equality constraints

2017-07-11 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16082548#comment-16082548 ] Atri Sharma commented on CALCITE-873: - [~julianhyde] Please let me know if this looks

[jira] [Commented] (CALCITE-500) Ensure EnumerableJoin hashes the smallest input

2017-07-10 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16080731#comment-16080731 ] Atri Sharma commented on CALCITE-500: - [~julianhyde] Please let me know if I am missi

[jira] [Comment Edited] (CALCITE-873) Prevent sort when ORDER BY not necessary due to equality constraints

2017-07-07 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16078520#comment-16078520 ] Atri Sharma edited comment on CALCITE-873 at 7/7/17 6:53 PM: -

[jira] [Commented] (CALCITE-873) Prevent sort when ORDER BY not necessary due to equality constraints

2017-07-07 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16078520#comment-16078520 ] Atri Sharma commented on CALCITE-873: - [~julianhyde] I fixed the tests and refactored

[jira] [Commented] (CALCITE-1345) Streaming GROUP BY

2017-07-06 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16077011#comment-16077011 ] Atri Sharma commented on CALCITE-1345: -- [~julianhyde] Looking at the test you wrote

[jira] [Commented] (CALCITE-500) Ensure EnumerableJoin hashes the smallest input

2017-07-05 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075201#comment-16075201 ] Atri Sharma commented on CALCITE-500: - [~julianhyde] I ran CalciteSuite with tracing

[jira] [Commented] (CALCITE-873) Prevent sort when ORDER BY not necessary due to equality constraints

2017-07-01 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071116#comment-16071116 ] Atri Sharma commented on CALCITE-873: - [~julianhyde] I have changed the test to the a

[jira] [Commented] (CALCITE-873) Prevent sort when ORDER BY not necessary due to equality constraints

2017-06-30 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070636#comment-16070636 ] Atri Sharma commented on CALCITE-873: - [~julianhyde] I added two tests, testSortConst

[jira] [Commented] (CALCITE-500) Ensure EnumerableJoin hashes the smallest input

2017-06-30 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070545#comment-16070545 ] Atri Sharma commented on CALCITE-500: - [~julianhyde] I see no unit tests with any of

[jira] [Commented] (CALCITE-1861) Spatial Indexes

2017-06-30 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070540#comment-16070540 ] Atri Sharma commented on CALCITE-1861: -- Spatial4j looks pretty good to me, I think

[jira] [Commented] (CALCITE-1861) Spatial Indexes

2017-06-30 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070493#comment-16070493 ] Atri Sharma commented on CALCITE-1861: -- [~julianhyde] Should I start by using the l

[jira] [Commented] (CALCITE-873) Prevent sort when ORDER BY not necessary due to equality constraints

2017-06-28 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067028#comment-16067028 ] Atri Sharma commented on CALCITE-873: - [~julianhyde] Thanks for your comments! 1) Fo

[jira] [Created] (CALCITE-1861) Spatial Indexes

2017-06-28 Thread Atri Sharma (JIRA)
Atri Sharma created CALCITE-1861: Summary: Spatial Indexes Key: CALCITE-1861 URL: https://issues.apache.org/jira/browse/CALCITE-1861 Project: Calcite Issue Type: Improvement Repor

[jira] [Commented] (CALCITE-1345) Streaming GROUP BY

2017-01-24 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15837212#comment-15837212 ] Atri Sharma commented on CALCITE-1345: -- [~cloneman] I have been trying out a PoC f

[jira] [Commented] (CALCITE-873) Prevent sort when ORDER BY not necessary due to equality constraints

2016-10-25 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15605854#comment-15605854 ] Atri Sharma commented on CALCITE-873: - Thanks, I will now refactor the CR > Prevent

[jira] [Commented] (CALCITE-873) Prevent sort when ORDER BY not necessary due to equality constraints

2016-10-25 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15605637#comment-15605637 ] Atri Sharma commented on CALCITE-873: - Super thanks, will refactor and update --

[jira] [Commented] (CALCITE-1368) Infer predicates for aggregate functions

2016-10-25 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15605088#comment-15605088 ] Atri Sharma commented on CALCITE-1368: -- [~julianhyde] What is the expected behaviou

[jira] [Commented] (CALCITE-873) Prevent sort when ORDER BY not necessary due to equality constraints

2016-10-25 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15605085#comment-15605085 ] Atri Sharma commented on CALCITE-873: - I will be waiting for completion of 1465 to re

[jira] [Commented] (CALCITE-873) Prevent sort when ORDER BY not necessary due to equality constraints

2016-10-23 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15600049#comment-15600049 ] Atri Sharma commented on CALCITE-873: - [~julianhyde] I added some tests, please see.

[jira] [Commented] (CALCITE-873) Prevent sort when ORDER BY not necessary due to equality constraints

2016-10-23 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15599258#comment-15599258 ] Atri Sharma commented on CALCITE-873: - [~jhyde.apa...@gmail.com] Please see a basic v

[jira] [Commented] (CALCITE-873) Prevent sort when ORDER BY not necessary due to equality constraints

2016-09-11 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15482139#comment-15482139 ] Atri Sharma commented on CALCITE-873: - I am planning to implement a rule which gets t

[jira] [Commented] (CALCITE-500) Ensure EnumerableJoin hashes the smallest input

2016-09-11 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15481896#comment-15481896 ] Atri Sharma commented on CALCITE-500: - Got that, I will run PlannerTest with tracing

[jira] [Commented] (CALCITE-500) Ensure EnumerableJoin hashes the smallest input

2016-09-11 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15481556#comment-15481556 ] Atri Sharma commented on CALCITE-500: - Thanks. I looked through EnumerableJoin but c

[jira] [Commented] (CALCITE-500) Ensure EnumerableJoin hashes the smallest input

2016-09-10 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15479734#comment-15479734 ] Atri Sharma commented on CALCITE-500: - I will fix this now assuming its still relevan

[jira] [Assigned] (CALCITE-500) Ensure EnumerableJoin hashes the smallest input

2016-09-10 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atri Sharma reassigned CALCITE-500: --- Assignee: Atri Sharma (was: Julian Hyde) > Ensure EnumerableJoin hashes the smallest input

[jira] [Commented] (CALCITE-873) Prevent sort when ORDER BY not necessary due to equality constraints

2016-06-25 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15349700#comment-15349700 ] Atri Sharma commented on CALCITE-873: - [~julianhyde] I would like to take this one. I

[jira] [Commented] (CALCITE-873) Prevent sort when ORDER BY not necessary due to equality constraints

2016-06-08 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322029#comment-15322029 ] Atri Sharma commented on CALCITE-873: - Yes, that is correct. +1 > Prevent sort when