[jira] [Updated] (CALCITE-4015) Pass through parent collation request on subset or superset of join keys for EnumerableMergeJoin

2020-06-06 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-4015: --- Summary: Pass through parent collation request on subset or superset of join keys for Enume

[jira] [Resolved] (CALCITE-4012) Implement trait propagation for EnumerableHashJoin and EnumerableNestedLoopJoin

2020-06-08 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-4012. Resolution: Fixed Fixed in  [https://github.com/apache/calcite/commit/eedd40bea825e0a00f5

[jira] [Resolved] (CALCITE-4007) MergeJoin collation check should not be limited to join key's order

2020-06-08 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-4007. Fix Version/s: 1.24.0 Resolution: Fixed Fixed in  [https://github.com/apache/calci

[jira] [Resolved] (CALCITE-4050) Traits Propagation for EnumerableMergeJoin Produces Incorrect Result

2020-06-08 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-4050. Fix Version/s: 1.24.0 Resolution: Fixed Fixed in  [https://github.com/apache/calci

[jira] [Commented] (CALCITE-4050) Traits Propagation for EnumerableMergeJoin Produces Incorrect Result

2020-06-08 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128722#comment-17128722 ] Haisheng Yuan commented on CALCITE-4050: The 1-1 mapping is OK, the problem is

[jira] [Resolved] (CALCITE-4041) Implement trait propagation for EnumerableCorrelate

2020-06-08 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-4041. Resolution: Fixed Fixed in  [https://github.com/apache/calcite/commit/61cf2bf30d0496cf795

[jira] [Commented] (CALCITE-4052) Enable Top-down Optimization

2020-06-08 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128824#comment-17128824 ] Haisheng Yuan commented on CALCITE-4052: +1, thanks! > Enable Top-down Optimiz

[jira] [Created] (CALCITE-4056) Remove Digest from RelNode and RexNode

2020-06-09 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-4056: -- Summary: Remove Digest from RelNode and RexNode Key: CALCITE-4056 URL: https://issues.apache.org/jira/browse/CALCITE-4056 Project: Calcite Issue Type: Im

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-09 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17129415#comment-17129415 ] Haisheng Yuan commented on CALCITE-3786: I noticed Danny opened a pull request,

[jira] [Commented] (CALCITE-4018) EnumerableValues should provide requested traits

2020-06-09 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17129902#comment-17129902 ] Haisheng Yuan commented on CALCITE-4018: Pull request: [https://github.com/apac

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-09 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130096#comment-17130096 ] Haisheng Yuan commented on CALCITE-3786: I am sorry for disappointing you, I sh

[jira] [Commented] (CALCITE-2648) Output collation of EnumerableWindow is not consistent with its implementation

2020-06-09 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130133#comment-17130133 ] Haisheng Yuan commented on CALCITE-2648: Pull request: https://github.com/apach

[jira] [Resolved] (CALCITE-4003) In MaterializationTest, FilterProjectTransposeRule matches with logical and physical convention

2020-06-10 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-4003. Fix Version/s: 1.24.0 Resolution: Fixed Fixed in https://github.com/apache/calcit

[jira] [Resolved] (CALCITE-4002) Add security check to make sure TransformationRule doesn't generate PhysicalNode

2020-06-10 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-4002. Fix Version/s: 1.24.0 Resolution: Fixed Fixed in https://github.com/apache/calcit

[jira] [Resolved] (CALCITE-4018) EnumerableValues should provide requested traits

2020-06-10 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-4018. Resolution: Fixed Fixed in https://github.com/apache/calcite/commit/7c5c7e3b77b6a7606e12

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-10 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132573#comment-17132573 ] Haisheng Yuan commented on CALCITE-3786: The digest of RelNode in the patch doe

[jira] [Commented] (CALCITE-4008) Implement Code generation for EnumerableSortedAggregate

2020-06-10 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132752#comment-17132752 ] Haisheng Yuan commented on CALCITE-4008: Sorry to replying late. Let's focus on

[jira] [Created] (CALCITE-4058) Add Limit and LogicalLimit operator and deprecate limit in Sort

2020-06-10 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-4058: -- Summary: Add Limit and LogicalLimit operator and deprecate limit in Sort Key: CALCITE-4058 URL: https://issues.apache.org/jira/browse/CALCITE-4058 Project: Calcit

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-10 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132916#comment-17132916 ] Haisheng Yuan commented on CALCITE-3786: {quote} That's not true, for RelNode w

[jira] [Commented] (CALCITE-4058) Add Limit and LogicalLimit operator and deprecate limit in Sort

2020-06-11 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133249#comment-17133249 ] Haisheng Yuan commented on CALCITE-4058: You mean objections? I would love to h

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-11 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133799#comment-17133799 ] Haisheng Yuan commented on CALCITE-3786: {quote} Even we are with these additi

[jira] [Updated] (CALCITE-4013) Remove traitset derivation when creating logical operators

2020-06-12 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-4013: --- Attachment: image-2020-06-12-08-46-26-846.png > Remove traitset derivation when creating lo

[jira] [Commented] (CALCITE-4013) Remove traitset derivation when creating logical operators

2020-06-12 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134228#comment-17134228 ] Haisheng Yuan commented on CALCITE-4013: LogicalFilter takes more: !image-2020

[jira] [Commented] (CALCITE-4023) Remove or deprecate ProjectSortTransposeRule

2020-06-13 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134926#comment-17134926 ] Haisheng Yuan commented on CALCITE-4023: Exactly, on the other hand, it implies

[jira] [Resolved] (CALCITE-4057) Implement trait propagation for EnumerableBatchNestedLoopJoin

2020-06-13 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-4057. Fix Version/s: 1.24.0 Resolution: Fixed Fixed in  [https://github.com/apache/calci

[jira] [Commented] (CALCITE-4027) Add -Doverwrite option to SqlToRelTestBase

2020-06-13 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134997#comment-17134997 ] Haisheng Yuan commented on CALCITE-4027: [~xzh_dz] Thanks for working on this.

[jira] [Commented] (CALCITE-4027) Add -Doverwrite option to SqlToRelTestBase

2020-06-13 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135002#comment-17135002 ] Haisheng Yuan commented on CALCITE-4027: You don't need to manually update the

[jira] [Commented] (CALCITE-4033) SqlNode.toSqlString generates wrong query for syntax "literal(select * from unnest(...))"

2020-06-14 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135415#comment-17135415 ] Haisheng Yuan commented on CALCITE-4033: {{Unnest}} is a table function, Postgr

[jira] [Commented] (CALCITE-4058) Add Limit and LogicalLimit operator and deprecate limit in Sort

2020-06-15 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135874#comment-17135874 ] Haisheng Yuan commented on CALCITE-4058: [~rubenql] I totally understand you co

[jira] [Commented] (CALCITE-4058) Add Limit and LogicalLimit operator and deprecate limit in Sort

2020-06-15 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136184#comment-17136184 ] Haisheng Yuan commented on CALCITE-4058: Hi [~julianhyde], thanks for commentin

[jira] [Resolved] (CALCITE-4056) Remove Digest from RelNode and RexNode

2020-06-17 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-4056. Fix Version/s: 1.24.0 Resolution: Fixed Fixed in  [https://github.com/apache/calci

[jira] [Commented] (CALCITE-4056) Remove Digest from RelNode and RexNode

2020-06-17 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139019#comment-17139019 ] Haisheng Yuan commented on CALCITE-4056: [~danny0405], thank you for your comme

[jira] [Commented] (CALCITE-4056) Remove Digest from RelNode and RexNode

2020-06-17 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139029#comment-17139029 ] Haisheng Yuan commented on CALCITE-4056: You told Laurent: It seems that you h

[jira] [Commented] (CALCITE-4056) Remove Digest from RelNode and RexNode

2020-06-17 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139059#comment-17139059 ] Haisheng Yuan commented on CALCITE-4056: Thank you for reviewing the code, Dann

[jira] [Commented] (CALCITE-4056) Remove Digest from RelNode and RexNode

2020-06-17 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139067#comment-17139067 ] Haisheng Yuan commented on CALCITE-4056: [~danny0405] I don't mind the code is

[jira] [Commented] (CALCITE-4056) Remove Digest from RelNode and RexNode

2020-06-17 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139075#comment-17139075 ] Haisheng Yuan commented on CALCITE-4056: [~danny0405] I pushed it again. Now yo

[jira] [Created] (CALCITE-4071) Make RelNode Immutable

2020-06-18 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-4071: -- Summary: Make RelNode Immutable Key: CALCITE-4071 URL: https://issues.apache.org/jira/browse/CALCITE-4071 Project: Calcite Issue Type: Improvement

[jira] [Commented] (CALCITE-4071) Make RelNode Immutable

2020-06-18 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139899#comment-17139899 ] Haisheng Yuan commented on CALCITE-4071: For backward compatibility. I would re

[jira] [Commented] (CALCITE-4071) Make RelNode Immutable

2020-06-18 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139912#comment-17139912 ] Haisheng Yuan commented on CALCITE-4071: No, the old one will be garbage collec

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-18 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140010#comment-17140010 ] Haisheng Yuan commented on CALCITE-3786: I think my objection on this proposal

[jira] [Commented] (CALCITE-4071) Make RelNode Immutable

2020-06-18 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140023#comment-17140023 ] Haisheng Yuan commented on CALCITE-4071: [~julianhyde] Let's completely remove

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-18 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140202#comment-17140202 ] Haisheng Yuan commented on CALCITE-3786: [~danny0405] Thank you for your feedba

[jira] [Commented] (CALCITE-4071) Make RelNode Immutable

2020-06-19 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140751#comment-17140751 ] Haisheng Yuan commented on CALCITE-4071: lol. HepPlanner is indeed a tricky one

[jira] [Commented] (CALCITE-4073) Add a new component RexNormalize for more effect rex nodes normalization

2020-06-19 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140810#comment-17140810 ] Haisheng Yuan commented on CALCITE-4073: I would refrain from adding new config

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-19 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140958#comment-17140958 ] Haisheng Yuan commented on CALCITE-3786: OK, let me put it in another way. What

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-20 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141240#comment-17141240 ] Haisheng Yuan commented on CALCITE-3786: {quote} We should be cautious for #equ

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-21 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141516#comment-17141516 ] Haisheng Yuan commented on CALCITE-3786: {quote} Just implement the #explainTer

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-21 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141648#comment-17141648 ] Haisheng Yuan commented on CALCITE-3786: {quote} I don't think having an interf

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-21 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141718#comment-17141718 ] Haisheng Yuan commented on CALCITE-3786: {quote} Make the Digest an inner class

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-22 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142038#comment-17142038 ] Haisheng Yuan commented on CALCITE-3786: [~danny0405] Thank you for replying an

[jira] [Comment Edited] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-22 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142038#comment-17142038 ] Haisheng Yuan edited comment on CALCITE-3786 at 6/22/20, 1:32 PM: ---

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-22 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142199#comment-17142199 ] Haisheng Yuan commented on CALCITE-3786: {quote}My example code just illustrate

[jira] [Created] (CALCITE-4083) RelTraitSet failed to canonize traits

2020-06-22 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-4083: -- Summary: RelTraitSet failed to canonize traits Key: CALCITE-4083 URL: https://issues.apache.org/jira/browse/CALCITE-4083 Project: Calcite Issue Type: Bug

[jira] [Resolved] (CALCITE-4083) RelTraitSet failed to canonize traits

2020-06-23 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-4083. Fix Version/s: 1.24.0 Resolution: Fixed Fixed in  [https://github.com/apache/calci

[jira] [Updated] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-23 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3786: --- Attachment: screenshot-1.png > Add Digest interface to enable efficient hashCode(equals) fo

[jira] [Updated] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-23 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3786: --- Attachment: screenshot-2.png > Add Digest interface to enable efficient hashCode(equals) fo

[jira] [Updated] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-23 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3786: --- Attachment: screenshot-3.png > Add Digest interface to enable efficient hashCode(equals) fo

[jira] [Updated] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-23 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3786: --- Attachment: screenshot-4.png > Add Digest interface to enable efficient hashCode(equals) fo

[jira] [Updated] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-23 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3786: --- Attachment: screenshot-5.png > Add Digest interface to enable efficient hashCode(equals) fo

[jira] [Updated] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-23 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3786: --- Attachment: screenshot-6.png > Add Digest interface to enable efficient hashCode(equals) fo

[jira] [Updated] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-23 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3786: --- Attachment: image-2020-06-23-12-47-25-599.png > Add Digest interface to enable efficient ha

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-23 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143173#comment-17143173 ] Haisheng Yuan commented on CALCITE-3786: OK, since you desire it so much, let m

[jira] [Resolved] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-24 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3786. Resolution: Fixed Dude, next time would you please refrain from reverting other member's

[jira] [Resolved] (CALCITE-4056) Remove Digest from RelNode and RexNode

2020-06-24 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-4056. Resolution: Fixed Fixed in - https://github.com/apache/calcite/commit/173624261263435916

[jira] [Created] (CALCITE-4096) Change Pair.hashCode() not to use XOR

2020-06-29 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-4096: -- Summary: Change Pair.hashCode() not to use XOR Key: CALCITE-4096 URL: https://issues.apache.org/jira/browse/CALCITE-4096 Project: Calcite Issue Type: Imp

[jira] [Created] (CALCITE-4097) Avoid requesting unnecessary trait request when deriving traits from child inputs

2020-06-30 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-4097: -- Summary: Avoid requesting unnecessary trait request when deriving traits from child inputs Key: CALCITE-4097 URL: https://issues.apache.org/jira/browse/CALCITE-4097

[jira] [Commented] (CALCITE-4097) Avoid requesting unnecessary trait request when deriving traits from child inputs

2020-06-30 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149057#comment-17149057 ] Haisheng Yuan commented on CALCITE-4097: LOL. :) Thanks! > Avoid requesting u

[jira] [Commented] (CALCITE-4097) Avoid requesting unnecessary trait request when deriving traits from child inputs

2020-06-30 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149058#comment-17149058 ] Haisheng Yuan commented on CALCITE-4097: I copied from code comment. > Avoid r

[jira] [Resolved] (CALCITE-4097) Avoid requesting unnecessary trait request when deriving traits from child inputs

2020-07-01 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-4097. Fix Version/s: 1.24.0 Resolution: Fixed Fixed in  [https://github.com/apache/calci

[jira] [Commented] (CALCITE-4096) Change Pair.hashCode() not to use XOR

2020-07-02 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150461#comment-17150461 ] Haisheng Yuan commented on CALCITE-4096: Flat2List is a good alternative. Howe

[jira] [Created] (CALCITE-4103) SetOp and Union should accept RelNode subclasses in the constructor

2020-07-02 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-4103: -- Summary: SetOp and Union should accept RelNode subclasses in the constructor Key: CALCITE-4103 URL: https://issues.apache.org/jira/browse/CALCITE-4103 Project: Ca

[jira] [Created] (CALCITE-4105) Replace Pair with Flat2List in RelDigestWriter to improve hash code distribution

2020-07-03 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-4105: -- Summary: Replace Pair with Flat2List in RelDigestWriter to improve hash code distribution Key: CALCITE-4105 URL: https://issues.apache.org/jira/browse/CALCITE-4105

[jira] [Commented] (CALCITE-4105) Replace Pair with Flat2List in RelDigestWriter to improve hash code distribution

2020-07-03 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151114#comment-17151114 ] Haisheng Yuan commented on CALCITE-4105: There is a discussion about changing P

[jira] [Resolved] (CALCITE-4103) SetOp and Union should accept RelNode subclasses in the constructor

2020-07-03 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-4103. Resolution: Not A Problem It is not worthwhile doing. > SetOp and Union should accept Re

[jira] [Commented] (CALCITE-4096) Change Pair.hashCode() not to use XOR

2020-07-06 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152482#comment-17152482 ] Haisheng Yuan commented on CALCITE-4096: I think I was not making myself clear.

[jira] [Resolved] (CALCITE-4096) Change Pair.hashCode() not to use XOR

2020-07-09 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-4096. Resolution: Not A Problem Opened a new JIRA to use FlatList instead of Pair: CALCITE-4105

[jira] [Commented] (CALCITE-2249) AggregateJoinTransposeRule generates inequivalent nodes if Aggregate relNode contains distinct aggregate function.

2018-04-11 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433540#comment-16433540 ] Haisheng Yuan commented on CALCITE-2249: We can bail out for distinct aggregatio

[jira] [Comment Edited] (CALCITE-2249) AggregateJoinTransposeRule generates inequivalent nodes if Aggregate relNode contains distinct aggregate function.

2018-04-11 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433540#comment-16433540 ] Haisheng Yuan edited comment on CALCITE-2249 at 4/11/18 8:07 AM: -

[jira] [Created] (CALCITE-2278) AggregateJoinTransposeRule fails to split agg call for unique input with agg call

2018-04-24 Thread Haisheng Yuan (JIRA)
Haisheng Yuan created CALCITE-2278: -- Summary: AggregateJoinTransposeRule fails to split agg call for unique input with agg call Key: CALCITE-2278 URL: https://issues.apache.org/jira/browse/CALCITE-2278

[jira] [Updated] (CALCITE-2278) AggregateJoinTransposeRule fails to split agg call for unique input with agg call

2018-04-24 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-2278: --- Description: For the following query: {code:java} select A.job, B.mgr, A.deptno, max(B.hire

[jira] [Updated] (CALCITE-2278) AggregateJoinTransposeRule fails to split agg call for unique input with agg call

2018-04-24 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-2278: --- Description: For the following query: {code:java} select A.job, B.mgr, A.deptno, max(B.hire

[jira] [Commented] (CALCITE-2278) AggregateJoinTransposeRule fails to split agg call for unique input with agg call

2018-04-24 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16451343#comment-16451343 ] Haisheng Yuan commented on CALCITE-2278: Opened PR: [https://github.com/apache/c

[jira] [Commented] (CALCITE-2278) AggregateJoinTransposeRule fails to split agg call for unique input with agg call

2018-05-21 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16482898#comment-16482898 ] Haisheng Yuan commented on CALCITE-2278: Thanks for your question. # The unique

[jira] [Commented] (CALCITE-2456) VolcanoRuleCall#match works incorrectly for unordered child operand

2018-08-08 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16573544#comment-16573544 ] Haisheng Yuan commented on CALCITE-2456: [~julianhyde] Can you take a look at t

[jira] [Commented] (CALCITE-2505) RexSimplify: isFalse(isNotDistinctFrom(vBool(0), vBool(1))) causes AssertionError: wrong operand count 1 for IS DISTINCT FROM

2018-09-11 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611529#comment-16611529 ] Haisheng Yuan commented on CALCITE-2505: I will take this one. > RexSimplify:

[jira] [Commented] (CALCITE-2505) RexSimplify: isFalse(isNotDistinctFrom(vBool(0), vBool(1))) causes AssertionError: wrong operand count 1 for IS DISTINCT FROM

2018-09-11 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611543#comment-16611543 ] Haisheng Yuan commented on CALCITE-2505: PR: https://github.com/apache/calcite/

[jira] [Commented] (CALCITE-2506) RexSimplify: coalesce(unaryPlus(nullInt), unaryPlus(vInt())) results in AssertionError: result mismatch

2018-09-17 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617840#comment-16617840 ] Haisheng Yuan commented on CALCITE-2506: PR: https://github.com/apache/calcite/

[jira] [Commented] (CALCITE-2506) RexSimplify: coalesce(unaryPlus(nullInt), unaryPlus(vInt())) results in AssertionError: result mismatch

2018-09-17 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16618011#comment-16618011 ] Haisheng Yuan commented on CALCITE-2506: Thanks for reviewing, I will update it

[jira] [Commented] (CALCITE-2506) RexSimplify: coalesce(unaryPlus(nullInt), unaryPlus(vInt())) results in AssertionError: result mismatch

2018-09-17 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16618095#comment-16618095 ] Haisheng Yuan commented on CALCITE-2506: Updated the PR, please take another lo

[jira] [Commented] (CALCITE-2506) RexSimplify: coalesce(unaryPlus(nullInt), unaryPlus(vInt())) results in AssertionError: result mismatch

2018-09-17 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16618130#comment-16618130 ] Haisheng Yuan commented on CALCITE-2506: [~vladimirsitnikov] Sorry, I didn't ge

[jira] [Commented] (CALCITE-2506) RexSimplify: coalesce(unaryPlus(nullInt), unaryPlus(vInt())) results in AssertionError: result mismatch

2018-09-17 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16618134#comment-16618134 ] Haisheng Yuan commented on CALCITE-2506: OK, I got it. > RexSimplify: coalesce

[jira] [Issue Comment Deleted] (CALCITE-2506) RexSimplify: coalesce(unaryPlus(nullInt), unaryPlus(vInt())) results in AssertionError: result mismatch

2018-09-17 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-2506: --- Comment: was deleted (was: [~vladimirsitnikov] Sorry, I didn't get it. Can you elaborate?)

[jira] [Commented] (CALCITE-2506) RexSimplify: coalesce(unaryPlus(nullInt), unaryPlus(vInt())) results in AssertionError: result mismatch

2018-09-30 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633521#comment-16633521 ] Haisheng Yuan commented on CALCITE-2506: [~vladimirsitnikov] I am currently not

[jira] [Commented] (CALCITE-2620) Simplify "coalesce(null,x)" to "x"

2018-10-11 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646120#comment-16646120 ] Haisheng Yuan commented on CALCITE-2620: This can be fixed using patch in http

[jira] [Commented] (CALCITE-2619) Reduce string literal creation cost by removing charset check

2018-10-12 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16647560#comment-16647560 ] Haisheng Yuan commented on CALCITE-2619: [~julianhyde] Once the CharsetEncoder

[jira] [Comment Edited] (CALCITE-2619) Reduce string literal creation cost by removing charset check

2018-10-12 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16647560#comment-16647560 ] Haisheng Yuan edited comment on CALCITE-2619 at 10/12/18 7:16 AM: ---

[jira] [Commented] (CALCITE-2619) Reduce string literal creation cost by removing charset check

2018-10-12 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16647565#comment-16647565 ] Haisheng Yuan commented on CALCITE-2619: I am not worried about the memory over

[jira] [Commented] (CALCITE-2648) Implementation of EnumerableWindow does not preserve input collation

2018-10-30 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669097#comment-16669097 ] Haisheng Yuan commented on CALCITE-2648: Agree with Julian. Window is not requi

[jira] [Commented] (CALCITE-2659) Wrong plan In natural left/right join

2018-11-07 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678837#comment-16678837 ] Haisheng Yuan commented on CALCITE-2659: Here is a simpler test case with exist

[jira] [Comment Edited] (CALCITE-2659) Wrong plan In natural left/right join

2018-11-07 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678837#comment-16678837 ] Haisheng Yuan edited comment on CALCITE-2659 at 11/7/18 9:58 PM:

<    6   7   8   9   10   11   12   >