[jira] [Commented] (CALCITE-2935) Support ANY, SOME, EVERY (also known as BOOL_OR, BOOL_AND) aggregate functions

2019-03-21 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798539#comment-16798539 ] Haisheng Yuan commented on CALCITE-2935: Agree, things get much easier to define BOOL_OR and

[jira] [Updated] (CALCITE-2903) Exception thrown when decorrelating query with TEMPORAL TABLE

2019-03-21 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-2903: --- Summary: Exception thrown when decorrelating query with TEMPORAL TABLE (was: Exception

[jira] [Commented] (CALCITE-2936) Simplify EXISTS or NOT EXISTS sub-query that has "GROUP BY ()"

2019-03-20 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797659#comment-16797659 ] Haisheng Yuan commented on CALCITE-2936: Revoke my previous statement. We can use

[jira] [Commented] (CALCITE-2936) Simplify EXISTS or NOT EXISTS sub-query that has "GROUP BY ()"

2019-03-20 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797653#comment-16797653 ] Haisheng Yuan commented on CALCITE-2936: In that case, the logical relational node we get from

[jira] [Commented] (CALCITE-2935) Support ANY, SOME, EVERY (also known as BOOL_OR, BOOL_AND) aggregate functions

2019-03-20 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797645#comment-16797645 ] Haisheng Yuan commented on CALCITE-2935: Yes, makes sense. Unfortunately, there is no

[jira] [Updated] (CALCITE-2936) Existential subquery that has aggregate without grouping key should be simplified

2019-03-20 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-2936: --- Description: An existential subquery whose inner child is an aggregate with no grouping

[jira] [Created] (CALCITE-2936) Existential subquery that has aggregate without grouping key should be simplified

2019-03-20 Thread Haisheng Yuan (JIRA)
Haisheng Yuan created CALCITE-2936: -- Summary: Existential subquery that has aggregate without grouping key should be simplified Key: CALCITE-2936 URL: https://issues.apache.org/jira/browse/CALCITE-2936

[jira] [Updated] (CALCITE-2935) Support ANY, SOME, EVERY aggregate functions

2019-03-19 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-2935: --- Description: ANY, SOME is equivalent with bool_or. EVERY is equivalent with bool_and.

[jira] [Created] (CALCITE-2935) Support ANY, SOME, EVERY aggregate functions

2019-03-19 Thread Haisheng Yuan (JIRA)
Haisheng Yuan created CALCITE-2935: -- Summary: Support ANY, SOME, EVERY aggregate functions Key: CALCITE-2935 URL: https://issues.apache.org/jira/browse/CALCITE-2935 Project: Calcite Issue

[jira] [Commented] (CALCITE-2926) IN operator type validation failure

2019-03-16 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794164#comment-16794164 ] Haisheng Yuan commented on CALCITE-2926: Sorry for the late. Yes, UDF will be your choice in

[jira] [Commented] (CALCITE-2904) Column not found in table when query contain duplicate table alias

2019-03-15 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794128#comment-16794128 ] Haisheng Yuan commented on CALCITE-2904: Me either. But I tried to run the following query on

[jira] [Commented] (CALCITE-2926) IN operator type validation failure

2019-03-15 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794024#comment-16794024 ] Haisheng Yuan commented on CALCITE-2926: Is it even a valid query? > IN operator type

[jira] [Commented] (CALCITE-574) Remove org.apache.calcite.util.Bug.CALCITE_461_FIXED

2019-03-14 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793214#comment-16793214 ] Haisheng Yuan commented on CALCITE-574: --- I will work on extending decorrelateRel. > Remove

[jira] [Issue Comment Deleted] (CALCITE-2857) SemiJoin extends Join directly instead of EquiJoin to support non-equi condition

2019-03-12 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-2857: --- Comment: was deleted (was: Cancel my previous comment. In that case, SemiJoin still needs

[jira] [Issue Comment Deleted] (CALCITE-2857) SemiJoin extends Join directly instead of EquiJoin to support non-equi condition

2019-03-12 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-2857: --- Comment: was deleted (was: Is it possible to add a join filter to current SemiJoin? I like

[jira] [Commented] (CALCITE-2857) SemiJoin extends Join directly instead of EquiJoin to support non-equi condition

2019-03-12 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790910#comment-16790910 ] Haisheng Yuan commented on CALCITE-2857: I have the same question with [~vgarg] that why can't

[jira] [Commented] (CALCITE-2893) Type mismatch assertion error when creating join condition

2019-03-12 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790901#comment-16790901 ] Haisheng Yuan commented on CALCITE-2893: We can update the data type when creating filter on

[jira] [Commented] (CALCITE-2893) Type mismatch assertion error when creating join condition

2019-03-12 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790900#comment-16790900 ] Haisheng Yuan commented on CALCITE-2893: I did some RCA, I believe the reason is as follows:

[jira] [Commented] (CALCITE-2857) SemiJoin extends Join directly instead of EquiJoin to support non-equi condition

2019-03-11 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790152#comment-16790152 ] Haisheng Yuan commented on CALCITE-2857: A simpler repro query would be: {code:sql} select *

[jira] [Commented] (CALCITE-2857) SemiJoin extends Join directly instead of EquiJoin to support non-equi condition

2019-03-11 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790064#comment-16790064 ] Haisheng Yuan commented on CALCITE-2857: Cancel my previous comment. In that case, SemiJoin

[jira] [Commented] (CALCITE-2857) SemiJoin extends Join directly instead of EquiJoin to support non-equi condition

2019-03-11 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790060#comment-16790060 ] Haisheng Yuan commented on CALCITE-2857: Is it possible to add a join filter to current

[jira] [Commented] (CALCITE-2857) SemiJoin extends Join directly instead of EquiJoin to support non-equi condition

2019-03-11 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790057#comment-16790057 ] Haisheng Yuan commented on CALCITE-2857: Ah, right. My mistake. > SemiJoin extends Join

[jira] [Commented] (CALCITE-2857) SemiJoin extends Join directly instead of EquiJoin to support non-equi condition

2019-03-11 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790053#comment-16790053 ] Haisheng Yuan commented on CALCITE-2857: Can we add a filter (emp.job > dept.name) on top of

[jira] [Commented] (CALCITE-2004) The TableFunction left outer join was improperly translated

2019-03-09 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788831#comment-16788831 ] Haisheng Yuan commented on CALCITE-2004: [~danny0405] Thanks! > The TableFunction left outer

[jira] [Commented] (CALCITE-2904) Column not found in table when query contain duplicate table alias

2019-03-09 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788830#comment-16788830 ] Haisheng Yuan commented on CALCITE-2904: Sure, thanks. Feel free to file a patch. > Column

[jira] [Commented] (CALCITE-1172) Add rule to flatten two Aggregate operators into one

2019-03-08 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788419#comment-16788419 ] Haisheng Yuan commented on CALCITE-1172: I will format the test cases. > Add rule to flatten

[jira] [Commented] (CALCITE-2903) Exception thrown when decorrelating streaming query

2019-03-08 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788415#comment-16788415 ] Haisheng Yuan commented on CALCITE-2903: Sorry about that. I am going to work on this issue. >

[jira] [Commented] (CALCITE-2904) Column not found in table when query contain duplicate table alias

2019-03-08 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788414#comment-16788414 ] Haisheng Yuan commented on CALCITE-2904: It will succeed if we change one of 't' to 't2'. It

[jira] [Created] (CALCITE-2904) Column not found in table when query contain duplicate table alias

2019-03-08 Thread Haisheng Yuan (JIRA)
Haisheng Yuan created CALCITE-2904: -- Summary: Column not found in table when query contain duplicate table alias Key: CALCITE-2904 URL: https://issues.apache.org/jira/browse/CALCITE-2904 Project:

[jira] [Commented] (CALCITE-2903) Exception thrown when decorrelating streaming query

2019-03-08 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788342#comment-16788342 ] Haisheng Yuan commented on CALCITE-2903: [~julianhyde] There is no handler to decorrelate

[jira] [Created] (CALCITE-2903) Exception thrown when decorrelating streaming query

2019-03-08 Thread Haisheng Yuan (JIRA)
Haisheng Yuan created CALCITE-2903: -- Summary: Exception thrown when decorrelating streaming query Key: CALCITE-2903 URL: https://issues.apache.org/jira/browse/CALCITE-2903 Project: Calcite

[jira] [Commented] (CALCITE-2004) The TableFunction left outer join was improperly translated

2019-03-08 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788114#comment-16788114 ] Haisheng Yuan commented on CALCITE-2004: I opened a PR for this issue:

[jira] [Commented] (CALCITE-2896) RelBuilder supports creating TableFunctionScan

2019-03-06 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786343#comment-16786343 ] Haisheng Yuan commented on CALCITE-2896: This is duplicate with

[jira] [Updated] (CALCITE-2893) Type mismatch assertion error when creating join condition

2019-03-06 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-2893: --- Description: Repro: in TableFunctionTest.java, add the following test case: {code:java}

[jira] [Created] (CALCITE-2893) Type mismatch assertion error when creating join condition

2019-03-05 Thread Haisheng Yuan (JIRA)
Haisheng Yuan created CALCITE-2893: -- Summary: Type mismatch assertion error when creating join condition Key: CALCITE-2893 URL: https://issues.apache.org/jira/browse/CALCITE-2893 Project: Calcite

[jira] [Commented] (CALCITE-1172) Add rule to flatten two Aggregate operators into one

2019-03-05 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785092#comment-16785092 ] Haisheng Yuan commented on CALCITE-1172: Hi [~julianhyde] I have opened a pull request to

[jira] [Commented] (CALCITE-896) Remove Aggregate if grouping columns are unique and all functions are splittable

2019-03-05 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784898#comment-16784898 ] Haisheng Yuan commented on CALCITE-896: --- I have updated the pull request to address comments, can

[jira] [Commented] (CALCITE-2891) Alias suggester failed to suggest name based on original name incrementally

2019-03-05 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784793#comment-16784793 ] Haisheng Yuan commented on CALCITE-2891: Good idea, I will add one. Thanks for reviewing. >

[jira] [Commented] (CALCITE-2891) Alias suggester failed to suggest name based on original name incrementally

2019-03-04 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784089#comment-16784089 ] Haisheng Yuan commented on CALCITE-2891: It may cause a problem if there are thousands of field

[jira] [Updated] (CALCITE-2891) Alias suggester failed to suggest name based on original name incrementally

2019-03-04 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-2891: --- Summary: Alias suggester failed to suggest name based on original name incrementally

[jira] [Created] (CALCITE-2891) Alias suggester failed to suggest name based on original name

2019-03-04 Thread Haisheng Yuan (JIRA)
Haisheng Yuan created CALCITE-2891: -- Summary: Alias suggester failed to suggest name based on original name Key: CALCITE-2891 URL: https://issues.apache.org/jira/browse/CALCITE-2891 Project: Calcite

[jira] [Commented] (CALCITE-2820) Add a version of AggregateReduceFunctionsRule that does not reduce SUm -> SUM0

2019-03-01 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782271#comment-16782271 ] Haisheng Yuan commented on CALCITE-2820: I am curious too. Maybe because AVG, COVAR_POP,

[jira] [Commented] (CALCITE-1373) select date column will fail in 1.8.0

2019-03-01 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782234#comment-16782234 ] Haisheng Yuan commented on CALCITE-1373: I can't reproduce it on latest branch. Should we close

[jira] [Commented] (CALCITE-2857) SemiJoin extends Join directly instead of EquiJoin to support non-equi condition

2019-03-01 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782229#comment-16782229 ] Haisheng Yuan commented on CALCITE-2857: Agree, either IN or NOT IN, a.k.a semi-join and

[jira] [Commented] (CALCITE-896) Remove Aggregate if grouping columns are unique and all functions are splittable

2019-03-01 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782122#comment-16782122 ] Haisheng Yuan commented on CALCITE-896: --- It seems like the patch in this PR triggered a bug in

[jira] [Updated] (CALCITE-896) Remove Aggregate if grouping columns are unique and all functions are splittable

2019-03-01 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-896: -- Attachment: node.png > Remove Aggregate if grouping columns are unique and all functions are

[jira] [Commented] (CALCITE-896) Remove Aggregate if grouping columns are unique and all functions are splittable

2019-02-28 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781091#comment-16781091 ] Haisheng Yuan commented on CALCITE-896: --- Hi [~julianhyde] I have opened a PR resolving this issue,

[jira] [Commented] (CALCITE-2818) EXTRACT returns wrong results for DATE and TIMESTAMP values before epoch

2019-02-28 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780783#comment-16780783 ] Haisheng Yuan commented on CALCITE-2818: It turns out extracting year,month,day has similar

[jira] [Commented] (CALCITE-1148) Trait conversion broken for RelTraits other than Convention

2019-02-26 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778759#comment-16778759 ] Haisheng Yuan commented on CALCITE-1148: I think If useAbstractConvertersForConversion return

[jira] [Commented] (CALCITE-2722) SqlImplementor createLeftCall method throws StackOverflowError

2019-02-17 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16770467#comment-16770467 ] Haisheng Yuan commented on CALCITE-2722: Yes, the original code does create left-deep tree. If

[jira] [Commented] (CALCITE-2722) SqlImplementor createLeftCall method throws StackOverflowError

2019-02-15 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769992#comment-16769992 ] Haisheng Yuan commented on CALCITE-2722: I opened a PR to rewrite the function in iterative

[jira] [Commented] (CALCITE-2630) Convert SqlInOperator to In-Expression

2019-02-01 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758607#comment-16758607 ] Haisheng Yuan commented on CALCITE-2630: We hit this issue quite often. Sometimes the query is

[jira] [Commented] (CALCITE-2798) Optimizer should remove ORDER BY in sub-query, provided it has no LIMIT or OFFSET

2019-01-31 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757761#comment-16757761 ] Haisheng Yuan commented on CALCITE-2798: Agree with [~julianhyde]. This is exactly how

[jira] [Commented] (CALCITE-2770) Add bitwise aggregate functions BIT_AND, BIT_OR

2019-01-31 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757744#comment-16757744 ] Haisheng Yuan commented on CALCITE-2770: Well, BIT_AND, BIT_OR are not SQL standard aggregate

[jira] [Comment Edited] (CALCITE-2798) Optimizer should remove unneeded Sort

2019-01-30 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16756763#comment-16756763 ] Haisheng Yuan edited comment on CALCITE-2798 at 1/31/19 1:41 AM: - Order

[jira] [Commented] (CALCITE-2798) Optimizer should remove unneeded Sort

2019-01-30 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16756763#comment-16756763 ] Haisheng Yuan commented on CALCITE-2798: Order by without limit and offset clause can be

[jira] [Comment Edited] (CALCITE-2770) Add bitwise aggregate functions BIT_AND, BIT_OR

2019-01-30 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16756391#comment-16756391 ] Haisheng Yuan edited comment on CALCITE-2770 at 1/30/19 6:30 PM: -

[jira] [Commented] (CALCITE-2770) Add bitwise aggregate functions BIT_AND, BIT_OR

2019-01-30 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16756391#comment-16756391 ] Haisheng Yuan commented on CALCITE-2770: [~michaelmior] Thanks! I updated the PR as your

[jira] [Commented] (CALCITE-2770) Add bitwise aggregate functions BIT_AND, BIT_OR

2019-01-17 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745849#comment-16745849 ] Haisheng Yuan commented on CALCITE-2770: [~julianhyde] Can you take a look if you have time?

[jira] [Commented] (CALCITE-2770) Add bitwise aggregate functions BIT_AND, BIT_OR

2019-01-05 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16734985#comment-16734985 ] Haisheng Yuan commented on CALCITE-2770: I opened a PR:

[jira] [Commented] (CALCITE-2770) Add bitwise aggregate functions BIT_AND, BIT_OR

2019-01-05 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16734892#comment-16734892 ] Haisheng Yuan commented on CALCITE-2770: [~julianhyde] Integer types, such as tinyint,

[jira] [Created] (CALCITE-2770) Add bitwise aggregate functions BIT_AND, BIT_OR

2019-01-03 Thread Haisheng Yuan (JIRA)
Haisheng Yuan created CALCITE-2770: -- Summary: Add bitwise aggregate functions BIT_AND, BIT_OR Key: CALCITE-2770 URL: https://issues.apache.org/jira/browse/CALCITE-2770 Project: Calcite

[jira] [Commented] (CALCITE-2717) Cached traits in RelTraitDef's canonicalMap can't be garbage-collected

2018-11-30 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705364#comment-16705364 ] Haisheng Yuan commented on CALCITE-2717: Opened PR: https://github.com/apache/calcite/pull/951

[jira] [Commented] (CALCITE-2717) Cached traits in RelTraitDef's canonicalMap can't be garbage-collected

2018-11-30 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705200#comment-16705200 ] Haisheng Yuan commented on CALCITE-2717: If the key and value are pointing to different object,

[jira] [Comment Edited] (CALCITE-2717) Cached traits in RelTraitDef's canonicalMap can't be garbage-collected

2018-11-29 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704311#comment-16704311 ] Haisheng Yuan edited comment on CALCITE-2717 at 11/30/18 6:19 AM: -- We

[jira] [Commented] (CALCITE-2717) Cached traits in RelTraitDef's canonicalMap can't be garbage-collected

2018-11-29 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704311#comment-16704311 ] Haisheng Yuan commented on CALCITE-2717: We have seen the OOM issue accidentally in our system

[jira] [Created] (CALCITE-2717) Cached traits in RelTraitDef's canonicalMap can't be garbage-collected

2018-11-28 Thread Haisheng Yuan (JIRA)
Haisheng Yuan created CALCITE-2717: -- Summary: Cached traits in RelTraitDef's canonicalMap can't be garbage-collected Key: CALCITE-2717 URL: https://issues.apache.org/jira/browse/CALCITE-2717

[jira] [Commented] (CALCITE-2679) Group by without aggregation function cannot be translated to correct JSON in Elasticsearch Adapter

2018-11-16 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690179#comment-16690179 ] Haisheng Yuan commented on CALCITE-2679: Any example? > Group by without aggregation function

[jira] [Comment Edited] (CALCITE-2659) Wrong plan In natural left/right join

2018-11-09 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681581#comment-16681581 ] Haisheng Yuan edited comment on CALCITE-2659 at 11/9/18 3:30 PM: - As I

[jira] [Comment Edited] (CALCITE-2659) Wrong plan In natural left/right join

2018-11-09 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681581#comment-16681581 ] Haisheng Yuan edited comment on CALCITE-2659 at 11/9/18 3:26 PM: - As I

[jira] [Commented] (CALCITE-2659) Wrong plan In natural left/right join

2018-11-09 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681581#comment-16681581 ] Haisheng Yuan commented on CALCITE-2659: As I mentioned, for left outer join, if the left side

[jira] [Commented] (CALCITE-2605) NullPointerException when left outer join implemented with EnumerableCorrelate

2018-11-08 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680602#comment-16680602 ] Haisheng Yuan commented on CALCITE-2605:

[jira] [Commented] (CALCITE-2605) NullPointerException when left outer join implemented with EnumerableCorrelate

2018-11-08 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680562#comment-16680562 ] Haisheng Yuan commented on CALCITE-2605: It looks like there is a build failure after this

[jira] [Commented] (CALCITE-2659) Wrong plan In natural left/right join

2018-11-07 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678856#comment-16678856 ] Haisheng Yuan commented on CALCITE-2659: The plan produces correct result in that within

[jira] [Comment Edited] (CALCITE-2659) Wrong plan In natural left/right join

2018-11-07 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678837#comment-16678837 ] Haisheng Yuan edited comment on CALCITE-2659 at 11/7/18 9:58 PM: - Here

[jira] [Commented] (CALCITE-2648) Implementation of EnumerableWindow does not preserve input collation

2018-10-30 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669097#comment-16669097 ] Haisheng Yuan commented on CALCITE-2648: Agree with Julian. Window is not required to preserve

[jira] [Commented] (CALCITE-2619) Reduce string literal creation cost by removing charset check

2018-10-12 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647565#comment-16647565 ] Haisheng Yuan commented on CALCITE-2619: I am not worried about the memory overhead for caching

[jira] [Comment Edited] (CALCITE-2619) Reduce string literal creation cost by removing charset check

2018-10-12 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647560#comment-16647560 ] Haisheng Yuan edited comment on CALCITE-2619 at 10/12/18 7:16 AM: --

[jira] [Commented] (CALCITE-2619) Reduce string literal creation cost by removing charset check

2018-10-12 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647560#comment-16647560 ] Haisheng Yuan commented on CALCITE-2619: [~julianhyde] Once the CharsetEncoder of the CharSet

[jira] [Commented] (CALCITE-2620) Simplify "coalesce(null,x)" to "x"

2018-10-11 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646120#comment-16646120 ] Haisheng Yuan commented on CALCITE-2620: This can be fixed using patch in

[jira] [Commented] (CALCITE-2506) RexSimplify: coalesce(unaryPlus(nullInt), unaryPlus(vInt())) results in AssertionError: result mismatch

2018-09-30 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633521#comment-16633521 ] Haisheng Yuan commented on CALCITE-2506: [~vladimirsitnikov] I am currently not working on this

[jira] [Issue Comment Deleted] (CALCITE-2506) RexSimplify: coalesce(unaryPlus(nullInt), unaryPlus(vInt())) results in AssertionError: result mismatch

2018-09-17 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-2506: --- Comment: was deleted (was: [~vladimirsitnikov] Sorry, I didn't get it. Can you elaborate?)

[jira] [Commented] (CALCITE-2506) RexSimplify: coalesce(unaryPlus(nullInt), unaryPlus(vInt())) results in AssertionError: result mismatch

2018-09-17 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618134#comment-16618134 ] Haisheng Yuan commented on CALCITE-2506: OK, I got it. > RexSimplify:

[jira] [Commented] (CALCITE-2506) RexSimplify: coalesce(unaryPlus(nullInt), unaryPlus(vInt())) results in AssertionError: result mismatch

2018-09-17 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618130#comment-16618130 ] Haisheng Yuan commented on CALCITE-2506: [~vladimirsitnikov] Sorry, I didn't get it. Can you

[jira] [Commented] (CALCITE-2506) RexSimplify: coalesce(unaryPlus(nullInt), unaryPlus(vInt())) results in AssertionError: result mismatch

2018-09-17 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618095#comment-16618095 ] Haisheng Yuan commented on CALCITE-2506: Updated the PR, please take another look. Thanks! >

[jira] [Commented] (CALCITE-2506) RexSimplify: coalesce(unaryPlus(nullInt), unaryPlus(vInt())) results in AssertionError: result mismatch

2018-09-17 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618011#comment-16618011 ] Haisheng Yuan commented on CALCITE-2506: Thanks for reviewing, I will update it. >

[jira] [Commented] (CALCITE-2506) RexSimplify: coalesce(unaryPlus(nullInt), unaryPlus(vInt())) results in AssertionError: result mismatch

2018-09-17 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617840#comment-16617840 ] Haisheng Yuan commented on CALCITE-2506: PR: https://github.com/apache/calcite/pull/836 Please

[jira] [Commented] (CALCITE-2505) RexSimplify: isFalse(isNotDistinctFrom(vBool(0), vBool(1))) causes AssertionError: wrong operand count 1 for IS DISTINCT FROM

2018-09-11 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611543#comment-16611543 ] Haisheng Yuan commented on CALCITE-2505: PR: https://github.com/apache/calcite/pull/828 >

[jira] [Commented] (CALCITE-2505) RexSimplify: isFalse(isNotDistinctFrom(vBool(0), vBool(1))) causes AssertionError: wrong operand count 1 for IS DISTINCT FROM

2018-09-11 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611529#comment-16611529 ] Haisheng Yuan commented on CALCITE-2505: I will take this one. > RexSimplify:

[jira] [Commented] (CALCITE-2456) VolcanoRuleCall#match works incorrectly for unordered child operand

2018-08-08 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573544#comment-16573544 ] Haisheng Yuan commented on CALCITE-2456: [~julianhyde] Can you take a look at this issue? >

[jira] [Commented] (CALCITE-2278) AggregateJoinTransposeRule fails to split agg call for unique input with agg call

2018-05-21 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482898#comment-16482898 ] Haisheng Yuan commented on CALCITE-2278: Thanks for your question. # The unique input can be

[jira] [Updated] (CALCITE-2278) AggregateJoinTransposeRule fails to split agg call for unique input with agg call

2018-04-24 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-2278: --- Description: For the following query: {code:java} select A.job, B.mgr, A.deptno,

[jira] [Updated] (CALCITE-2278) AggregateJoinTransposeRule fails to split agg call for unique input with agg call

2018-04-24 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-2278: --- Description: For the following query: {code:java} select A.job, B.mgr, A.deptno,

[jira] [Created] (CALCITE-2278) AggregateJoinTransposeRule fails to split agg call for unique input with agg call

2018-04-24 Thread Haisheng Yuan (JIRA)
Haisheng Yuan created CALCITE-2278: -- Summary: AggregateJoinTransposeRule fails to split agg call for unique input with agg call Key: CALCITE-2278 URL: https://issues.apache.org/jira/browse/CALCITE-2278

[jira] [Comment Edited] (CALCITE-2249) AggregateJoinTransposeRule generates inequivalent nodes if Aggregate relNode contains distinct aggregate function.

2018-04-11 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433540#comment-16433540 ] Haisheng Yuan edited comment on CALCITE-2249 at 4/11/18 8:07 AM: - We can

[jira] [Commented] (CALCITE-2249) AggregateJoinTransposeRule generates inequivalent nodes if Aggregate relNode contains distinct aggregate function.

2018-04-11 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433540#comment-16433540 ] Haisheng Yuan commented on CALCITE-2249: We can bail out for distinct aggregation. >

<    6   7   8   9   10   11