[jira] [Commented] (CALCITE-3963) Maintains logical properties at RelSet (equivalent group) instead of RelNode

2020-04-30 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17096985#comment-17096985 ] Haisheng Yuan commented on CALCITE-3963: As long as all the alternatives in a RelSet share the

[jira] [Comment Edited] (CALCITE-2970) Performance issue when enabling abstract converter for EnumerableConvention

2020-04-29 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095582#comment-17095582 ] Haisheng Yuan edited comment on CALCITE-2970 at 4/29/20, 4:04 PM: --

[jira] [Commented] (CALCITE-2970) Performance issue when enabling abstract converter for EnumerableConvention

2020-04-29 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095582#comment-17095582 ] Haisheng Yuan commented on CALCITE-2970: LOL. [~zabetak], we had the same thought:

[jira] [Updated] (CALCITE-3916) Support cascades style top-down driven rule apply

2020-04-29 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3916: --- Summary: Support cascades style top-down driven rule apply (was: Apply rules bottom up by

[jira] [Commented] (CALCITE-2970) Performance issue when enabling abstract converter for EnumerableConvention

2020-04-28 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17094955#comment-17094955 ] Haisheng Yuan commented on CALCITE-2970: I am good the current change. [~julianhyde] Can you

[jira] [Resolved] (CALCITE-3878) Make ArrayList creation with initial capacity when size is fixed

2020-04-28 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3878. Fix Version/s: 1.23.0 Resolution: Fixed Fixed in

[jira] [Resolved] (CALCITE-3949) RelDistributions.of() and RelCollations.of() should canonize trait instance

2020-04-28 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3949. Fix Version/s: 1.23.0 Resolution: Fixed Fixed in

[jira] [Resolved] (CALCITE-3937) Fire rule for RelSubset only when it is derived

2020-04-28 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3937. Resolution: Not A Problem Reverted in

[jira] [Updated] (CALCITE-3937) Fire rule for RelSubset only when it is derived

2020-04-28 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3937: --- Fix Version/s: (was: 1.23.0) > Fire rule for RelSubset only when it is derived >

[jira] [Reopened] (CALCITE-3937) Fire rule for RelSubset only when it is derived

2020-04-28 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan reopened CALCITE-3937: > Fire rule for RelSubset only when it is derived >

[jira] [Commented] (CALCITE-3949) RelDistributions.of() and RelCollations.of() should canonize trait instance

2020-04-28 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17094731#comment-17094731 ] Haisheng Yuan commented on CALCITE-3949: PR: https://github.com/apache/calcite/pull/1952 >

[jira] [Reopened] (CALCITE-3947) AbstractRelOptPlanner.classes should be LinkedHashSet so that rule match order is deterministic across runs

2020-04-24 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan reopened CALCITE-3947: Reverted in

[jira] [Updated] (CALCITE-3947) AbstractRelOptPlanner.classes should be LinkedHashSet so that rule match order is deterministic across runs

2020-04-24 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3947: --- Fix Version/s: (was: 1.23.0) > AbstractRelOptPlanner.classes should be LinkedHashSet

[jira] [Commented] (CALCITE-3947) AbstractRelOptPlanner.classes should be LinkedHashSet so that rule match order is deterministic across runs

2020-04-24 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092005#comment-17092005 ] Haisheng Yuan commented on CALCITE-3947: I guess [~botong] is trying to solve the same issue as

[jira] [Commented] (CALCITE-3947) AbstractRelOptPlanner.classes should be LinkedHashSet so that rule match order is deterministic across runs

2020-04-24 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092004#comment-17092004 ] Haisheng Yuan commented on CALCITE-3947: Oops, I misinterpreted it. Will revert the commit. >

[jira] [Commented] (CALCITE-3957) AggregateMergeRule should be able to merge SUM0 into COUNT even with empty group by

2020-04-24 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17091907#comment-17091907 ] Haisheng Yuan commented on CALCITE-3957: Agree. Here is the context:

[jira] [Updated] (CALCITE-3932) Make data type cache thread local, non-evictable

2020-04-23 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3932: --- Fix Version/s: (was: 1.23.0) > Make data type cache thread local, non-evictable >

[jira] [Commented] (CALCITE-3932) Make data type cache thread local, non-evictable

2020-04-23 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17091078#comment-17091078 ] Haisheng Yuan commented on CALCITE-3932: Yes, that is feasible. But what if down stream

[jira] [Commented] (CALCITE-3952) Improve SortRemoveRule to remove Sort based on rowcount

2020-04-23 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17091029#comment-17091029 ] Haisheng Yuan commented on CALCITE-3952: [~vgarg] Why do we need a configuration to turn it

[jira] [Commented] (CALCITE-3952) Improve SortRemoveRule to remove Sort based on rowcount

2020-04-23 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17091027#comment-17091027 ] Haisheng Yuan commented on CALCITE-3952: [~vgarg] select count(*) as c from foo order by c

[jira] [Resolved] (CALCITE-3932) Make data type cache thread local, non-evictable

2020-04-23 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3932. Resolution: Won't Fix > Make data type cache thread local, non-evictable >

[jira] [Commented] (CALCITE-3932) Make data type cache thread local, non-evictable

2020-04-23 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090927#comment-17090927 ] Haisheng Yuan commented on CALCITE-3932: For thread local, even it is long-lived, as long as

[jira] [Commented] (CALCITE-3952) Improve SortRemoveRule to remove Sort based on rowcount

2020-04-22 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090240#comment-17090240 ] Haisheng Yuan commented on CALCITE-3952: That makes sense. deptno is not the output column of

[jira] [Commented] (CALCITE-3952) Improve SortRemoveRule to remove Sort based on rowcount

2020-04-22 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090225#comment-17090225 ] Haisheng Yuan commented on CALCITE-3952: Oh, I even didn't know we can generate baseline xml

[jira] [Commented] (CALCITE-3952) Improve SortRemoveRule to remove Sort based on rowcount

2020-04-22 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090221#comment-17090221 ] Haisheng Yuan commented on CALCITE-3952: OK, got it. thanks. > Improve SortRemoveRule to

[jira] [Commented] (CALCITE-3952) Improve SortRemoveRule to remove Sort based on rowcount

2020-04-22 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090212#comment-17090212 ] Haisheng Yuan commented on CALCITE-3952: What if we have limit 0? > Improve SortRemoveRule to

[jira] [Issue Comment Deleted] (CALCITE-3932) Make data type cache thread local, non-evictable

2020-04-22 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3932: --- Comment: was deleted (was: Thanks for your advice. [~Junzheng Zheng] I opened a

[jira] [Updated] (CALCITE-3932) Make data type cache thread local, non-evictable

2020-04-22 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3932: --- External issue URL: (was: https://github.com/apache/calcite/pull/1939) > Make data type

[jira] [Comment Edited] (CALCITE-3932) Make data type cache thread local, non-evictable

2020-04-22 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090165#comment-17090165 ] Haisheng Yuan edited comment on CALCITE-3932 at 4/23/20, 2:14 AM: --

[jira] [Updated] (CALCITE-3932) Make data type cache thread local, non-evictable

2020-04-22 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3932: --- External issue URL: https://github.com/apache/calcite/pull/1939 > Make data type cache

[jira] [Commented] (CALCITE-3932) Make data type cache thread local, non-evictable

2020-04-22 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090165#comment-17090165 ] Haisheng Yuan commented on CALCITE-3932: Thanks for your advice. [~Junzheng Zheng] I opened a

[jira] [Commented] (CALCITE-3878) Make ArrayList creation with initial capacity when size is fixed

2020-04-22 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090154#comment-17090154 ] Haisheng Yuan commented on CALCITE-3878: I will commit this patch if there are no more

[jira] [Commented] (CALCITE-2223) ProjectMergeRule is infinitely matched when is applied after ProjectReduceExpressionsRule

2020-04-22 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090133#comment-17090133 ] Haisheng Yuan commented on CALCITE-2223: [~rubenql] I think it is resolved by other commits. 

[jira] [Resolved] (CALCITE-3915) Add rule listener to report rule attempts and time at DEBUG log level

2020-04-22 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3915. Fix Version/s: 1.23.0 Resolution: Fixed Fixed in 

[jira] [Resolved] (CALCITE-3948) Improve operand's RelSubset matching handling in VolcanoRuleCall

2020-04-22 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3948. Fix Version/s: 1.23.0 Resolution: Fixed Fixed in 

[jira] [Commented] (CALCITE-3932) Make data type cache thread local, non-evictable

2020-04-22 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089712#comment-17089712 ] Haisheng Yuan commented on CALCITE-3932: If we consider the use of ThreadPool, we probably

[jira] [Updated] (CALCITE-3949) RelDistributions.of() and RelCollations.of() should canonize trait instance

2020-04-21 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3949: --- Description: Otherwise, in Sort constructor, the assertion might fail. assert

[jira] [Created] (CALCITE-3949) RelDistributions.of() and RelCollations.of() should canonize trait instance

2020-04-21 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-3949: -- Summary: RelDistributions.of() and RelCollations.of() should canonize trait instance Key: CALCITE-3949 URL: https://issues.apache.org/jira/browse/CALCITE-3949

[jira] [Resolved] (CALCITE-3422) reOpen CALCITE-1751 tests in PigRelBuilderStyleTest.

2020-04-21 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3422. Resolution: Won't Fix > reOpen CALCITE-1751 tests in PigRelBuilderStyleTest. >

[jira] [Commented] (CALCITE-3878) Make ArrayList creation with initial capacity when size is fixed

2020-04-21 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089237#comment-17089237 ] Haisheng Yuan commented on CALCITE-3878: Hi [~julianhyde], how do you like the latest changes? 

[jira] [Resolved] (CALCITE-3939) Change UnionEliminatorRule and ProjectRemoveRule to auto pruning SubstitutionRule

2020-04-21 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3939. Fix Version/s: 1.23.0 Resolution: Fixed Fixed in 

[jira] [Resolved] (CALCITE-3944) Move dumpSets and dumpGraphviz out of VolcanoPlanner

2020-04-21 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3944. Fix Version/s: 1.23.0 Resolution: Fixed Fixed in 

[jira] [Resolved] (CALCITE-3947) AbstractRelOptPlanner.classes should be LinkedHashSet so that rule match order is deterministic across runs

2020-04-21 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3947. Fix Version/s: 1.23.0 Resolution: Fixed Fixed in 

[jira] [Commented] (CALCITE-3947) AbstractRelOptPlanner.classes should be LinkedHashSet so that rule match order is deterministic across runs

2020-04-21 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089082#comment-17089082 ] Haisheng Yuan commented on CALCITE-3947: Will the plan be different between different runs? >

[jira] [Resolved] (CALCITE-3937) Fire rule for RelSubset only when it is derived

2020-04-21 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3937. Fix Version/s: 1.23.0 Resolution: Fixed Fixed in 

[jira] [Resolved] (CALCITE-3927) RelSubset is not fired for rule when set gets merged

2020-04-21 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3927. Fix Version/s: 1.23.0 Resolution: Fixed Fixed in 

[jira] [Commented] (CALCITE-3944) Move dumpSets and dumpGraphviz out of VolcanoPlanner

2020-04-21 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088918#comment-17088918 ] Haisheng Yuan commented on CALCITE-3944: Yes, it is named Dumpers.java > Move dumpSets and

[jira] [Created] (CALCITE-3944) Move dumpSets and dumpGraphviz out of VolcanoPlanner

2020-04-21 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-3944: -- Summary: Move dumpSets and dumpGraphviz out of VolcanoPlanner Key: CALCITE-3944 URL: https://issues.apache.org/jira/browse/CALCITE-3944 Project: Calcite

[jira] [Resolved] (CALCITE-3868) Remove redundant ruleSet and ruleNames in VolcanoPlanner

2020-04-21 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3868. Fix Version/s: 1.23.0 Resolution: Fixed Fixed in 

[jira] [Commented] (CALCITE-2057) StackOverflowError when running a JDBC query

2020-04-20 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088293#comment-17088293 ] Haisheng Yuan commented on CALCITE-2057: The query posted by Julian doesn't trigger

[jira] [Resolved] (CALCITE-3918) SubQueryFilterRemoveRule failed to decorrelate subquery for TPCH q17

2020-04-19 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3918. Resolution: Not A Problem > SubQueryFilterRemoveRule failed to decorrelate subquery for

[jira] [Commented] (CALCITE-3918) SubQueryFilterRemoveRule failed to decorrelate subquery for TPCH q17

2020-04-19 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087324#comment-17087324 ] Haisheng Yuan commented on CALCITE-3918: Sorry, my fault. Haven't read this piece of code for a

[jira] [Commented] (CALCITE-3918) SubQueryFilterRemoveRule failed to decorrelate subquery for TPCH q17

2020-04-19 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087318#comment-17087318 ] Haisheng Yuan commented on CALCITE-3918: I am expecting SubQueryFilterRemoveRule can

[jira] [Commented] (CALCITE-3918) SubQueryFilterRemoveRule failed to decorrelate subquery for TPCH q17

2020-04-19 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087315#comment-17087315 ] Haisheng Yuan commented on CALCITE-3918: Modify the code and return the relnode directly

[jira] [Updated] (CALCITE-3937) Fire rule for RelSubset only when it is derived

2020-04-18 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3937: --- Summary: Fire rule for RelSubset only when it is derived (was: Only fire rule for

[jira] [Created] (CALCITE-3937) Only fire rule for RelSubset when it is derived

2020-04-18 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-3937: -- Summary: Only fire rule for RelSubset when it is derived Key: CALCITE-3937 URL: https://issues.apache.org/jira/browse/CALCITE-3937 Project: Calcite

[jira] [Commented] (CALCITE-3932) Make data type cache thread local, non-evictable

2020-04-17 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086242#comment-17086242 ] Haisheng Yuan commented on CALCITE-3932: [~julianhyde] What do you think? Are the two caches

[jira] [Commented] (CALCITE-3896) Pass through parent trait requests to child operators

2020-04-17 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086015#comment-17086015 ] Haisheng Yuan commented on CALCITE-3896: {quote} I hope this "won't and shouldn't" can be

[jira] [Commented] (CALCITE-3932) Make data type cache thread local, non-evictable

2020-04-16 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085406#comment-17085406 ] Haisheng Yuan commented on CALCITE-3932: How can it be garbage collected while still being

[jira] [Commented] (CALCITE-2970) Performance issue when enabling abstract converter for EnumerableConvention

2020-04-16 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085348#comment-17085348 ] Haisheng Yuan commented on CALCITE-2970: [~julianhyde] Will {{UnaryOperator

[jira] [Commented] (CALCITE-3932) Make data type cache thread local, non-evictable

2020-04-16 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085322#comment-17085322 ] Haisheng Yuan commented on CALCITE-3932: RelDataTypeFactoryImpl KEY2TYPE_CACHE and 

[jira] [Commented] (CALCITE-2970) Performance issue when enabling abstract converter for EnumerableConvention

2020-04-16 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085296#comment-17085296 ] Haisheng Yuan commented on CALCITE-2970: Getting back to the physical RelBuilder pull request.

[jira] [Commented] (CALCITE-3932) Make data type cache thread local, non-evictable

2020-04-16 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085290#comment-17085290 ] Haisheng Yuan commented on CALCITE-3932: Most of the data type among different queries are not

[jira] [Updated] (CALCITE-3932) Make data type cache thread local, non-evictable

2020-04-16 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3932: --- Description: Data type can be evicted out of cache, which is global, thread-safe. It

[jira] [Commented] (CALCITE-3149) CACHE in RelDataTypeFactoryImpl can't be garbage collected

2020-04-16 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085083#comment-17085083 ] Haisheng Yuan commented on CALCITE-3149: Correct, If the data type is in use, it should not be

[jira] [Commented] (CALCITE-3149) CACHE in RelDataTypeFactoryImpl can't be garbage collected

2020-04-16 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085043#comment-17085043 ] Haisheng Yuan commented on CALCITE-3149: Created JIRA:

[jira] [Created] (CALCITE-3932) Make data type cache thread local, non-evictable

2020-04-16 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-3932: -- Summary: Make data type cache thread local, non-evictable Key: CALCITE-3932 URL: https://issues.apache.org/jira/browse/CALCITE-3932 Project: Calcite

[jira] [Commented] (CALCITE-3149) CACHE in RelDataTypeFactoryImpl can't be garbage collected

2020-04-16 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084990#comment-17084990 ] Haisheng Yuan commented on CALCITE-3149: You know it is a cache, and cache can be evicted,

[jira] [Commented] (CALCITE-3927) RelSubset is not fired for rule when set gets merged

2020-04-15 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084366#comment-17084366 ] Haisheng Yuan commented on CALCITE-3927: That might be challenging. [~botong] Any easy case? >

[jira] [Updated] (CALCITE-3927) RelSubset is not fired for rule when set gets merged

2020-04-15 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3927: --- Description: In VolcanoPlanner, when set gets merged, planner fires rules again for

[jira] [Created] (CALCITE-3927) RelSubset is not fired for rule when set gets merged

2020-04-15 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-3927: -- Summary: RelSubset is not fired for rule when set gets merged Key: CALCITE-3927 URL: https://issues.apache.org/jira/browse/CALCITE-3927 Project: Calcite

[jira] [Commented] (CALCITE-3926) CannotPlanException when an empty LogicalValues requires a certain collation

2020-04-15 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084254#comment-17084254 ] Haisheng Yuan commented on CALCITE-3926: Hi [~rubenql], same conclusion here. Please go ahead

[jira] [Updated] (CALCITE-3926) CannotPlanException when an empty LogicalValues requires a certain collation

2020-04-15 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3926: --- Attachment: (was: image-2020-04-15-11-14-41-581.png) > CannotPlanException when an

[jira] [Updated] (CALCITE-3926) CannotPlanException when an empty LogicalValues requires a certain collation

2020-04-15 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3926: --- Attachment: image-2020-04-15-11-14-41-581.png > CannotPlanException when an empty

[jira] [Commented] (CALCITE-3926) CannotPlanException when an empty LogicalValues requires a certain collation

2020-04-15 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084110#comment-17084110 ] Haisheng Yuan commented on CALCITE-3926: Thanks for reporting, I will take a look. >

[jira] [Commented] (CALCITE-3896) Pass through parent trait requests to child operators

2020-04-14 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083523#comment-17083523 ] Haisheng Yuan commented on CALCITE-3896: Your example is not valid. When passing through parent

[jira] [Resolved] (CALCITE-3324) Infinite loop when calling DDL from remote Avatica driver to LocalService wrapping CalciteMetaImpl

2020-04-14 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3324. Fix Version/s: 1.23.0 Resolution: Fixed Fixed in

[jira] [Commented] (CALCITE-3917) Revive pruned node when a rule generates RelNode that is already pruned

2020-04-13 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17082802#comment-17082802 ] Haisheng Yuan commented on CALCITE-3917: [~danny0405] Your problem is easy to fix with some

[jira] [Resolved] (CALCITE-3576) Remove Enumerable convention check in FilterIntoJoinRule

2020-04-13 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3576. Fix Version/s: 1.23.0 Resolution: Fixed Fixed in

[jira] [Commented] (CALCITE-3920) Improve ORDER BY computation in Enumerable convention by exploiting LIMIT

2020-04-13 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17082397#comment-17082397 ] Haisheng Yuan commented on CALCITE-3920: Well, given that Enumerable is in-memory, that almost

[jira] [Commented] (CALCITE-3920) Improve ORDER BY computation in Enumerable convention by exploiting LIMIT

2020-04-13 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17082393#comment-17082393 ] Haisheng Yuan commented on CALCITE-3920: Maybe we don't have to implement them together. Simply

[jira] [Commented] (CALCITE-2593) Sometimes fails to plan when a RelNode transform multiple collations to single collation

2020-04-12 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081984#comment-17081984 ] Haisheng Yuan commented on CALCITE-2593: The most fundamental change is dropping

[jira] [Commented] (CALCITE-2010) Cannot plan query that is UNION ALL applied to VALUES

2020-04-12 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081960#comment-17081960 ] Haisheng Yuan commented on CALCITE-2010: Opened PR to fix the underlying issue:

[jira] [Resolved] (CALCITE-2010) Cannot plan query that is UNION ALL applied to VALUES

2020-04-12 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-2010. Fix Version/s: 1.23.0 Resolution: Fixed Fixed in

[jira] [Resolved] (CALCITE-3865) RelCollationTraitDef.canConvert should always return true

2020-04-12 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3865. Fix Version/s: 1.23.0 Resolution: Fixed Fixed in

[jira] [Resolved] (CALCITE-2593) Sometimes fails to plan when a RelNode transform multiple collations to single collation

2020-04-12 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-2593. Fix Version/s: 1.23.0 Resolution: Fixed Fixed in

[jira] [Resolved] (CALCITE-2592) EnumerableMergeJoin is never taken

2020-04-12 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-2592. Fix Version/s: 1.23.0 Resolution: Fixed Fixed in

[jira] [Commented] (CALCITE-3916) Apply rules bottom up by RelSet

2020-04-12 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081837#comment-17081837 ] Haisheng Yuan commented on CALCITE-3916: No matter before removing importance from subset or

[jira] [Comment Edited] (CALCITE-3916) Apply rules bottom up by RelSet

2020-04-12 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081819#comment-17081819 ] Haisheng Yuan edited comment on CALCITE-3916 at 4/12/20, 2:39 PM: -- Hi

[jira] [Commented] (CALCITE-3916) Apply rules bottom up by RelSet

2020-04-12 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081819#comment-17081819 ] Haisheng Yuan commented on CALCITE-3916: Hi [~zabetak], I understand that it might be a little

[jira] [Commented] (CALCITE-3917) Revive pruned node when a rule generates RelNode that is already pruned

2020-04-12 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081803#comment-17081803 ] Haisheng Yuan commented on CALCITE-3917: That is why many optimizers use walking through the

[jira] [Commented] (CALCITE-3917) Revive pruned node when a rule generates RelNode that is already pruned

2020-04-12 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081802#comment-17081802 ] Haisheng Yuan commented on CALCITE-3917: Yes, I agree. > Revive pruned node when a rule

[jira] [Created] (CALCITE-3918) SubQueryFilterRemoveRule failed to decorrelate subquery for TPCH q17

2020-04-11 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-3918: -- Summary: SubQueryFilterRemoveRule failed to decorrelate subquery for TPCH q17 Key: CALCITE-3918 URL: https://issues.apache.org/jira/browse/CALCITE-3918 Project:

[jira] [Commented] (CALCITE-3917) Revive pruned node when a rule generates RelNode that is already pruned

2020-04-11 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081573#comment-17081573 ] Haisheng Yuan commented on CALCITE-3917: It is open for pickup. > Revive pruned node when a

[jira] [Created] (CALCITE-3917) Revive pruned node when a rule generates RelNode that is already pruned

2020-04-11 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-3917: -- Summary: Revive pruned node when a rule generates RelNode that is already pruned Key: CALCITE-3917 URL: https://issues.apache.org/jira/browse/CALCITE-3917

[jira] [Assigned] (CALCITE-3916) Apply rules bottom up by RelSet

2020-04-11 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan reassigned CALCITE-3916: -- Assignee: Haisheng Yuan > Apply rules bottom up by RelSet >

[jira] [Created] (CALCITE-3916) Apply rules bottom up by RelSet

2020-04-11 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-3916: -- Summary: Apply rules bottom up by RelSet Key: CALCITE-3916 URL: https://issues.apache.org/jira/browse/CALCITE-3916 Project: Calcite Issue Type:

[jira] [Updated] (CALCITE-3915) Add rule listener to report rule attempts and time at DEBUG log level

2020-04-10 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3915: --- Description: We can add a rule listener to the VolcanoPlanner for recording rule attempts

[jira] [Updated] (CALCITE-3915) Add rule listener to report rule attempts and time at DEBUG log level

2020-04-10 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3915: --- Description: We can add a rule listener to the VolcanoPlanner for recording rule attempts

[jira] [Commented] (CALCITE-3913) Test correctness using formal verification techniques

2020-04-10 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081011#comment-17081011 ] Haisheng Yuan commented on CALCITE-3913: I think one use case is that there are tens of

<    1   2   3   4   5   6   7   8   9   10   >