[jira] [Commented] (CALCITE-6632) Wrong optimization because window missing constants in digest

2024-10-17 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17890442#comment-17890442 ] Jiajun Xie commented on CALCITE-6632: - [~asolimando] , ok. I added the digest and

[jira] [Updated] (CALCITE-6632) Wrong optimization because window missing constants in digest

2024-10-17 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiajun Xie updated CALCITE-6632: Description: Here is a simple case: {code:java} select sum(100) over (partition by deptno order b

[jira] [Updated] (CALCITE-6632) Wrong optimization because window missing constants in digest

2024-10-17 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiajun Xie updated CALCITE-6632: Description: Here is a simple case: {code:java} select sum(100) over (partition by deptno order b

[jira] [Updated] (CALCITE-6632) Wrong optimization because window missing constants in digest

2024-10-16 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiajun Xie updated CALCITE-6632: Environment: !image-2024-10-17-10-41-11-032.png|width=482,height=203! (was: !image-2024-10-17-10

[jira] [Created] (CALCITE-6632) Wrong optimization because window missing constants in digest

2024-10-16 Thread Jiajun Xie (Jira)
Jiajun Xie created CALCITE-6632: --- Summary: Wrong optimization because window missing constants in digest Key: CALCITE-6632 URL: https://issues.apache.org/jira/browse/CALCITE-6632 Project: Calcite

[jira] [Created] (CALCITE-6569) RelToSqlConverter support IGNORE NULLS for window functions

2024-09-10 Thread Jiajun Xie (Jira)
Jiajun Xie created CALCITE-6569: --- Summary: RelToSqlConverter support IGNORE NULLS for window functions Key: CALCITE-6569 URL: https://issues.apache.org/jira/browse/CALCITE-6569 Project: Calcite

[jira] [Comment Edited] (CALCITE-6317) Optimization CoreRules.PROJECT_REDUCE_EXPRESSIONS is unsound

2024-03-11 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825487#comment-17825487 ] Jiajun Xie edited comment on CALCITE-6317 at 3/12/24 1:55 AM: ---

[jira] [Commented] (CALCITE-6317) Optimization CoreRules.PROJECT_REDUCE_EXPRESSIONS is unsound

2024-03-11 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825487#comment-17825487 ] Jiajun Xie commented on CALCITE-6317: - For calcite user, the message maybe better:

[jira] [Created] (CALCITE-6318) Add some rules that WeTune discovers and verifies

2024-03-10 Thread Jiajun Xie (Jira)
Jiajun Xie created CALCITE-6318: --- Summary: Add some rules that WeTune discovers and verifies Key: CALCITE-6318 URL: https://issues.apache.org/jira/browse/CALCITE-6318 Project: Calcite Issue Typ

[jira] [Commented] (CALCITE-6193) If a query has more than one subexpression that matches a materialized view, only the first is substituted

2024-03-06 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824257#comment-17824257 ] Jiajun Xie commented on CALCITE-6193: - I was worried about side effects that from y

[jira] [Updated] (CALCITE-6193) If a query has more than one subexpression that matches a materialized view, only the first is substituted

2024-03-06 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiajun Xie updated CALCITE-6193: Fix Version/s: (was: 1.37.0) > If a query has more than one subexpression that matches a mate

[jira] [Comment Edited] (CALCITE-6193) If a query has more than one subexpression that matches a materialized view, only the first is substituted

2024-02-29 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822079#comment-17822079 ] Jiajun Xie edited comment on CALCITE-6193 at 2/29/24 11:01 AM: --

[jira] [Commented] (CALCITE-6193) If a query has more than one subexpression that matches a materialized view, only the first is substituted

2024-02-29 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822079#comment-17822079 ] Jiajun Xie commented on CALCITE-6193: - [~4wei] Your thinking is too one-sided.  

[jira] [Commented] (CALCITE-6193) If a query has more than one subexpression that matches a materialized view, only the first is substituted

2024-02-28 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821912#comment-17821912 ] Jiajun Xie commented on CALCITE-6193: - [~4wei] , `undo` is another issue. Please c

[jira] [Commented] (CALCITE-6193) If a query has more than one subexpression that matches a materialized view, only the first is substituted

2024-02-26 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820966#comment-17820966 ] Jiajun Xie commented on CALCITE-6193: - [~4wei] , Can you answer my question in PR?

[jira] [Resolved] (CALCITE-6273) Add sqrt negative test in SqlOperatorTest

2024-02-19 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiajun Xie resolved CALCITE-6273. - Resolution: Fixed > Add sqrt negative test in SqlOperatorTest > ---

[jira] [Commented] (CALCITE-6273) Add sqrt negative test in SqlOperatorTest

2024-02-19 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818608#comment-17818608 ] Jiajun Xie commented on CALCITE-6273: - Fixed in [31d66e7.|https://github.com/apach

[jira] [Commented] (CALCITE-6214) Remove DISTINCT in aggregate function if field is unique

2024-02-11 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816494#comment-17816494 ] Jiajun Xie commented on CALCITE-6214: - Fixed in [ec0dc3c|https://github.com/apache

[jira] [Resolved] (CALCITE-6214) Remove DISTINCT in aggregate function if field is unique

2024-02-11 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiajun Xie resolved CALCITE-6214. - Fix Version/s: 1.37.0 Resolution: Fixed > Remove DISTINCT in aggregate function if field

[jira] [Commented] (CALCITE-1317) Rewrite "MAX" as "ORDER BY ... LIMIT ..."

2024-02-03 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813895#comment-17813895 ] Jiajun Xie commented on CALCITE-1317: - Oh, I am thinking about similar optimization

[jira] [Updated] (CALCITE-6240) Remove ROW_NUMBER if OVER PARTITION BY unique key

2024-02-03 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiajun Xie updated CALCITE-6240: Priority: Minor (was: Major) > Remove ROW_NUMBER if OVER PARTITION BY unique key > -

[jira] [Updated] (CALCITE-6240) Remove ROW_NUMBER if OVER PARTITION BY unique key

2024-02-03 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiajun Xie updated CALCITE-6240: Summary: Remove ROW_NUMBER if OVER PARTITION BY unique key (was: Removed ROW_NUMBER if OVER PART

[jira] [Created] (CALCITE-6240) Removed ROW_NUMBER if OVER PARTITION BY unique key

2024-02-03 Thread Jiajun Xie (Jira)
Jiajun Xie created CALCITE-6240: --- Summary: Removed ROW_NUMBER if OVER PARTITION BY unique key Key: CALCITE-6240 URL: https://issues.apache.org/jira/browse/CALCITE-6240 Project: Calcite Issue Ty

[jira] [Commented] (CALCITE-6214) Remove DISTINCT in aggregate function if field is unique

2024-02-03 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813884#comment-17813884 ] Jiajun Xie commented on CALCITE-6214: - Sorry, I misunderstood. The distinct can be

[jira] [Commented] (CALCITE-6214) Remove DISTINCT in aggregate function if field is unique

2024-02-02 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813676#comment-17813676 ] Jiajun Xie commented on CALCITE-6214: - Yes, empno is unique key, we can remove dist

[jira] [Commented] (CALCITE-6193) If a query has more than one subexpression that matches a materialized view, only the first is substituted

2024-02-01 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813203#comment-17813203 ] Jiajun Xie commented on CALCITE-6193: - BTW, [~4wei] Do you have benchmark for you P

[jira] [Commented] (CALCITE-6193) If a query has more than one subexpression that matches a materialized view, only the first is substituted

2024-02-01 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813202#comment-17813202 ] Jiajun Xie commented on CALCITE-6193: - [~4wei] Sorry, I don't have enough time to r

[jira] [Commented] (CALCITE-6175) Upgrade OpenCSV to version 5

2024-01-28 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811708#comment-17811708 ] Jiajun Xie commented on CALCITE-6175: - Look good. [~ymlai87416] , I am very intere

[jira] [Commented] (CALCITE-6214) Remove DISTINCT in aggregate function if field is unique

2024-01-28 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811647#comment-17811647 ] Jiajun Xie commented on CALCITE-6214: - I removed `AggregateRemoveDistinctRule` and

[jira] [Resolved] (CALCITE-6199) Trim unused fields for SNAPSHOT and SAMPLE if table has VIRTUAL column

2024-01-27 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiajun Xie resolved CALCITE-6199. - Fix Version/s: 1.37.0 Resolution: Fixed > Trim unused fields for SNAPSHOT and SAMPLE if

[jira] [Commented] (CALCITE-6199) Trim unused fields for SNAPSHOT and SAMPLE if table has VIRTUAL column

2024-01-27 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811479#comment-17811479 ] Jiajun Xie commented on CALCITE-6199: - Fixed in [75511b8.|https://github.com/apach

[jira] [Commented] (CALCITE-6222) Mysql does not have to_char function

2024-01-26 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811250#comment-17811250 ] Jiajun Xie commented on CALCITE-6222: - Calcite has many users, and any compatibilit

[jira] [Commented] (CALCITE-6222) Mysql does not have to_char function

2024-01-26 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811245#comment-17811245 ] Jiajun Xie commented on CALCITE-6222: - MariaDB have it: [https://mariadb.com/kb/en/

[jira] [Comment Edited] (CALCITE-6214) Remove DISTINCT in aggregate function if field is unique

2024-01-21 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809214#comment-17809214 ] Jiajun Xie edited comment on CALCITE-6214 at 1/22/24 2:29 AM: ---

[jira] [Commented] (CALCITE-6214) Remove DISTINCT in aggregate function if field is unique

2024-01-21 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809214#comment-17809214 ] Jiajun Xie commented on CALCITE-6214: - 1. Changed `COUNT` to `aggregate function`.

[jira] [Updated] (CALCITE-6214) Remove DISTINCT in aggregate function if field is unique

2024-01-21 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiajun Xie updated CALCITE-6214: Summary: Remove DISTINCT in aggregate function if field is unique (was: Remove `DISTINCT` in `CO

[jira] [Resolved] (CALCITE-3952) Improve SortRemoveRule to remove Sort based on rowcount

2024-01-21 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiajun Xie resolved CALCITE-3952. - Resolution: Fixed > Improve SortRemoveRule to remove Sort based on rowcount > -

[jira] [Commented] (CALCITE-6201) Merge Aggregate node if count distinct column has been deduplicated

2024-01-21 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809092#comment-17809092 ] Jiajun Xie commented on CALCITE-6201: - Remove `DISTINCT` in count is a better solut

[jira] [Resolved] (CALCITE-6201) Merge Aggregate node if count distinct column has been deduplicated

2024-01-21 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiajun Xie resolved CALCITE-6201. - Resolution: Duplicate > Merge Aggregate node if count distinct column has been deduplicated > -

[jira] [Created] (CALCITE-6214) Remove `DISTINCT` in `COUNT` if field is unique

2024-01-21 Thread Jiajun Xie (Jira)
Jiajun Xie created CALCITE-6214: --- Summary: Remove `DISTINCT` in `COUNT` if field is unique Key: CALCITE-6214 URL: https://issues.apache.org/jira/browse/CALCITE-6214 Project: Calcite Issue Type:

[jira] [Commented] (CALCITE-6206) Add library operator mapping for unparsing

2024-01-17 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17808006#comment-17808006 ] Jiajun Xie commented on CALCITE-6206: - I have seen similar features before. There

[jira] [Updated] (CALCITE-6206) Add library operator mapping for unparsing

2024-01-17 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiajun Xie updated CALCITE-6206: Attachment: image-2024-01-18-13-13-02-636.png > Add library operator mapping for unparsing >

[jira] [Updated] (CALCITE-6206) Add library operator mapping for unparsing

2024-01-17 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiajun Xie updated CALCITE-6206: Attachment: (was: image-2024-01-18-13-13-02-636.png) > Add library operator mapping for unpar

[jira] [Created] (CALCITE-6201) Merge Aggregate node if count distinct column has been deduplicated

2024-01-13 Thread Jiajun Xie (Jira)
Jiajun Xie created CALCITE-6201: --- Summary: Merge Aggregate node if count distinct column has been deduplicated Key: CALCITE-6201 URL: https://issues.apache.org/jira/browse/CALCITE-6201 Project: Calcite

[jira] [Created] (CALCITE-6200) RelJson throw UnsupportedOperationException for RexDynamicParam

2024-01-13 Thread Jiajun Xie (Jira)
Jiajun Xie created CALCITE-6200: --- Summary: RelJson throw UnsupportedOperationException for RexDynamicParam Key: CALCITE-6200 URL: https://issues.apache.org/jira/browse/CALCITE-6200 Project: Calcite

[jira] [Resolved] (CALCITE-3952) Improve SortRemoveRule to remove Sort based on rowcount

2024-01-13 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiajun Xie resolved CALCITE-3952. - Resolution: Fixed > Improve SortRemoveRule to remove Sort based on rowcount > -

[jira] [Updated] (CALCITE-3952) Improve SortRemoveRule to remove Sort based on rowcount

2024-01-13 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiajun Xie updated CALCITE-3952: Fix Version/s: 1.36.0 > Improve SortRemoveRule to remove Sort based on rowcount > ---

[jira] [Reopened] (CALCITE-3952) Improve SortRemoveRule to remove Sort based on rowcount

2024-01-13 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiajun Xie reopened CALCITE-3952: - > Improve SortRemoveRule to remove Sort based on rowcount > ---

[jira] [Commented] (CALCITE-3952) Improve SortRemoveRule to remove Sort based on rowcount

2024-01-13 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806419#comment-17806419 ] Jiajun Xie commented on CALCITE-3952: - I think that we solved it in 1.36 and I add

[jira] [Created] (CALCITE-6199) Trim unused fields for SNAPSHOT and SAMPLE if table has VIRTUAL column

2024-01-13 Thread Jiajun Xie (Jira)
Jiajun Xie created CALCITE-6199: --- Summary: Trim unused fields for SNAPSHOT and SAMPLE if table has VIRTUAL column Key: CALCITE-6199 URL: https://issues.apache.org/jira/browse/CALCITE-6199 Project: Calc

[jira] [Updated] (CALCITE-6199) Trim unused fields for SNAPSHOT and SAMPLE if table has VIRTUAL column

2024-01-13 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiajun Xie updated CALCITE-6199: Description: RelFieldTrimmer not support SNAPSHOT( So do Sample) * Here is a SQL example {code:j

[jira] [Commented] (CALCITE-6193) SubstitutionVisitor stop trying incorrect subtree because of wrong parent relationship when replace query

2024-01-12 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806244#comment-17806244 ] Jiajun Xie commented on CALCITE-6193: - I think the root cause is always `[getInput

[jira] [Comment Edited] (CALCITE-6193) SubstitutionVisitor stop trying incorrect subtree because of wrong parent relationship when replace query

2024-01-11 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805862#comment-17805862 ] Jiajun Xie edited comment on CALCITE-6193 at 1/12/24 2:30 AM: ---

[jira] [Commented] (CALCITE-6193) SubstitutionVisitor stop trying incorrect subtree because of wrong parent relationship when replace query

2024-01-11 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805862#comment-17805862 ] Jiajun Xie commented on CALCITE-6193: - [~4wei] , Do you try to use `SubstitutionVis

[jira] [Commented] (CALCITE-6193) SubstitutionVisitor stop trying incorrect subtree because of wrong parent relationship when replace query

2024-01-09 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804970#comment-17804970 ] Jiajun Xie commented on CALCITE-6193: - [~4wei] Yes, your PR is at work for that sim

[jira] [Comment Edited] (CALCITE-6193) SubstitutionVisitor stop trying incorrect subtree because of wrong parent relationship when replace query

2024-01-09 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804944#comment-17804944 ] Jiajun Xie edited comment on CALCITE-6193 at 1/10/24 2:22 AM: ---

[jira] [Commented] (CALCITE-6193) SubstitutionVisitor stop trying incorrect subtree because of wrong parent relationship when replace query

2024-01-09 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804944#comment-17804944 ] Jiajun Xie commented on CALCITE-6193: - The issue is not related to the filter condi

[jira] [Comment Edited] (CALCITE-6193) SubstitutionVisitor stop trying incorrect subtree because of wrong parent relationship when replace query

2024-01-09 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804944#comment-17804944 ] Jiajun Xie edited comment on CALCITE-6193 at 1/10/24 2:22 AM: ---

[jira] [Resolved] (CALCITE-6191) Remove join if input is one row literal

2024-01-07 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiajun Xie resolved CALCITE-6191. - Resolution: Fixed > Remove join if input is one row literal > -

[jira] [Created] (CALCITE-6191) Remove join if input is one row literal

2024-01-07 Thread Jiajun Xie (Jira)
Jiajun Xie created CALCITE-6191: --- Summary: Remove join if input is one row literal Key: CALCITE-6191 URL: https://issues.apache.org/jira/browse/CALCITE-6191 Project: Calcite Issue Type: Improve

[jira] [Commented] (CALCITE-6131) There are duplicate sample tests in SqlTypeUtilTest

2023-12-11 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795565#comment-17795565 ] Jiajun Xie commented on CALCITE-6131: - Fixed in [https://github.com/apache/calcite

[jira] [Resolved] (CALCITE-6131) There are duplicate sample tests in SqlTypeUtilTest

2023-12-11 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiajun Xie resolved CALCITE-6131. - Resolution: Fixed > There are duplicate sample tests in SqlTypeUtilTest > -

[jira] [Resolved] (CALCITE-5811) Error messages produced for constant out-of-bounds arguments are confusing

2023-12-11 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiajun Xie resolved CALCITE-5811. - Resolution: Fixed > Error messages produced for constant out-of-bounds arguments are confusing

[jira] [Updated] (CALCITE-5811) Error messages produced for constant out-of-bounds arguments are confusing

2023-12-11 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiajun Xie updated CALCITE-5811: Fix Version/s: 1.37.0 > Error messages produced for constant out-of-bounds arguments are confusin

[jira] [Commented] (CALCITE-5811) Error messages produced for constant out-of-bounds arguments are confusing

2023-12-11 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795562#comment-17795562 ] Jiajun Xie commented on CALCITE-5811: - Fixed in [https://github.com/apache/calcite

[jira] [Commented] (CALCITE-5791) DDL commands ceased to work in 1.23-1.24 transition

2023-12-11 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795558#comment-17795558 ] Jiajun Xie commented on CALCITE-5791: - I removed the label and 'Fix Versions'.  

[jira] [Updated] (CALCITE-5791) DDL commands ceased to work in 1.23-1.24 transition

2023-12-11 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiajun Xie updated CALCITE-5791: Fix Version/s: (was: 1.23.0) Labels: (was: newbie) > DDL commands ceased to work

[jira] [Updated] (CALCITE-6145) Function 'TRIM' without parameters throw NullPointerException

2023-12-11 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiajun Xie updated CALCITE-6145: Labels: newbie (was: easy-fix) > Function 'TRIM' without parameters throw NullPointerException >

[jira] [Updated] (CALCITE-5525) GROUPING_ID() should be rewritten to GROUPING() for some dialects in RelToSqlConverter

2023-12-11 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiajun Xie updated CALCITE-5525: Labels: newbie (was: easy-fix) > GROUPING_ID() should be rewritten to GROUPING() for some dialec

[jira] [Updated] (CALCITE-6145) Function 'TRIM' without parameters throw NullPointerException

2023-12-09 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiajun Xie updated CALCITE-6145: Labels: easy-fix (was: ) > Function 'TRIM' without parameters throw NullPointerException > -

[jira] [Updated] (CALCITE-5525) GROUPING_ID() should be rewritten to GROUPING() for some dialects in RelToSqlConverter

2023-12-09 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiajun Xie updated CALCITE-5525: Labels: easy-fix (was: ) > GROUPING_ID() should be rewritten to GROUPING() for some dialects in

[jira] [Commented] (CALCITE-6161) The equalsDeep of sqlCall should compare sqlOperator's sqlKind

2023-12-08 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794928#comment-17794928 ] Jiajun Xie commented on CALCITE-6161: - [~jiefei30] I'm worried that the change will

[jira] [Commented] (CALCITE-6123) DruidAdapterIT#testInterleaveBetweenAggregateAndGroupOrderByOnMetrics fails

2023-12-06 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793695#comment-17793695 ] Jiajun Xie commented on CALCITE-6123: - [~zabetak], Nice work. After running CI aga

[jira] [Resolved] (CALCITE-6093) Unstable unit test in Druid tests

2023-12-06 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiajun Xie resolved CALCITE-6093. - Resolution: Duplicate > Unstable unit test in Druid tests > - >

[jira] [Commented] (CALCITE-6123) DruidAdapter2IT is failing

2023-12-03 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792632#comment-17792632 ] Jiajun Xie commented on CALCITE-6123: - Thank you for your suggestion, [~libenchao] 

[jira] [Commented] (CALCITE-6093) Unstable unit test in Druid tests

2023-12-03 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792517#comment-17792517 ] Jiajun Xie commented on CALCITE-6093: - Zulu JDK8 seems to be stable and successful

[jira] [Commented] (CALCITE-6123) DruidAdapter2IT is failing

2023-12-03 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792502#comment-17792502 ] Jiajun Xie commented on CALCITE-6123: - calcite-druid-dataset is innocent. The bug

[jira] [Commented] (CALCITE-6140) Add percentile test on SqlParserTest

2023-11-28 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790842#comment-17790842 ] Jiajun Xie commented on CALCITE-6140: - [~caicancai]  What do you mean the results?

[jira] [Commented] (CALCITE-6123) DruidAdapter2IT is failing

2023-11-25 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789626#comment-17789626 ] Jiajun Xie commented on CALCITE-6123: - Oh, I found the issue:[https://github.com/ap

[jira] [Commented] (CALCITE-6130) Transformation optimization of different physical conventions on the production of new physical nodes

2023-11-23 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789288#comment-17789288 ] Jiajun Xie commented on CALCITE-6130: - I removed fix version 1.36.0 because 1.36.0

[jira] [Updated] (CALCITE-6130) Transformation optimization of different physical conventions on the production of new physical nodes

2023-11-23 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiajun Xie updated CALCITE-6130: Fix Version/s: (was: 1.36.0) > Transformation optimization of different physical conventions

[jira] [Commented] (CALCITE-6121) Invalid unparse for TIMESTAMP with SparkSqlDialect

2023-11-20 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788216#comment-17788216 ] Jiajun Xie commented on CALCITE-6121: - Fixed in [8556807|https://github.com/apache

[jira] [Resolved] (CALCITE-6121) Invalid unparse for TIMESTAMP with SparkSqlDialect

2023-11-20 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiajun Xie resolved CALCITE-6121. - Fix Version/s: 1.37.0 Resolution: Fixed > Invalid unparse for TIMESTAMP with SparkSqlDia

[jira] [Commented] (CALCITE-6123) DruidAdapter2IT is failing

2023-11-19 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787571#comment-17787571 ] Jiajun Xie commented on CALCITE-6123: - It seems that there were many changes in the

[jira] [Comment Edited] (CALCITE-6123) DruidAdapter2IT is failing

2023-11-18 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787567#comment-17787567 ] Jiajun Xie edited comment on CALCITE-6123 at 11/19/23 7:25 AM: --

[jira] [Commented] (CALCITE-6123) DruidAdapter2IT is failing

2023-11-18 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787567#comment-17787567 ] Jiajun Xie commented on CALCITE-6123: - The first failed in the main branch is http

[jira] [Updated] (CALCITE-6123) DruidAdapter2IT is failing

2023-11-18 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiajun Xie updated CALCITE-6123: Attachment: image-2023-11-19-15-17-53-699.png > DruidAdapter2IT is failing > ---

[jira] [Commented] (CALCITE-6123) DruidAdapter2IT is failing

2023-11-18 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787559#comment-17787559 ] Jiajun Xie commented on CALCITE-6123: - [~libenchao], I rerun *Druid Tests* in your

[jira] [Commented] (CALCITE-6121) Invalid unparse for TIMESTAMP with SparkSqlDialect

2023-11-18 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787467#comment-17787467 ] Jiajun Xie commented on CALCITE-6121: - +1, Presto does not support TIMESTAMP with p

[jira] [Assigned] (CALCITE-6121) Invalid unparse for TIMESTAMP with SparkSqlDialect

2023-11-17 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiajun Xie reassigned CALCITE-6121: --- Assignee: Jiajun Xie > Invalid unparse for TIMESTAMP with SparkSqlDialect > --

[jira] [Commented] (CALCITE-6102) SqlWriter in SqlInsert's unparse start a list but does not end it

2023-11-15 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786573#comment-17786573 ] Jiajun Xie commented on CALCITE-6102: - Fixed in [db192e9|https://github.com/apache

[jira] [Resolved] (CALCITE-6102) SqlWriter in SqlInsert's unparse start a list but does not end it

2023-11-15 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiajun Xie resolved CALCITE-6102. - Resolution: Fixed > SqlWriter in SqlInsert's unparse start a list but does not end it > ---

[jira] [Commented] (CALCITE-6102) SqlWriter in SqlInsert's unparse start a list but does not end it

2023-11-13 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785716#comment-17785716 ] Jiajun Xie commented on CALCITE-6102: - [~jiefei30] You clearly explained the reason

[jira] [Resolved] (CALCITE-6088) SqlItemOperator fails in RelToSqlConverter

2023-11-05 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiajun Xie resolved CALCITE-6088. - Fix Version/s: 1.36.0 Resolution: Fixed > SqlItemOperator fails in RelToSqlConverter > -

[jira] [Commented] (CALCITE-6088) SqlItemOperator fails in RelToSqlConverter

2023-11-05 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782967#comment-17782967 ] Jiajun Xie commented on CALCITE-6088: - Fixed in [94dc167.|https://github.com/apach

[jira] [Assigned] (CALCITE-6088) SqlItemOperator fails in RelToSqlConverter

2023-11-04 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiajun Xie reassigned CALCITE-6088: --- Assignee: Jiajun Xie > SqlItemOperator fails in RelToSqlConverter > --

[jira] [Updated] (CALCITE-6093) Unstable unit test in Druid tests

2023-11-03 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiajun Xie updated CALCITE-6093: Summary: Unstable unit test in Druid tests (was: Unstable unit tes in Druid tests) > Unstable u

[jira] [Updated] (CALCITE-6093) Unstable unit tes in Druid tests

2023-11-03 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiajun Xie updated CALCITE-6093: Description: FAILURE 38.6sec, 235 completed, 1 failed, 6 skipped, org.apache.calcite.test.

[jira] [Created] (CALCITE-6093) Unstable unit tes in Druid tests

2023-11-03 Thread Jiajun Xie (Jira)
Jiajun Xie created CALCITE-6093: --- Summary: Unstable unit tes in Druid tests Key: CALCITE-6093 URL: https://issues.apache.org/jira/browse/CALCITE-6093 Project: Calcite Issue Type: Improvement

[jira] [Updated] (CALCITE-6091) Char that in array or map is truncated if CASE WHEN statement contains null

2023-11-03 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiajun Xie updated CALCITE-6091: Summary: Char that in array or map is truncated if CASE WHEN statement contains null (was: Char

  1   2   3   4   5   6   >