[jira] [Commented] (CALCITE-4787) Evaluate use of Immutables instead of ImmutableBeans

2021-09-22 Thread Laurent Goujon (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17418763#comment-17418763 ] Laurent Goujon commented on CALCITE-4787: - {quote} My last concern is compatibility. If a

[jira] [Commented] (CALCITE-4224) Add an method for RelNode to output its tree digest like RelOptUtil.toString

2020-09-09 Thread Laurent Goujon (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193075#comment-17193075 ] Laurent Goujon commented on CALCITE-4224: - I'm not sure I see how much more convenient it is to

[jira] [Commented] (CALCITE-4025) DelegatingScope#fullyQualify may exit too soon when resolving table alias

2020-08-20 Thread Laurent Goujon (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181450#comment-17181450 ] Laurent Goujon commented on CALCITE-4025: - Thinking more about it (and before changing the

[jira] [Commented] (CALCITE-4025) DelegatingScope#fullyQualify may exit too soon when resolving table alias

2020-08-20 Thread Laurent Goujon (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181443#comment-17181443 ] Laurent Goujon commented on CALCITE-4025: - Sure. Does the test case look valid at least? >

[jira] [Commented] (CALCITE-4179) org.apache.calcite.jdbc package polluting core Calcite planning packages

2020-08-20 Thread Laurent Goujon (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181251#comment-17181251 ] Laurent Goujon commented on CALCITE-4179: - Likely. I went over open JIRAs to find similar

[jira] [Created] (CALCITE-4179) org.apache.calcite.jdbc package polluting core Calcite planning packages

2020-08-17 Thread Laurent Goujon (Jira)
Laurent Goujon created CALCITE-4179: --- Summary: org.apache.calcite.jdbc package polluting core Calcite planning packages Key: CALCITE-4179 URL: https://issues.apache.org/jira/browse/CALCITE-4179

[jira] [Resolved] (CALCITE-4092) NPE using WITH clause without a corresponding SELECT FROM

2020-07-13 Thread Laurent Goujon (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laurent Goujon resolved CALCITE-4092. - Fix Version/s: 1.24.0 Resolution: Fixed Merged as commit

[jira] [Updated] (CALCITE-4092) NPE using WITH clause without a corresponding SELECT FROM

2020-06-25 Thread Laurent Goujon (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laurent Goujon updated CALCITE-4092: Component/s: core > NPE using WITH clause without a corresponding SELECT FROM >

[jira] [Comment Edited] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-16 Thread Laurent Goujon (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17137805#comment-17137805 ] Laurent Goujon edited comment on CALCITE-3786 at 6/17/20, 1:00 AM: ---

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-16 Thread Laurent Goujon (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17137805#comment-17137805 ] Laurent Goujon commented on CALCITE-3786: - {quote} Laurent Goujon It seems that you have some

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-15 Thread Laurent Goujon (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17136282#comment-17136282 ] Laurent Goujon commented on CALCITE-3786: - I'm not sure I understand why the change has been

[jira] [Reopened] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-15 Thread Laurent Goujon (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laurent Goujon reopened CALCITE-3786: - > Add Digest interface to enable efficient hashCode(equals) for RexNode and > RelNode >

[jira] [Commented] (CALCITE-4025) DelegatingScope#fullyQualify may exit too soon when resolving table alias

2020-05-26 Thread Laurent Goujon (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117160#comment-17117160 ] Laurent Goujon commented on CALCITE-4025: - Thanks for helping me on the the test case, I'll try

[jira] [Assigned] (CALCITE-4025) DelegatingScope#fullyQualify may exit too soon when resolving table alias

2020-05-26 Thread Laurent Goujon (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laurent Goujon reassigned CALCITE-4025: --- Assignee: Laurent Goujon > DelegatingScope#fullyQualify may exit too soon when

[jira] [Commented] (CALCITE-4025) DelegatingScope#fullyQualify may exit too soon when resolving table alias

2020-05-26 Thread Laurent Goujon (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117149#comment-17117149 ] Laurent Goujon commented on CALCITE-4025: - I mentioned it as a possible issue on the Calcite

[jira] [Updated] (CALCITE-4025) DelegatingScope#fullyQualify may exit too soon when resolving table alias

2020-05-26 Thread Laurent Goujon (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laurent Goujon updated CALCITE-4025: Issue Type: Bug (was: Improvement) > DelegatingScope#fullyQualify may exit too soon

[jira] [Created] (CALCITE-4025) DelegatingScope#fullyQualify may exit too soon when resolving table alias

2020-05-26 Thread Laurent Goujon (Jira)
Laurent Goujon created CALCITE-4025: --- Summary: DelegatingScope#fullyQualify may exit too soon when resolving table alias Key: CALCITE-4025 URL: https://issues.apache.org/jira/browse/CALCITE-4025

[jira] [Commented] (CALCITE-3996) Fix NPE when query syntax is invalid

2020-05-13 Thread Laurent Goujon (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1710#comment-1710 ] Laurent Goujon commented on CALCITE-3996: - Can you please provide a more detailed description?

[jira] [Commented] (CALCITE-3956) Unify comparison logic for RelOptCost

2020-05-07 Thread Laurent Goujon (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101806#comment-17101806 ] Laurent Goujon commented on CALCITE-3956: - I'm dubious about this change: Like Julian, I'm not

[jira] [Resolved] (CALCITE-3965) Excessive time waiting on DiffRepository lock

2020-05-06 Thread Laurent Goujon (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laurent Goujon resolved CALCITE-3965. - Fix Version/s: 1.23.0 Resolution: Fixed Changed merged as

[jira] [Commented] (CALCITE-3965) Excessive time waiting on DiffRepository lock

2020-05-06 Thread Laurent Goujon (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101202#comment-17101202 ] Laurent Goujon commented on CALCITE-3965: - Sounds reasonable > Excessive time waiting on

[jira] [Commented] (CALCITE-3517) DiffRepository spends too much time writing XML, makes some tests 5x slower

2020-05-06 Thread Laurent Goujon (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101182#comment-17101182 ] Laurent Goujon commented on CALCITE-3517: - I'm proposing a patch to create a JUnit extension to

[jira] [Commented] (CALCITE-3965) Excessive time waiting on DiffRepository lock

2020-05-06 Thread Laurent Goujon (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101161#comment-17101161 ] Laurent Goujon commented on CALCITE-3965: - I guess after all this time, I still don't know how

[jira] [Commented] (CALCITE-3965) Excessive time waiting on DiffRepository lock

2020-04-30 Thread Laurent Goujon (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097079#comment-17097079 ] Laurent Goujon commented on CALCITE-3965: - I agree with the unnecessary xml writing, but adding

[jira] [Commented] (CALCITE-3965) Excessive time waiting on DiffRepository lock

2020-04-30 Thread Laurent Goujon (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097071#comment-17097071 ] Laurent Goujon commented on CALCITE-3965: - This is somehow related to CALCITE-3517, but after a

[jira] [Created] (CALCITE-3965) Excessive time waiting on DiffRepository lock

2020-04-30 Thread Laurent Goujon (Jira)
Laurent Goujon created CALCITE-3965: --- Summary: Excessive time waiting on DiffRepository lock Key: CALCITE-3965 URL: https://issues.apache.org/jira/browse/CALCITE-3965 Project: Calcite

[jira] [Commented] (CALCITE-3187) Derive all decimal return type through type factory

2019-07-31 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897591#comment-16897591 ] Laurent Goujon commented on CALCITE-3187: - According to Travis CI, {{-Werror}} is not causing

[jira] [Commented] (CALCITE-3187) Derive all decimal return type through type factory

2019-07-31 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897568#comment-16897568 ] Laurent Goujon commented on CALCITE-3187: - Here's a pull request to address compiler warnings

[jira] [Commented] (CALCITE-3187) Derive all decimal return type through type factory

2019-07-31 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897552#comment-16897552 ] Laurent Goujon commented on CALCITE-3187: - For {{RelDataTypeFactoryImpl}}, shouldn't I suppress

[jira] [Comment Edited] (CALCITE-3216) ClassCastException when running window function over union

2019-07-26 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893969#comment-16893969 ] Laurent Goujon edited comment on CALCITE-3216 at 7/26/19 4:32 PM: -- The

[jira] [Commented] (CALCITE-3216) ClassCastException when running window function over union

2019-07-26 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893969#comment-16893969 ] Laurent Goujon commented on CALCITE-3216: - The problem is likely to be common to any set

[jira] [Created] (CALCITE-3216) ClassCastException when running window function over union

2019-07-26 Thread Laurent Goujon (JIRA)
Laurent Goujon created CALCITE-3216: --- Summary: ClassCastException when running window function over union Key: CALCITE-3216 URL: https://issues.apache.org/jira/browse/CALCITE-3216 Project: Calcite

[jira] [Resolved] (CALCITE-3187) Derive all decimal return type through type factory

2019-07-16 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laurent Goujon resolved CALCITE-3187. - Resolution: Fixed Fix Version/s: 1.21.0 Fixed with commit

[jira] [Assigned] (CALCITE-3187) Derive all decimal return type through type factory

2019-07-16 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laurent Goujon reassigned CALCITE-3187: --- Assignee: Laurent Goujon > Derive all decimal return type through type factory >

[jira] [Commented] (CALCITE-3187) Derive all decimal return type through type factory

2019-07-15 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885548#comment-16885548 ] Laurent Goujon commented on CALCITE-3187: - Will do. > Derive all decimal return type through

[jira] [Commented] (CALCITE-3187) Derive all decimal return type through type factory

2019-07-11 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883256#comment-16883256 ] Laurent Goujon commented on CALCITE-3187: - Correct, my bad. Sounds reasonable to me.

[jira] [Commented] (CALCITE-3183) Trimming method for Filter rel uses wrong traitSet

2019-07-11 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883185#comment-16883185 ] Laurent Goujon commented on CALCITE-3183: - why not using {{Iterable}} for the factory too? it

[jira] [Commented] (CALCITE-3187) Derive all decimal return type through type factory

2019-07-10 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882235#comment-16882235 ] Laurent Goujon commented on CALCITE-3187: - I was wondering about this. It seems that long time

[jira] [Commented] (CALCITE-3111) Allow custom implementations of Correlate in RelDecorrelator

2019-06-12 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862317#comment-16862317 ] Laurent Goujon commented on CALCITE-3111: - Working in the same team as [~Juhwan], yes, it is

[jira] [Commented] (CALCITE-3111) Allow custom implementations of Correlate in RelDecorrelator

2019-06-12 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862320#comment-16862320 ] Laurent Goujon commented on CALCITE-3111: - {quote} I guess it would be convenient to generalize

[jira] [Resolved] (CALCITE-3082) NPE in SqlUtil#getSelectListItem

2019-05-30 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laurent Goujon resolved CALCITE-3082. - Resolution: Fixed Fix Version/s: 1.20.0 Fixed in

[jira] [Commented] (CALCITE-3101) PushDownJoinConditions is not always a valid transformation

2019-05-30 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852036#comment-16852036 ] Laurent Goujon commented on CALCITE-3101: - {quote} Laurent Goujon, I agree, but whether we

[jira] [Commented] (CALCITE-3101) PushDownJoinConditions is not always a valid transformation

2019-05-29 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851485#comment-16851485 ] Laurent Goujon commented on CALCITE-3101: - One could argue that in Calcite dialect/Rel tree,

[jira] [Commented] (CALCITE-3085) Unused stack field in RelShuttleImpl

2019-05-28 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850155#comment-16850155 ] Laurent Goujon commented on CALCITE-3085: - It's so useful no subclasses uses it (unlike

[jira] [Commented] (CALCITE-3085) Unused stack field in RelShuttleImpl

2019-05-22 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846395#comment-16846395 ] Laurent Goujon commented on CALCITE-3085: - This is why I did check on Github. [~danny0405] are

[jira] [Commented] (CALCITE-3085) Unused stack field in RelShuttleImpl

2019-05-22 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846271#comment-16846271 ] Laurent Goujon commented on CALCITE-3085: - Alternative would be to create a variant of the

[jira] [Updated] (CALCITE-3085) Unused stack field in RelShuttleImpl

2019-05-22 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laurent Goujon updated CALCITE-3085: Priority: Minor (was: Major) > Unused stack field in RelShuttleImpl >

[jira] [Updated] (CALCITE-3085) Unused stack field in RelShuttleImpl

2019-05-22 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laurent Goujon updated CALCITE-3085: Issue Type: Improvement (was: Bug) > Unused stack field in RelShuttleImpl >

[jira] [Created] (CALCITE-3085) Unused stack field in RelShuttleImpl

2019-05-22 Thread Laurent Goujon (JIRA)
Laurent Goujon created CALCITE-3085: --- Summary: Unused stack field in RelShuttleImpl Key: CALCITE-3085 URL: https://issues.apache.org/jira/browse/CALCITE-3085 Project: Calcite Issue Type:

[jira] [Resolved] (CALCITE-2807) Identify expanded IS NOT DISTINCT FROM expression when pushing down filter past join

2019-05-22 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laurent Goujon resolved CALCITE-2807. - Resolution: Fixed Assignee: Laurent Goujon Fix Version/s: 1.20.0 >

[jira] [Commented] (CALCITE-2807) Identify expanded IS NOT DISTINCT FROM expression when pushing down filter past join

2019-05-21 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845293#comment-16845293 ] Laurent Goujon commented on CALCITE-2807: - I was not necessary thinking of Github guidelines

[jira] [Commented] (CALCITE-2807) Identify expanded IS NOT DISTINCT FROM expression when pushing down filter past join

2019-05-21 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845286#comment-16845286 ] Laurent Goujon commented on CALCITE-2807: - I agree that IDNF is jargon but I actually mentioned

[jira] [Updated] (CALCITE-3082) NPE in SqlUtil#getSelectListItem

2019-05-21 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laurent Goujon updated CALCITE-3082: Description: Queries similar to {{SELECT 1 UNION SELECT 2, 3}} causes validator to

[jira] [Created] (CALCITE-3082) NPE in SqlUtil#getSelectListItem

2019-05-21 Thread Laurent Goujon (JIRA)
Laurent Goujon created CALCITE-3082: --- Summary: NPE in SqlUtil#getSelectListItem Key: CALCITE-3082 URL: https://issues.apache.org/jira/browse/CALCITE-3082 Project: Calcite Issue Type: Bug

[jira] [Commented] (CALCITE-2421) RexSimplify#simplifyAnds foregoes some simplications if unknownAsFalse set to true

2019-05-17 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842764#comment-16842764 ] Laurent Goujon commented on CALCITE-2421: - [~kgyrtkirk] sorry for not being responsive. No

[jira] [Commented] (CALCITE-2397) Column Index not getting set on correlationIds

2019-05-17 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842498#comment-16842498 ] Laurent Goujon commented on CALCITE-2397: - [~julianhyde] [~vladimirsitnikov] we missed some of

[jira] [Resolved] (CALCITE-3062) Do not populate provenanceMap if not used

2019-05-16 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laurent Goujon resolved CALCITE-3062. - Resolution: Fixed Fix Version/s: 1.20.0 Merged as

[jira] [Resolved] (CALCITE-2803) Identify expanded IS NOT DISTINCT FROM expression when pushing project past join

2019-05-13 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laurent Goujon resolved CALCITE-2803. - Resolution: Fixed > Identify expanded IS NOT DISTINCT FROM expression when pushing

[jira] [Updated] (CALCITE-2803) Identify expanded IS NOT DISTINCT FROM expression when pushing project past join

2019-05-13 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laurent Goujon updated CALCITE-2803: Fix Version/s: 1.20.0 > Identify expanded IS NOT DISTINCT FROM expression when pushing

[jira] [Assigned] (CALCITE-2803) Identify expanded IS NOT DISTINCT FROM expression when pushing project past join

2019-05-13 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laurent Goujon reassigned CALCITE-2803: --- Assignee: Laurent Goujon > Identify expanded IS NOT DISTINCT FROM expression when

[jira] [Commented] (CALCITE-3062) Do not populate provenanceMap if not used

2019-05-13 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838652#comment-16838652 ] Laurent Goujon commented on CALCITE-3062: - To my knowledge, I don't recollect looking at the

[jira] [Commented] (CALCITE-3062) Do not populate provenanceMap if not used

2019-05-11 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837894#comment-16837894 ] Laurent Goujon commented on CALCITE-3062: - Can you clarify what do you mean by that? There's

[jira] [Commented] (CALCITE-3062) Do not populate provenanceMap if not used

2019-05-10 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837762#comment-16837762 ] Laurent Goujon commented on CALCITE-3062: - I didn't observe the behavior you mention. Based on

[jira] [Created] (CALCITE-3062) Do not populate provenanceMap if not used

2019-05-10 Thread Laurent Goujon (JIRA)
Laurent Goujon created CALCITE-3062: --- Summary: Do not populate provenanceMap if not used Key: CALCITE-3062 URL: https://issues.apache.org/jira/browse/CALCITE-3062 Project: Calcite Issue

[jira] [Resolved] (CALCITE-2340) Invalid cast generated by AvgVarianceConvertlet

2019-03-05 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laurent Goujon resolved CALCITE-2340. - Resolution: Fixed Fix Version/s: 1.18.0 > Invalid cast generated by

[jira] [Commented] (CALCITE-2340) Invalid cast generated by AvgVarianceConvertlet

2019-03-05 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785024#comment-16785024 ] Laurent Goujon commented on CALCITE-2340: - Actually fixed as part of the work for CALCITE-2402

[jira] [Resolved] (CALCITE-2830) Fix AvgVarianceConvertlet

2019-03-05 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laurent Goujon resolved CALCITE-2830. - Resolution: Duplicate > Fix AvgVarianceConvertlet > - > >

[jira] [Commented] (CALCITE-2340) Invalid cast generated by AvgVarianceConvertlet

2019-03-05 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784993#comment-16784993 ] Laurent Goujon commented on CALCITE-2340: - Let me do that > Invalid cast generated by

[jira] [Commented] (CALCITE-2142) Set rand() function as non-deterministic.

2019-02-28 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781156#comment-16781156 ] Laurent Goujon commented on CALCITE-2142: - Moreover RAND(1) is deterministic row wise, but not

[jira] [Commented] (CALCITE-2142) Set rand() function as non-deterministic.

2019-02-28 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781152#comment-16781152 ] Laurent Goujon commented on CALCITE-2142: - Sorry for the long delay. First, I think there is

[jira] [Commented] (CALCITE-2823) Prevent optimization of non-deterministic functions

2019-02-28 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781102#comment-16781102 ] Laurent Goujon commented on CALCITE-2823: - Is RAND() deterministic? no, because it returns a

[jira] [Commented] (CALCITE-2827) Allow CONVENTION.NONE planning with VolcanoPlanner

2019-02-27 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779974#comment-16779974 ] Laurent Goujon commented on CALCITE-2827: - Didn't I answer it? Our planner has a planning phase

[jira] [Resolved] (CALCITE-2827) Allow CONVENTION.NONE planning with VolcanoPlanner

2019-02-27 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laurent Goujon resolved CALCITE-2827. - Resolution: Fixed Fix Version/s: 1.19.0 > Allow CONVENTION.NONE planning with

[jira] [Assigned] (CALCITE-2827) Allow CONVENTION.NONE planning with VolcanoPlanner

2019-02-27 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laurent Goujon reassigned CALCITE-2827: --- Assignee: Juhwan Kim > Allow CONVENTION.NONE planning with VolcanoPlanner >

[jira] [Commented] (CALCITE-2827) Allow CONVENTION.NONE planning with VolcanoPlanner

2019-02-27 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779769#comment-16779769 ] Laurent Goujon commented on CALCITE-2827: - Use case is to use volcano planner for doing cost

[jira] [Created] (CALCITE-2807) Identify expanded IS NOT DISTINCT FROM expression when pushing down filter past join

2019-01-25 Thread Laurent Goujon (JIRA)
Laurent Goujon created CALCITE-2807: --- Summary: Identify expanded IS NOT DISTINCT FROM expression when pushing down filter past join Key: CALCITE-2807 URL: https://issues.apache.org/jira/browse/CALCITE-2807

[jira] [Commented] (CALCITE-2803) Identify expanded IS NOT DISTINCT FROM expression when pushing project past join

2019-01-25 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752591#comment-16752591 ] Laurent Goujon commented on CALCITE-2803: - One possible solution is to normalize the join

[jira] [Updated] (CALCITE-2803) Identify expanded IS NOT DISTINCT FROM expression when pushing project past join

2019-01-25 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laurent Goujon updated CALCITE-2803: Description: {{IS NOT DISTINCT FROM}} expressions in join condition might actually be

[jira] [Created] (CALCITE-2803) Identify expanded IS NOT DISTINCT FROM expression when pushing project past join

2019-01-25 Thread Laurent Goujon (JIRA)
Laurent Goujon created CALCITE-2803: --- Summary: Identify expanded IS NOT DISTINCT FROM expression when pushing project past join Key: CALCITE-2803 URL: https://issues.apache.org/jira/browse/CALCITE-2803

[jira] [Commented] (CALCITE-2437) FilterMultiJoinMergeRule doesn't combine postFilterCondition

2018-12-21 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726940#comment-16726940 ] Laurent Goujon commented on CALCITE-2437: - I guessed I just jinxed myself? I actually triggered

[jira] [Commented] (CALCITE-2737) Depending on the version of Maven installed, the build will fail

2018-12-11 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718493#comment-16718493 ] Laurent Goujon commented on CALCITE-2737: - I tried with 3.3.9, 3.5.0 and 3.5.3, and was not

[jira] [Commented] (CALCITE-2629) Unnecessary call to CatalogReader#getAllSchemaObjects in CatalogScope

2018-10-23 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16661019#comment-16661019 ] Laurent Goujon commented on CALCITE-2629: - It looks like several tests in

[jira] [Commented] (CALCITE-2629) Unnecessary call to CatalogReader#getAllSchemaObjects in CatalogScope

2018-10-17 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654404#comment-16654404 ] Laurent Goujon commented on CALCITE-2629: - let me give it a try. Meanwhile, I posted a PR:

[jira] [Created] (CALCITE-2629) Unnecessary call to CatalogReader#getAllSchemaObjects in CatalogScope

2018-10-17 Thread Laurent Goujon (JIRA)
Laurent Goujon created CALCITE-2629: --- Summary: Unnecessary call to CatalogReader#getAllSchemaObjects in CatalogScope Key: CALCITE-2629 URL: https://issues.apache.org/jira/browse/CALCITE-2629

[jira] [Commented] (CALCITE-2537) Make sure assertions are enabled before calling VolcanoPlanner#validate

2018-09-06 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606117#comment-16606117 ] Laurent Goujon commented on CALCITE-2537: - Attaching pull request (since stopped being done

[jira] [Assigned] (CALCITE-2537) Make sure assertions are enabled before calling VolcanoPlanner#validate

2018-09-06 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laurent Goujon reassigned CALCITE-2537: --- Assignee: Laurent Goujon (was: Julian Hyde) > Make sure assertions are enabled

[jira] [Commented] (CALCITE-2537) Make sure assertions are enabled before calling VolcanoPlanner#validate

2018-09-05 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605093#comment-16605093 ] Laurent Goujon commented on CALCITE-2537: - I would also be happy transforming the assertions

[jira] [Comment Edited] (CALCITE-2537) Make sure assertions are enabled before calling VolcanoPlanner#validate

2018-09-05 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605091#comment-16605091 ] Laurent Goujon edited comment on CALCITE-2537 at 9/6/18 12:30 AM: -- My

[jira] [Commented] (CALCITE-2537) Make sure assertions are enabled before calling VolcanoPlanner#validate

2018-09-05 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605091#comment-16605091 ] Laurent Goujon commented on CALCITE-2537: - My point is more that log level should control

[jira] [Resolved] (CALCITE-2538) Missing RelMetadataQuery invalidation before subset cost improvement propagation

2018-09-05 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laurent Goujon resolved CALCITE-2538. - Resolution: Duplicate > Missing RelMetadataQuery invalidation before subset cost

[jira] [Commented] (CALCITE-2538) Missing RelMetadataQuery invalidation before subset cost improvement propagation

2018-09-05 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605071#comment-16605071 ] Laurent Goujon commented on CALCITE-2538: - Seems very similar to CALCITE-2018 > Missing

[jira] [Comment Edited] (CALCITE-2537) Make sure assertions are enabled before calling VolcanoPlanner#validate

2018-09-05 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605069#comment-16605069 ] Laurent Goujon edited comment on CALCITE-2537 at 9/6/18 12:05 AM: --

[jira] [Commented] (CALCITE-2537) Make sure assertions are enabled before calling VolcanoPlanner#validate

2018-09-05 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605069#comment-16605069 ] Laurent Goujon commented on CALCITE-2537: - It's not just the logging but the fact that validate

[jira] [Created] (CALCITE-2538) Missing RelMetadataQuery invalidation before subset cost improvement propagation

2018-09-05 Thread Laurent Goujon (JIRA)
Laurent Goujon created CALCITE-2538: --- Summary: Missing RelMetadataQuery invalidation before subset cost improvement propagation Key: CALCITE-2538 URL: https://issues.apache.org/jira/browse/CALCITE-2538

[jira] [Created] (CALCITE-2537) Make sure assertions are enabled before calling VolcanoPlanner#validate

2018-09-05 Thread Laurent Goujon (JIRA)
Laurent Goujon created CALCITE-2537: --- Summary: Make sure assertions are enabled before calling VolcanoPlanner#validate Key: CALCITE-2537 URL: https://issues.apache.org/jira/browse/CALCITE-2537

[jira] [Commented] (CALCITE-2471) RelNode description includes all tree when recomputed

2018-08-16 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582876#comment-16582876 ] Laurent Goujon commented on CALCITE-2471: - Added a simple test case, comparing description and

[jira] [Commented] (CALCITE-2471) RelNode description includes all tree when recomputed

2018-08-16 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582816#comment-16582816 ] Laurent Goujon commented on CALCITE-2471: - I wonder if doing a string match is a good enough

[jira] [Commented] (CALCITE-2471) RelNode description includes all tree when recomputed

2018-08-16 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582791#comment-16582791 ] Laurent Goujon commented on CALCITE-2471: - Here's my pull request to address the issue:

[jira] [Created] (CALCITE-2471) RelNode description includes all tree when recomputed

2018-08-16 Thread Laurent Goujon (JIRA)
Laurent Goujon created CALCITE-2471: --- Summary: RelNode description includes all tree when recomputed Key: CALCITE-2471 URL: https://issues.apache.org/jira/browse/CALCITE-2471 Project: Calcite

[jira] [Created] (CALCITE-2437) FilterMultiJoinMergeRule doesn't combine postFilterCondition

2018-08-01 Thread Laurent Goujon (JIRA)
Laurent Goujon created CALCITE-2437: --- Summary: FilterMultiJoinMergeRule doesn't combine postFilterCondition Key: CALCITE-2437 URL: https://issues.apache.org/jira/browse/CALCITE-2437 Project:

  1   2   3   >