[
https://issues.apache.org/jira/browse/CALCITE-2699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16706434#comment-16706434
]
Julian Hyde edited comment on CALCITE-2699 at 12/4/18 12:45 AM:
----------------------------------------------------------------
Fixed in
[d0bdec4f|http://git-wip-us.apache.org/repos/asf/calcite/commit/d0bdec4f];
thanks for the PR, [~x1q1j1]!
was (Author: julianhyde):
Fixed in
[18caf38f|http://git-wip-us.apache.org/repos/asf/calcite/commit/18caf38f];
thanks for the PR, [~x1q1j1]!
> TIMESTAMPADD function handles TIME incorrectly
> ----------------------------------------------
>
> Key: CALCITE-2699
> URL: https://issues.apache.org/jira/browse/CALCITE-2699
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: 1.17.0
> Reporter: xuqianjin
> Assignee: Julian Hyde
> Priority: Major
> Fix For: 1.18.0
>
>
> Two errors occur when {{timestampadd(MINUTE, 1, time '01:00:00')}} is
> executed:
> # The return result can only be of {{TimeStamp}} type and is expected to be
> of {{Time}} type
> # The return value is {{1970-01-01 01:01:00}}, and the expectation is
> {{01:01:00}}
> # I think it should meet the following conditions:
> ||expression||Expect the result||
> |timestampadd(MINUTE, -1, time '00:00:00')|23:59:00|
> |timestampadd(MINUTE, 1, time '00:00:00')|00:01:00|
> |timestampadd(MINUTE, 1, time '23:59:59')|00:00:59|
> |timestampadd(SECOND, 1, time '23:59:59')|00:00:00|
> |timestampadd(HOUR, 1, time '23:59:59')|00:59:59|
> |timestampadd(DAY, -1, time '23:59:59')|23:59:59|
> |timestampadd(WEEK, -1, time '23:59:59')|23:59:59|
> |timestampadd(MONTH, -1, time '23:59:59')|23:59:59|
> |timestampadd(QUARTER, -1, time '23:59:59')|23:59:59|
> |timestampadd(YEAR, -1, time '23:59:59')|23:59:59|
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
