[ https://issues.apache.org/jira/browse/CALCITE-2992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850357#comment-16850357 ]
Chunwei Lei edited comment on CALCITE-2992 at 5/29/19 3:17 AM: --------------------------------------------------------------- [~michaelmior], [~hhlai1990] there are more discussion about complete implicit type coercion[1]. So I am wondering if we can move forward after we reach consensus on it. [1] [https://lists.apache.org/thread.html/a458d4e9d88bb1404710c8cd696b6493b2b78288b4b6495c4e617723@%3Cdev.calcite.apache.org%3E] was (Author: chunwei lei): [~michaelmior], [~hhlai1990] there are more discussion about complete implicit type coercion[1]. So I am wondering if we can move forward after we reach consensus on it. [1] [https://lists.apache.org/thread.html/a458d4e9d88bb1404710c8cd696b6493b2b78288b4b6495c4e617723@%3Cdev.calcite.apache.org%3E] > Enhance implicit conversions when generating hash join keys for an > equiCondition > -------------------------------------------------------------------------------- > > Key: CALCITE-2992 > URL: https://issues.apache.org/jira/browse/CALCITE-2992 > Project: Calcite > Issue Type: Improvement > Components: core > Affects Versions: 1.19.0 > Reporter: Lai Zhou > Priority: Major > Labels: pull-request-available > Time Spent: 50m > Remaining Estimate: 0h > > Considering follow sql join: > > {code:java} > select t1.*,t2.* from t1 join t2 on t1.intValue=t2.longValue > {code} > as known in java : > > {code:java} > Integer intValue = 2; > Long longValue = 2L; > new Object[]{intValue}.hashCode().equals > ( > new Object[]{longValue}.hashCode() > ) > = false; > {code} > We shoudn't use the orginal Object as a key in the HashMap, > I think it'd be better to convert hash join keys to string and compare string > values. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)