[ https://issues.apache.org/jira/browse/CALCITE-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16916763#comment-16916763 ]
Volodymyr Vysotskyi edited comment on CALCITE-3244 at 8/27/19 2:45 PM: ----------------------------------------------------------------------- I have checked your branch, and problem with types wasn't fixed fully, so for example, the following test fails: {code:java} @Test public void testDecorrelateExists3() throws Exception { final String sql = "select \n" + " exists (select min(t2.id) \n" + " from (values(1), (2)) t2(id) where t2.id = t1.id)\n" + " from (values(3), (4)) t1(id)"; checkSubQuery(sql).withLateDecorrelation(true).check(); } {code} {noformat} java.lang.AssertionError: Cannot add expression of different type to set: set type is RecordType(INTEGER NOT NULL ID, BOOLEAN i) NOT NULL expression type is RecordType(INTEGER NOT NULL ID, BOOLEAN NOT NULL i) NOT NULL set is rel#44:LogicalCorrelate(left=HepRelVertex#36,right=HepRelVertex#43,correlation=$cor0,joinType=left,requiredColumns={0}) expression is LogicalProject(ID=[$0], i=[true]) LogicalCorrelate(correlation=[$cor0], joinType=[left], requiredColumns=[{0}]) LogicalValues(tuples=[[{ 3 }, { 4 }]]) LogicalAggregate(group=[{}], EXPR$0=[MIN($0)]) LogicalFilter(condition=[=($0, $cor0.ID)]) LogicalValues(tuples=[[{ 1 }, { 2 }]]) at org.apache.calcite.plan.RelOptUtil.verifyTypeEquivalence(RelOptUtil.java:383) at org.apache.calcite.plan.hep.HepRuleCall.transformTo(HepRuleCall.java:57) at org.apache.calcite.plan.RelOptRuleCall.transformTo(RelOptRuleCall.java:236) at org.apache.calcite.sql2rel.RelDecorrelator$AdjustProjectForCountAggregateRule.onMatch2(RelDecorrelator.java:2528) at org.apache.calcite.sql2rel.RelDecorrelator$AdjustProjectForCountAggregateRule.onMatch(RelDecorrelator.java:2436) at org.apache.calcite.plan.AbstractRelOptPlanner.fireRule(AbstractRelOptPlanner.java:319) at org.apache.calcite.plan.hep.HepPlanner.applyRule(HepPlanner.java:560) at org.apache.calcite.plan.hep.HepPlanner.applyRules(HepPlanner.java:419) at org.apache.calcite.plan.hep.HepPlanner.executeInstruction(HepPlanner.java:256) at org.apache.calcite.plan.hep.HepInstruction$RuleInstance.execute(HepInstruction.java:127) at org.apache.calcite.plan.hep.HepPlanner.executeProgram(HepPlanner.java:215) at org.apache.calcite.plan.hep.HepPlanner.findBestExp(HepPlanner.java:202) at org.apache.calcite.sql2rel.RelDecorrelator.decorrelate(RelDecorrelator.java:250) at org.apache.calcite.sql2rel.RelDecorrelator.decorrelateQuery(RelDecorrelator.java:215) at org.apache.calcite.test.RelOptTestBase.checkPlanning(RelOptTestBase.java:213) at org.apache.calcite.test.RelOptTestBase$Sql.check(RelOptTestBase.java:338) at org.apache.calcite.test.RelOptTestBase$Sql.check(RelOptTestBase.java:321) at org.apache.calcite.test.RelOptRulesTest.testDecorrelateExists2(RelOptRulesTest.java:5626) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.junit.runner.JUnitCore.run(JUnitCore.java:137) at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68) at com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:47) at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242) at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70) {noformat} was (Author: vvysotskyi): I have checked your branch, and the following test fails: {code:java} @Test public void testDecorrelateExists3() throws Exception { final String sql = "select \n" + " exists (select min(t2.id) \n" + " from (values(1), (2)) t2(id) where t2.id = t1.id)\n" + " from (values(3), (4)) t1(id)"; checkSubQuery(sql).withLateDecorrelation(true).check(); } {code} {noformat} java.lang.AssertionError: Cannot add expression of different type to set: set type is RecordType(INTEGER NOT NULL ID, BOOLEAN i) NOT NULL expression type is RecordType(INTEGER NOT NULL ID, BOOLEAN NOT NULL i) NOT NULL set is rel#44:LogicalCorrelate(left=HepRelVertex#36,right=HepRelVertex#43,correlation=$cor0,joinType=left,requiredColumns={0}) expression is LogicalProject(ID=[$0], i=[true]) LogicalCorrelate(correlation=[$cor0], joinType=[left], requiredColumns=[{0}]) LogicalValues(tuples=[[{ 3 }, { 4 }]]) LogicalAggregate(group=[{}], EXPR$0=[MIN($0)]) LogicalFilter(condition=[=($0, $cor0.ID)]) LogicalValues(tuples=[[{ 1 }, { 2 }]]) at org.apache.calcite.plan.RelOptUtil.verifyTypeEquivalence(RelOptUtil.java:383) at org.apache.calcite.plan.hep.HepRuleCall.transformTo(HepRuleCall.java:57) at org.apache.calcite.plan.RelOptRuleCall.transformTo(RelOptRuleCall.java:236) at org.apache.calcite.sql2rel.RelDecorrelator$AdjustProjectForCountAggregateRule.onMatch2(RelDecorrelator.java:2528) at org.apache.calcite.sql2rel.RelDecorrelator$AdjustProjectForCountAggregateRule.onMatch(RelDecorrelator.java:2436) at org.apache.calcite.plan.AbstractRelOptPlanner.fireRule(AbstractRelOptPlanner.java:319) at org.apache.calcite.plan.hep.HepPlanner.applyRule(HepPlanner.java:560) at org.apache.calcite.plan.hep.HepPlanner.applyRules(HepPlanner.java:419) at org.apache.calcite.plan.hep.HepPlanner.executeInstruction(HepPlanner.java:256) at org.apache.calcite.plan.hep.HepInstruction$RuleInstance.execute(HepInstruction.java:127) at org.apache.calcite.plan.hep.HepPlanner.executeProgram(HepPlanner.java:215) at org.apache.calcite.plan.hep.HepPlanner.findBestExp(HepPlanner.java:202) at org.apache.calcite.sql2rel.RelDecorrelator.decorrelate(RelDecorrelator.java:250) at org.apache.calcite.sql2rel.RelDecorrelator.decorrelateQuery(RelDecorrelator.java:215) at org.apache.calcite.test.RelOptTestBase.checkPlanning(RelOptTestBase.java:213) at org.apache.calcite.test.RelOptTestBase$Sql.check(RelOptTestBase.java:338) at org.apache.calcite.test.RelOptTestBase$Sql.check(RelOptTestBase.java:321) at org.apache.calcite.test.RelOptRulesTest.testDecorrelateExists2(RelOptRulesTest.java:5626) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.junit.runner.JUnitCore.run(JUnitCore.java:137) at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68) at com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:47) at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242) at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70) {noformat} > RelDecorrelator unable to decorrelate expression with filter and aggregate on > top > --------------------------------------------------------------------------------- > > Key: CALCITE-3244 > URL: https://issues.apache.org/jira/browse/CALCITE-3244 > Project: Calcite > Issue Type: Improvement > Affects Versions: 1.20.0 > Reporter: benj > Assignee: Danny Chan > Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Some very useful type of requests currently failed with: > {code:java} > SYSTEM ERROR: UnsupportedOperationException: Adding Implicit RowID column is > not supported for ValuesPrel operator > {code} > Examples from DRILL-7050: > {code:sql} > select t1.id, > (select count(t2.id) > from ( > select 1 as id > union all > select 2 as id > ) t2 where t2.id = t1.id) > from ( > select 1 as id > union all > select 2 as id > ) t1 > {code} > {code:sql} > SELECT t, > (SELECT count(*) FROM > (SELECT split(r,' ') AS r FROM > (SELECT sub.t AS r)) AS x > ,LATERAL(SELECT $unnest AS u FROM unnest(x.r)) > /* WHERE ... */) t2 > FROM > (SELECT 'unnest is useful' AS t) sub > {code} > > _Please note that in 1.18 the error for these requests was:_ > {code:java} > Error: PLAN ERROR: Cannot convert RexNode to equivalent Drill expression. > RexNode Class: org.apache.calcite.rex.RexCorrelVariable, RexNode Digest: $cor0 > {code} -- This message was sent by Atlassian Jira (v8.3.2#803003)