[jira] [Commented] (CALCITE-1824) GROUP_ID returns wrong result

2020-02-01 Thread Michael Mior (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028198#comment-17028198 ] Michael Mior commented on CALCITE-1824: --- Fixed in

[jira] [Commented] (CALCITE-1824) GROUP_ID returns wrong result

2020-01-13 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014579#comment-17014579 ] Julian Hyde commented on CALCITE-1824: -- My first rewrite duplicated rows before the Aggregate. My

[jira] [Commented] (CALCITE-1824) GROUP_ID returns wrong result

2020-01-12 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014095#comment-17014095 ] Feng Zhu commented on CALCITE-1824: --- >From my understanding, you have the same meaning. But current

[jira] [Commented] (CALCITE-1824) GROUP_ID returns wrong result

2020-01-12 Thread Vladimir Sitnikov (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014079#comment-17014079 ] Vladimir Sitnikov commented on CALCITE-1824: Can you please double-check? I'm sure both my

[jira] [Commented] (CALCITE-1824) GROUP_ID returns wrong result

2020-01-12 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17013932#comment-17013932 ] Julian Hyde commented on CALCITE-1824: -- Yes, it's different because we would duplicate rows after

[jira] [Commented] (CALCITE-1824) GROUP_ID returns wrong result

2020-01-12 Thread Vladimir Sitnikov (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17013885#comment-17013885 ] Vladimir Sitnikov commented on CALCITE-1824: {quote}for every row in the result for which

[jira] [Commented] (CALCITE-1824) GROUP_ID returns wrong result

2020-01-12 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17013879#comment-17013879 ] Julian Hyde commented on CALCITE-1824: -- A more efficient rewrite just occurred to me. We could

[jira] [Commented] (CALCITE-1824) GROUP_ID returns wrong result

2020-01-09 Thread Vladimir Sitnikov (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17012148#comment-17012148 ] Vladimir Sitnikov commented on CALCITE-1824: {quote} you'll end up with something involving

[jira] [Commented] (CALCITE-1824) GROUP_ID returns wrong result

2020-01-09 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17012103#comment-17012103 ] Julian Hyde commented on CALCITE-1824: -- Yes, we support LATERAL. But LATERAL followed by a

[jira] [Commented] (CALCITE-1824) GROUP_ID returns wrong result

2020-01-07 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010425#comment-17010425 ] Feng Zhu commented on CALCITE-1824: --- Yes, your are right. In calcite, we can use lateral and unnest.

[jira] [Commented] (CALCITE-1824) GROUP_ID returns wrong result

2020-01-07 Thread Vladimir Sitnikov (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010398#comment-17010398 ] Vladimir Sitnikov commented on CALCITE-1824: What do you mean by "we do not support lateral

[jira] [Commented] (CALCITE-1824) GROUP_ID returns wrong result

2020-01-07 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010324#comment-17010324 ] Feng Zhu commented on CALCITE-1824: --- Thanks [~vladimirsitnikov], rewriting to UNION-ALL is more

[jira] [Commented] (CALCITE-1824) GROUP_ID returns wrong result

2020-01-07 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010316#comment-17010316 ] Feng Zhu commented on CALCITE-1824: ---   {quote}The problem with UNION ALL is that it duplicates the

[jira] [Commented] (CALCITE-1824) GROUP_ID returns wrong result

2020-01-07 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010014#comment-17010014 ] Julian Hyde commented on CALCITE-1824: -- I'm not arguing. Both our approaches work. > GROUP_ID

[jira] [Commented] (CALCITE-1824) GROUP_ID returns wrong result

2020-01-07 Thread Vladimir Sitnikov (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010007#comment-17010007 ] Vladimir Sitnikov commented on CALCITE-1824: {quote}The problem with UNION ALL is that it

[jira] [Commented] (CALCITE-1824) GROUP_ID returns wrong result

2020-01-07 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010002#comment-17010002 ] Julian Hyde commented on CALCITE-1824: -- By the way, GROUP BY ... GROUPING SETS (i.e. Aggregate

[jira] [Commented] (CALCITE-1824) GROUP_ID returns wrong result

2020-01-07 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17009995#comment-17009995 ] Julian Hyde commented on CALCITE-1824: -- The problem with UNION ALL is that it duplicates the input

[jira] [Commented] (CALCITE-1824) GROUP_ID returns wrong result

2020-01-06 Thread Vladimir Sitnikov (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17009408#comment-17009408 ] Vladimir Sitnikov commented on CALCITE-1824: How about rewriting non-zero grouping cases

[jira] [Commented] (CALCITE-1824) GROUP_ID returns wrong result

2020-01-06 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17009377#comment-17009377 ] Feng Zhu commented on CALCITE-1824: --- Thanks [~julianhyde], it sounds like a feasible solution. I'd

[jira] [Commented] (CALCITE-1824) GROUP_ID returns wrong result

2020-01-06 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17009285#comment-17009285 ] Julian Hyde commented on CALCITE-1824: -- Could this be done as a rewrite? The second query above