[jira] [Commented] (CALCITE-1911) Support WITHIN clause in MATCH_RECOGNIZE

2017-08-24 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16140589#comment-16140589 ] Julian Hyde commented on CALCITE-1911: -- Fixed in http://git-wip-us.apache.org/repos

[jira] [Commented] (CALCITE-1911) Support WITHIN clause in MATCH_RECOGNIZE

2017-08-22 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137885#comment-16137885 ] Julian Hyde commented on CALCITE-1911: -- Reviewing/testing now. > Support WITHIN cl

[jira] [Commented] (CALCITE-1911) Support WITHIN clause in MATCH_RECOGNIZE

2017-08-22 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137738#comment-16137738 ] Dian Fu commented on CALCITE-1911: -- Hi [~julianhyde], I have addressed your comments in

[jira] [Commented] (CALCITE-1911) Support WITHIN clause in MATCH_RECOGNIZE

2017-08-13 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125149#comment-16125149 ] Dian Fu commented on CALCITE-1911: -- Make sense. Have updated the tests for INTERVAL. >

[jira] [Commented] (CALCITE-1911) Support WITHIN clause in MATCH_RECOGNIZE

2017-08-11 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123502#comment-16123502 ] Julian Hyde commented on CALCITE-1911: -- You've addressed almost everything. I was p

[jira] [Commented] (CALCITE-1911) Support WITHIN clause in MATCH_RECOGNIZE

2017-08-11 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123278#comment-16123278 ] Dian Fu commented on CALCITE-1911: -- Have updated the PR according to review comments. H

[jira] [Commented] (CALCITE-1911) Support WITHIN clause in MATCH_RECOGNIZE

2017-08-08 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119167#comment-16119167 ] Julian Hyde commented on CALCITE-1911: -- I think it's just a matter of generating th

[jira] [Commented] (CALCITE-1911) Support WITHIN clause in MATCH_RECOGNIZE

2017-08-08 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118240#comment-16118240 ] Dian Fu commented on CALCITE-1911: -- [~julianhyde], [~ransom] Thanks a lot for your revi

[jira] [Commented] (CALCITE-1911) Support WITHIN clause in MATCH_RECOGNIZE

2017-08-08 Thread Zhiqiang He (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118070#comment-16118070 ] Zhiqiang He commented on CALCITE-1911: -- SqlValidatorImpl.java shoud add check order

[jira] [Commented] (CALCITE-1911) Support within clause in MATCH_RECOGNIZE

2017-08-07 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117548#comment-16117548 ] Julian Hyde commented on CALCITE-1911: -- A few review comments: * Add comments in Ma

[jira] [Commented] (CALCITE-1911) Support within clause in MATCH_RECOGNIZE

2017-08-07 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116608#comment-16116608 ] Dian Fu commented on CALCITE-1911: -- [~julianhyde] [~ransom], Have create a PR. Could yo

[jira] [Commented] (CALCITE-1911) Support within clause in MATCH_RECOGNIZE

2017-07-31 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108289#comment-16108289 ] Dian Fu commented on CALCITE-1911: -- Right, I think the {{rowtime}} column can be seen a

[jira] [Commented] (CALCITE-1911) Support within clause in MATCH_RECOGNIZE

2017-07-31 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108279#comment-16108279 ] Julian Hyde commented on CALCITE-1911: -- Here's a possible solution. If people want

[jira] [Commented] (CALCITE-1911) Support within clause in MATCH_RECOGNIZE

2017-07-31 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108257#comment-16108257 ] Dian Fu commented on CALCITE-1911: -- Yes, this is not in Oracle 12 and also not in the S

[jira] [Commented] (CALCITE-1911) Support within clause in MATCH_RECOGNIZE

2017-07-31 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107993#comment-16107993 ] Julian Hyde commented on CALCITE-1911: -- To be clear, this is not in Oracle 12, and