[jira] [Commented] (CALCITE-2188) JDBC adapter generates invalid SQL for DATE/INTERVAL arithmetic

2018-03-23 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16412009#comment-16412009 ] Julian Hyde commented on CALCITE-2188: -- Any reason why SqlDialect.unparseSqlInterva

[jira] [Commented] (CALCITE-2188) JDBC adapter generates invalid SQL for DATE/INTERVAL arithmetic

2018-03-17 Thread Rahul Raj (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403457#comment-16403457 ] Rahul Raj commented on CALCITE-2188: [~julianhyde] I have incorporated your review c

[jira] [Commented] (CALCITE-2188) JDBC adapter generates invalid SQL for DATE/INTERVAL arithmetic

2018-03-12 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396144#comment-16396144 ] Julian Hyde commented on CALCITE-2188: -- Reviewing [bc26af6|https://github.com/apac

[jira] [Commented] (CALCITE-2188) JDBC adapter generates invalid SQL for DATE/INTERVAL arithmetic

2018-03-03 Thread Rahul Raj (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16384983#comment-16384983 ] Rahul Raj commented on CALCITE-2188: Please find the PR [https://github.com/apache/c

[jira] [Commented] (CALCITE-2188) JDBC adapter generates invalid SQL for DATE/INTERVAL arithmetic

2018-02-27 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16379810#comment-16379810 ] Julian Hyde commented on CALCITE-2188: -- Sounds promising. I hope you're adding test

[jira] [Commented] (CALCITE-2188) JDBC adapter generates invalid SQL for DATE/INTERVAL arithmetic

2018-02-27 Thread Rahul Raj (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16379758#comment-16379758 ] Rahul Raj commented on CALCITE-2188: I have made the following fixes: # Interval Ad

[jira] [Commented] (CALCITE-2188) JDBC adapter generates invalid SQL for DATE/INTERVAL arithmetic

2018-02-22 Thread Rahul Raj (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372680#comment-16372680 ] Rahul Raj commented on CALCITE-2188: The INTERVAL syntax is different between databa

[jira] [Commented] (CALCITE-2188) JDBC adapter generates invalid SQL for DATE/INTERVAL arithmetic

2018-02-21 Thread Rahul Raj (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372262#comment-16372262 ] Rahul Raj commented on CALCITE-2188: I have it ready. I will test few more cases/DBs

[jira] [Commented] (CALCITE-2188) JDBC adapter generates invalid SQL for DATE/INTERVAL arithmetic

2018-02-21 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372009#comment-16372009 ] Julian Hyde commented on CALCITE-2188: -- Do you have a PR? > JDBC adapter generates