[jira] [Commented] (CALCITE-2303) Support DECADE time unit in EXTRACT function

2018-05-25 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16491078#comment-16491078 ] Julian Hyde commented on CALCITE-2303: -- Please make a pull request for the Calcite

[jira] [Commented] (CALCITE-2303) Support DECADE time unit in EXTRACT function

2018-05-25 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16491159#comment-16491159 ] Julian Hyde commented on CALCITE-2303: -- Please also rebase and squash your changes.

[jira] [Commented] (CALCITE-2303) Support DECADE time unit in EXTRACT function

2018-05-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16492346#comment-16492346 ] ASF GitHub Bot commented on CALCITE-2303: - GitHub user snuyanzin opened a pull r

[jira] [Commented] (CALCITE-2303) Support DECADE time unit in EXTRACT function

2018-05-28 Thread Sergey Nuyanzin (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16492448#comment-16492448 ] Sergey Nuyanzin commented on CALCITE-2303: -- added both PRs squashed without spe

[jira] [Commented] (CALCITE-2303) Support DECADE time unit in EXTRACT function

2018-05-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16492449#comment-16492449 ] ASF GitHub Bot commented on CALCITE-2303: - Github user snuyanzin closed the pull

[jira] [Commented] (CALCITE-2303) Support DECADE time unit in EXTRACT function

2018-05-28 Thread Sergey Nuyanzin (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16492489#comment-16492489 ] Sergey Nuyanzin commented on CALCITE-2303: -- There is [GitHub Pull Request #50|

[jira] [Commented] (CALCITE-2303) Support DECADE time unit in EXTRACT function

2018-05-29 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1649#comment-1649 ] Julian Hyde commented on CALCITE-2303: -- I have fixed up the Calcite changes here:

[jira] [Commented] (CALCITE-2303) Support DECADE time unit in EXTRACT function

2018-05-29 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494529#comment-16494529 ] Julian Hyde commented on CALCITE-2303: -- Here's an easy way to test against Postgre

[jira] [Commented] (CALCITE-2303) Support DECADE time unit in EXTRACT function

2018-05-29 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494579#comment-16494579 ] Laurent Goujon commented on CALCITE-2303: - Regarding WEEK, postgres uses ISOWEE

[jira] [Commented] (CALCITE-2303) Support DECADE time unit in EXTRACT function

2018-05-29 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494583#comment-16494583 ] Laurent Goujon commented on CALCITE-2303: - Also, for DOW, note that current Cal

[jira] [Commented] (CALCITE-2303) Support DECADE time unit in EXTRACT function

2018-05-30 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495820#comment-16495820 ] Julian Hyde commented on CALCITE-2303: -- Since {{EXTRACT(DOW FROM ...)}} is differe

[jira] [Commented] (CALCITE-2303) Support DECADE time unit in EXTRACT function

2018-05-30 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495852#comment-16495852 ] Laurent Goujon commented on CALCITE-2303: - Currently {{\{fn DAYOFWEEK\}}} is ma

[jira] [Commented] (CALCITE-2303) Support DECADE time unit in EXTRACT function

2018-05-30 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495862#comment-16495862 ] Julian Hyde commented on CALCITE-2303: -- If you're suggesting adding a bug-compatib

[jira] [Commented] (CALCITE-2303) Support DECADE time unit in EXTRACT function

2018-05-30 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495886#comment-16495886 ] Laurent Goujon commented on CALCITE-2303: - I'm not suggesting a bug-compatibili

[jira] [Commented] (CALCITE-2303) Support DECADE time unit in EXTRACT function

2018-05-30 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495889#comment-16495889 ] Laurent Goujon commented on CALCITE-2303: - (Note that behaviour change in Dremi

[jira] [Commented] (CALCITE-2303) Support DECADE time unit in EXTRACT function

2018-05-30 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495898#comment-16495898 ] Julian Hyde commented on CALCITE-2303: -- We tend to shadow Postgres because Postgre

[jira] [Commented] (CALCITE-2303) Support DECADE time unit in EXTRACT function

2018-05-30 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495900#comment-16495900 ] Julian Hyde commented on CALCITE-2303: -- As a committer, you have to figure out whe

[jira] [Commented] (CALCITE-2303) Support DECADE time unit in EXTRACT function

2018-05-30 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495909#comment-16495909 ] Laurent Goujon commented on CALCITE-2303: - I'm still not asking for a bug compa

[jira] [Commented] (CALCITE-2303) Support DECADE time unit in EXTRACT function

2018-05-30 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495928#comment-16495928 ] Julian Hyde commented on CALCITE-2303: -- We (the Calcite community) didn't choose t

[jira] [Commented] (CALCITE-2303) Support DECADE time unit in EXTRACT function

2018-05-30 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495931#comment-16495931 ] Julian Hyde commented on CALCITE-2303: -- I'm seeing the old open-core anti-pattern:

[jira] [Commented] (CALCITE-2303) Support DECADE time unit in EXTRACT function

2018-05-30 Thread Laurent Goujon (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495942#comment-16495942 ] Laurent Goujon commented on CALCITE-2303: - {quote} Actually, we do. You guys. W

[jira] [Commented] (CALCITE-2303) Support DECADE time unit in EXTRACT function

2018-06-01 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16498237#comment-16498237 ] Julian Hyde commented on CALCITE-2303: -- You may think it is reasonable to ask for

[jira] [Commented] (CALCITE-2303) Support DECADE time unit in EXTRACT function

2018-06-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16498658#comment-16498658 ] ASF GitHub Bot commented on CALCITE-2303: - Github user asfgit closed the pull r

[jira] [Commented] (CALCITE-2303) Support DECADE time unit in EXTRACT function

2018-06-01 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16498666#comment-16498666 ] Julian Hyde commented on CALCITE-2303: -- Fixed the Avatica part of this in [b86398