[jira] [Commented] (CALCITE-2455) simplifyCoalesce of constant should match nullability

2018-09-28 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16632150#comment-16632150 ] Julian Hyde commented on CALCITE-2455: -- Failure #1 in CALCITE-2598 seems to be a d

[jira] [Commented] (CALCITE-2455) simplifyCoalesce of constant should match nullability

2018-08-12 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577727#comment-16577727 ] Julian Hyde commented on CALCITE-2455: -- [~danny0405], Maybe you need to make sure

[jira] [Commented] (CALCITE-2455) simplifyCoalesce of constant should match nullability

2018-08-10 Thread Yuzhao Chen (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577034#comment-16577034 ] Yuzhao Chen commented on CALCITE-2455: -- [~vladimirsitnikov] Sorry, i think {{simp

[jira] [Commented] (CALCITE-2455) simplifyCoalesce of constant should match nullability

2018-08-10 Thread Yuzhao Chen (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577032#comment-16577032 ] Yuzhao Chen commented on CALCITE-2455: -- hi, [~julianhyde] yuzhao.cyz is my accoun

[jira] [Commented] (CALCITE-2455) simplifyCoalesce of constant should match nullability

2018-08-10 Thread Vladimir Sitnikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576851#comment-16576851 ] Vladimir Sitnikov commented on CALCITE-2455: It looks like the change is in

[jira] [Commented] (CALCITE-2455) simplifyCoalesce of constant should match nullability

2018-08-10 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576651#comment-16576651 ] Julian Hyde commented on CALCITE-2455: -- Who made this change? The commit is by yuz

[jira] [Commented] (CALCITE-2455) simplifyCoalesce of constant should match nullability

2018-08-10 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576611#comment-16576611 ] Julian Hyde commented on CALCITE-2455: -- Reviewing and testing now. > simplifyCoal

[jira] [Commented] (CALCITE-2455) simplifyCoalesce of constant should match nullability

2018-08-10 Thread Yuzhao Chen (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16575853#comment-16575853 ] Yuzhao Chen commented on CALCITE-2455: -- Hi, [~julianhyde],  i have added the test

[jira] [Commented] (CALCITE-2455) simplifyCoalesce of constant should match nullability

2018-08-09 Thread Volodymyr Vysotskyi (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16574560#comment-16574560 ] Volodymyr Vysotskyi commented on CALCITE-2455: -- Thanks for the explanation

[jira] [Commented] (CALCITE-2455) simplifyCoalesce of constant should match nullability

2018-08-09 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16574491#comment-16574491 ] Julian Hyde commented on CALCITE-2455: -- [~danny0405] the PR looks good, but we als

[jira] [Commented] (CALCITE-2455) simplifyCoalesce of constant should match nullability

2018-08-09 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16574489#comment-16574489 ] Julian Hyde commented on CALCITE-2455: -- [~vvysotskyi] I’m not 100% sure why the Co

[jira] [Commented] (CALCITE-2455) simplifyCoalesce of constant should match nullability

2018-08-09 Thread Yuzhao Chen (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16574447#comment-16574447 ] Yuzhao Chen commented on CALCITE-2455: -- [~vvysotskyi], actually we can infer that

[jira] [Commented] (CALCITE-2455) simplifyCoalesce of constant should match nullability

2018-08-08 Thread Volodymyr Vysotskyi (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16574369#comment-16574369 ] Volodymyr Vysotskyi commented on CALCITE-2455: -- [~danny0405], I'm wonderin

[jira] [Commented] (CALCITE-2455) simplifyCoalesce of constant should match nullability

2018-08-08 Thread Yuzhao Chen (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16574203#comment-16574203 ] Yuzhao Chen commented on CALCITE-2455: -- Hi, [~julianhyde] I have attach the detail