[ 
https://issues.apache.org/jira/browse/CALCITE-2778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16737495#comment-16737495
 ] 

Julian Hyde commented on CALCITE-2778:
--------------------------------------

Synchronization would not solve the problem is the sub-object was de-allocated 
in the same thread. The "forgotten" is not necessarily the last.

Be careful before you "improve" code that you don't understand. But I 
acknowledge that it is difficult to understand without tests.

Yes I think you can just remove the classes.

> Remove CompoundClosableAllocation
> ---------------------------------
>
>                 Key: CALCITE-2778
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2778
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: BELUGA BEHR
>            Assignee: Julian Hyde
>            Priority: Minor
>
> In Java, ArrayList should be the default choice over LinkedList.  It 
> generally requires less memory and is faster.  Update 
> {{CompoundClosableAllocation}} to use an Array structure instead of linked 
> list and simplify the code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to