[jira] [Commented] (CALCITE-2791) Add the JSON_TYPE function

2019-01-26 Thread Hongze Zhang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753160#comment-16753160 ] Hongze Zhang commented on CALCITE-2791: --- Sorry for the reassignation [~julianhyde

[jira] [Commented] (CALCITE-2791) Add the JSON_TYPE function

2019-01-26 Thread xuqianjin (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753253#comment-16753253 ] xuqianjin commented on CALCITE-2791: hi [~zhztheplayer] Thank you very much for you

[jira] [Commented] (CALCITE-2791) Add the JSON_TYPE function

2019-01-26 Thread xuqianjin (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753255#comment-16753255 ] xuqianjin commented on CALCITE-2791: hi [~zhztheplayer] I've turned off the PR. be

[jira] [Commented] (CALCITE-2791) Add the JSON_TYPE function

2019-01-26 Thread xuqianjin (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753265#comment-16753265 ] xuqianjin commented on CALCITE-2791: hi [~zhztheplayer] I've turned off the PR. be

[jira] [Commented] (CALCITE-2791) Add the JSON_TYPE function

2019-01-26 Thread Hongze Zhang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753270#comment-16753270 ] Hongze Zhang commented on CALCITE-2791: --- Thanks for the explanition [~x1q1j1], I

[jira] [Commented] (CALCITE-2791) Add the JSON_TYPE function

2019-01-26 Thread xuqianjin (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753274#comment-16753274 ] xuqianjin commented on CALCITE-2791: hi [~zhztheplayer] Which multi-parameter is re

[jira] [Commented] (CALCITE-2791) Add the JSON_TYPE function

2019-01-26 Thread Hongze Zhang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753276#comment-16753276 ] Hongze Zhang commented on CALCITE-2791: --- {quote}do you think this JSON_TYPE funct

[jira] [Commented] (CALCITE-2791) Add the JSON_TYPE function

2019-01-26 Thread Hongze Zhang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753278#comment-16753278 ] Hongze Zhang commented on CALCITE-2791: --- And [~julianhyde] do you have any though

[jira] [Commented] (CALCITE-2791) Add the JSON_TYPE function

2019-01-26 Thread xuqianjin (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753281#comment-16753281 ] xuqianjin commented on CALCITE-2791: hi [~zhztheplayer] I really appreciate your re

[jira] [Commented] (CALCITE-2791) Add the JSON_TYPE function

2019-01-27 Thread xuqianjin (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753329#comment-16753329 ] xuqianjin commented on CALCITE-2791: hi [~zhztheplayer] I hope you can spare your p

[jira] [Commented] (CALCITE-2791) Add the JSON_TYPE function

2019-01-28 Thread xuqianjin (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16754601#comment-16754601 ] xuqianjin commented on CALCITE-2791: hi [~zhztheplayer] I have modified this PR. Ca

[jira] [Commented] (CALCITE-2791) Add the JSON_TYPE function

2019-01-28 Thread Hongze Zhang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16754681#comment-16754681 ] Hongze Zhang commented on CALCITE-2791: --- [~x1q1j1] I would like to take a look at

[jira] [Commented] (CALCITE-2791) Add the JSON_TYPE function

2019-01-29 Thread xuqianjin (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16754713#comment-16754713 ] xuqianjin commented on CALCITE-2791: hi [~zhztheplayer] Ok, I can understand. I am

[jira] [Commented] (CALCITE-2791) Add the JSON_TYPE function

2019-01-30 Thread xuqianjin (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756821#comment-16756821 ] xuqianjin commented on CALCITE-2791: hi [~zhztheplayer] I have modified this PR, ca

[jira] [Commented] (CALCITE-2791) Add the JSON_TYPE function

2019-01-30 Thread Hongze Zhang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756885#comment-16756885 ] Hongze Zhang commented on CALCITE-2791: --- I just leaved some comments in your PR,

[jira] [Commented] (CALCITE-2791) Add the JSON_TYPE function

2019-01-31 Thread xuqianjin (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16757196#comment-16757196 ] xuqianjin commented on CALCITE-2791: hi [~zhztheplayer] I have modified this PR, ca

[jira] [Commented] (CALCITE-2791) Add the JSON_TYPE function

2019-01-31 Thread xuqianjin (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16757200#comment-16757200 ] xuqianjin commented on CALCITE-2791: hi [~zhztheplayer] Some discussions about the

[jira] [Commented] (CALCITE-2791) Add the JSON_TYPE function

2019-02-04 Thread Hongze Zhang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16760465#comment-16760465 ] Hongze Zhang commented on CALCITE-2791: --- [~x1q1j1] I've made some comments on the

[jira] [Commented] (CALCITE-2791) Add the JSON_TYPE function

2019-02-12 Thread Forward Xu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16766809#comment-16766809 ] Forward Xu commented on CALCITE-2791: - hi [~zhztheplayer] Thanks for the review, al

[jira] [Commented] (CALCITE-2791) Add the JSON_TYPE function

2019-02-13 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767561#comment-16767561 ] Julian Hyde commented on CALCITE-2791: -- I like that you have added some examples t

[jira] [Commented] (CALCITE-2791) Add the JSON_TYPE function

2019-02-14 Thread Forward Xu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16768093#comment-16768093 ] Forward Xu commented on CALCITE-2791: - hi [~julianhyde] Thank you very much. I adde

[jira] [Commented] (CALCITE-2791) Add the JSON_TYPE function

2019-02-14 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16768688#comment-16768688 ] Julian Hyde commented on CALCITE-2791: -- Does the SQL work? I didn't test it. > Ad

[jira] [Commented] (CALCITE-2791) Add the JSON_TYPE function

2019-02-18 Thread Forward Xu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16770938#comment-16770938 ] Forward Xu commented on CALCITE-2791: - hi [~zhztheplayer] [~julianhyde] Can you giv

[jira] [Commented] (CALCITE-2791) Add the JSON_TYPE function

2019-02-18 Thread Hongze Zhang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16770973#comment-16770973 ] Hongze Zhang commented on CALCITE-2791: --- [~x1q1j1] Sorry for the late response ,

[jira] [Commented] (CALCITE-2791) Add the JSON_TYPE function

2019-02-18 Thread Forward Xu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16770988#comment-16770988 ] Forward Xu commented on CALCITE-2791: - hi [~zhztheplayer] [~julianhyde] Thank you v

[jira] [Commented] (CALCITE-2791) Add the JSON_TYPE function

2019-02-18 Thread Forward Xu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771202#comment-16771202 ] Forward Xu commented on CALCITE-2791: - hi [~zhztheplayer] [~julianhyde] Thank you v

[jira] [Commented] (CALCITE-2791) Add the JSON_TYPE function

2019-02-18 Thread Forward Xu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771552#comment-16771552 ] Forward Xu commented on CALCITE-2791: - hi [~zhztheplayer] Is there a problem with j

[jira] [Commented] (CALCITE-2791) Add the JSON_TYPE function

2019-02-18 Thread Hongze Zhang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771575#comment-16771575 ] Hongze Zhang commented on CALCITE-2791: --- [~x1q1j1], Did you intent to include to

[jira] [Commented] (CALCITE-2791) Add the JSON_TYPE function

2019-02-18 Thread Forward Xu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771610#comment-16771610 ] Forward Xu commented on CALCITE-2791: - hi [~zhztheplayer] Thank you very much. I ha

[jira] [Commented] (CALCITE-2791) Add the JSON_TYPE function

2019-02-20 Thread Forward Xu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16773591#comment-16773591 ] Forward Xu commented on CALCITE-2791: - hi [~zhztheplayer] Thank you very much.I hop

[jira] [Commented] (CALCITE-2791) Add the JSON_TYPE function

2019-02-20 Thread Hongze Zhang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16773621#comment-16773621 ] Hongze Zhang commented on CALCITE-2791: --- bq. I hope to get your help from the tes

[jira] [Commented] (CALCITE-2791) Add the JSON_TYPE function

2019-02-20 Thread Forward Xu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16773679#comment-16773679 ] Forward Xu commented on CALCITE-2791: - hi [~zhztheplayer] Thank you for your advice

[jira] [Commented] (CALCITE-2791) Add the JSON_TYPE function

2019-02-21 Thread Hongze Zhang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16774766#comment-16774766 ] Hongze Zhang commented on CALCITE-2791: --- LGTM +1. Does anyone else have suggestio

[jira] [Commented] (CALCITE-2791) Add the JSON_TYPE function

2019-02-22 Thread Hongze Zhang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16775476#comment-16775476 ] Hongze Zhang commented on CALCITE-2791: --- Fixed in [5101703c3bb7e051766f9dc932534