[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916597#comment-16916597 ] Stamatis Zampetakis commented on CALCITE-2973: -- I think one +1 is enough for this PR; go

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916465#comment-16916465 ] Danny Chan commented on CALCITE-2973: - CALCITE-2302 and CALCITE-1581 are almost ready to be merged,

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916457#comment-16916457 ] Ruben Quesada Lopez commented on CALCITE-2973: -- [~hyuan], [~danny0405], [~julianhyde], I

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913882#comment-16913882 ] Lai Zhou commented on CALCITE-2973: --- I noticed this performance issue before. I'll try to find a

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913391#comment-16913391 ] Ruben Quesada Lopez commented on CALCITE-2973: -- [~hhlai1990], thanks for this PR, I think

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912893#comment-16912893 ] Haisheng Yuan commented on CALCITE-2973: Sure, will do. > Allow theta joins that have equi

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912868#comment-16912868 ] Lai Zhou commented on CALCITE-2973: --- [~rubenql]， [~hyuan] ,[~julianhyde], [~danny0405], the pr is

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852961#comment-16852961 ] Michael Mior commented on CALCITE-2973: --- For now I've removed this from 1.20.0. If anyone has

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852772#comment-16852772 ] Danny Chan commented on CALCITE-2973: - +1 to skip this patch for 1.20 version. > Allow theta joins

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852748#comment-16852748 ] Ruben Quesada Lopez commented on CALCITE-2973: -- Since we are going towards the deprecation

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852684#comment-16852684 ] Haisheng Yuan commented on CALCITE-2973: Agree, I think this patch can be done after 3089 is

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852674#comment-16852674 ] Lai Zhou commented on CALCITE-2973: --- [~rubenql],[~michaelmior], now the patch is good enough to be

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851820#comment-16851820 ] Michael Mior commented on CALCITE-2973: --- That solution seems fine to me. [~hhlai1990] do you

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840269#comment-16840269 ] Ruben Quesada Lopez commented on CALCITE-2973: -- [~hhlai1990], I was just running the tests

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840251#comment-16840251 ] Lai Zhou commented on CALCITE-2973: --- [~rubenql] , good analysis. I tested this solution, but there're

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840194#comment-16840194 ] Ruben Quesada Lopez commented on CALCITE-2973: -- Digging into my previous comment, I

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840190#comment-16840190 ] Lai Zhou commented on CALCITE-2973: --- [~rubenql],thanks , I understand it. When creating a SemiJoin

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840140#comment-16840140 ] Ruben Quesada Lopez commented on CALCITE-2973: -- The problem seems to be in

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839965#comment-16839965 ] Lai Zhou commented on CALCITE-2973: --- [~rubenql], now the inner join with a remainCondtion won't be

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839561#comment-16839561 ] Stamatis Zampetakis commented on CALCITE-2973: -- It seems that the majority ([~hhlai1990],

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838611#comment-16838611 ] Lai Zhou commented on CALCITE-2973: --- [~rubenql], I agree with you. It's a good idea to using

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838592#comment-16838592 ] Ruben Quesada Lopez commented on CALCITE-2973: -- [~hhlai1990], I have just checked the PR,

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838246#comment-16838246 ] Lai Zhou commented on CALCITE-2973: --- [~zabetak], the query as you said, {code:java} SELECT e.name

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837476#comment-16837476 ] Stamatis Zampetakis commented on CALCITE-2973: -- Today I was looking again into another

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833468#comment-16833468 ] Stamatis Zampetakis commented on CALCITE-2973: -- I had a quick look in the PR and seems to

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823659#comment-16823659 ] Lai Zhou commented on CALCITE-2973: --- I modified EnumerableJoin to be able to deal with non-equi join

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823090#comment-16823090 ] Lai Zhou commented on CALCITE-2973: --- [~zabetak],[~hyuan], should we keep EnumerableJoin  as an

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822387#comment-16822387 ] Stamatis Zampetakis commented on CALCITE-2973: -- bq. Both EnumerableHashJoin and

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822133#comment-16822133 ] Haisheng Yuan commented on CALCITE-2973: Every physical join, no matter inner join or outer

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822079#comment-16822079 ] Haisheng Yuan commented on CALCITE-2973: EnumerableJoin and EnumerableThetaJoin are not good

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16821654#comment-16821654 ] Haisheng Yuan commented on CALCITE-2973: {quote} For the record, here is a non-equi join where

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16821642#comment-16821642 ] Haisheng Yuan commented on CALCITE-2973: I don't like the idea of breaking theta join into

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820902#comment-16820902 ] Lai Zhou commented on CALCITE-2973: --- [~zabetak], I can't find a good way to break a theta join into

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819701#comment-16819701 ] Lai Zhou commented on CALCITE-2973: --- [~zabetak], great thanks to your suggestion. I'll  take it into

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818940#comment-16818940 ] Stamatis Zampetakis commented on CALCITE-2973: -- In terms of code re-use, it would seem

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816069#comment-16816069 ] Danny Chan commented on CALCITE-2973: - Hi, [~hhlai1990], i think this issue has strong association

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16815943#comment-16815943 ] Lai Zhou commented on CALCITE-2973: --- [~julianhyde],[~zabetak],[~hyuan] I make a PR to improve the