[jira] [Commented] (CALCITE-2991) getMaxRowCount should return rowcount 1 for an aggregate with constant keys

2019-04-11 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815859#comment-16815859 ] Haisheng Yuan commented on CALCITE-2991: I would prefer to do the simplificatio

[jira] [Commented] (CALCITE-2991) getMaxRowCount should return rowcount 1 for an aggregate with constant keys

2019-04-11 Thread Vineet Garg (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815869#comment-16815869 ] Vineet Garg commented on CALCITE-2991: -- [~hyuan] I am not sure if I understand wha

[jira] [Commented] (CALCITE-2991) getMaxRowCount should return rowcount 1 for an aggregate with constant keys

2019-04-11 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815888#comment-16815888 ] Haisheng Yuan commented on CALCITE-2991: I see your concern. For count(*), it w

[jira] [Commented] (CALCITE-2991) getMaxRowCount should return rowcount 1 for an aggregate with constant keys

2019-04-12 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816556#comment-16816556 ] Julian Hyde commented on CALCITE-2991: -- Regarding a rule to eliminate constant key

[jira] [Commented] (CALCITE-2991) getMaxRowCount should return rowcount 1 for an aggregate with constant keys

2019-04-12 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816743#comment-16816743 ] Julian Hyde commented on CALCITE-2991: -- I'm reviewing again. [~hyuan] I'll make su

[jira] [Commented] (CALCITE-2991) getMaxRowCount should return rowcount 1 for an aggregate with constant keys

2019-04-12 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816744#comment-16816744 ] Haisheng Yuan commented on CALCITE-2991: OK, thanks! > getMaxRowCount should r