[jira] [Commented] (CALCITE-2992) Make implicit conversions when generating hash join keys for an equiCondition

2019-04-16 Thread Lai Zhou (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818765#comment-16818765 ] Lai Zhou commented on CALCITE-2992: --- [~julianhyde], you're right. I add a test case:

[jira] [Commented] (CALCITE-2992) Make implicit conversions when generating hash join keys for an equiCondition

2019-04-12 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816784#comment-16816784 ] Chunwei Lei commented on CALCITE-2992: -- Agree with [~danny0405]. Maybe we should convert the

[jira] [Commented] (CALCITE-2992) Make implicit conversions when generating hash join keys for an equiCondition

2019-04-12 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816077#comment-16816077 ] Danny Chan commented on CALCITE-2992: - I don't think it's a good idea to coerce type int (long) to

[jira] [Commented] (CALCITE-2992) Make implicit conversions when generating hash join keys for an equiCondition

2019-04-12 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816075#comment-16816075 ] Julian Hyde commented on CALCITE-2992: -- Converting keys to strings is a waste of both cpu and