[ 
https://issues.apache.org/jira/browse/CALCITE-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16839200#comment-16839200
 ] 

Danny Chan commented on CALCITE-3034:
-------------------------------------

Fixed inĀ 
[b039a3|https://github.com/apache/calcite/commit/b039a36a3d683f0948531b16a9d97ee50615a5eb],
 thx for your PR [~Faxian] !

> CSV test case description does not match it's code logic
> --------------------------------------------------------
>
>                 Key: CALCITE-3034
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3034
>             Project: Calcite
>          Issue Type: Bug
>          Components: csv-adapter
>            Reporter: FaxianZhao
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> The javadoc of the o.a.c.t.CsvTest#testFilterableWhere2 is 'Filter that can 
> be partly handled by CsvFilterableTable.' 
>  Actually it never handle it, o.a.c.a.c.CsvFilterableTable#scan will get the 
> whole WHERE condition RexNode and that's SqlKind is AND.
>  So, the code logic will return false directly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to