[jira] [Commented] (CALCITE-3119) Deprecate Linq4j CorrelateJoinType (in favor of JoinType)

2019-06-13 Thread Michael Mior (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863301#comment-16863301 ] Michael Mior commented on CALCITE-3119: --- Fixed in

[jira] [Commented] (CALCITE-3119) Deprecate Linq4j CorrelateJoinType (in favor of JoinType)

2019-06-13 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863295#comment-16863295 ] Julian Hyde commented on CALCITE-3119: -- +1 > Deprecate Linq4j CorrelateJoinType (in favor of

[jira] [Commented] (CALCITE-3119) Deprecate Linq4j CorrelateJoinType (in favor of JoinType)

2019-06-13 Thread Ruben Quesada Lopez (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863021#comment-16863021 ] Ruben Quesada Lopez commented on CALCITE-3119: -- [~michaelmior], in my opinion, yes. >

[jira] [Commented] (CALCITE-3119) Deprecate Linq4j CorrelateJoinType (in favor of JoinType)

2019-06-13 Thread Michael Mior (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863017#comment-16863017 ] Michael Mior commented on CALCITE-3119: --- Is this ready to be merged? > Deprecate Linq4j

[jira] [Commented] (CALCITE-3119) Deprecate Linq4j CorrelateJoinType (in favor of JoinType)

2019-06-12 Thread Ruben Quesada Lopez (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861925#comment-16861925 ] Ruben Quesada Lopez commented on CALCITE-3119: -- Thanks for your feedback [~julianhyde], I

[jira] [Commented] (CALCITE-3119) Deprecate Linq4j CorrelateJoinType (in favor of JoinType)

2019-06-11 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861217#comment-16861217 ] Julian Hyde commented on CALCITE-3119: -- Remove, don't deprecate, unused methods in

[jira] [Commented] (CALCITE-3119) Deprecate Linq4j CorrelateJoinType (in favor of JoinType)

2019-06-11 Thread Michael Mior (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861038#comment-16861038 ] Michael Mior commented on CALCITE-3119: --- [~julianhyde] PR looks good to me but do you mind giving

[jira] [Commented] (CALCITE-3119) Deprecate Linq4j CorrelateJoinType (in favor of JoinType)

2019-06-07 Thread Ruben Quesada Lopez (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858796#comment-16858796 ] Ruben Quesada Lopez commented on CALCITE-3119: -- [~julianhyde], I agree. PR available. >

[jira] [Commented] (CALCITE-3119) Deprecate Linq4j CorrelateJoinType (in favor of JoinType)

2019-06-07 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858792#comment-16858792 ] Julian Hyde commented on CALCITE-3119: -- I think we should do this before 1.20. There aren't many