[jira] [Commented] (CALCITE-3386) CyclicMetadataException gives misleading stack trace

2019-10-04 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16944862#comment-16944862 ] Haisheng Yuan commented on CALCITE-3386: Agree > CyclicMetadataException gives

[jira] [Commented] (CALCITE-3386) CyclicMetadataException gives misleading stack trace

2019-10-07 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946175#comment-16946175 ] Julian Hyde commented on CALCITE-3386: -- I don't agree. I wish I had seen this earl

[jira] [Commented] (CALCITE-3386) CyclicMetadataException gives misleading stack trace

2019-10-07 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946218#comment-16946218 ] Haisheng Yuan commented on CALCITE-3386: It is an exception, not an error. Thro

[jira] [Commented] (CALCITE-3386) CyclicMetadataException gives misleading stack trace

2019-10-07 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946247#comment-16946247 ] Haisheng Yuan commented on CALCITE-3386: "CyclicMetadataException is intended f

[jira] [Commented] (CALCITE-3386) CyclicMetadataException gives misleading stack trace

2019-10-07 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946349#comment-16946349 ] Haisheng Yuan commented on CALCITE-3386: Hi Julian, do you still disagree? If s

[jira] [Commented] (CALCITE-3386) CyclicMetadataException gives misleading stack trace

2019-10-07 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946408#comment-16946408 ] Julian Hyde commented on CALCITE-3386: -- I don't think you should back out the chan

[jira] [Commented] (CALCITE-3386) CyclicMetadataException gives misleading stack trace

2019-10-08 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16947058#comment-16947058 ] Haisheng Yuan commented on CALCITE-3386: Hmm, but throwing a new exception can

[jira] [Commented] (CALCITE-3386) CyclicMetadataException gives misleading stack trace

2019-10-08 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16947130#comment-16947130 ] Julian Hyde commented on CALCITE-3386: -- Sure. I'm not saying the new code doesn't

[jira] [Commented] (CALCITE-3386) CyclicMetadataException gives misleading stack trace

2019-10-08 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16947232#comment-16947232 ] Haisheng Yuan commented on CALCITE-3386: I understand that {{FoundOne.NULL}} is