[jira] [Commented] (CALCITE-3830) The ‘approximate’ field should be considered when computing the digest of AggregateCall

2020-02-27 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047008#comment-17047008 ] Julian Hyde commented on CALCITE-3830: -- My preference would be "COUNT(APPROXIMATE DISTINCT xx)".

[jira] [Commented] (CALCITE-3830) The ‘approximate’ field should be considered when computing the digest of AggregateCall

2020-02-27 Thread Shuo Cheng (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046503#comment-17046503 ] Shuo Cheng commented on CALCITE-3830: - Hi [~julianhyde], I'm considering where the keyword 

[jira] [Commented] (CALCITE-3830) The ‘approximate’ field should be considered when computing the digest of AggregateCall

2020-02-27 Thread Shuo Cheng (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046452#comment-17046452 ] Shuo Cheng commented on CALCITE-3830: - [~julianhyde], I've been also hesitated in the way you

[jira] [Commented] (CALCITE-3830) The ‘approximate’ field should be considered when computing the digest of AggregateCall

2020-02-26 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046272#comment-17046272 ] Julian Hyde commented on CALCITE-3830: -- Let’s emit the keyword APPROXIMATE if the flag is set.

[jira] [Commented] (CALCITE-3830) The ‘approximate’ field should be considered when computing the digest of AggregateCall

2020-02-26 Thread Shuo Cheng (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046184#comment-17046184 ] Shuo Cheng commented on CALCITE-3830: - [~danny0405], I've created a pr, please have a look. > The