[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118013#comment-17118013
]
Haisheng Yuan commented on CALCITE-3997:
Sorry for the mis-operation, now I know the real file
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117983#comment-17117983
]
Julian Hyde commented on CALCITE-3997:
--
I saw you manually added a case to
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109227#comment-17109227
]
Anton Haidai commented on CALCITE-3997:
---
{quote}Anton Haidai Would you mind testing latest master
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109191#comment-17109191
]
Ruben Q L commented on CALCITE-3997:
Thanks for your comment, [~xndai], I agree that we should
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109171#comment-17109171
]
Xiening Dai commented on CALCITE-3997:
--
Hi [~rubenql], I agree with most what you said. We should
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108920#comment-17108920
]
Ruben Q L commented on CALCITE-3997:
[~FatLittle], usually this is the case, and I am also using
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108725#comment-17108725
]
Jinpeng Wu commented on CALCITE-3997:
-
[~rubenql] I also think that physical transformation rules
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108688#comment-17108688
]
Haisheng Yuan commented on CALCITE-3997:
This is not a big issue, we can come up a good
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108681#comment-17108681
]
Ruben Q L commented on CALCITE-3997:
[~hyuan], unfortunately, it is not that simple.
I would not
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108613#comment-17108613
]
Xiening Dai commented on CALCITE-3997:
--
There's an downside with my approach (thanks Haisheng for
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108612#comment-17108612
]
Haisheng Yuan commented on CALCITE-3997:
[~rubenql] How difficult is it for you to change your
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108581#comment-17108581
]
Ruben Q L commented on CALCITE-3997:
Yes, [~xndai], I have the impression that, in order to solve
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108529#comment-17108529
]
Xiening Dai commented on CALCITE-3997:
--
I think [~rubenql] has a good point. If TransformationRule
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108433#comment-17108433
]
Haisheng Yuan commented on CALCITE-3997:
[~anha] Would you mind testing latest master against
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108286#comment-17108286
]
Ruben Q L commented on CALCITE-3997:
Ok, thanks for the clarification, [~hyuan].
> Problem with
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108283#comment-17108283
]
Haisheng Yuan commented on CALCITE-3997:
And this only affect subclass of PhysicalNode
>
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108281#comment-17108281
]
Haisheng Yuan commented on CALCITE-3997:
Yes, this is expected. I will mark it as a breaking
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108274#comment-17108274
]
Ruben Q L commented on CALCITE-3997:
However, I am bit worried that the introduction of
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108262#comment-17108262
]
Ruben Q L commented on CALCITE-3997:
Thanks [~hyuan], the quickfix should work fine.
I admit that
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108256#comment-17108256
]
Haisheng Yuan commented on CALCITE-3997:
Thanks for confirming, [~rubenql].
As a quick fix, I
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108253#comment-17108253
]
Ruben Q L commented on CALCITE-3997:
[~hyuan] changing ProjectMergeRule did not work.
However, I
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108207#comment-17108207
]
Ruben Q L commented on CALCITE-3997:
Thanks for the quick reply [~hyuan], I'll check that.
>
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108201#comment-17108201
]
Haisheng Yuan commented on CALCITE-3997:
The can be removed. Can you check?
> Problem with
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108199#comment-17108199
]
Haisheng Yuan commented on CALCITE-3997:
I guess because I add the following to
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108191#comment-17108191
]
Ruben Q L commented on CALCITE-3997:
I observe a potential regression after this change in one of
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108053#comment-17108053
]
Enrico Olivelli commented on CALCITE-3997:
--
[~hyuan] I confirm that on current master in
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107610#comment-17107610
]
Enrico Olivelli commented on CALCITE-3997:
--
Thank you.
I will check tomorrow if this patch
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107421#comment-17107421
]
Haisheng Yuan commented on CALCITE-3997:
PR: https://github.com/apache/calcite/pull/1976
Test
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107352#comment-17107352
]
Haisheng Yuan commented on CALCITE-3997:
I am able to reproduce the issue now.
> Problem with
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107260#comment-17107260
]
Enrico Olivelli commented on CALCITE-3997:
--
[~hyuan]
I have removed that rules
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106432#comment-17106432
]
Haisheng Yuan commented on CALCITE-3997:
No, maybe CALCITE-3576. The context is
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106372#comment-17106372
]
Enrico Olivelli commented on CALCITE-3997:
--
can be issue related to CALCITE-3982 ?
> Problem
32 matches
Mail list logo