[
https://issues.apache.org/jira/browse/CALCITE-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157992#comment-17157992
]
Danny Chen commented on CALCITE-4000:
-
I want to have a final review on this PR, but only have time
[
https://issues.apache.org/jira/browse/CALCITE-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157909#comment-17157909
]
Chunwei Lei commented on CALCITE-4000:
--
[~amaliujia] , is the PR good enough to be merged?
>
[
https://issues.apache.org/jira/browse/CALCITE-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107732#comment-17107732
]
Rui Wang commented on CALCITE-4000:
---
Thanks Viliam! Those are great points.
> 1. The parameter
[
https://issues.apache.org/jira/browse/CALCITE-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107665#comment-17107665
]
Viliam Durina commented on CALCITE-4000:
Few more notes:
1. The parameter names, unlike Java,
[
https://issues.apache.org/jira/browse/CALCITE-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107638#comment-17107638
]
Rui Wang commented on CALCITE-4000:
---
Yes you are right. SESSION does not have the offset parameter
