[jira] [Commented] (CALCITE-4096) Change Pair.hashCode() not to use XOR

2020-06-30 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17148814#comment-17148814 ] Julian Hyde commented on CALCITE-4096: -- It's a trade-off. On balance I prefer what

[jira] [Commented] (CALCITE-4096) Change Pair.hashCode() not to use XOR

2020-06-30 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17148824#comment-17148824 ] Julian Hyde commented on CALCITE-4096: -- As long as {{Pair}} implements {{Map.Entry

[jira] [Commented] (CALCITE-4096) Change Pair.hashCode() not to use XOR

2020-07-02 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150461#comment-17150461 ] Haisheng Yuan commented on CALCITE-4096: Flat2List is a good alternative. Howe

[jira] [Commented] (CALCITE-4096) Change Pair.hashCode() not to use XOR

2020-07-06 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152265#comment-17152265 ] Julian Hyde commented on CALCITE-4096: -- It's not "insane". * {{Map.Entry}} is so

[jira] [Commented] (CALCITE-4096) Change Pair.hashCode() not to use XOR

2020-07-06 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152482#comment-17152482 ] Haisheng Yuan commented on CALCITE-4096: I think I was not making myself clear.