[jira] [Commented] (CALCITE-4115) Improve the prompt of using SQL keywords for sql parser

2020-07-25 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164804#comment-17164804 ] Chunwei Lei commented on CALCITE-4115: -- [~danny0405], I force-pushed the master. Could you please

[jira] [Commented] (CALCITE-4115) Improve the prompt of using SQL keywords for sql parser

2020-07-24 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164681#comment-17164681 ] Julian Hyde commented on CALCITE-4115: -- Agreed. [~Chunwei Lei] As release manager, please

[jira] [Commented] (CALCITE-4115) Improve the prompt of using SQL keywords for sql parser

2020-07-22 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162963#comment-17162963 ] Haisheng Yuan commented on CALCITE-4115: [~danny0405] You might want to refrain from committing

[jira] [Commented] (CALCITE-4115) Improve the prompt of using SQL keywords for sql parser

2020-07-19 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160876#comment-17160876 ] Danny Chen commented on CALCITE-4115: - Another fix in

[jira] [Commented] (CALCITE-4115) Improve the prompt of using SQL keywords for sql parser

2020-07-14 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157806#comment-17157806 ] Danny Chen commented on CALCITE-4115: - Thanks, re-opened to expect a nice conversion about how to

[jira] [Commented] (CALCITE-4115) Improve the prompt of using SQL keywords for sql parser

2020-07-14 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157613#comment-17157613 ] Julian Hyde commented on CALCITE-4115: -- Thanks for improving this. However, I see that you did not

[jira] [Commented] (CALCITE-4115) Improve the prompt of using SQL keywords for sql parser

2020-07-13 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157094#comment-17157094 ] Danny Chen commented on CALCITE-4115: - Another fix in

[jira] [Commented] (CALCITE-4115) Improve the prompt of using SQL keywords for sql parser

2020-07-13 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156545#comment-17156545 ] Danny Chen commented on CALCITE-4115: - A following fix in

[jira] [Commented] (CALCITE-4115) Improve the prompt of using SQL keywords for sql parser

2020-07-12 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156464#comment-17156464 ] Danny Chen commented on CALCITE-4115: - Oh, i figure out a way to make the throw message better,

[jira] [Commented] (CALCITE-4115) Improve the prompt of using SQL keywords for sql parser

2020-07-12 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156463#comment-17156463 ] Danny Chen commented on CALCITE-4115: - Yes, one kind of the exception is a function that uses SQL

[jira] [Commented] (CALCITE-4115) Improve the prompt of using SQL keywords for sql parser

2020-07-11 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156046#comment-17156046 ] Julian Hyde commented on CALCITE-4115: -- Danny, you’ve made the fix that I hoped (and I thought you

[jira] [Commented] (CALCITE-4115) Improve the prompt of using SQL keywords for sql parser

2020-07-09 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17155050#comment-17155050 ] Danny Chen commented on CALCITE-4115: - I want the message to be only in the contexts where an

[jira] [Commented] (CALCITE-4115) Improve the prompt of using SQL keywords for sql parser

2020-07-09 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154773#comment-17154773 ] Julian Hyde commented on CALCITE-4115: -- Do you propose to give the improved message only in

[jira] [Commented] (CALCITE-4115) Improve the prompt of using SQL keywords for sql parser

2020-07-09 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154398#comment-17154398 ] Danny Chen commented on CALCITE-4115: - Finally i found it is hard to give a proper fix suggestion,