[jira] [Commented] (CALCITE-4171) Support named parameters for table window functions

2020-08-18 Thread Rui Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180007#comment-17180007 ] Rui Wang commented on CALCITE-4171: --- Thank you Danny! > Support named parameters fo

[jira] [Commented] (CALCITE-4171) Support named parameters for table window functions

2020-08-18 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17179473#comment-17179473 ] Danny Chen commented on CALCITE-4171: - Finally i removed the {{SqlOperator.paramFal

[jira] [Commented] (CALCITE-4171) Support named parameters for table window functions

2020-08-16 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17178732#comment-17178732 ] Danny Chen commented on CALCITE-4171: - Current problem is not how to get the {{isOp

[jira] [Commented] (CALCITE-4171) Support named parameters for table window functions

2020-08-16 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17178641#comment-17178641 ] Julian Hyde commented on CALCITE-4171: -- There is already an API that determines wh

[jira] [Commented] (CALCITE-4171) Support named parameters for table window functions

2020-08-14 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177614#comment-17177614 ] Danny Chen commented on CALCITE-4171: - [~julianhyde] ~ {quote}I saw you added som

[jira] [Commented] (CALCITE-4171) Support named parameters for table window functions

2020-08-13 Thread Rui Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177522#comment-17177522 ] Rui Wang commented on CALCITE-4171: --- One question jumped into my mind: Is parameter n

[jira] [Commented] (CALCITE-4171) Support named parameters for table window functions

2020-08-13 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177521#comment-17177521 ] Julian Hyde commented on CALCITE-4171: -- [~danny0405], I saw you added some mechani

[jira] [Commented] (CALCITE-4171) Support named parameters for table window functions

2020-08-13 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177272#comment-17177272 ] Julian Hyde commented on CALCITE-4171: -- Sorry; as I said, I didn't see any tests,

[jira] [Commented] (CALCITE-4171) Support named parameters for table window functions

2020-08-11 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175929#comment-17175929 ] Danny Chen commented on CALCITE-4171: - > I didn't see any tests I don't understand

[jira] [Commented] (CALCITE-4171) Support named parameters for table window functions

2020-08-11 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175681#comment-17175681 ] Julian Hyde commented on CALCITE-4171: -- bq. I tested I didn't see any tests. Yes,

[jira] [Commented] (CALCITE-4171) Support named parameters for table window functions

2020-08-11 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175364#comment-17175364 ] Danny Chen commented on CALCITE-4171: - bq. Did you test parameters in different ord

[jira] [Commented] (CALCITE-4171) Support named parameters for table window functions

2020-08-10 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17174963#comment-17174963 ] Julian Hyde commented on CALCITE-4171: -- I removed 'fixVersion = 1.25'. 1.25 has sh