[ https://issues.apache.org/jira/browse/CALCITE-5050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508528#comment-17508528 ]
Jing Zhang commented on CALCITE-5050: ------------------------------------- [~julianhyde]Thanks very much for review. I updated the pr to address point1 and point 2. I'm not sure about point3. Could you please explain it a little bit more? The return value of RelMdRowCount is a double. I checked other UT in RelMetadataTest to testRowCount, they all use 'is'. > Aggregate with no GROUP BY always returns 1 row > ----------------------------------------------- > > Key: CALCITE-5050 > URL: https://issues.apache.org/jira/browse/CALCITE-5050 > Project: Calcite > Issue Type: Bug > Components: core > Affects Versions: 1.29.0, 1.30.0 > Reporter: Jing Zhang > Priority: Minor > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Currently, RowCount of aggregate without group keys are unexpected. > The problem could be appear in the following UT: > {code:java} > @Test void testRowCountAggregateEmptyKey1() { > fixture() > .withRelFn(b -> > b.scan("EMP") > .aggregate( > b.groupKey(), > b.count(false, "C")) > .build()) > .assertThatRowCount(is(1D), is(1D), is(1D)); > } > {code} > Now, the above UT would be failed because row count return 1.4D instead of 1D. -- This message was sent by Atlassian Jira (v8.20.1#820001)