[jira] [Commented] (CALCITE-5085) Firebolt dialect implementation

2022-04-22 Thread Raghav Sharma (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526704#comment-17526704 ] Raghav Sharma commented on CALCITE-5085: Thankyou for supporting and guiding us throughout the

[jira] [Commented] (CALCITE-5085) Firebolt dialect implementation

2022-04-22 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526638#comment-17526638 ] Julian Hyde commented on CALCITE-5085: -- Reviewing now. > Firebolt dialect implementation >

[jira] [Commented] (CALCITE-5085) Firebolt dialect implementation

2022-04-22 Thread Raghav Sharma (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526460#comment-17526460 ] Raghav Sharma commented on CALCITE-5085: All checks have passed. I would request the calcite

[jira] [Commented] (CALCITE-5085) Firebolt dialect implementation

2022-04-22 Thread Raghav Sharma (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526425#comment-17526425 ] Raghav Sharma commented on CALCITE-5085: Done. Initial checks have passed. Please approve the

[jira] [Commented] (CALCITE-5085) Firebolt dialect implementation

2022-04-22 Thread Alessandro Solimando (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526252#comment-17526252 ] Alessandro Solimando commented on CALCITE-5085: --- [~kevinmarr], Druid tests are known to

[jira] [Commented] (CALCITE-5085) Firebolt dialect implementation

2022-04-21 Thread Kevin Marr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526122#comment-17526122 ] Kevin Marr commented on CALCITE-5085: - Hey folks, any idea how we can proceed? Looks like the Druid

[jira] [Commented] (CALCITE-5085) Firebolt dialect implementation

2022-04-18 Thread Raghav Sharma (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17523550#comment-17523550 ] Raghav Sharma commented on CALCITE-5085: One of the checks('{*}CI / Linux (JDK 8) Druid Tests

[jira] [Commented] (CALCITE-5085) Firebolt dialect implementation

2022-04-14 Thread Raghav Sharma (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17522357#comment-17522357 ] Raghav Sharma commented on CALCITE-5085: [~asolimando], the initial checks were successful

[jira] [Commented] (CALCITE-5085) Firebolt dialect implementation

2022-04-14 Thread Raghav Sharma (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17522143#comment-17522143 ] Raghav Sharma commented on CALCITE-5085: [~julianhyde] strange how those got skipped.

[jira] [Commented] (CALCITE-5085) Firebolt dialect implementation

2022-04-13 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17521961#comment-17521961 ] Julian Hyde commented on CALCITE-5085: -- [~raghavSharma], I see some whitespace changes that you

[jira] [Commented] (CALCITE-5085) Firebolt dialect implementation

2022-04-13 Thread Raghav Sharma (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17521519#comment-17521519 ] Raghav Sharma commented on CALCITE-5085: Thanks Alessandro! All checks have passed. Can you go

[jira] [Commented] (CALCITE-5085) Firebolt dialect implementation

2022-04-13 Thread Alessandro Solimando (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17521506#comment-17521506 ] Alessandro Solimando commented on CALCITE-5085: --- I have approved the workflow, tests are

[jira] [Commented] (CALCITE-5085) Firebolt dialect implementation

2022-04-13 Thread Raghav Sharma (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17521496#comment-17521496 ] Raghav Sharma commented on CALCITE-5085: Hi Julian! After committing latest changes, the

[jira] [Commented] (CALCITE-5085) Firebolt dialect implementation

2022-04-12 Thread Raghav Sharma (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17521240#comment-17521240 ] Raghav Sharma commented on CALCITE-5085: Sure Julian! We'll back those out. > Firebolt

[jira] [Commented] (CALCITE-5085) Firebolt dialect implementation

2022-04-12 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17521226#comment-17521226 ] Julian Hyde commented on CALCITE-5085: -- If it wasn't clear, I meant to say

[jira] [Commented] (CALCITE-5085) Firebolt dialect implementation

2022-04-12 Thread Raghav Sharma (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17521009#comment-17521009 ] Raghav Sharma commented on CALCITE-5085: Thanks for confirming the issue Julian. We have added

[jira] [Commented] (CALCITE-5085) Firebolt dialect implementation

2022-04-11 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17520863#comment-17520863 ] Julian Hyde commented on CALCITE-5085: -- Raghav, I ran {{RelToSqlConverterTest.testSubstring}} in a