[jira] [Commented] (CALCITE-5118) SqlDatePartFunction#rewriteCall should check operands length

2022-05-22 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540721#comment-17540721 ] Benchao Li commented on CALCITE-5118: - Thanks [~julianhyde] 's suggestion, I've cre

[jira] [Commented] (CALCITE-5118) SqlDatePartFunction#rewriteCall should check operands length

2022-05-20 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540308#comment-17540308 ] Julian Hyde commented on CALCITE-5118: -- I generally can't tell whether a task is '

[jira] [Commented] (CALCITE-5118) SqlDatePartFunction#rewriteCall should check operands length

2022-05-18 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538840#comment-17538840 ] Benchao Li commented on CALCITE-5118: - Hi guys, do you have any suggestions about m

[jira] [Commented] (CALCITE-5118) SqlDatePartFunction#rewriteCall should check operands length

2022-04-29 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529886#comment-17529886 ] Benchao Li commented on CALCITE-5118: - I kind of agree with [~julianhyde], {{rewrit

[jira] [Commented] (CALCITE-5118) SqlDatePartFunction#rewriteCall should check operands length

2022-04-28 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529687#comment-17529687 ] Julian Hyde commented on CALCITE-5118: -- When CALCITE-1606 created {{class SqlDataP

[jira] [Commented] (CALCITE-5118) SqlDatePartFunction#rewriteCall should check operands length

2022-04-28 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529508#comment-17529508 ] Julian Hyde commented on CALCITE-5118: -- I’m a bit skeptical about the rewriteCall

[jira] [Commented] (CALCITE-5118) SqlDatePartFunction#rewriteCall should check operands length

2022-04-28 Thread Alessandro Solimando (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529447#comment-17529447 ] Alessandro Solimando commented on CALCITE-5118: --- Thanks for the explanati

[jira] [Commented] (CALCITE-5118) SqlDatePartFunction#rewriteCall should check operands length

2022-04-28 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529445#comment-17529445 ] Benchao Li commented on CALCITE-5118: - When wrote the code, I also wondered what th

[jira] [Commented] (CALCITE-5118) SqlDatePartFunction#rewriteCall should check operands length

2022-04-28 Thread Alessandro Solimando (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529292#comment-17529292 ] Alessandro Solimando commented on CALCITE-5118: --- [~julianhyde], by "valid

[jira] [Commented] (CALCITE-5118) SqlDatePartFunction#rewriteCall should check operands length

2022-04-27 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528852#comment-17528852 ] Julian Hyde commented on CALCITE-5118: -- I haven’t looked closely at this but I don

[jira] [Commented] (CALCITE-5118) SqlDatePartFunction#rewriteCall should check operands length

2022-04-27 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528831#comment-17528831 ] Benchao Li commented on CALCITE-5118: - [~asolimando]  I'm proposing to have a more

[jira] [Commented] (CALCITE-5118) SqlDatePartFunction#rewriteCall should check operands length

2022-04-27 Thread Alessandro Solimando (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528815#comment-17528815 ] Alessandro Solimando commented on CALCITE-5118: --- Thanks [~libenchao], I w

[jira] [Commented] (CALCITE-5118) SqlDatePartFunction#rewriteCall should check operands length

2022-04-27 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528811#comment-17528811 ] Benchao Li commented on CALCITE-5118: - [~asolimando] Thanks for the suggestion, I'v

[jira] [Commented] (CALCITE-5118) SqlDatePartFunction#rewriteCall should check operands length

2022-04-27 Thread Alessandro Solimando (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528801#comment-17528801 ] Alessandro Solimando commented on CALCITE-5118: --- [~libenchao], can you de