[jira] [Commented] (CALCITE-5506) RelToSqlConverter should retain the aggregation logic when Project without RexInputRef on the Aggregate

2023-05-30 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17727752#comment-17727752 ] Jiajun Xie commented on CALCITE-5506: - [~julianhyde] , Thank you. > RelToSqlConver

[jira] [Commented] (CALCITE-5506) RelToSqlConverter should retain the aggregation logic when Project without RexInputRef on the Aggregate

2023-05-30 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17727748#comment-17727748 ] Julian Hyde commented on CALCITE-5506: -- [~jiajunbernoulli], I merged the improveme

[jira] [Commented] (CALCITE-5506) RelToSqlConverter should retain the aggregation logic when Project without RexInputRef on the Aggregate

2023-05-27 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17726877#comment-17726877 ] Jiajun Xie commented on CALCITE-5506: - [~julianhyde]  Do you have time to submit yo

[jira] [Commented] (CALCITE-5506) RelToSqlConverter should retain the aggregation logic when Project without RexInputRef on the Aggregate

2023-05-10 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721584#comment-17721584 ] Jiajun Xie commented on CALCITE-5506: - It's a better improvement. Thank you, [~jul

[jira] [Commented] (CALCITE-5506) RelToSqlConverter should retain the aggregation logic when Project without RexInputRef on the Aggregate

2023-05-10 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721567#comment-17721567 ] Julian Hyde commented on CALCITE-5506: -- I have added some test cases, and simplifi

[jira] [Commented] (CALCITE-5506) RelToSqlConverter should retain the aggregation logic when Project without RexInputRef on the Aggregate

2023-05-06 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17720282#comment-17720282 ] Jiajun Xie commented on CALCITE-5506: - Ok, I find a simple case. * Before my patch

[jira] [Commented] (CALCITE-5506) RelToSqlConverter should retain the aggregation logic when Project without RexInputRef on the Aggregate

2023-05-06 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17720245#comment-17720245 ] Julian Hyde commented on CALCITE-5506: -- I don't understand what problem was solved

[jira] [Commented] (CALCITE-5506) RelToSqlConverter should retain the aggregation logic when Project without RexInputRef on the Aggregate

2023-05-03 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17718853#comment-17718853 ] Benchao Li commented on CALCITE-5506: - Sure, will review this when I have time. Bes

[jira] [Commented] (CALCITE-5506) RelToSqlConverter should retain the aggregation logic when Project without RexInputRef on the Aggregate

2023-05-02 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17718786#comment-17718786 ] Jiajun Xie commented on CALCITE-5506: - [~libenchao] ，I used a more detailed descrip