[
https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863887#comment-17863887
]
Julian Hyde commented on CALCITE-873:
-
Commit
[47a2597b|https://github.com/apache/c
[
https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16489517#comment-16489517
]
Julian Hyde commented on CALCITE-873:
-
Reviewing & testing now.
> Prevent sort when
[
https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476971#comment-16476971
]
Atri Sharma commented on CALCITE-873:
-
[~julianhyde] I am reviving this PR with runni
[
https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16084397#comment-16084397
]
Atri Sharma commented on CALCITE-873:
-
[~julianhyde] Yes, I see no test failures in C
[
https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16082650#comment-16082650
]
Julian Hyde commented on CALCITE-873:
-
If you add the rule to the default list of rul
[
https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16082548#comment-16082548
]
Atri Sharma commented on CALCITE-873:
-
[~julianhyde] Please let me know if this looks
[
https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16078520#comment-16078520
]
Atri Sharma commented on CALCITE-873:
-
[~julianhyde] I fixed the tests and refactored
[
https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16077031#comment-16077031
]
Julian Hyde commented on CALCITE-873:
-
This still isn't ready to commit. The disabled
[
https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071116#comment-16071116
]
Atri Sharma commented on CALCITE-873:
-
[~julianhyde] I have changed the test to the a
[
https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070932#comment-16070932
]
Julian Hyde commented on CALCITE-873:
-
{{testSortConstantRemoval}} is not present in
[
https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070636#comment-16070636
]
Atri Sharma commented on CALCITE-873:
-
[~julianhyde] I added two tests, testSortConst
[
https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070603#comment-16070603
]
Julian Hyde commented on CALCITE-873:
-
I reviewed the PR as of
https://github.com/ap
[
https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16068654#comment-16068654
]
Julian Hyde commented on CALCITE-873:
-
[~atris], I see you have changed the PR. Revie
[
https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067028#comment-16067028
]
Atri Sharma commented on CALCITE-873:
-
[~julianhyde] Thanks for your comments!
1) Fo
[
https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065389#comment-16065389
]
Julian Hyde commented on CALCITE-873:
-
[~atris], Thanks for the PR! Comments:
* You a
[
https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15605854#comment-15605854
]
Atri Sharma commented on CALCITE-873:
-
Thanks, I will now refactor the CR
> Prevent
[
https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15605637#comment-15605637
]
Atri Sharma commented on CALCITE-873:
-
Super thanks, will refactor and update
--
[
https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15605625#comment-15605625
]
Julian Hyde commented on CALCITE-873:
-
CALCITE-1465 is fixed and committed.
> Preven
[
https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15605085#comment-15605085
]
Atri Sharma commented on CALCITE-873:
-
I will be waiting for completion of 1465 to re
[
https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15600053#comment-15600053
]
Julian Hyde commented on CALCITE-873:
-
Treat RelNodes as immutable. When you fire a r
[
https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15600049#comment-15600049
]
Atri Sharma commented on CALCITE-873:
-
[~julianhyde] I added some tests, please see.
[
https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15600036#comment-15600036
]
Julian Hyde commented on CALCITE-873:
-
You're on the right track. However what you're
[
https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15599258#comment-15599258
]
Atri Sharma commented on CALCITE-873:
-
[~jhyde.apa...@gmail.com] Please see a basic v
[
https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15486612#comment-15486612
]
Julian Hyde commented on CALCITE-873:
-
Yes.
For finding out which columns are const
[
https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15482139#comment-15482139
]
Atri Sharma commented on CALCITE-873:
-
I am planning to implement a rule which gets t
[
https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15349700#comment-15349700
]
Atri Sharma commented on CALCITE-873:
-
[~julianhyde] I would like to take this one. I
[
https://issues.apache.org/jira/browse/CALCITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322029#comment-15322029
]
Atri Sharma commented on CALCITE-873:
-
Yes, that is correct. +1
> Prevent sort when
27 matches
Mail list logo