[
https://issues.apache.org/jira/browse/CALCITE-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Hyde resolved CALCITE-1826.
----------------------------------
Resolution: Fixed
Fix Version/s: 1.14.0
Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/8cb189f7. I
added test cases for a few more dialects. Thanks for the PR, [~chris-baynes]!
> Jdbc dialect specific FLOOR fails when in GROUP BY
> --------------------------------------------------
>
> Key: CALCITE-1826
> URL: https://issues.apache.org/jira/browse/CALCITE-1826
> Project: Calcite
> Issue Type: Bug
> Components: jdbc-adapter
> Reporter: Chris Baynes
> Assignee: Julian Hyde
> Fix For: 1.14.0
>
>
> Currently the SqlFloorFunction sometimes modifies the operands in a SqlCall
> (i.e. replaceTimeUnitOperand). This is fine if the floor is only used in a
> project, but when used again in an aggregate this modification will change
> the aggregate, which will break the unparsing of it there.
> This can be reproduced by adding a "group by" to the
> RelToSqlConverterTest#testFloor.
> SqlBasicCall#clone is a shallow clone so cannot be used to fix the problem
> (since the underlying operands are not cloned).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
