[ https://issues.apache.org/jira/browse/CALCITE-5650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ASF GitHub Bot updated CALCITE-5650: ------------------------------------ Labels: pull-request-available (was: ) > Sql.dialect method in RelToSqlConverterTests ignores dialect type system > ------------------------------------------------------------------------ > > Key: CALCITE-5650 > URL: https://issues.apache.org/jira/browse/CALCITE-5650 > Project: Calcite > Issue Type: Bug > Components: core > Affects Versions: 1.34.0 > Reporter: Mihai Budiu > Priority: Minor > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > The problem is in the file SqlToRelConverterTest.java, in the static class > Sql, in the following method: > Sql dialect(SqlDialect dialect) { > return new Sql(schemaSpec, sql, dialect, parserConfig, librarySet, > config, > relFn, transforms, typeSystem); > } > The problem is that the dialect may have a different type system, which is > ignored in this function. I think the function should read: > Sql dialect(SqlDialect dialect) { > return new Sql(schemaSpec, sql, dialect, parserConfig, librarySet, > config, > relFn, transforms, dialect.getTypeSystem()); > } > Several tests in this file do change the dialect type system. -- This message was sent by Atlassian Jira (v8.20.10#820010)