[GitHub] carbondata issue #1231: [CARBONDATA-1359] Unable to use carbondata on hive

2017-08-16 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1231 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wis

[GitHub] carbondata issue #1248: [CARBONDATA-1371] Support creating decoder based on ...

2017-08-16 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1248 SDV Build Failed with Spark 2.1, Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/209/ --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] carbondata issue #1262: [BUGFIX] Fix ZERO_BYTE_ARRAY constant not found in c...

2017-08-16 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1262 SDV Build Success with Spark 2.1, Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/208/ --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] carbondata issue #1261: [CARBONDATA-1373] Enhance update performance by incr...

2017-08-16 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1261 SDV Build Failed with Spark 2.1, Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/207/ --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] carbondata issue #1231: [CARBONDATA-1359] Unable to use carbondata on hive

2017-08-16 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1231 SDV Build Success with Spark 2.1, Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/206/ --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] carbondata issue #1255: [CARBONDATA-1375] clean hive pom

2017-08-16 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1255 1.use hadoop.version instead of 2.6.0 2.use hive.version instead of 1.2.1 3.remove thrift 4.remove zookeeper 5.remove spark-hive and spark-sql --- If your project is set up for

[jira] [Created] (CARBONDATA-1385) Add Test cases for Hive Integration

2017-08-16 Thread anubhav tarar (JIRA)
anubhav tarar created CARBONDATA-1385: - Summary: Add Test cases for Hive Integration Key: CARBONDATA-1385 URL: https://issues.apache.org/jira/browse/CARBONDATA-1385 Project: CarbonData Is

[GitHub] carbondata issue #1261: [CARBONDATA-1373] Enhance update performance by incr...

2017-08-16 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1261 SDV Build Success with Spark 2.1, Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/205/ --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] carbondata pull request #1249: [WIP] Use ColumnPage in reader for measure co...

2017-08-16 Thread jackylk
Github user jackylk closed the pull request at: https://github.com/apache/carbondata/pull/1249 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] carbondata pull request #1258: [CARBONDATA-1325] Add partition guidance doc

2017-08-16 Thread zzcclp
Github user zzcclp commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1258#discussion_r133619308 --- Diff: docs/partition-guide.md --- @@ -0,0 +1,124 @@ + + +### CarbonData Partition Table Guidance +This guidance illustrates how to cre

[GitHub] carbondata pull request #1258: [CARBONDATA-1325] Add partition guidance doc

2017-08-16 Thread zzcclp
Github user zzcclp commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1258#discussion_r133619148 --- Diff: docs/partition-guide.md --- @@ -0,0 +1,124 @@ + + +### CarbonData Partition Table Guidance +This guidance illustrates how to cre

[GitHub] carbondata pull request #1262: [BUGFIX] Fix ZERO_BYTE_ARRAY constant not fou...

2017-08-16 Thread jackylk
GitHub user jackylk opened a pull request: https://github.com/apache/carbondata/pull/1262 [BUGFIX] Fix ZERO_BYTE_ARRAY constant not found in codegen CarbonCommonConstant.ZERO_BYTE_ARRAY is used in codegen, it should not be deleted. This PR add it back You can merge this pull reques

[GitHub] carbondata issue #1231: [CARBONDATA-1359] Unable to use carbondata on hive

2017-08-16 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1231 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wis

[GitHub] carbondata issue #1240: [CARBONDATA-1365] add RLE codec implementation

2017-08-16 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1240 SDV Build Success with Spark 2.1, Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/204/ --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] carbondata issue #1231: [CARBONDATA-1359] Unable to use carbondata on hive

2017-08-16 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1231 SDV Build Success with Spark 2.1, Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/203/ --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] carbondata pull request #1240: [CARBONDATA-1365] add RLE codec implementatio...

2017-08-16 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1240#discussion_r133606402 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/RLECodec.java --- @@ -0,0 +1,417 @@ +/* + * Licensed to the Apa

[GitHub] carbondata pull request #1240: [CARBONDATA-1365] add RLE codec implementatio...

2017-08-16 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1240#discussion_r133606239 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/RLECodec.java --- @@ -0,0 +1,417 @@ +/* + * Licensed to the Apa

[GitHub] carbondata issue #1231: [CARBONDATA-1359] Unable to use carbondata on hive

2017-08-16 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1231 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wis

[jira] [Resolved] (CARBONDATA-940) 6. Alter table add/split partition

2017-08-16 Thread Jacky Li (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacky Li resolved CARBONDATA-940. - Resolution: Fixed Fix Version/s: 1.2.0 > 6. Alter table add/split partition > -

[GitHub] carbondata pull request #1192: [CARBONDATA-940] alter table add/split partit...

2017-08-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/1192 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] carbondata issue #1192: [CARBONDATA-940] alter table add/split partition for...

2017-08-16 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/1192 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] carbondata issue #1192: [CARBONDATA-940] alter table add/split partition for...

2017-08-16 Thread QiangCai
Github user QiangCai commented on the issue: https://github.com/apache/carbondata/pull/1192 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] carbondata issue #1234: fix bug in Spi2CarbondataTypeMapper method, it will ...

2017-08-16 Thread anubhav100
Github user anubhav100 commented on the issue: https://github.com/apache/carbondata/pull/1234 @linqer please correct your PR title as per : https://github.com/apache/carbondata/blob/master/docs/How-to-contribute-to-Apache-CarbonData.md --- If your project is set up for it, you can re

[GitHub] carbondata issue #1236: fixed bug for fetching the error value of decimal ty...

2017-08-16 Thread anubhav100
Github user anubhav100 commented on the issue: https://github.com/apache/carbondata/pull/1236 @steven-qin 1.please correct your PR title as per : https://github.com/apache/carbondata/blob/master/docs/How-to-contribute-to-Apache-CarbonData.md 2.there is still problem with decima

[GitHub] carbondata issue #1236: fixed bug for fetching the error value of decimal ty...

2017-08-16 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1236 SDV Build Success with Spark 2.1, Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/202/ --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] carbondata issue #1260: [CARBONDATA-1382] Add more test cases for bucket fea...

2017-08-16 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1260 SDV Build Failed with Spark 2.1, Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/201/ --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] carbondata issue #1258: [CARBONDATA-1325] Add partition guidance doc

2017-08-16 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1258 SDV Build Success with Spark 2.1, Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/200/ --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] carbondata issue #1236: fixed bug for fetching the error value of decimal ty...

2017-08-16 Thread anubhav100
Github user anubhav100 commented on the issue: https://github.com/apache/carbondata/pull/1236 @chenliang sure he has done a great job --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] carbondata issue #1236: fixed bug for fetching the error value of decimal ty...

2017-08-16 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1236 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wis

[GitHub] carbondata issue #1236: fixed bug for fetching the error value of decimal ty...

2017-08-16 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1236 @anubhav100 i prefer to using steven-qin's pull request, because steven-qin fix it earlier. --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Resolved] (CARBONDATA-1372) Fix some errors and update the examples in documentation

2017-08-16 Thread Liang Chen (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liang Chen resolved CARBONDATA-1372. Resolution: Fixed Fix Version/s: 1.2.0 > Fix some errors and update the examples

[GitHub] carbondata pull request #1252: [CARBONDATA-1372]Update the documentation

2017-08-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/1252 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] carbondata issue #1260: [CARBONDATA-1382] Add more test cases for bucket fea...

2017-08-16 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1260 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishe

[GitHub] carbondata pull request #1258: [CARBONDATA-1325] Add partition guidance doc

2017-08-16 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1258#discussion_r133453134 --- Diff: docs/partition-guide.md --- @@ -0,0 +1,124 @@ + + +### CarbonData Partition Table Guidance +This guidance illustrates how

[GitHub] carbondata issue #1258: [CARBONDATA-1325] Add partition guidance doc

2017-08-16 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1258 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wis

[GitHub] carbondata issue #1255: [CARBONDATA-1375] clean hive pom

2017-08-16 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1255 @cenyuhai can you explain this PR, which part you removed, which part you added, and why ? Just i reviewed, only some pom script be changed the position, very less changed. --- If yo

[GitHub] carbondata issue #1258: [CARBONDATA-1325] Add partition guidance doc

2017-08-16 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/1258 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wis

[GitHub] carbondata pull request #1204: [CARBONDATA-1326] Fixed normal/low priority f...

2017-08-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/1204 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] carbondata issue #1204: [CARBONDATA-1326] Fixed normal/low priority findbug ...

2017-08-16 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1204 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] carbondata issue #1204: [CARBONDATA-1326] Fixed normal/low priority findbug ...

2017-08-16 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1204 SDV Build Success with Spark 2.1, Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/199/ --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] carbondata issue #1204: [CARBONDATA-1326] Fixed normal/low priority findbug ...

2017-08-16 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1204 SDV Build Success with Spark 2.1, Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/198/ --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] carbondata issue #1257: [CARBONDATA-1347] Implemented Columnar Reading Of Da...

2017-08-16 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1257 SDV Build Failed with Spark 2.1, Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/197/ --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] carbondata issue #1204: [CARBONDATA-1326] Fixed normal/low priority findbug ...

2017-08-16 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1204 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishe

[GitHub] carbondata issue #1261: [CARBONDATA-1373] Enhance update performance by incr...

2017-08-16 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1261 SDV Build Failed with Spark 2.1, Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/195/ --- If your project is set up for it, you can reply to this email and have your reply app

[jira] [Created] (CARBONDATA-1384) Add Test Cases For Presto-Carbon Integration

2017-08-16 Thread anubhav tarar (JIRA)
anubhav tarar created CARBONDATA-1384: - Summary: Add Test Cases For Presto-Carbon Integration Key: CARBONDATA-1384 URL: https://issues.apache.org/jira/browse/CARBONDATA-1384 Project: CarbonData

[GitHub] carbondata issue #1235: fixed bug for IsNull and IsNotNull clause in presto

2017-08-16 Thread anubhav100
Github user anubhav100 commented on the issue: https://github.com/apache/carbondata/pull/1235 @steven-qin 1.please correct your PR title as per : https://github.com/apache/carbondata/blob/master/docs/How-to-contribute-to-Apache-CarbonData.md 2.Can you please provide the reprod

[GitHub] carbondata pull request #1257: [CARBONDATA-1347] Implemented Columnar Readin...

2017-08-16 Thread anubhav100
Github user anubhav100 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1257#discussion_r133407524 --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/constants/CarbonCommonConstants.java --- @@ -0,0 +1,1319 @@ +/* ---

[GitHub] carbondata issue #1204: [CARBONDATA-1326] Fixed normal/low priority findbug ...

2017-08-16 Thread sraghunandan
Github user sraghunandan commented on the issue: https://github.com/apache/carbondata/pull/1204 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wis

[GitHub] carbondata pull request #1126: [CARBONDATA-1258] CarbonData should not allow...

2017-08-16 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1126#discussion_r133404888 --- Diff: core/src/main/java/org/apache/carbondata/core/keygenerator/directdictionary/timestamp/DateDirectDictionaryGenerator.java --- @@ -1

[GitHub] carbondata pull request #1202: [CARBONDATA-1326] Fixed normal/low priority f...

2017-08-16 Thread mohammadshahidkhan
Github user mohammadshahidkhan closed the pull request at: https://github.com/apache/carbondata/pull/1202 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] carbondata issue #1202: [CARBONDATA-1326] Fixed normal/low priority findbug ...

2017-08-16 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/1202 not required --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wis

[GitHub] carbondata issue #1234: fix bug in Spi2CarbondataTypeMapper method, it will ...

2017-08-16 Thread anubhav100
Github user anubhav100 commented on the issue: https://github.com/apache/carbondata/pull/1234 @linqer how to test this pr can you provide reproducable steps? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] carbondata issue #1259: [Review][CARBONDATA-1381] Add test cases for missing...

2017-08-16 Thread sraghunandan
Github user sraghunandan commented on the issue: https://github.com/apache/carbondata/pull/1259 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wis

[GitHub] carbondata pull request #1253: [CARBONDATA-1373] Enhance update performance ...

2017-08-16 Thread xuchuanyin
Github user xuchuanyin closed the pull request at: https://github.com/apache/carbondata/pull/1253 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] carbondata issue #1236: fixed bug for fetching the error value of decimal ty...

2017-08-16 Thread anubhav100
Github user anubhav100 commented on the issue: https://github.com/apache/carbondata/pull/1236 @steven-qin this pr has resolved this issue with more optimizations #1257 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] carbondata pull request #1257: [CARBONDATA-1347] Implemented Columnar Readin...

2017-08-16 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1257#discussion_r133377510 --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/readers/DecimalSliceStreamReader.java --- @@ -0,0 +1,103 @@ +package o

[GitHub] carbondata pull request #1257: [CARBONDATA-1347] Implemented Columnar Readin...

2017-08-16 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1257#discussion_r133377209 --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/readers/DecimalSliceStreamReader.java --- @@ -0,0 +1,103 @@ +package o

[GitHub] carbondata pull request #1257: [CARBONDATA-1347] Implemented Columnar Readin...

2017-08-16 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1257#discussion_r133377118 --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/readers/BooleanStreamReader.java --- @@ -0,0 +1,31 @@ +package org.apa

[GitHub] carbondata issue #1253: [CARBONDATA-1373] Enhance update performance by incr...

2017-08-16 Thread xuchuanyin
Github user xuchuanyin commented on the issue: https://github.com/apache/carbondata/pull/1253 A new PR #1261 has been raised to solve this problem in a better way. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] carbondata pull request #1257: [CARBONDATA-1347] Implemented Columnar Readin...

2017-08-16 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1257#discussion_r133376989 --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/readers/BooleanStreamReader.java --- @@ -0,0 +1,31 @@ +package org.apa

[GitHub] carbondata issue #1261: [CARBONDATA-1373] Enhance update performance by incr...

2017-08-16 Thread xuchuanyin
Github user xuchuanyin commented on the issue: https://github.com/apache/carbondata/pull/1261 Previous PR #1253 is closed, use this new PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] carbondata pull request #1261: [CARBONDATA-1373] Enhance update performance ...

2017-08-16 Thread xuchuanyin
GitHub user xuchuanyin opened a pull request: https://github.com/apache/carbondata/pull/1261 [CARBONDATA-1373] Enhance update performance by increasing parallelism # Scenario Recently I have tested the update feature provided in Carbondata and found its poor performance.

[GitHub] carbondata issue #1235: fixed bug for IsNull and IsNotNull clause in presto

2017-08-16 Thread anubhav100
Github user anubhav100 commented on the issue: https://github.com/apache/carbondata/pull/1235 @steven-qin can you please provide reproducable steps? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] carbondata pull request #1257: [CARBONDATA-1347] Implemented Columnar Readin...

2017-08-16 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1257#discussion_r133375914 --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/memory/LocalMemoryContext.java --- @@ -0,0 +1,40 @@ +/* + * Licens

[GitHub] carbondata pull request #1257: [CARBONDATA-1347] Implemented Columnar Readin...

2017-08-16 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1257#discussion_r133375796 --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/memory/AggregatedMemoryContext.java --- @@ -0,0 +1,62 @@ +/* + * L

[GitHub] carbondata pull request #1257: [CARBONDATA-1347] Implemented Columnar Readin...

2017-08-16 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1257#discussion_r133375740 --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/memory/AbstractAggregatedMemoryContext.java --- @@ -0,0 +1,37 @@ +/*

[GitHub] carbondata pull request #1257: [CARBONDATA-1347] Implemented Columnar Readin...

2017-08-16 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1257#discussion_r133372855 --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/constants/CarbonCommonConstants.java --- @@ -0,0 +1,1319 @@ +/* --

[GitHub] carbondata pull request #1257: [CARBONDATA-1347] Implemented Columnar Readin...

2017-08-16 Thread anubhav100
Github user anubhav100 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1257#discussion_r133371582 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/expression/ExpressionResult.java --- @@ -183,7 +183,7 @@ public String getString() thro