[GitHub] carbondata pull request #1469: [WIP] Spark-2.2 Carbon Integration - Phase 1

2017-11-26 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1469#discussion_r153062664 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/parser/CarbonSparkSqlParser.scala --- @@ -69,12 +71,11 @@ class CarbonSparkSqlParse

[GitHub] carbondata pull request #1469: [WIP] Spark-2.2 Carbon Integration - Phase 1

2017-11-26 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1469#discussion_r153062707 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/parser/CarbonSparkSqlParser.scala --- @@ -184,10 +126,86 @@ class CarbonSqlAstBuild

[GitHub] carbondata pull request #1469: [WIP] Spark-2.2 Carbon Integration - Phase 1

2017-11-26 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1469#discussion_r153062720 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/parser/CarbonSparkSqlParser.scala --- @@ -184,10 +126,86 @@ class CarbonSqlAstBuild

[GitHub] carbondata pull request #1469: [WIP] Spark-2.2 Carbon Integration - Phase 1

2017-11-26 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1469#discussion_r153062729 --- Diff: integration/spark2/src/main/scala/org/apache/spark/util/AlterTableUtil.scala --- @@ -21,10 +21,11 @@ import scala.collection.JavaConverters

[GitHub] carbondata pull request #1469: [WIP] Spark-2.2 Carbon Integration - Phase 1

2017-11-26 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1469#discussion_r153062759 --- Diff: integration/spark2/src/main/scala/org/apache/spark/util/CarbonClassReflectionUtils.scala --- @@ -0,0 +1,186 @@ +/* + * Licensed to

[GitHub] carbondata pull request #1469: [WIP] Spark-2.2 Carbon Integration - Phase 1

2017-11-26 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1469#discussion_r153062777 --- Diff: integration/spark2/src/main/scala/org/apache/spark/util/CarbonClassReflectionUtils.scala --- @@ -0,0 +1,186 @@ +/* + * Licensed to

[GitHub] carbondata pull request #1469: [WIP] Spark-2.2 Carbon Integration - Phase 1

2017-11-26 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1469#discussion_r153062806 --- Diff: integration/spark2/src/main/scala/org/apache/spark/util/CarbonClassReflectionUtils.scala --- @@ -0,0 +1,186 @@ +/* + * Licensed to

[GitHub] carbondata pull request #1469: [WIP] Spark-2.2 Carbon Integration - Phase 1

2017-11-26 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1469#discussion_r153062831 --- Diff: integration/spark2/src/main/spark2.1/CarbonSessionState.scala --- @@ -24,16 +24,18 @@ import org.apache.spark.sql.catalyst.catalog.{Functio

[GitHub] carbondata pull request #1469: [WIP] Spark-2.2 Carbon Integration - Phase 1

2017-11-26 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1469#discussion_r153062848 --- Diff: integration/spark2/src/main/spark2.1/CarbonSessionState.scala --- @@ -84,8 +86,8 @@ class CarbonSessionCatalog( var toRefreshRelati

[GitHub] carbondata pull request #1469: [WIP] Spark-2.2 Carbon Integration - Phase 1

2017-11-26 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1469#discussion_r153062859 --- Diff: integration/spark2/src/main/spark2.1/CarbonSessionState.scala --- @@ -107,15 +110,14 @@ class CarbonSessionCatalog( carbonEnv.carbo

[jira] [Created] (CARBONDATA-1810) Bad record path is not correct for UT

2017-11-26 Thread xubo245 (JIRA)
xubo245 created CARBONDATA-1810: --- Summary: Bad record path is not correct for UT Key: CARBONDATA-1810 URL: https://issues.apache.org/jira/browse/CARBONDATA-1810 Project: CarbonData Issue Type:

[GitHub] carbondata pull request #1568: [CARBONDATA-1810] Bad record path is not corr...

2017-11-26 Thread xubo245
GitHub user xubo245 opened a pull request: https://github.com/apache/carbondata/pull/1568 [CARBONDATA-1810] Bad record path is not correct for UT Changed bad record path in TestQueryExecutor Be sure to do all of the following checklist to help us incorporate your contri

[GitHub] carbondata pull request #1469: [WIP] Spark-2.2 Carbon Integration - Phase 1

2017-11-26 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1469#discussion_r153064184 --- Diff: integration/spark2/src/main/spark2.1/CarbonSessionState.scala --- @@ -133,7 +134,9 @@ class CarbonSessionState(sparkSession: SparkSession)

[GitHub] carbondata pull request #1469: [WIP] Spark-2.2 Carbon Integration - Phase 1

2017-11-26 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1469#discussion_r153064193 --- Diff: integration/spark2/src/main/spark2.1/CarbonSessionState.scala --- @@ -150,9 +153,8 @@ class CarbonSessionState(sparkSession: SparkSession)

[GitHub] carbondata pull request #1469: [WIP] Spark-2.2 Carbon Integration - Phase 1

2017-11-26 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1469#discussion_r153064203 --- Diff: integration/spark2/src/main/spark2.1/CarbonSessionState.scala --- @@ -207,3 +213,26 @@ class CarbonOptimizer( super.execute(transFo

[GitHub] carbondata pull request #1469: [WIP] Spark-2.2 Carbon Integration - Phase 1

2017-11-26 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1469#discussion_r153064235 --- Diff: integration/spark2/src/main/spark2.2/CarbonSessionState.scala --- @@ -0,0 +1,256 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] carbondata pull request #1469: [WIP] Spark-2.2 Carbon Integration - Phase 1

2017-11-26 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1469#discussion_r153064253 --- Diff: integration/spark2/src/test/scala/org/apache/spark/carbondata/restructure/AlterTableValidationTestCase.scala --- @@ -85,71 +85,75 @@ class

[GitHub] carbondata pull request #1469: [WIP] Spark-2.2 Carbon Integration - Phase 1

2017-11-26 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1469#discussion_r153064274 --- Diff: pom.xml --- @@ -509,6 +501,8 @@ ${basedir}/integration/hive/src/main/java ${basedir}/integration

[GitHub] carbondata pull request #1469: [WIP] Spark-2.2 Carbon Integration - Phase 1

2017-11-26 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1469#discussion_r153064291 --- Diff: pom.xml --- @@ -554,6 +553,8 @@ ${basedir}/integration/hive/src/main/java ${basedir}/integration

[GitHub] carbondata issue #1469: [WIP] Spark-2.2 Carbon Integration - Phase 1

2017-11-26 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1469 Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/377/ ---

[GitHub] carbondata issue #1469: [WIP] Spark-2.2 Carbon Integration - Phase 1

2017-11-26 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1469 @sounakr Please change the branch to master. ---

[GitHub] carbondata issue #1568: [CARBONDATA-1810] Bad record path is not correct for...

2017-11-26 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1568 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1462/ ---

[GitHub] carbondata issue #1552: [CARBONDATA-1796] While submitting new job to Hadoop...

2017-11-26 Thread dhatchayani
Github user dhatchayani commented on the issue: https://github.com/apache/carbondata/pull/1552 merged with PR#1558 ---

[GitHub] carbondata pull request #1557: [CARBONDATA-1796] While submitting new job to...

2017-11-26 Thread dhatchayani
Github user dhatchayani closed the pull request at: https://github.com/apache/carbondata/pull/1557 ---

[GitHub] carbondata issue #1557: [CARBONDATA-1796] While submitting new job to Hadoop...

2017-11-26 Thread dhatchayani
Github user dhatchayani commented on the issue: https://github.com/apache/carbondata/pull/1557 already merged with PR#1558 ---

[GitHub] carbondata issue #1568: [CARBONDATA-1810] Bad record path is not correct for...

2017-11-26 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1568 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1879/ ---

[GitHub] carbondata issue #1568: [CARBONDATA-1810] Bad record path is not correct for...

2017-11-26 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/1568 @jackylk @QiangCai Please review it. ---

[GitHub] carbondata issue #1558: [CARBONDATA-1803] Changing format of Show segments

2017-11-26 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1558 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1463/ ---

[GitHub] carbondata issue #1558: [CARBONDATA-1803] Changing format of Show segments

2017-11-26 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1558 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1880/ ---

[GitHub] carbondata issue #1523: [CARBONDATA-1756] Improve Boolean data compress rate...

2017-11-26 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1523 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1464/ ---

[GitHub] carbondata issue #1558: [CARBONDATA-1803] Changing format of Show segments

2017-11-26 Thread dhatchayani
Github user dhatchayani commented on the issue: https://github.com/apache/carbondata/pull/1558 retest this please ---

[GitHub] carbondata issue #1523: [CARBONDATA-1756] Improve Boolean data compress rate...

2017-11-26 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1523 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1881/ ---

[GitHub] carbondata issue #1523: [CARBONDATA-1756] Improve Boolean data compress rate...

2017-11-26 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/1523 retest this please ---

[GitHub] carbondata issue #1558: [CARBONDATA-1803] Changing format of Show segments

2017-11-26 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1558 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1465/ ---

[GitHub] carbondata issue #1508: [CARBONDATA-1738] [PreAgg] Block direct insert/load ...

2017-11-26 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1508 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1466/ ---

[GitHub] carbondata issue #1558: [CARBONDATA-1803] Changing format of Show segments

2017-11-26 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1558 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1882/ ---

[GitHub] carbondata issue #1558: [CARBONDATA-1803] Changing format of Show segments

2017-11-26 Thread dhatchayani
Github user dhatchayani commented on the issue: https://github.com/apache/carbondata/pull/1558 retest sdv please ---

[GitHub] carbondata issue #1523: [CARBONDATA-1756] Improve Boolean data compress rate...

2017-11-26 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1523 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1467/ ---

[GitHub] carbondata issue #1501: [CARBONDATA-1713] Fixed Aggregate query on main tabl...

2017-11-26 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1501 @jackylk tablename, dbname and column names are case insensitive in carbon ---

[GitHub] carbondata issue #1501: [CARBONDATA-1713] Fixed Aggregate query on main tabl...

2017-11-26 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1501 LGTM ---

[GitHub] carbondata issue #1508: [CARBONDATA-1738] [PreAgg] Block direct insert/load ...

2017-11-26 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1508 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1883/ ---

[GitHub] carbondata pull request #1501: [CARBONDATA-1713] Fixed Aggregate query on ma...

2017-11-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/1501 ---

[jira] [Resolved] (CARBONDATA-1713) Carbon1.3.0-Pre-AggregateTable - Aggregate query on main table fails after creating pre-aggregate table when upper case used for column name

2017-11-26 Thread Ravindra Pesala (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravindra Pesala resolved CARBONDATA-1713. - Resolution: Fixed > Carbon1.3.0-Pre-AggregateTable - Aggregate query on main

[GitHub] carbondata pull request #1508: [CARBONDATA-1738] [PreAgg] Block direct inser...

2017-11-26 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1508#discussion_r153067591 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/CreatePreAggregateTableCommand.scala --- @@ -94,10

[GitHub] carbondata pull request #1523: [CARBONDATA-1756] Improve Boolean data compre...

2017-11-26 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1523#discussion_r153067752 --- Diff: integration/spark2/src/test/scala/org/apache/carbondata/spark/testsuite/booleantype/compress/BooleanFile.scala --- @@ -0,0 +1,59 @@ +/*

[GitHub] carbondata pull request #1508: [CARBONDATA-1738] [PreAgg] Block direct inser...

2017-11-26 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1508#discussion_r153067934 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonPreAggregateRules.scala --- @@ -736,6 +739,45 @@ case class CarbonPreAgg

[GitHub] carbondata pull request #1508: [CARBONDATA-1738] [PreAgg] Block direct inser...

2017-11-26 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1508#discussion_r153067988 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonPreAggregateRules.scala --- @@ -736,6 +739,45 @@ case class CarbonPreAgg

[GitHub] carbondata pull request #1508: [CARBONDATA-1738] [PreAgg] Block direct inser...

2017-11-26 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1508#discussion_r153068009 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonEnv.scala --- @@ -55,6 +55,7 @@ class CarbonEnv { // added for handli

[GitHub] carbondata pull request #1508: [CARBONDATA-1738] [PreAgg] Block direct inser...

2017-11-26 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1508#discussion_r153068092 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateListeners.scala --- @@ -49,13 +50,52 @@

[GitHub] carbondata pull request #1508: [CARBONDATA-1738] [PreAgg] Block direct inser...

2017-11-26 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1508#discussion_r153068121 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/CreatePreAggregateTableCommand.scala --- @@ -94,10

[GitHub] carbondata pull request #1569: [CARBONDATA-1752] There are some scalastyle e...

2017-11-26 Thread xubo245
GitHub user xubo245 opened a pull request: https://github.com/apache/carbondata/pull/1569 [CARBONDATA-1752] There are some scalastyle error should be optimized in CarbonData There are some scalastyle error should be optimized in CarbonData, including removing useless import, o

[GitHub] carbondata issue #1510: [CARBONDATA-1543] Supported DataMap chooser and expr...

2017-11-26 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1510 @jackylk Please review, I have moved the `like` expression conversion to carbon layer in this PR itself, so like expression can be accessed as `STARTSWITH` or `ENDSWITH` or `CONTAINSWITH` to

[GitHub] carbondata issue #1521: [WIP] [CARBONDATA-1743] fix conurrent pre-agg creati...

2017-11-26 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1521 @kunal642 Please rebase and fix the build ---

[GitHub] carbondata issue #1508: [CARBONDATA-1738] [PreAgg] Block direct insert/load ...

2017-11-26 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1508 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1884/ ---

[GitHub] carbondata pull request #1542: [CARBONDATA-1757] [PreAgg] Fix for wrong avg ...

2017-11-26 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1542#discussion_r153068582 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonPreAggregateRules.scala --- @@ -797,33 +798,59 @@ object CarbonPreInsert

[GitHub] carbondata issue #1544: [CARBONDATA-1740] Fixed order by issue in case of pr...

2017-11-26 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1544 @kumarvishal09 Add PR description ---

[GitHub] carbondata issue #1546: [CARBONDATA-1736] Query from segment set is not effe...

2017-11-26 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1546 @jackylk you are right, we will use Load command directly and pass the segments to it. ---

[GitHub] carbondata pull request #1544: [CARBONDATA-1740] Fixed order by issue in cas...

2017-11-26 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1544#discussion_r153068779 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonPreAggregateRules.scala --- @@ -160,6 +155,90 @@ case class CarbonPreAgg

[GitHub] carbondata pull request #1542: [CARBONDATA-1757] [PreAgg] Fix for wrong avg ...

2017-11-26 Thread kunal642
Github user kunal642 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1542#discussion_r153068856 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonPreAggregateRules.scala --- @@ -797,33 +798,59 @@ object CarbonPreInsertio

[GitHub] carbondata issue #1569: [CARBONDATA-1752] There are some scalastyle error sh...

2017-11-26 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1569 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1468/ ---

[GitHub] carbondata issue #1558: [CARBONDATA-1803] Changing format of Show segments

2017-11-26 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1558 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1885/ ---

[GitHub] carbondata issue #1508: [CARBONDATA-1738] [PreAgg] Block direct insert/load ...

2017-11-26 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1508 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1469/ ---

[GitHub] carbondata issue #1558: [CARBONDATA-1803] Changing format of Show segments

2017-11-26 Thread dhatchayani
Github user dhatchayani commented on the issue: https://github.com/apache/carbondata/pull/1558 Retest sdv please ---

[GitHub] carbondata issue #1569: [CARBONDATA-1752] There are some scalastyle error sh...

2017-11-26 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1569 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1886/ ---

[GitHub] carbondata issue #1496: [CARBONDATA-1709][DataFrame] Support sort_columns op...

2017-11-26 Thread xuchuanyin
Github user xuchuanyin commented on the issue: https://github.com/apache/carbondata/pull/1496 @ravipesala hi, can you review it? ---

[GitHub] carbondata issue #1508: [CARBONDATA-1738] [PreAgg] Block direct insert/load ...

2017-11-26 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1508 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1887/ ---

[GitHub] carbondata issue #1558: [CARBONDATA-1803] Changing format of Show segments

2017-11-26 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1558 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1888/ ---

[GitHub] carbondata pull request #1570: Support skip.header.line.count option for Hiv...

2017-11-26 Thread sehriff
GitHub user sehriff opened a pull request: https://github.com/apache/carbondata/pull/1570 Support skip.header.line.count option for Hive Table in Carbon Support skip.header.line.count option for Hive Table in Carbon Be sure to do all of the following checklist to help us inc

[GitHub] carbondata issue #1570: [CARBONDATA-1730] Support skip.header.line.count opt...

2017-11-26 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1570 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1470/ ---

[jira] [Updated] (CARBONDATA-1730) Support skip.header.line.count option for Hive Table in Carbon

2017-11-26 Thread JIRA
[ https://issues.apache.org/jira/browse/CARBONDATA-1730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sehriff[FFCS研究院] updated CARBONDATA-1730: - Description: Since Support skip.header.line.count option for Hive Table in Ca

[GitHub] carbondata issue #1558: [CARBONDATA-1803] Changing format of Show segments

2017-11-26 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1558 LGTM ---

[GitHub] carbondata issue #1570: [CARBONDATA-1730] Support skip.header.line.count opt...

2017-11-26 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1570 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1889/ ---

[jira] [Resolved] (CARBONDATA-1803) Changing format of Show segments

2017-11-26 Thread Ravindra Pesala (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravindra Pesala resolved CARBONDATA-1803. - Resolution: Fixed Fix Version/s: 1.3.0 > Changing format of Show segme

[GitHub] carbondata pull request #1469: [WIP] Spark-2.2 Carbon Integration - Phase 1

2017-11-26 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1469#discussion_r153076314 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonExpressions.scala --- @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache S

[GitHub] carbondata pull request #1469: [WIP] Spark-2.2 Carbon Integration - Phase 1

2017-11-26 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1469#discussion_r153076333 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSession.scala --- @@ -19,10 +19,10 @@ package org.apache.spark.sql import ja

[GitHub] carbondata pull request #1469: [WIP] Spark-2.2 Carbon Integration - Phase 1

2017-11-26 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1469#discussion_r153076325 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonExpressions.scala --- @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache S

[GitHub] carbondata pull request #1469: [WIP] Spark-2.2 Carbon Integration - Phase 1

2017-11-26 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1469#discussion_r153076329 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonExpressions.scala --- @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache S

[GitHub] carbondata pull request #1469: [WIP] Spark-2.2 Carbon Integration - Phase 1

2017-11-26 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1469#discussion_r153076321 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonExpressions.scala --- @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache S

[GitHub] carbondata pull request #1469: [WIP] Spark-2.2 Carbon Integration - Phase 1

2017-11-26 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1469#discussion_r153076376 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSession.scala --- @@ -43,14 +43,15 @@ class CarbonSession(@transient val sc: Spar

[GitHub] carbondata pull request #1469: [WIP] Spark-2.2 Carbon Integration - Phase 1

2017-11-26 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1469#discussion_r153076398 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/CastExpressionOptimization.scala --- @@ -21,12 +21,14 @@ import java.text.{P

[GitHub] carbondata pull request #1469: [WIP] Spark-2.2 Carbon Integration - Phase 1

2017-11-26 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1469#discussion_r153076418 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/AlterTableDataTypeChangeCommand.scala --- @@ -94,10 +95,7 @@

[GitHub] carbondata pull request #1469: [WIP] Spark-2.2 Carbon Integration - Phase 1

2017-11-26 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1469#discussion_r153076407 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/AlterTableDataTypeChangeCommand.scala --- @@ -19,9 +19,10 @@

[GitHub] carbondata pull request #1469: [WIP] Spark-2.2 Carbon Integration - Phase 1

2017-11-26 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1469#discussion_r153076449 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/AlterTableDropColumnCommand.scala --- @@ -120,10 +121,7 @@ pr

[GitHub] carbondata pull request #1469: [WIP] Spark-2.2 Carbon Integration - Phase 1

2017-11-26 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1469#discussion_r153076436 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/AlterTableDropColumnCommand.scala --- @@ -20,9 +20,10 @@ pack

[GitHub] carbondata pull request #1469: [WIP] Spark-2.2 Carbon Integration - Phase 1

2017-11-26 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1469#discussion_r153076462 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/CarbonLateDecodeStrategy.scala --- @@ -42,6 +43,7 @@ import org.ap

[GitHub] carbondata pull request #1469: [WIP] Spark-2.2 Carbon Integration - Phase 1

2017-11-26 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1469#discussion_r153076471 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/DDLStrategy.scala --- @@ -26,13 +26,19 @@ import org.apache.spark.

[GitHub] carbondata pull request #1469: [WIP] Spark-2.2 Carbon Integration - Phase 1

2017-11-26 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1469#discussion_r153076491 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/DDLStrategy.scala --- @@ -26,13 +26,19 @@ import org.apache.spark.

[GitHub] carbondata pull request #1469: [WIP] Spark-2.2 Carbon Integration - Phase 1

2017-11-26 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1469#discussion_r153076517 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/DDLStrategy.scala --- @@ -155,6 +161,14 @@ class DDLStrategy(sparkS

[GitHub] carbondata pull request #1469: [WIP] Spark-2.2 Carbon Integration - Phase 1

2017-11-26 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1469#discussion_r153076529 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/DDLStrategy.scala --- @@ -155,6 +161,14 @@ class DDLStrategy(sparkS

[GitHub] carbondata pull request #1469: [WIP] Spark-2.2 Carbon Integration - Phase 1

2017-11-26 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1469#discussion_r153076559 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonAnalysisRules.scala --- @@ -24,17 +24,15 @@ import org.apache.spark.sql.ca

[GitHub] carbondata pull request #1469: [WIP] Spark-2.2 Carbon Integration - Phase 1

2017-11-26 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1469#discussion_r153076600 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonAnalysisRules.scala --- @@ -58,6 +57,8 @@ object CarbonPreInsertionCasts ex

[jira] [Created] (CARBONDATA-1811) Use TableInfo and StructType to create the table

2017-11-26 Thread Jacky Li (JIRA)
Jacky Li created CARBONDATA-1811: Summary: Use TableInfo and StructType to create the table Key: CARBONDATA-1811 URL: https://issues.apache.org/jira/browse/CARBONDATA-1811 Project: CarbonData

[GitHub] carbondata pull request #1571: [CARBONDATA-1811] [CTAS] Use TableInfo and St...

2017-11-26 Thread jackylk
GitHub user jackylk opened a pull request: https://github.com/apache/carbondata/pull/1571 [CARBONDATA-1811] [CTAS] Use TableInfo and StructType when creating table This PR contains refactory for CarbonCreateTableCommand and CarbonAlterTableAddColumnCommand, they should use TableInfo

[jira] [Updated] (CARBONDATA-1811) Use TableInfo and StructType to create the table

2017-11-26 Thread Jacky Li (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacky Li updated CARBONDATA-1811: - Issue Type: Improvement (was: Bug) > Use TableInfo and StructType to create the table >

[GitHub] carbondata issue #1571: [CARBONDATA-1811] [CTAS] Use TableInfo and StructTyp...

2017-11-26 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1571 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1471/ ---

[GitHub] carbondata issue #1571: [CARBONDATA-1811] [CTAS] Use StructType as schema wh...

2017-11-26 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1571 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1891/ ---

[GitHub] carbondata issue #1571: [CARBONDATA-1811] [CTAS] Use StructType as schema wh...

2017-11-26 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1571 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1472/ ---

[GitHub] carbondata pull request #1566: [CARBONDATA-1586][Streaming] Support handoff ...

2017-11-26 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1566#discussion_r153092758 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/result/iterator/RawResultIterator.java --- @@ -64,6 +64,10 @@ public RawResultIterator(Car

[GitHub] carbondata pull request #1566: [CARBONDATA-1586][Streaming] Support handoff ...

2017-11-26 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1566#discussion_r153093237 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/streaming/CarbonStreamRecordReader.java --- @@ -342,7 +349,11 @@ private boolean nextRow()

[GitHub] carbondata pull request #1566: [CARBONDATA-1586][Streaming] Support handoff ...

2017-11-26 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1566#discussion_r153093394 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonMergerRDD.scala --- @@ -116,7 +116,7 @@ class CarbonMergerRDD[K

  1   2   >