[GitHub] carbondata issue #1749: [CARBONDATA-1968] Add external table support

2018-01-13 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1749 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2752/ ---

[GitHub] carbondata issue #1749: [CARBONDATA-1968] Add external table support

2018-01-13 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/1749 @mohammadshahidkhan Yes, that is correct. Drop table should not delete data. I have modify the testcase to verify it. I have added a internal table property ("_external"), it will be set to

[GitHub] carbondata issue #1749: [CARBONDATA-1968] Add external table support

2018-01-13 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/1749 @jackylk I have couple of Queries. For carbon external table, how to identify the table is external table? What would be drop table behaviour for external carbon table?

[GitHub] carbondata issue #1749: [CARBONDATA-1968] Add external table support

2018-01-13 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1749 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1518/ ---

[GitHub] carbondata issue #1749: [CARBONDATA-1968] Add external table support

2018-01-13 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1749 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2750/ ---

[GitHub] carbondata pull request #1790: [CARBONDATA-2009][Documentation] Document Ref...

2018-01-13 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1790#discussion_r161375031 --- Diff: docs/data-management-on-carbondata.md --- @@ -271,6 +271,7 @@ This tutorial is going to introduce all commands and data operations

[GitHub] carbondata issue #1749: [CARBONDATA-1968] Add external table support

2018-01-13 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1749 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2749/ ---

[GitHub] carbondata issue #1765: [CARBONDATA-1992] Remove partitionId in CarbonTableP...

2018-01-13 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1765 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1516/ ---

[GitHub] carbondata issue #1765: [CARBONDATA-1992] Remove partitionId in CarbonTableP...

2018-01-13 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1765 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2748/ ---

[GitHub] carbondata issue #1797: [CARBONDATA-2024][IUD] Fixed after update empty fold...

2018-01-13 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1797 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1515/ ---

[GitHub] carbondata issue #1797: [CARBONDATA-2024][IUD] Fixed after update empty fold...

2018-01-13 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1797 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2747/ ---

[GitHub] carbondata issue #1791: [CARBONDATA-2010] Block streaming on main table of p...

2018-01-13 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1791 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1514/ ---

[GitHub] carbondata issue #1777: [CARBONDATA-1973] User Should not Be able to give th...

2018-01-13 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1777 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1513/ ---

[GitHub] carbondata issue #1777: [CARBONDATA-1973] User Should not Be able to give th...

2018-01-13 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1777 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2745/ ---

[GitHub] carbondata issue #1458: [CARBONDATA-1663] Decouple spark and core modules

2018-01-13 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1458 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2744/ ---

[GitHub] carbondata issue #1458: [CARBONDATA-1663] Decouple spark and core modules

2018-01-13 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1458 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1512/ ---

[GitHub] carbondata issue #1772: [CARBONDATA-1995] Unify all writer steps and make te...

2018-01-13 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1772 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1511/ ---

[GitHub] carbondata issue #1772: [CARBONDATA-1995] Unify all writer steps and make te...

2018-01-13 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1772 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2743/ ---

[GitHub] carbondata pull request #1791: [CARBONDATA-2010] Block streaming on main tab...

2018-01-13 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1791#discussion_r161369358 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableInfo.java --- @@ -316,4 +316,18 @@ public static TableInfo

[GitHub] carbondata issue #1765: [CARBONDATA-1992] Remove partitionId in CarbonTableP...

2018-01-13 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1765 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2742/ ---

[GitHub] carbondata issue #1765: [CARBONDATA-1992] Remove partitionId in CarbonTableP...

2018-01-13 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1765 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1510/ ---

[GitHub] carbondata issue #1777: [CARBONDATA-1973] User Should not Be able to give th...

2018-01-13 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1777 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1509/ ---

[GitHub] carbondata issue #1768: [CARBONDATA-2025] Unify all path construction throug...

2018-01-13 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1768 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2741/ ---

[GitHub] carbondata issue #1777: [CARBONDATA-1973] User Should not Be able to give th...

2018-01-13 Thread anubhav100
Github user anubhav100 commented on the issue: https://github.com/apache/carbondata/pull/1777 retest this please ---

[GitHub] carbondata issue #1777: [CARBONDATA-1973] User Should not Be able to give th...

2018-01-13 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1777 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2740/ ---

[GitHub] carbondata issue #1768: [CARBONDATA-2025] Unify all path construction throug...

2018-01-13 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1768 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1508/ ---

[GitHub] carbondata issue #1774: [CARBONDATA-2001] Unable to Save DataFrame As Carbon...

2018-01-13 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1774 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1507/ ---

[GitHub] carbondata issue #1774: [CARBONDATA-2001] Unable to Save DataFrame As Carbon...

2018-01-13 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1774 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2739/ ---

[GitHub] carbondata issue #1749: [CARBONDATA-1968] Add external table support

2018-01-13 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1749 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1506/ ---

[GitHub] carbondata issue #1749: [CARBONDATA-1968] Add external table support

2018-01-13 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1749 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2738/ ---

[GitHub] carbondata issue #1749: [CARBONDATA-1968] Add external table support

2018-01-13 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/1749 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2863/ ---

[jira] [Created] (CARBONDATA-2025) Refactor CarbonTablePath

2018-01-13 Thread Jacky Li (JIRA)
Jacky Li created CARBONDATA-2025: Summary: Refactor CarbonTablePath Key: CARBONDATA-2025 URL: https://issues.apache.org/jira/browse/CARBONDATA-2025 Project: CarbonData Issue Type: Sub-task

[GitHub] carbondata pull request #1777: [CARBONDATA-1973] User Should not Be able to ...

2018-01-13 Thread anubhav100
Github user anubhav100 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1777#discussion_r161367489 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/parser/CarbonSparkSqlParser.scala --- @@ -200,7 +200,8 @@ class

[GitHub] carbondata pull request #1774: [CARBONDATA-2001] Unable to Save DataFrame As...

2018-01-13 Thread anubhav100
Github user anubhav100 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1774#discussion_r161367434 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonDataFrameWriter.scala --- @@ -167,13 +167,20 @@ class

[GitHub] carbondata pull request #1774: [CARBONDATA-2001] Unable to Save DataFrame As...

2018-01-13 Thread anubhav100
Github user anubhav100 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1774#discussion_r161367429 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonDataFrameWriter.scala --- @@ -167,13 +167,19 @@ class

[GitHub] carbondata pull request #1782: [CARBONDATA-2019] Enhancement of merge index ...

2018-01-13 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1782#discussion_r161366867 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala --- @@ -893,33 +893,58 @@ object

[GitHub] carbondata pull request #1782: [CARBONDATA-2019] Enhancement of merge index ...

2018-01-13 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1782#discussion_r161366900 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala --- @@ -893,33 +893,58 @@ object

[GitHub] carbondata pull request #1782: [CARBONDATA-2019] Enhancement of merge index ...

2018-01-13 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1782#discussion_r161367075 --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/SegmentIndexFileStore.java --- @@ -185,4 +219,98 @@

[GitHub] carbondata pull request #1774: [CARBONDATA-2001] Unable to Save DataFrame As...

2018-01-13 Thread anubhav100
Github user anubhav100 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1774#discussion_r161367337 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonDataFrameWriter.scala --- @@ -167,13 +167,20 @@ class

[GitHub] carbondata issue #71: [CARBONDATA-155] Code refactor to avoid the Type Casti...

2018-01-13 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/71 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2737/ ---

[GitHub] carbondata issue #1104: [CARBONDATA-1239] Add validation for set command par...

2018-01-13 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1104 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1504/ ---

[GitHub] carbondata issue #71: [CARBONDATA-155] Code refactor to avoid the Type Casti...

2018-01-13 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/71 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1505/ ---

[GitHub] carbondata issue #1104: [CARBONDATA-1239] Add validation for set command par...

2018-01-13 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1104 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2736/ ---

[GitHub] carbondata issue #1749: [CARBONDATA-1968] Add external table support

2018-01-13 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/1749 retest this please ---

[GitHub] carbondata pull request #1751: [CARBONDATA-1971][Blocklet Prunning] Measure ...

2018-01-13 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1751#discussion_r161366923 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/SimpleStatsResult.java --- @@ -25,6 +25,8 @@ Object

[GitHub] carbondata pull request #1751: [CARBONDATA-1971][Blocklet Prunning] Measure ...

2018-01-13 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1751#discussion_r161366903 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/SimpleStatsResult.java --- @@ -25,6 +25,8 @@ Object

[jira] [Resolved] (CARBONDATA-2017) Error occurs when loading multiple files

2018-01-13 Thread Jacky Li (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacky Li resolved CARBONDATA-2017. -- Resolution: Fixed Fix Version/s: 1.3.0 > Error occurs when loading multiple files >

[jira] [Resolved] (CARBONDATA-1965) SET command is not setting the parameter carbon.options.sort.scope

2018-01-13 Thread Jacky Li (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-1965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacky Li resolved CARBONDATA-1965. -- Resolution: Fixed > SET command is not setting the parameter carbon.options.sort.scope >

[GitHub] carbondata pull request #1784: [CARBONDATA-1965]removed sort_scope from dyna...

2018-01-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/1784 ---

[GitHub] carbondata issue #1784: [CARBONDATA-1965]removed sort_scope from dynamic con...

2018-01-13 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/1784 LGTM ---