Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2197#discussion_r183200584
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/preaggregate/TestPreAggregateTableSelection.scala
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2197#discussion_r183200529
--- Diff: dev/findbugs-exclude.xml ---
@@ -40,7 +40,7 @@
-
+
--- End diff --
fixed
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2169
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5263/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2169
Build Success with Spark 2.2.1, Please check CI
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4082/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2148
Build Failed with Spark 2.2.1, Please check CI
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4080/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2148
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5261/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2200
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5262/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2200
Build Failed with Spark 2.2.1, Please check CI
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4081/
---
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2186
---
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2197#discussion_r183199499
--- Diff:
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2165
Build Success with Spark 2.2.1, Please check CI
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4079/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2169
Build Success with Spark 2.2.1, Please check CI
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4078/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2169
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5259/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2165
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5260/
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2169
@xuchuanyin What I have mentioned is that instead of adding the mapping in
datamap, handle while writing the datamap.
Currently the blocklet number is respective to each block while
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2169
retest this please
---
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2200#discussion_r183199149
--- Diff:
datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMapFactory.java
---
@@ -0,0 +1,192 @@
+/*
+ *
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2200#discussion_r183199053
--- Diff:
datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMap.java
---
@@ -0,0 +1,243 @@
+/*
+ * Licensed
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2200#discussion_r183199028
--- Diff:
datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMap.java
---
@@ -0,0 +1,243 @@
+/*
+ * Licensed
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2200#discussion_r183198993
--- Diff: datamap/bloom/pom.xml ---
@@ -0,0 +1,88 @@
+http://maven.apache.org/POM/4.0.0;
+
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2200#discussion_r183198962
--- Diff: datamap/bloom/pom.xml ---
@@ -0,0 +1,88 @@
+http://maven.apache.org/POM/4.0.0;
+
GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/2200
[CARBONDATA-2373][DataMap] Add bloom datamap to support precise equal query
For each indexed column, adding a bloom filter for each blocklet to
indicate whether it belongs to this
xuchuanyin created CARBONDATA-2373:
--
Summary: Add bloom filter datamap to support precise query
Key: CARBONDATA-2373
URL: https://issues.apache.org/jira/browse/CARBONDATA-2373
Project: CarbonData
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2190
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5257/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2190
Build Success with Spark 2.2.1, Please check CI
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4076/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2181
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5258/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2181
Build Success with Spark 2.2.1, Please check CI
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4077/
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2169
@ravipesala After I studied the code, I found that we must keep a map
between unique-blockletId to DMRow-pointer-index.
The relative blockletId in previous code was generated before
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2197#discussion_r183196989
--- Diff: dev/findbugs-exclude.xml ---
@@ -40,7 +40,7 @@
-
+
--- End diff --
not required match
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2165
retest this please
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2161
it need Committer review and merge this.
---
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2184#discussion_r183196683
--- Diff:
datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneDataMapWriter.java
---
@@ -222,12 +236,10 @@ public void
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2190
Build Success with Spark 2.2.1, Please check CI
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4074/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2190
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5255/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2180
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5256/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2180
Build Failed with Spark 2.2.1, Please check CI
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4075/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2148
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5254/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2197
Build Failed with Spark 2.2.1, Please check CI
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4072/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2197
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5251/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2148
Build Failed with Spark 2.2.1, Please check CI
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4073/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2195
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5252/
---
Github user Indhumathi27 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2180#discussion_r183140729
--- Diff:
datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneFineGrainDataMap.java
---
@@ -182,7 +182,7 @@ private String
Github user Indhumathi27 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2180#discussion_r183140665
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/datamap/lucene/LuceneFineGrainDataMapSuite.scala
---
@@ -197,13
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2179
Build Success with Spark 2.2.1, Please check CI
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4070/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2073
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5249/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1929
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5250/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2148
Build Failed with Spark 2.2.1, Please check CI
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4071/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2186
Build Success with Spark 2.2.1, Please check CI
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4069/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2190
Build Failed with Spark 2.2.1, Please check CI
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4068/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2172
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5247/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2148
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5248/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2179
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5246/
---
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2175
retest sdv please
---
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2175
LGTM
---
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2165#discussion_r183113401
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/S3UsingSDkExample.scala
---
@@ -0,0 +1,145 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/CARBONDATA-2330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated CARBONDATA-2330:
---
Description:
{code}
DataInputStream dataInputStream =
[
https://issues.apache.org/jira/browse/CARBONDATA-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated CARBONDATA-2336:
---
Description:
In bindToPort :
{code}
TransportServer transportServer = context
Ted Yu created CARBONDATA-2372:
--
Summary: Potential division by zero in
InputProcessorStepForPartitionImpl#partitionInputReaderIterators
Key: CARBONDATA-2372
URL:
[
https://issues.apache.org/jira/browse/CARBONDATA-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated CARBONDATA-2331:
---
Description:
{code}
synchronized (tableUniqueName.intern()) {
{code}
Please see the
[
https://issues.apache.org/jira/browse/CARBONDATA-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated CARBONDATA-2342:
---
Description:
Here is related code:
{code}
for (RecordReader reader :
[
https://issues.apache.org/jira/browse/CARBONDATA-2332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated CARBONDATA-2332:
---
Description:
Here is one example from getFloatPage :
{code}
for (int i = 0; i <
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2195
Build Failed with Spark 2.2.1, Please check CI
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4067/
---
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2186
LGTM
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2180
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5245/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2198
Build Success with Spark 2.2.1, Please check CI
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4065/
---
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2179
---
[
https://issues.apache.org/jira/browse/CARBONDATA-2361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacky Li resolved CARBONDATA-2361.
--
Resolution: Fixed
Fix Version/s: 1.4.0
> Refactor Read Committed Scope
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2181
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5244/
---
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2179
LGTM
---
[
https://issues.apache.org/jira/browse/CARBONDATA-2365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacky Li resolved CARBONDATA-2365.
--
Resolution: Fixed
Fix Version/s: 1.4.0
> Add QueryExecutor in SearchMode for
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2196
---
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2196
LGTM
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2197
Build Failed with Spark 2.2.1, Please check CI
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4066/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2179
Build Success with Spark 2.2.1, Please check CI
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4064/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2190
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5242/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2180
Build Success with Spark 2.2.1, Please check CI
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4063/
---
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2177#discussion_r183085758
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java
---
@@ -144,12 +144,12 @@
private boolean
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2177#discussion_r183085076
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java
---
@@ -144,12 +144,12 @@
private boolean
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2182#discussion_r183084661
--- Diff: docs/streaming-guide.md ---
@@ -26,64 +26,64 @@ Start spark-shell in new terminal, type :paste, then
copy and run the following
import
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2180#discussion_r183083696
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/datamap/lucene/LuceneFineGrainDataMapSuite.scala
---
@@ -197,13 +197,334
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2180#discussion_r183083335
--- Diff:
datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneFineGrainDataMap.java
---
@@ -182,7 +182,7 @@ private String
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2193
---
[
https://issues.apache.org/jira/browse/CARBONDATA-2364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacky Li resolved CARBONDATA-2364.
--
Resolution: Fixed
Fix Version/s: 1.4.0
> Remove useless and time consuming code
[
https://issues.apache.org/jira/browse/CARBONDATA-2312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacky Li resolved CARBONDATA-2312.
--
Resolution: Fixed
Fix Version/s: 1.4.0
> Support In Memory catalog
>
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2193
LGTM
---
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2103
LGTM
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2186
Build Success with Spark 2.2.1, Please check CI
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4062/
---
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2148#discussion_r183077945
--- Diff:
store/search/src/main/java/org/apache/carbondata/store/worker/SearchRequestHandler.java
---
@@ -0,0 +1,176 @@
+/*
+ * Licensed to
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2148#discussion_r183077175
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSession.scala ---
@@ -110,6 +149,69 @@ class CarbonSession(@transient val sc:
Jacky Li created CARBONDATA-2371:
Summary: Add Profiler output in EXPLAIN command
Key: CARBONDATA-2371
URL: https://issues.apache.org/jira/browse/CARBONDATA-2371
Project: CarbonData
Issue
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2195
Build Failed with Spark 2.2.1, Please check CI
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4061/
---
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2177#discussion_r183074326
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/util/CarbonLoaderUtil.java
---
@@ -169,8 +169,28 @@ public static boolean
Github user sounakr commented on the issue:
https://github.com/apache/carbondata/pull/2179
Retest this please.
---
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2148#discussion_r183071058
--- Diff:
store/search/src/main/java/org/apache/carbondata/store/worker/SearchRequestHandler.java
---
@@ -0,0 +1,176 @@
+/*
+ * Licensed
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2148#discussion_r183063006
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/executor/impl/SearchModeVectorDetailQueryExecutor.java
---
@@ -31,35 +31,53 @@
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2179#discussion_r183069890
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/Segment.java ---
@@ -36,9 +39,23 @@
private String segmentFileName;
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2179#discussion_r183069772
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/Segment.java ---
@@ -80,6 +115,22 @@ public static Segment toSegment(String segmentId)
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2179#discussion_r183069834
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/Segment.java ---
@@ -80,6 +115,22 @@ public static Segment toSegment(String segmentId)
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2195
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5241/
---
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2179#discussion_r183069718
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/Segment.java ---
@@ -36,9 +39,23 @@
private String segmentFileName;
1 - 100 of 204 matches
Mail list logo