[GitHub] carbondata pull request #2366: [CARBONDATA-2532][Integration] Carbon to supp...

2018-06-18 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2366#discussion_r195980220 --- Diff: integration/spark-common/src/main/java/org/apache/carbondata/streaming/CarbonStreamRecordReader.java --- @@ -71,15 +72,10 @@ import org

[GitHub] carbondata issue #2378: [CARBONDATA-2614] Fix the error when using FG in sea...

2018-06-18 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/2378 LGTM ---

[jira] [Resolved] (CARBONDATA-2614) There are some exception when using FG in search mode and the prune result is none

2018-06-18 Thread Jacky Li (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-2614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacky Li resolved CARBONDATA-2614. -- Resolution: Fixed Fix Version/s: 1.4.1 1.5.0 > There are some ex

[GitHub] carbondata pull request #2378: [CARBONDATA-2614] Fix the error when using FG...

2018-06-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/2378 ---

[GitHub] carbondata issue #2372: [CARBONDATA-2609] Change RPC implementation to Hadoo...

2018-06-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2372 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6359/ ---

[GitHub] carbondata issue #2372: [CARBONDATA-2609] Change RPC implementation to Hadoo...

2018-06-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2372 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5197/ ---

[GitHub] carbondata issue #2372: [CARBONDATA-2609] Change RPC implementation to Hadoo...

2018-06-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2372 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6360/ ---

[GitHub] carbondata issue #2350: [CARBONDATA-2553] support ZSTD compression for sort ...

2018-06-18 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/2350 LGTM ---

[GitHub] carbondata issue #2372: [CARBONDATA-2609] Change RPC implementation to Hadoo...

2018-06-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2372 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5198/ ---

[jira] [Resolved] (CARBONDATA-2553) support ZSTD compression for sort temp file

2018-06-18 Thread Jacky Li (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-2553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacky Li resolved CARBONDATA-2553. -- Resolution: Fixed Fix Version/s: 1.4.1 1.5.0 > support ZSTD comp

[GitHub] carbondata pull request #2350: [CARBONDATA-2553] support ZSTD compression fo...

2018-06-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/2350 ---

[GitHub] carbondata pull request #2328: [CARBONDATA-2504][STREAM] Support StreamSQL f...

2018-06-18 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2328#discussion_r196086445 --- Diff: integration/spark-common/src/main/java/org/apache/carbondata/spark/util/SparkDataTypeConverterImpl.java --- @@ -171,4 +176,21 @@ public Objec

[GitHub] carbondata pull request #2328: [CARBONDATA-2504][STREAM] Support StreamSQL f...

2018-06-18 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2328#discussion_r196087279 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/StreamingOption.scala --- @@ -0,0 +1,67 @@ +/* + * Licensed to th

[GitHub] carbondata pull request #2328: [CARBONDATA-2504][STREAM] Support StreamSQL f...

2018-06-18 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2328#discussion_r196087809 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/StreamingOption.scala --- @@ -0,0 +1,67 @@ +/* + * Licensed to th

[GitHub] carbondata pull request #2328: [CARBONDATA-2504][STREAM] Support StreamSQL f...

2018-06-18 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2328#discussion_r196089005 --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/stream/StreamJobManager.scala --- @@ -0,0 +1,185 @@ +/* + * Licensed to the A

[GitHub] carbondata pull request #2328: [CARBONDATA-2504][STREAM] Support StreamSQL f...

2018-06-18 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2328#discussion_r196089874 --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/stream/StreamJobManager.scala --- @@ -0,0 +1,185 @@ +/* + * Licensed to the A

[GitHub] carbondata issue #2372: [CARBONDATA-2609] Change RPC implementation to Hadoo...

2018-06-18 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2372 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5308/ ---

[GitHub] carbondata issue #2372: [CARBONDATA-2609] Change RPC implementation to Hadoo...

2018-06-18 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2372 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5309/ ---

[GitHub] carbondata pull request #2328: [CARBONDATA-2504][STREAM] Support StreamSQL f...

2018-06-18 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2328#discussion_r196132467 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/parser/CarbonSpark2SqlParser.scala --- @@ -145,6 +149,41 @@ class CarbonSpark2SqlParse

[GitHub] carbondata pull request #2328: [CARBONDATA-2504][STREAM] Support StreamSQL f...

2018-06-18 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2328#discussion_r196132442 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/parser/CarbonSpark2SqlParser.scala --- @@ -145,6 +149,41 @@ class CarbonSpark2SqlParse

[GitHub] carbondata pull request #2328: [CARBONDATA-2504][STREAM] Support StreamSQL f...

2018-06-18 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2328#discussion_r196137795 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/stream/CarbonCreateStreamCommand.scala --- @@ -0,0 +1,132 @@ +/*

[GitHub] carbondata pull request #1265: [CARBONDATA-1128] Add encoding for non-dictio...

2018-06-18 Thread jackylk
Github user jackylk closed the pull request at: https://github.com/apache/carbondata/pull/1265 ---

[GitHub] carbondata pull request #1640: [WIP] Annotate carbon property

2018-06-18 Thread jackylk
Github user jackylk closed the pull request at: https://github.com/apache/carbondata/pull/1640 ---

[GitHub] carbondata issue #2376: [CARBONDATA-2610] Fix for datamap creation failed on...

2018-06-18 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/2376 LGTM ---

[GitHub] carbondata issue #2372: [CARBONDATA-2609] Change RPC implementation to Hadoo...

2018-06-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2372 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6362/ ---

[GitHub] carbondata pull request #2376: [CARBONDATA-2610] Fix for datamap creation fa...

2018-06-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/2376 ---

[jira] [Resolved] (CARBONDATA-2610) DataMap creation fails on null values

2018-06-18 Thread Jacky Li (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-2610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacky Li resolved CARBONDATA-2610. -- Resolution: Fixed > DataMap creation fails on null values > -

[GitHub] carbondata issue #2287: [CARBONDATA-2418] [Presto] [S3] Fixed Presto Can't Q...

2018-06-18 Thread jackylk
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/2287 LGTM ---

[GitHub] carbondata pull request #2287: [CARBONDATA-2418] [Presto] [S3] Fixed Presto ...

2018-06-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/2287 ---

[GitHub] carbondata issue #2372: [CARBONDATA-2609] Change RPC implementation to Hadoo...

2018-06-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2372 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5200/ ---

[jira] [Resolved] (CARBONDATA-2418) Presto can't query Carbon table when carbonstore is created at s3

2018-06-18 Thread Jacky Li (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-2418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacky Li resolved CARBONDATA-2418. -- Resolution: Fixed Fix Version/s: 1.4.1 1.5.0 > Presto can't quer

[GitHub] carbondata issue #2372: [CARBONDATA-2609] Change RPC implementation to Hadoo...

2018-06-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2372 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6363/ ---

[GitHub] carbondata pull request #1668: [CARBONDATA-1787] Updated data-management-on-...

2018-06-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/1668 ---

[jira] [Resolved] (CARBONDATA-1787) Carbon 1.3.0- Global Sort: Global_Sort_Partitions parameter doesn't work, if specified in the Tblproperties, while creating the table.

2018-06-18 Thread Jacky Li (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacky Li resolved CARBONDATA-1787. -- Resolution: Fixed Fix Version/s: 1.4.1 1.5.0 > Carbon 1.3.0- Glo

[GitHub] carbondata issue #2372: [CARBONDATA-2609] Change RPC implementation to Hadoo...

2018-06-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2372 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5201/ ---

[GitHub] carbondata issue #2328: [CARBONDATA-2504][STREAM] Support StreamSQL for stre...

2018-06-18 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2328 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5310/ ---

[GitHub] carbondata issue #2328: [CARBONDATA-2504][STREAM] Support StreamSQL for stre...

2018-06-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2328 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6361/ ---

[GitHub] carbondata issue #2328: [CARBONDATA-2504][STREAM] Support StreamSQL for stre...

2018-06-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2328 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5199/ ---

[GitHub] carbondata issue #2372: [CARBONDATA-2609] Change RPC implementation to Hadoo...

2018-06-18 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2372 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5311/ ---

[GitHub] carbondata issue #2372: [CARBONDATA-2609] Change RPC implementation to Hadoo...

2018-06-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2372 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6364/ ---

[GitHub] carbondata issue #2372: [CARBONDATA-2609] Change RPC implementation to Hadoo...

2018-06-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2372 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5202/ ---

[GitHub] carbondata issue #2372: [CARBONDATA-2609] Change RPC implementation to Hadoo...

2018-06-18 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2372 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5312/ ---

[GitHub] carbondata issue #2372: [CARBONDATA-2609] Change RPC implementation to Hadoo...

2018-06-18 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2372 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5313/ ---

[GitHub] carbondata pull request #2252: [CARBONDATA-2420][32K] Support string longer ...

2018-06-18 Thread xuchuanyin
Github user xuchuanyin closed the pull request at: https://github.com/apache/carbondata/pull/2252 ---

[GitHub] carbondata pull request #2375: [CARBONDATA-2585][CARBONDATA-2586][Local Dict...

2018-06-18 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2375#discussion_r196304734 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -883,6 +883,37 @@ public static final Str

[GitHub] carbondata pull request #2375: [CARBONDATA-2585][CARBONDATA-2586][Local Dict...

2018-06-18 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2375#discussion_r196304856 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -883,6 +883,37 @@ public static final Str

[GitHub] carbondata pull request #2379: [CARBONDATA-2420][32K] Support string longer ...

2018-06-18 Thread xuchuanyin
GitHub user xuchuanyin opened a pull request: https://github.com/apache/carbondata/pull/2379 [CARBONDATA-2420][32K] Support string longer than 32000 characters Add a property in creating table 'long_string_columns' to support string columns that will contains more than 32000 charact

[GitHub] carbondata pull request #2375: [CARBONDATA-2585][CARBONDATA-2586][Local Dict...

2018-06-18 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2375#discussion_r196305311 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java --- @@ -150,6 +150,16 @@ private boolean

[GitHub] carbondata pull request #2375: [CARBONDATA-2585][CARBONDATA-2586][Local Dict...

2018-06-18 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2375#discussion_r196305365 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java --- @@ -150,6 +150,16 @@ private boolean

[GitHub] carbondata issue #2252: [CARBONDATA-2420][32K] Support string longer than 32...

2018-06-18 Thread xuchuanyin
Github user xuchuanyin commented on the issue: https://github.com/apache/carbondata/pull/2252 I deleted the origin branch unexpectedly,so I raised another PR #2379 ---

[GitHub] carbondata pull request #2375: [CARBONDATA-2585][CARBONDATA-2586][Local Dict...

2018-06-18 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2375#discussion_r196305431 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java --- @@ -1032,5 +1073,32 @@ public static void update

[GitHub] carbondata pull request #2375: [CARBONDATA-2585][CARBONDATA-2586][Local Dict...

2018-06-18 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2375#discussion_r196305534 --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java --- @@ -17,12 +17,31 @@ package org.apache.carbondata.core.ut

[GitHub] carbondata issue #2379: [CARBONDATA-2420][32K] Support string longer than 32...

2018-06-18 Thread xuchuanyin
Github user xuchuanyin commented on the issue: https://github.com/apache/carbondata/pull/2379 @kumarvishal09 Can you review and merge it? The previous discussion can be found in #2252 ---

[GitHub] carbondata pull request #2375: [CARBONDATA-2585][CARBONDATA-2586][Local Dict...

2018-06-18 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2375#discussion_r19630 --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java --- @@ -17,12 +17,31 @@ package org.apache.carbondata.core.ut

[GitHub] carbondata pull request #2375: [CARBONDATA-2585][CARBONDATA-2586][Local Dict...

2018-06-18 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2375#discussion_r196305827 --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala --- @@ -550,6 +550,11 @@ clas

[GitHub] carbondata pull request #2375: [CARBONDATA-2585][CARBONDATA-2586][Local Dict...

2018-06-18 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2375#discussion_r196307015 --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java --- @@ -3000,5 +3019,95 @@ public static String getBlockId(AbsoluteTabl

[GitHub] carbondata pull request #2375: [CARBONDATA-2585][CARBONDATA-2586][Local Dict...

2018-06-18 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2375#discussion_r196307346 --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java --- @@ -3000,5 +3019,95 @@ public static String getBlockId(AbsoluteTabl

[GitHub] carbondata pull request #2374: [CARBONDATA-2613] Support csv based carbon ta...

2018-06-18 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2374#discussion_r196307354 --- Diff: common/src/main/java/org/apache/carbondata/common/annotations/Since.java --- @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software

[GitHub] carbondata pull request #2366: [CARBONDATA-2532][Integration] Carbon to supp...

2018-06-18 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2366#discussion_r196307852 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/sql/commands/StoredAsCarbondataSuite.scala --- @@ -87,7 +87,7 @@ class Sto

[GitHub] carbondata pull request #2366: [CARBONDATA-2532][Integration] Carbon to supp...

2018-06-18 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2366#discussion_r196307942 --- Diff: integration/spark-common/pom.xml --- @@ -65,6 +65,11 @@ scalatest_${scala.binary.version} provided +

[GitHub] carbondata pull request #2375: [CARBONDATA-2585][CARBONDATA-2586][Local Dict...

2018-06-18 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2375#discussion_r196308657 --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala --- @@ -289,7 +290,79 @@ abstract class Car

[GitHub] carbondata pull request #2375: [CARBONDATA-2585][CARBONDATA-2586][Local Dict...

2018-06-18 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2375#discussion_r196308732 --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala --- @@ -289,7 +290,79 @@ abstract class Car

[GitHub] carbondata pull request #2375: [CARBONDATA-2585][CARBONDATA-2586][Local Dict...

2018-06-18 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2375#discussion_r196309547 --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala --- @@ -1044,13 +1177,13 @@ abstract class

[GitHub] carbondata pull request #2366: [CARBONDATA-2532][Integration] Carbon to supp...

2018-06-18 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2366#discussion_r196309518 --- Diff: integration/spark-common/src/main/java/org/apache/carbondata/streaming/CarbonStreamRecordReader.java --- @@ -115,7 +109,7 @@

[GitHub] carbondata pull request #2366: [CARBONDATA-2532][Integration] Carbon to supp...

2018-06-18 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2366#discussion_r196309854 --- Diff: integration/spark-common/src/main/java/org/apache/carbondata/streaming/CarbonStreamRecordReader.java --- @@ -115,7 +109,7 @@

[GitHub] carbondata pull request #2366: [CARBONDATA-2532][Integration] Carbon to supp...

2018-06-18 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2366#discussion_r196310131 --- Diff: integration/spark-common/src/main/java/org/apache/carbondata/streaming/CarbonStreamRecordReader.java --- @@ -418,36 +412,47 @@ private boolea

[GitHub] carbondata pull request #2366: [CARBONDATA-2532][Integration] Carbon to supp...

2018-06-18 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2366#discussion_r196310194 --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/execution/streaming/CarbonAppendableStreamSink.scala --- @@ -127,7 +127,7 @@ cla

[GitHub] carbondata pull request #2375: [CARBONDATA-2585][CARBONDATA-2586][Local Dict...

2018-06-18 Thread akashrn5
Github user akashrn5 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2375#discussion_r196310318 --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala --- @@ -1044,13 +1177,13 @@ abstract class Ca

[GitHub] carbondata pull request #2366: [CARBONDATA-2532][Integration] Carbon to supp...

2018-06-18 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2366#discussion_r196310344 --- Diff: integration/spark-common/src/main/scala/org/apache/spark/util/CarbonReflectionUtils.scala --- @@ -247,6 +252,32 @@ object CarbonReflectionUti

[GitHub] carbondata pull request #2366: [CARBONDATA-2532][Integration] Carbon to supp...

2018-06-18 Thread sujith71955
Github user sujith71955 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2366#discussion_r196310355 --- Diff: integration/spark-common/src/main/java/org/apache/carbondata/streaming/CarbonStreamRecordReader.java --- @@ -71,15 +72,10 @@ import

[GitHub] carbondata pull request #2366: [CARBONDATA-2532][Integration] Carbon to supp...

2018-06-18 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2366#discussion_r196310531 --- Diff: integration/spark-common/src/main/scala/org/apache/spark/util/CarbonReflectionUtils.scala --- @@ -247,6 +252,32 @@ object CarbonReflectionUti

[GitHub] carbondata pull request #2366: [CARBONDATA-2532][Integration] Carbon to supp...

2018-06-18 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2366#discussion_r196310806 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/DDLStrategy.scala --- @@ -38,9 +39,17 @@ import org.apache.carbonda

[GitHub] carbondata pull request #2366: [CARBONDATA-2532][Integration] Carbon to supp...

2018-06-18 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2366#discussion_r196310953 --- Diff: integration/spark2/src/main/spark2.1/org/apache/spark/sql/CarbonVectorProxy.java --- @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache