[GitHub] carbondata pull request #2820: [CARBONDATA-3013] Added support for pruning p...

2018-10-21 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2820#discussion_r226905099 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/ExcludeFilterExecuterImpl.java --- @@ -143,6 +144,40 @@ public

[GitHub] carbondata pull request #2820: [CARBONDATA-3013] Added support for pruning p...

2018-10-21 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2820#discussion_r226905048 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/ExcludeFilterExecuterImpl.java --- @@ -143,6 +144,40 @@ public

[GitHub] carbondata pull request #2820: [CARBONDATA-3013] Added support for pruning p...

2018-10-21 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2820#discussion_r226905066 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/ExcludeFilterExecuterImpl.java --- @@ -143,6 +144,40 @@ public

[GitHub] carbondata issue #2772: [CARBONDATA-2977] Write uncompress_size to ChunkComp...

2018-10-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2772 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1088/ ---

[GitHub] carbondata issue #1933: [CARBONDATA-2132] [Partition] Fixed Error while load...

2018-10-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1933 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1087/ ---

[GitHub] carbondata issue #1138: [CARBONDATA-1263]Single pass load does not take defa...

2018-10-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1138 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1090/ ---

[GitHub] carbondata issue #1138: [CARBONDATA-1263]Single pass load does not take defa...

2018-10-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1138 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9159/ ---

[GitHub] carbondata issue #1933: [CARBONDATA-2132] [Partition] Fixed Error while load...

2018-10-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1933 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/895/ ---

[GitHub] carbondata issue #2772: [CARBONDATA-2977] Write uncompress_size to ChunkComp...

2018-10-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2772 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/894/ ---

[GitHub] carbondata issue #1138: [CARBONDATA-1263]Single pass load does not take defa...

2018-10-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1138 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9158/ ---

[GitHub] carbondata issue #1933: [CARBONDATA-2132] [Partition] Fixed Error while load...

2018-10-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1933 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/893/ ---

[GitHub] carbondata issue #2772: [CARBONDATA-2977] Write uncompress_size to ChunkComp...

2018-10-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2772 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/891/ ---

[GitHub] carbondata issue #1138: [CARBONDATA-1263]Single pass load does not take defa...

2018-10-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1138 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1089/ ---

[GitHub] carbondata issue #1138: [CARBONDATA-1263]Single pass load does not take defa...

2018-10-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1138 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9155/ ---

[GitHub] carbondata issue #1138: [CARBONDATA-1263]Single pass load does not take defa...

2018-10-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1138 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/888/ ---

[GitHub] carbondata issue #1138: [CARBONDATA-1263]Single pass load does not take defa...

2018-10-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1138 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9153/ ---

[GitHub] carbondata pull request #2839: [CARBONDATA-3030] Remove no use parameter in ...

2018-10-21 Thread xubo245
GitHub user xubo245 opened a pull request: https://github.com/apache/carbondata/pull/2839 [CARBONDATA-3030] Remove no use parameter in test case [CARBONDATA-3030] Remove no use parameter in test case Remove no use parameter in test case 1. remove

[jira] [Created] (CARBONDATA-3030) Remove no use parameter in test case

2018-10-21 Thread xubo245 (JIRA)
xubo245 created CARBONDATA-3030: --- Summary: Remove no use parameter in test case Key: CARBONDATA-3030 URL: https://issues.apache.org/jira/browse/CARBONDATA-3030 Project: CarbonData Issue Type:

[GitHub] carbondata issue #2836: [CARBONDATA-3027] Increase unsafe working memory def...

2018-10-21 Thread xuchuanyin
Github user xuchuanyin commented on the issue: https://github.com/apache/carbondata/pull/2836 so we should not change this value without better knowledge about it. If you really want to change it, the corresponding documents are needed to be changed at the same time. If

[GitHub] carbondata issue #2836: [CARBONDATA-3027] Increase unsafe working memory def...

2018-10-21 Thread xuchuanyin
Github user xuchuanyin commented on the issue: https://github.com/apache/carbondata/pull/2836 so we should not change this default value without better knowledge about it. If you really want to change it, the corresponding documents are needed to be changed at the same time.

[GitHub] carbondata issue #2836: [CARBONDATA-3027] Increase unsafe working memory def...

2018-10-21 Thread xuchuanyin
Github user xuchuanyin commented on the issue: https://github.com/apache/carbondata/pull/2836 so we should not change this default value without better knowledge about it. If you really want to change it, the corresponding documents are needed to be changed at the same time.

[GitHub] carbondata issue #2836: [CARBONDATA-3027] Increase unsafe working memory def...

2018-10-21 Thread xuchuanyin
Github user xuchuanyin commented on the issue: https://github.com/apache/carbondata/pull/2836 so we should not change this value without better knowledge about it. If you really want to change it, the corresponding documents are needed to be changed too ---

[GitHub] carbondata issue #2836: [CARBONDATA-3027] Increase unsafe working memory def...

2018-10-21 Thread xuchuanyin
Github user xuchuanyin commented on the issue: https://github.com/apache/carbondata/pull/2836 so we should not change this value without better knowledge about it. If you really want to change it, the corresponding documents are needed to be changed too ---

[GitHub] carbondata issue #2836: [CARBONDATA-3027] Increase unsafe working memory def...

2018-10-21 Thread xuchuanyin
Github user xuchuanyin commented on the issue: https://github.com/apache/carbondata/pull/2836 so we should not change this value without better knowledge about it. If you really want to change it, the corresponding documents are needed to be changed too ---

[GitHub] carbondata issue #2819: [CARBONDATA-3012] Added support for full scan querie...

2018-10-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2819 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9152/ ---

[GitHub] carbondata issue #2819: [CARBONDATA-3012] Added support for full scan querie...

2018-10-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2819 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1085/ ---

[GitHub] carbondata issue #2819: [CARBONDATA-3012] Added support for full scan querie...

2018-10-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2819 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/887/ ---

[GitHub] carbondata pull request #2823: [CARBONDATA-3015] Support Lazy load in carbon...

2018-10-21 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2823#discussion_r226867984 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/adaptive/AdaptiveDeltaIntegralCodec.java --- @@ -272,5 +295,169 @@

[GitHub] carbondata pull request #2823: [CARBONDATA-3015] Support Lazy load in carbon...

2018-10-21 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2823#discussion_r226867910 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/adaptive/AdaptiveDeltaFloatingCodec.java --- @@ -225,6 +238,71 @@

[GitHub] carbondata pull request #2823: [CARBONDATA-3015] Support Lazy load in carbon...

2018-10-21 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2823#discussion_r226867851 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/safe/AbstractNonDictionaryVectorFiller.java --- @@ -0,0 +1,274

[GitHub] carbondata pull request #2823: [CARBONDATA-3015] Support Lazy load in carbon...

2018-10-21 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2823#discussion_r226867498 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/safe/AbstractNonDictionaryVectorFiller.java --- @@ -0,0 +1,274

[GitHub] carbondata pull request #2823: [CARBONDATA-3015] Support Lazy load in carbon...

2018-10-21 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2823#discussion_r226867364 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/safe/AbstractNonDictionaryVectorFiller.java --- @@ -0,0 +1,274

[GitHub] carbondata pull request #2823: [CARBONDATA-3015] Support Lazy load in carbon...

2018-10-21 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2823#discussion_r226867324 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/safe/AbstractNonDictionaryVectorFiller.java --- @@ -0,0 +1,274

[GitHub] carbondata pull request #2823: [CARBONDATA-3015] Support Lazy load in carbon...

2018-10-21 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2823#discussion_r226867290 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/safe/AbstractNonDictionaryVectorFiller.java --- @@ -0,0 +1,274

[GitHub] carbondata pull request #2823: [CARBONDATA-3015] Support Lazy load in carbon...

2018-10-21 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2823#discussion_r226867258 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/safe/SafeVariableLengthDimensionDataChunkStore.java --- @@ -91,6

[GitHub] carbondata issue #2820: [CARBONDATA-3013] Added support for pruning pages fo...

2018-10-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2820 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1084/ ---

[GitHub] carbondata issue #2820: [CARBONDATA-3013] Added support for pruning pages fo...

2018-10-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2820 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9151/ ---

[GitHub] carbondata issue #2820: [CARBONDATA-3013] Added support for pruning pages fo...

2018-10-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2820 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/886/ ---

[GitHub] carbondata pull request #2820: [CARBONDATA-3013] Added support for pruning p...

2018-10-21 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2820#discussion_r226866881 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelRangeGrtThanFiterExecuterImpl.java --- @@ -148,6 +148,61 @@

[GitHub] carbondata pull request #2820: [CARBONDATA-3013] Added support for pruning p...

2018-10-21 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2820#discussion_r226863906 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/scanner/impl/BlockletFilterScanner.java --- @@ -316,4 +320,167 @@ private

[GitHub] carbondata pull request #2820: [CARBONDATA-3013] Added support for pruning p...

2018-10-21 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2820#discussion_r226863877 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/IncludeFilterExecuterImpl.java --- @@ -179,6 +167,75 @@ public

[GitHub] carbondata pull request #2820: [CARBONDATA-3013] Added support for pruning p...

2018-10-21 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2820#discussion_r226863869 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/IncludeFilterExecuterImpl.java --- @@ -179,6 +167,75 @@ public

[GitHub] carbondata pull request #2820: [CARBONDATA-3013] Added support for pruning p...

2018-10-21 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2820#discussion_r226863873 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RangeValueFilterExecuterImpl.java --- @@ -146,6 +146,44 @@ public

[GitHub] carbondata issue #2819: [CARBONDATA-3012] Added support for full scan querie...

2018-10-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2819 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9150/ ---

[GitHub] carbondata issue #2819: [CARBONDATA-3012] Added support for full scan querie...

2018-10-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2819 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1083/ ---

[GitHub] carbondata pull request #2820: [CARBONDATA-3013] Added support for pruning p...

2018-10-21 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2820#discussion_r226863773 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/ExcludeFilterExecuterImpl.java --- @@ -143,6 +144,40 @@ public

[GitHub] carbondata issue #2819: [CARBONDATA-3012] Added support for full scan querie...

2018-10-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2819 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/885/ ---

[GitHub] carbondata pull request #2820: [CARBONDATA-3013] Added support for pruning p...

2018-10-21 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2820#discussion_r226863702 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/impl/MeasureRawColumnChunk.java --- @@ -94,7 +95,7 @@ public ColumnPage

[GitHub] carbondata pull request #2819: [CARBONDATA-3012] Added support for full scan...

2018-10-21 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2819#discussion_r226863664 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java --- @@ -633,6 +622,56 @@ public boolean getBoolean(int rowId)

[GitHub] carbondata pull request #2819: [CARBONDATA-3012] Added support for full scan...

2018-10-21 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2819#discussion_r226863659 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/reader/dimension/v3/CompressedDimensionChunkFileBasedReaderV3.java --- @@

[GitHub] carbondata pull request #2819: [CARBONDATA-3012] Added support for full scan...

2018-10-21 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2819#discussion_r226863656 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/reader/dimension/v3/CompressedDimensionChunkFileBasedReaderV3.java --- @@

[GitHub] carbondata pull request #2819: [CARBONDATA-3012] Added support for full scan...

2018-10-21 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2819#discussion_r226863654 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/safe/AbstractNonDictionaryVectorFiller.java --- @@ -0,0 +1,274

[GitHub] carbondata pull request #2819: [CARBONDATA-3012] Added support for full scan...

2018-10-21 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2819#discussion_r226863651 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/safe/SafeVariableLengthDimensionDataChunkStore.java --- @@ -91,6

[GitHub] carbondata pull request #2819: [CARBONDATA-3012] Added support for full scan...

2018-10-21 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2819#discussion_r226863640 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/impl/FixedLengthDimensionColumnPage.java --- @@ -46,10 +46,37 @@ public

[GitHub] carbondata pull request #2819: [CARBONDATA-3012] Added support for full scan...

2018-10-21 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2819#discussion_r226863624 --- Diff: integration/spark-datasource/src/main/scala/org/apache/carbondata/spark/vectorreader/VectorizedCarbonRecordReader.java --- @@ -290,12

[GitHub] carbondata pull request #2819: [CARBONDATA-3012] Added support for full scan...

2018-10-21 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2819#discussion_r226863633 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/compress/DirectCompressCodec.java --- @@ -178,6 +196,143 @@ public

[GitHub] carbondata pull request #2819: [CARBONDATA-3012] Added support for full scan...

2018-10-21 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2819#discussion_r226863645 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/ColumnPageDecoder.java --- @@ -29,6 +31,12 @@ */

[GitHub] carbondata pull request #2819: [CARBONDATA-3012] Added support for full scan...

2018-10-21 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2819#discussion_r226863637 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/compress/DirectCompressCodec.java --- @@ -178,6 +196,143 @@ public

[GitHub] carbondata pull request #2819: [CARBONDATA-3012] Added support for full scan...

2018-10-21 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2819#discussion_r226863628 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/compress/DirectCompressCodec.java --- @@ -95,10 +99,24 @@ public

[GitHub] carbondata pull request #2819: [CARBONDATA-3012] Added support for full scan...

2018-10-21 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2819#discussion_r226863615 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/LocalDictDimensionDataChunkStore.java --- @@ -49,6 +51,29 @@

[GitHub] carbondata pull request #2819: [CARBONDATA-3012] Added support for full scan...

2018-10-21 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2819#discussion_r226863618 --- Diff: integration/spark-datasource/src/main/scala/org/apache/carbondata/spark/vectorreader/ColumnarVectorWrapperDirect.java --- @@ -0,0 +1,223

[GitHub] carbondata pull request #2819: [CARBONDATA-3012] Added support for full scan...

2018-10-21 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2819#discussion_r226863599 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/safe/AbstractNonDictionaryVectorFiller.java --- @@ -0,0 +1,274

[GitHub] carbondata pull request #2819: [CARBONDATA-3012] Added support for full scan...

2018-10-21 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2819#discussion_r226863591 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/safe/AbstractNonDictionaryVectorFiller.java --- @@ -0,0 +1,274

[GitHub] carbondata pull request #2819: [CARBONDATA-3012] Added support for full scan...

2018-10-21 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2819#discussion_r226863569 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DirectPageWiseVectorFillResultCollector.java --- @@ -0,0 +1,181 @@

[GitHub] carbondata pull request #2819: [CARBONDATA-3012] Added support for full scan...

2018-10-21 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2819#discussion_r226863577 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/LazyColumnPage.java --- @@ -91,6 +108,8 @@ public double getDouble(int

[GitHub] carbondata pull request #2819: [CARBONDATA-3012] Added support for full scan...

2018-10-21 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2819#discussion_r226863584 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/safe/SafeFixedLengthDimensionDataChunkStore.java --- @@ -30,9

[GitHub] carbondata pull request #2819: [CARBONDATA-3012] Added support for full scan...

2018-10-21 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2819#discussion_r226863559 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DirectPageWiseVectorFillResultCollector.java --- @@ -0,0 +1,181 @@

[GitHub] carbondata pull request #2819: [CARBONDATA-3012] Added support for full scan...

2018-10-21 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2819#discussion_r226863575 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/adaptive/AdaptiveDeltaIntegralCodec.java --- @@ -272,5 +293,164 @@

[GitHub] carbondata pull request #2819: [CARBONDATA-3012] Added support for full scan...

2018-10-21 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2819#discussion_r226863585 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/safe/SafeFixedLengthDimensionDataChunkStore.java --- @@ -30,9

[GitHub] carbondata pull request #2819: [CARBONDATA-3012] Added support for full scan...

2018-10-21 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2819#discussion_r226863580 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/LazyColumnPage.java --- @@ -42,10 +43,26 @@ private

[GitHub] carbondata issue #2838: [HOTFIX] Upgrade pom version to 1.6-SNAPSHOT

2018-10-21 Thread zzcclp
Github user zzcclp commented on the issue: https://github.com/apache/carbondata/pull/2838 @xuchuanyin 1.5.1 version is on branch 1.5 ---

[GitHub] carbondata issue #2838: [HOTFIX] Upgrade pom version to 1.6-SNAPSHOT

2018-10-21 Thread xuchuanyin
Github user xuchuanyin commented on the issue: https://github.com/apache/carbondata/pull/2838 @chenliang613 no 1.5.1 version? ---