[GitHub] carbondata pull request #2792: [CARBONDATA-2981] Support read primitive data...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2792#discussion_r228054034 --- Diff: store/CSDK/CarbonReader.cpp --- @@ -38,9 +37,9 @@ jobject CarbonReader::builder(JNIEnv *env, char *path) { jclass carbonReaderCla

[GitHub] carbondata issue #2830: [CARBONDATA-3025]Added CLI enhancements

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2830 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1005/ ---

[GitHub] carbondata pull request #2715: [CARBONDATA-2930] Support customize column co...

2018-10-25 Thread xuchuanyin
Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2715#discussion_r228054678 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/dataload/TestLoadDataWithCompression.scala ---

[GitHub] carbondata issue #2829: [CARBONDATA-3025]add more metadata in carbon file fo...

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2829 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1215/ ---

[GitHub] carbondata pull request #2792: [CARBONDATA-2981] Support read primitive data...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2792#discussion_r228055937 --- Diff: store/CSDK/CarbonRow.cpp --- @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] carbondata pull request #2792: [CARBONDATA-2981] Support read primitive data...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2792#discussion_r228056749 --- Diff: docs/csdk-guide.md --- @@ -30,106 +30,13 @@ code and without CarbonSession. In the carbon jars package, there exist a carbondata-sdk.

[GitHub] carbondata pull request #2826: [CARBONDATA-3023] Alter add column issue with...

2018-10-25 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2826#discussion_r228056940 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RangeValueFilterExecuterImpl.java --- @@ -511,7 +511,7 @@ private BitSet s

[GitHub] carbondata pull request #2792: [CARBONDATA-2981] Support read primitive data...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2792#discussion_r228055673 --- Diff: store/CSDK/main.cpp --- @@ -21,6 +21,7 @@ #include --- End diff -- we just have to create a folder and move this file t

[GitHub] carbondata pull request #2792: [CARBONDATA-2981] Support read primitive data...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2792#discussion_r228056225 --- Diff: store/CSDK/CarbonRow.cpp --- @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] carbondata pull request #2792: [CARBONDATA-2981] Support read primitive data...

2018-10-25 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2792#discussion_r228061918 --- Diff: store/CSDK/CarbonRow.cpp --- @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contr

[GitHub] carbondata pull request #2792: [CARBONDATA-2981] Support read primitive data...

2018-10-25 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2792#discussion_r228062513 --- Diff: store/CSDK/CarbonRow.cpp --- @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contr

[GitHub] carbondata issue #2830: [CARBONDATA-3025]Added CLI enhancements

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2830 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1218/ ---

[GitHub] carbondata pull request #2792: [CARBONDATA-2981] Support read primitive data...

2018-10-25 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2792#discussion_r228067726 --- Diff: store/CSDK/CarbonReader.cpp --- @@ -19,15 +19,14 @@ #include jobject CarbonReader::builder(JNIEnv *env, char *path, char *tabl

[GitHub] carbondata pull request #2792: [CARBONDATA-2981] Support read primitive data...

2018-10-25 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2792#discussion_r228067882 --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java --- @@ -1522,4 +1522,208 @@ public boolean accept(File dir, Strin

[GitHub] carbondata issue #2792: [CARBONDATA-2981] Support read primitive data type i...

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2792 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1221/ ---

[GitHub] carbondata issue #2819: [CARBONDATA-3012] Added support for full scan querie...

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2819 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1220/ ---

[jira] [Created] (CARBONDATA-3043) Add test framework for CSDK

2018-10-25 Thread xubo245 (JIRA)
xubo245 created CARBONDATA-3043: --- Summary: Add test framework for CSDK Key: CARBONDATA-3043 URL: https://issues.apache.org/jira/browse/CARBONDATA-3043 Project: CarbonData Issue Type: Sub-task

[GitHub] carbondata issue #2830: [CARBONDATA-3025]Added CLI enhancements

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2830 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9271/ ---

[jira] [Created] (CARBONDATA-3044) Handle exception in CSDK

2018-10-25 Thread xubo245 (JIRA)
xubo245 created CARBONDATA-3044: --- Summary: Handle exception in CSDK Key: CARBONDATA-3044 URL: https://issues.apache.org/jira/browse/CARBONDATA-3044 Project: CarbonData Issue Type: Sub-task

[GitHub] carbondata pull request #2792: [CARBONDATA-2981] Support read primitive data...

2018-10-25 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2792#discussion_r228072138 --- Diff: store/CSDK/main.cpp --- @@ -21,6 +21,7 @@ #include --- End diff -- OK,done ---

[GitHub] carbondata issue #2772: [CARBONDATA-2977] Write uncompress_size to ChunkComp...

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2772 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9274/ ---

[GitHub] carbondata issue #2792: [CARBONDATA-2981] Support read primitive data type i...

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2792 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9273/ ---

[GitHub] carbondata pull request #2792: [CARBONDATA-2981] Support read primitive data...

2018-10-25 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2792#discussion_r228073382 --- Diff: docs/csdk-guide.md --- @@ -30,106 +30,13 @@ code and without CarbonSession. In the carbon jars package, there exist a carbondata-sdk.jar,

[GitHub] carbondata issue #2819: [CARBONDATA-3012] Added support for full scan querie...

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2819 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1007/ ---

[GitHub] carbondata pull request #2792: [CARBONDATA-2981] Support read primitive data...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2792#discussion_r228074939 --- Diff: store/CSDK/CarbonReader.cpp --- @@ -19,15 +19,14 @@ #include jobject CarbonReader::builder(JNIEnv *env, char *path, char

[GitHub] carbondata issue #2772: [CARBONDATA-2977] Write uncompress_size to ChunkComp...

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2772 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1009/ ---

[GitHub] carbondata issue #2819: [CARBONDATA-3012] Added support for full scan querie...

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2819 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9272/ ---

[GitHub] carbondata issue #2792: [CARBONDATA-2981] Support read primitive data type i...

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2792 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1008/ ---

[GitHub] carbondata issue #2792: [CARBONDATA-2981] Support read primitive data type i...

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2792 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1011/ ---

[GitHub] carbondata issue #2852: [WIP]Column Schema objects are present in Driver eve...

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2852 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1010/ ---

[GitHub] carbondata issue #2772: [CARBONDATA-2977] Write uncompress_size to ChunkComp...

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2772 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1222/ ---

[GitHub] carbondata issue #2772: [CARBONDATA-2977] Write uncompress_size to ChunkComp...

2018-10-25 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2772 LGTM ---

[GitHub] carbondata pull request #2772: [CARBONDATA-2977] Write uncompress_size to Ch...

2018-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/2772 ---

[GitHub] carbondata pull request #2820: [CARBONDATA-3013] Added support for pruning p...

2018-10-25 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2820#discussion_r228091134 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/impl/DimensionRawColumnChunk.java --- @@ -121,6 +122,22 @@ public DimensionC

[jira] [Resolved] (CARBONDATA-2977) Write uncompress_size to ChunkCompressMeta in the file

2018-10-25 Thread Manish Gupta (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-2977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manish Gupta resolved CARBONDATA-2977. -- Resolution: Fixed Assignee: Jacky Li Fix Version/s: 1.5.1 > Write

[GitHub] carbondata pull request #2820: [CARBONDATA-3013] Added support for pruning p...

2018-10-25 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2820#discussion_r228092934 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/ExcludeFilterExecuterImpl.java --- @@ -143,6 +144,40 @@ public BitSetGr

[GitHub] carbondata pull request #2823: [CARBONDATA-3015] Support Lazy load in carbon...

2018-10-25 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2823#discussion_r228096779 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/safe/AbstractNonDictionaryVectorFiller.java --- @@ -48,7 +48,11 @

[GitHub] carbondata pull request #2823: [CARBONDATA-3015] Support Lazy load in carbon...

2018-10-25 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2823#discussion_r228099219 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/result/BlockletScannedResult.java --- @@ -145,6 +147,8 @@ protected QueryS

[GitHub] carbondata pull request #2823: [CARBONDATA-3015] Support Lazy load in carbon...

2018-10-25 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2823#discussion_r228099605 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/result/vector/impl/directread/AbstractCarbonColumnarVector.java --- @@ -130,4 +131,9 @@

[GitHub] carbondata pull request #2823: [CARBONDATA-3015] Support Lazy load in carbon...

2018-10-25 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2823#discussion_r228100832 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/scanner/LazyBlockletLoad.java --- @@ -0,0 +1,158 @@ +/* + * Licensed to the Apa

[GitHub] carbondata issue #2792: [CARBONDATA-2981] Support read primitive data type i...

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2792 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9276/ ---

[GitHub] carbondata issue #2852: [WIP]Column Schema objects are present in Driver eve...

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2852 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9275/ ---

[GitHub] carbondata issue #2792: [CARBONDATA-2981] Support read primitive data type i...

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2792 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1224/ ---

[GitHub] carbondata issue #2852: [WIP]Column Schema objects are present in Driver eve...

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2852 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1223/ ---

[GitHub] carbondata pull request #2823: [CARBONDATA-3015] Support Lazy load in carbon...

2018-10-25 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2823#discussion_r228106032 --- Diff: integration/spark-datasource/src/main/spark2.1andspark2.2/org/apache/spark/sql/CarbonVectorProxy.java --- @@ -150,127 +140,189 @@ public v

[GitHub] carbondata issue #2822: [CARBONDATA-3014] Added support for inverted index a...

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2822 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1226/ ---

[GitHub] carbondata issue #2822: [CARBONDATA-3014] Added support for inverted index a...

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2822 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1013/ ---

[GitHub] carbondata issue #2820: [CARBONDATA-3013] Added support for pruning pages fo...

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2820 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1227/ ---

[GitHub] carbondata issue #2820: [CARBONDATA-3013] Added support for pruning pages fo...

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2820 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1014/ ---

[GitHub] carbondata issue #2823: [CARBONDATA-3015] Support Lazy load in carbon vector

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2823 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1228/ ---

[GitHub] carbondata issue #2822: [CARBONDATA-3014] Added support for inverted index a...

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2822 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9278/ ---

[GitHub] carbondata issue #2820: [CARBONDATA-3013] Added support for pruning pages fo...

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2820 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9279/ ---

[GitHub] carbondata issue #2823: [CARBONDATA-3015] Support Lazy load in carbon vector

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2823 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1015/ ---

[GitHub] carbondata issue #2845: [CARBONDATA-3039] Fix Custom Deterministic Expressio...

2018-10-25 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2845 @Indhumathi27 Please add testcase if possible ---

[GitHub] carbondata issue #2823: [CARBONDATA-3015] Support Lazy load in carbon vector

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2823 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9280/ ---

[GitHub] carbondata issue #2830: [CARBONDATA-3025]Added CLI enhancements

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2830 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1012/ ---

[GitHub] carbondata pull request #2853: [CARBONDATA_3025]make cli compilable with jav...

2018-10-25 Thread akashrn5
GitHub user akashrn5 opened a pull request: https://github.com/apache/carbondata/pull/2853 [CARBONDATA_3025]make cli compilable with java 1.7 This PR helps to compile the cli module to be compile with java 1.7 Be sure to do all of the following checklist to help us incorpora

[GitHub] carbondata pull request #2830: [CARBONDATA-3025]Added CLI enhancements

2018-10-25 Thread akashrn5
Github user akashrn5 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2830#discussion_r228123616 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/parser/CarbonSpark2SqlParser.scala --- @@ -493,6 +493,23 @@ class CarbonSpark2SqlPars

[GitHub] carbondata pull request #2830: [CARBONDATA-3025]Added CLI enhancements

2018-10-25 Thread akashrn5
Github user akashrn5 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2830#discussion_r228123741 --- Diff: tools/cli/src/main/java/org/apache/carbondata/tool/CarbonCli.java --- @@ -40,6 +41,10 @@ @InterfaceStability.Unstable public class

[GitHub] carbondata pull request #2829: [CARBONDATA-3025]add more metadata in carbon ...

2018-10-25 Thread akashrn5
Github user akashrn5 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2829#discussion_r228123905 --- Diff: format/src/main/thrift/carbondata.thrift --- @@ -206,6 +206,8 @@ struct FileFooter3{ 4: optional list blocklet_info_list3; // Infor

[GitHub] carbondata pull request #2830: [CARBONDATA-3025]Added CLI enhancements

2018-10-25 Thread akashrn5
Github user akashrn5 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2830#discussion_r228123653 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonShowSummaryCommand.scala --- @@ -0,0 +1,57 @@

[GitHub] carbondata pull request #2830: [CARBONDATA-3025]Added CLI enhancements

2018-10-25 Thread akashrn5
Github user akashrn5 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2830#discussion_r228123785 --- Diff: tools/cli/src/main/java/org/apache/carbondata/tool/DataSummary.java --- @@ -226,25 +282,46 @@ private int getColumnIndex(String columnName) {

[GitHub] carbondata pull request #2829: [CARBONDATA-3025]add more metadata in carbon ...

2018-10-25 Thread akashrn5
Github user akashrn5 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2829#discussion_r228123974 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestCarbonFileInputFormatWithExternalCarbonTable.s

[GitHub] carbondata pull request #2829: [CARBONDATA-3025]add more metadata in carbon ...

2018-10-25 Thread akashrn5
Github user akashrn5 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2829#discussion_r228124063 --- Diff: integration/spark-datasource/src/test/scala/org/apache/spark/sql/carbondata/datasource/SparkCarbonDataSourceTest.scala --- @@ -984,7 +984,7

[GitHub] carbondata pull request #2829: [CARBONDATA-3025]add more metadata in carbon ...

2018-10-25 Thread akashrn5
Github user akashrn5 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2829#discussion_r228124017 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestNonTransactionalCarbonTable.scala --- @@

[GitHub] carbondata pull request #2829: [CARBONDATA-3025]add more metadata in carbon ...

2018-10-25 Thread akashrn5
Github user akashrn5 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2829#discussion_r228124241 --- Diff: format/src/main/thrift/carbondata.thrift --- @@ -206,6 +206,7 @@ struct FileFooter3{ 4: optional list blocklet_info_list3; // Infor

[GitHub] carbondata pull request #2829: [CARBONDATA-3025]add more metadata in carbon ...

2018-10-25 Thread akashrn5
Github user akashrn5 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2829#discussion_r228124157 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/CarbonDataLoadConfiguration.java --- @@ -460,4 +464,20 @@ public String ge

[GitHub] carbondata pull request #2829: [CARBONDATA-3025]add more metadata in carbon ...

2018-10-25 Thread akashrn5
Github user akashrn5 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2829#discussion_r228124274 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java --- @@ -371,8 +381,14 @@ public CarbonWriter build() throws

[GitHub] carbondata issue #2829: [CARBONDATA-3025]add more metadata in carbon file fo...

2018-10-25 Thread akashrn5
Github user akashrn5 commented on the issue: https://github.com/apache/carbondata/pull/2829 > @akashrn5 Instead of changing many classes to pass writtenBy and appName can't we set to CarbonProperties and in writer step we can get from the same and write to thrift?? handled

[GitHub] carbondata pull request #2792: [CARBONDATA-2981] Support read primitive data...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2792#discussion_r228124647 --- Diff: store/CSDK/src/CarbonReader.cpp --- @@ -19,15 +19,14 @@ #include jobject CarbonReader::builder(JNIEnv *env, char *path, c

[GitHub] carbondata pull request #2792: [CARBONDATA-2981] Support read primitive data...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2792#discussion_r228126086 --- Diff: store/CSDK/src/CarbonReader.h --- @@ -35,6 +40,13 @@ class CarbonReader { */ jobject carbonReaderObject; +pub

[GitHub] carbondata issue #2830: [CARBONDATA-3025]Added CLI enhancements

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2830 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1225/ ---

[GitHub] carbondata issue #2829: [CARBONDATA-3025]add more metadata in carbon file fo...

2018-10-25 Thread kunal642
Github user kunal642 commented on the issue: https://github.com/apache/carbondata/pull/2829 LGTM ---

[GitHub] carbondata issue #2853: [CARBONDATA_3025]make cli compilable with java 1.7

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2853 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1016/ ---

[GitHub] carbondata pull request #2792: [CARBONDATA-2981] Support read primitive data...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2792#discussion_r228128521 --- Diff: store/CSDK/src/CarbonReader.cpp --- @@ -79,21 +78,19 @@ jobject CarbonReader::build() { jmethodID buildID = jniEnv->GetMethodID(c

[GitHub] carbondata pull request #2829: [CARBONDATA-3025]add more metadata in carbon ...

2018-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/2829 ---

[GitHub] carbondata pull request #2792: [CARBONDATA-2981] Support read primitive data...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2792#discussion_r228130454 --- Diff: store/CSDK/src/CarbonReader.cpp --- @@ -79,21 +78,19 @@ jobject CarbonReader::build() { jmethodID buildID = jniEnv->GetMethodID(c

[GitHub] carbondata issue #2826: [CARBONDATA-3023] Alter add column issue with SORT_C...

2018-10-25 Thread dhatchayani
Github user dhatchayani commented on the issue: https://github.com/apache/carbondata/pull/2826 retest this please ---

[GitHub] carbondata issue #2830: [CARBONDATA-3025]Added CLI enhancements

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2830 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9277/ ---

[GitHub] carbondata issue #2853: [CARBONDATA_3025]make cli compilable with java 1.7

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2853 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9281/ ---

[GitHub] carbondata issue #2830: [CARBONDATA-3025]Added CLI enhancements

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2830 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1018/ ---

[GitHub] carbondata issue #2848: [CARBONDATA-3036] Cache Columns And Refresh Table Is...

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2848 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1017/ ---

[GitHub] carbondata issue #2818: [CARBONDATA-3011] Add carbon property to configure v...

2018-10-25 Thread kumarvishal09
Github user kumarvishal09 commented on the issue: https://github.com/apache/carbondata/pull/2818 LGTM ---

[GitHub] carbondata pull request #2818: [CARBONDATA-3011] Add carbon property to conf...

2018-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/2818 ---

[GitHub] carbondata issue #2826: [CARBONDATA-3023] Alter add column issue with SORT_C...

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2826 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1019/ ---

[jira] [Assigned] (CARBONDATA-3011) Add carbon property to configure vector based row pruning push down

2018-10-25 Thread kumar vishal (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-3011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kumar vishal reassigned CARBONDATA-3011: Assignee: Ravindra Pesala > Add carbon property to configure vector based row

[jira] [Resolved] (CARBONDATA-3011) Add carbon property to configure vector based row pruning push down

2018-10-25 Thread kumar vishal (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-3011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kumar vishal resolved CARBONDATA-3011. -- Resolution: Fixed > Add carbon property to configure vector based row pruning push

[GitHub] carbondata issue #2818: [CARBONDATA-3011] Add carbon property to configure v...

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2818 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1020/ ---

[GitHub] carbondata issue #2818: [CARBONDATA-3011] Add carbon property to configure v...

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2818 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9285/ ---

[GitHub] carbondata issue #2819: [CARBONDATA-3012] Added support for full scan querie...

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2819 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1021/ ---

[GitHub] carbondata issue #2819: [CARBONDATA-3012] Added support for full scan querie...

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2819 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9286/ ---

[GitHub] carbondata pull request #2816: [CARBONDATA-3003] Suppor read batch row in CS...

2018-10-25 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2816#discussion_r228156985 --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java --- @@ -1616,7 +1616,6 @@ public boolean accept(File dir, St

[GitHub] carbondata issue #2853: [CARBONDATA_3025]make cli compilable with java 1.7

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2853 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1229/ ---

[GitHub] carbondata issue #2826: [CARBONDATA-3023] Alter add column issue with SORT_C...

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2826 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1232/ ---

[GitHub] carbondata issue #2848: [CARBONDATA-3036] Cache Columns And Refresh Table Is...

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2848 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1230/ ---

[GitHub] carbondata issue #2826: [CARBONDATA-3023] Alter add column issue with SORT_C...

2018-10-25 Thread dhatchayani
Github user dhatchayani commented on the issue: https://github.com/apache/carbondata/pull/2826 retest this please ---

[GitHub] carbondata issue #2830: [CARBONDATA-3025]Added CLI enhancements

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2830 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1231/ ---

[GitHub] carbondata issue #2848: [CARBONDATA-3036] Cache Columns And Refresh Table Is...

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2848 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9282/ ---

[GitHub] carbondata issue #2830: [CARBONDATA-3025]Added CLI enhancements

2018-10-25 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2830 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9283/ ---

[GitHub] carbondata issue #2848: [CARBONDATA-3036] Cache Columns And Refresh Table Is...

2018-10-25 Thread kunal642
Github user kunal642 commented on the issue: https://github.com/apache/carbondata/pull/2848 LGTM ---

  1   2   >