[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3664: [CARBONDATA-3740] Add line separator option to load command to configure the line separator during csv parsing.

2020-03-30 Thread GitBox
ajantha-bhat commented on a change in pull request #3664: [CARBONDATA-3740] Add line separator option to load command to configure the line separator during csv parsing. URL: https://github.com/apache/carbondata/pull/3664#discussion_r400683302 ## File path: integration/spark/src/t

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3664: [CARBONDATA-3740] Add line separator option to load command to configure the line separator during csv parsing.

2020-03-30 Thread GitBox
ajantha-bhat commented on a change in pull request #3664: [CARBONDATA-3740] Add line separator option to load command to configure the line separator during csv parsing. URL: https://github.com/apache/carbondata/pull/3664#discussion_r400683066 ## File path: integration/spark/src/t

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3664: [CARBONDATA-3740] Add line separator option to load command to configure the line separator during csv parsing.

2020-03-30 Thread GitBox
ajantha-bhat commented on a change in pull request #3664: [CARBONDATA-3740] Add line separator option to load command to configure the line separator during csv parsing. URL: https://github.com/apache/carbondata/pull/3664#discussion_r400682260 ## File path: integration/spark/src/t

[GitHub] [carbondata] kevinjmh closed pull request #2713: [WIP][CARBONDATA-2931][BloomDataMap] Optimize bloom datamap pruning

2020-03-30 Thread GitBox
kevinjmh closed pull request #2713: [WIP][CARBONDATA-2931][BloomDataMap] Optimize bloom datamap pruning URL: https://github.com/apache/carbondata/pull/2713 This is an automated message from the Apache Git Service. To respond

[GitHub] [carbondata] niuge01 commented on a change in pull request #3661: [CARBONDATA-3704] Support create materialized view on all type table, and make mv support mutil-tenant.

2020-03-30 Thread GitBox
niuge01 commented on a change in pull request #3661: [CARBONDATA-3704] Support create materialized view on all type table, and make mv support mutil-tenant. URL: https://github.com/apache/carbondata/pull/3661#discussion_r400681805 ## File path: core/src/main/java/org/apache/carbond

[GitHub] [carbondata] niuge01 commented on a change in pull request #3661: [CARBONDATA-3704] Support create materialized view on all type table, and make mv support mutil-tenant.

2020-03-30 Thread GitBox
niuge01 commented on a change in pull request #3661: [CARBONDATA-3704] Support create materialized view on all type table, and make mv support mutil-tenant. URL: https://github.com/apache/carbondata/pull/3661#discussion_r400681680 ## File path: integration/spark/src/test/scala/org/

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3664: [CARBONDATA-3740] Add line separator option to load command to configure the line separator during csv parsing.

2020-03-30 Thread GitBox
ajantha-bhat commented on a change in pull request #3664: [CARBONDATA-3740] Add line separator option to load command to configure the line separator during csv parsing. URL: https://github.com/apache/carbondata/pull/3664#discussion_r400681109 ## File path: integration/spark/src/t

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3664: [CARBONDATA-3740] Add line separator option to load command to configure the line separator during csv parsing.

2020-03-30 Thread GitBox
ajantha-bhat commented on a change in pull request #3664: [CARBONDATA-3740] Add line separator option to load command to configure the line separator during csv parsing. URL: https://github.com/apache/carbondata/pull/3664#discussion_r400679823 ## File path: integration/spark/src/m

[GitHub] [carbondata] niuge01 commented on a change in pull request #3661: [CARBONDATA-3704] Support create materialized view on all type table, and make mv support mutil-tenant.

2020-03-30 Thread GitBox
niuge01 commented on a change in pull request #3661: [CARBONDATA-3704] Support create materialized view on all type table, and make mv support mutil-tenant. URL: https://github.com/apache/carbondata/pull/3661#discussion_r400679356 ## File path: docs/index-developer-guide.md ###

[GitHub] [carbondata] niuge01 commented on a change in pull request #3661: [CARBONDATA-3704] Support create materialized view on all type table, and make mv support mutil-tenant.

2020-03-30 Thread GitBox
niuge01 commented on a change in pull request #3661: [CARBONDATA-3704] Support create materialized view on all type table, and make mv support mutil-tenant. URL: https://github.com/apache/carbondata/pull/3661#discussion_r400679356 ## File path: docs/index-developer-guide.md ###

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3664: [CARBONDATA-3740] Add line separator option to load command to configure the line separator during csv parsing.

2020-03-30 Thread GitBox
ajantha-bhat commented on a change in pull request #3664: [CARBONDATA-3740] Add line separator option to load command to configure the line separator during csv parsing. URL: https://github.com/apache/carbondata/pull/3664#discussion_r400679006 ## File path: integration/presto/src/

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3664: [CARBONDATA-3740] Add line separator option to load command to configure the line separator during csv parsing.

2020-03-30 Thread GitBox
ajantha-bhat commented on a change in pull request #3664: [CARBONDATA-3740] Add line separator option to load command to configure the line separator during csv parsing. URL: https://github.com/apache/carbondata/pull/3664#discussion_r400678851 ## File path: hadoop/src/main/java/or

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3661: [CARBONDATA-3704] Support create materialized view on all type table, and make mv support mutil-tenant.

2020-03-30 Thread GitBox
CarbonDataQA1 commented on issue #3661: [CARBONDATA-3704] Support create materialized view on all type table, and make mv support mutil-tenant. URL: https://github.com/apache/carbondata/pull/3661#issuecomment-606428588 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3661: [CARBONDATA-3704] Support create materialized view on all type table, and make mv support mutil-tenant.

2020-03-30 Thread GitBox
CarbonDataQA1 commented on issue #3661: [CARBONDATA-3704] Support create materialized view on all type table, and make mv support mutil-tenant. URL: https://github.com/apache/carbondata/pull/3661#issuecomment-606426926 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12

[GitHub] [carbondata] jack86596 commented on issue #3664: [CARBONDATA-3740] Add line separator option to load command to configure the line separator during csv parsing.

2020-03-30 Thread GitBox
jack86596 commented on issue #3664: [CARBONDATA-3740] Add line separator option to load command to configure the line separator during csv parsing. URL: https://github.com/apache/carbondata/pull/3664#issuecomment-606423084 @akashrn5 '\r' is carriage_return, it commands a printer, or other o

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3661: [CARBONDATA-3704] Support create materialized view on all type table, and make mv support mutil-tenant.

2020-03-30 Thread GitBox
Indhumathi27 commented on a change in pull request #3661: [CARBONDATA-3704] Support create materialized view on all type table, and make mv support mutil-tenant. URL: https://github.com/apache/carbondata/pull/3661#discussion_r400663521 ## File path: core/src/main/java/org/apache/c

[GitHub] [carbondata] akashrn5 commented on issue #3664: [CARBONDATA-3740] Add line separator option to load command to configure the line separator during csv parsing.

2020-03-30 Thread GitBox
akashrn5 commented on issue #3664: [CARBONDATA-3740] Add line separator option to load command to configure the line separator during csv parsing. URL: https://github.com/apache/carbondata/pull/3664#issuecomment-606419073 when i did select * on the table, i cannot see 1 and 2 values, looks

[GitHub] [carbondata] niuge01 commented on a change in pull request #3661: [WIP] Support materialized view

2020-03-30 Thread GitBox
niuge01 commented on a change in pull request #3661: [WIP] Support materialized view URL: https://github.com/apache/carbondata/pull/3661#discussion_r400626587 ## File path: core/src/main/java/org/apache/carbondata/core/datamap/DataMapStoreManager.java ## @@ -163,6 +165,17

[GitHub] [carbondata] niuge01 commented on a change in pull request #3661: [WIP] Support materialized view

2020-03-30 Thread GitBox
niuge01 commented on a change in pull request #3661: [WIP] Support materialized view URL: https://github.com/apache/carbondata/pull/3661#discussion_r400626624 ## File path: core/src/main/java/org/apache/carbondata/core/datamap/IndexChooser.java ## @@ -59,76 +59,76 @@ *

[GitHub] [carbondata] jackylk closed pull request #3663: [WIP] Test CI for Index refactory

2020-03-30 Thread GitBox
jackylk closed pull request #3663: [WIP] Test CI for Index refactory URL: https://github.com/apache/carbondata/pull/3663 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [carbondata] jack86596 commented on issue #3664: [CARBONDATA-3740] Add line separator option to load command to configure the line separator during csv parsing.

2020-03-30 Thread GitBox
jack86596 commented on issue #3664: [CARBONDATA-3740] Add line separator option to load command to configure the line separator during csv parsing. URL: https://github.com/apache/carbondata/pull/3664#issuecomment-606360527 @akashrn5 hive table doesn't have parsing logic during loading, load

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3688: [WIP] Refactor Index Metadata

2020-03-30 Thread GitBox
CarbonDataQA1 commented on issue #3688: [WIP] Refactor Index Metadata URL: https://github.com/apache/carbondata/pull/3688#issuecomment-606108217 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2594/ ---

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3688: [WIP] Refactor Index Metadata

2020-03-30 Thread GitBox
CarbonDataQA1 commented on issue #3688: [WIP] Refactor Index Metadata URL: https://github.com/apache/carbondata/pull/3688#issuecomment-606107531 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/886/ ---

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3687: [WIP] Remove redundant conversion for complex type insert

2020-03-30 Thread GitBox
CarbonDataQA1 commented on issue #3687: [WIP] Remove redundant conversion for complex type insert URL: https://github.com/apache/carbondata/pull/3687#issuecomment-606095130 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/885/

[GitHub] [carbondata] akashrn5 edited a comment on issue #3664: [CARBONDATA-3740] Add line separator option to load command to configure the line separator during csv parsing.

2020-03-30 Thread GitBox
akashrn5 edited a comment on issue #3664: [CARBONDATA-3740] Add line separator option to load command to configure the line separator during csv parsing. URL: https://github.com/apache/carbondata/pull/3664#issuecomment-606089836 @jack86596 is the behavior same for hive tables also, please c

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3687: [WIP] Remove redundant conversion for complex type insert

2020-03-30 Thread GitBox
CarbonDataQA1 commented on issue #3687: [WIP] Remove redundant conversion for complex type insert URL: https://github.com/apache/carbondata/pull/3687#issuecomment-606090142 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2593/ --

[GitHub] [carbondata] akashrn5 commented on issue #3664: [CARBONDATA-3740] Add line separator option to load command to configure the line separator during csv parsing.

2020-03-30 Thread GitBox
akashrn5 commented on issue #3664: [CARBONDATA-3740] Add line separator option to load command to configure the line separator during csv parsing. URL: https://github.com/apache/carbondata/pull/3664#issuecomment-606089836 @jack86596 is the behavior same for hive tables also, please check, t

[GitHub] [carbondata] Indhumathi27 edited a comment on issue #3661: [WIP] Support materialized view

2020-03-30 Thread GitBox
Indhumathi27 edited a comment on issue #3661: [WIP] Support materialized view URL: https://github.com/apache/carbondata/pull/3661#issuecomment-606019193 @niuge01 @jackylk Please describe what all index related changes are done in this PR also --

[GitHub] [carbondata] Indhumathi27 commented on issue #3661: [WIP] Support materialized view

2020-03-30 Thread GitBox
Indhumathi27 commented on issue #3661: [WIP] Support materialized view URL: https://github.com/apache/carbondata/pull/3661#issuecomment-606019193 @niuge01 Please describe what all index related changes are done in this PR also ---

[GitHub] [carbondata] Indhumathi27 opened a new pull request #3688: [WIP] Refactor Index Metadata

2020-03-30 Thread GitBox
Indhumathi27 opened a new pull request #3688: [WIP] Refactor Index Metadata URL: https://github.com/apache/carbondata/pull/3688 This PR depends on [PR-3661](https://github.com/apache/carbondata/pull/3661) ### Why is this PR needed? ### What changes were proposed in this

[GitHub] [carbondata] ajantha-bhat opened a new pull request #3687: [WIP] Remove redundant conversion for complex type insert

2020-03-30 Thread GitBox
ajantha-bhat opened a new pull request #3687: [WIP] Remove redundant conversion for complex type insert URL: https://github.com/apache/carbondata/pull/3687 ### Why is this PR needed? ### What changes were proposed in this PR? ### Does this PR introduce any use

[GitHub] [carbondata] kunal642 commented on issue #3639: [CARBONDATA-3724] Secondary Index enable on partition Table

2020-03-30 Thread GitBox
kunal642 commented on issue #3639: [CARBONDATA-3724] Secondary Index enable on partition Table URL: https://github.com/apache/carbondata/pull/3639#issuecomment-605919858 @Indhumathi27 @jackylk @akashrn5 Please review This is

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3639: [CARBONDATA-3724] Secondary Index enable on partition Table

2020-03-30 Thread GitBox
CarbonDataQA1 commented on issue #3639: [CARBONDATA-3724] Secondary Index enable on partition Table URL: https://github.com/apache/carbondata/pull/3639#issuecomment-605857670 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2592/

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3639: [CARBONDATA-3724] Secondary Index enable on partition Table

2020-03-30 Thread GitBox
CarbonDataQA1 commented on issue #3639: [CARBONDATA-3724] Secondary Index enable on partition Table URL: https://github.com/apache/carbondata/pull/3639#issuecomment-605854854 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/884/

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3677: [wip]Fix segment cache issue with parallel spark applications on same store

2020-03-30 Thread GitBox
akashrn5 commented on a change in pull request #3677: [wip]Fix segment cache issue with parallel spark applications on same store URL: https://github.com/apache/carbondata/pull/3677#discussion_r40598 ## File path: core/src/main/java/org/apache/carbondata/core/indexstore/blockle

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3677: [wip]Fix segment cache issue with parallel spark applications on same store

2020-03-30 Thread GitBox
ajantha-bhat commented on a change in pull request #3677: [wip]Fix segment cache issue with parallel spark applications on same store URL: https://github.com/apache/carbondata/pull/3677#discussion_r399987268 ## File path: core/src/main/java/org/apache/carbondata/core/indexstore/blo

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3661: [WIP] Support materialized view

2020-03-30 Thread GitBox
ajantha-bhat commented on a change in pull request #3661: [WIP] Support materialized view URL: https://github.com/apache/carbondata/pull/3661#discussion_r399971835 ## File path: integration/spark/src/test/scala/org/apache/carbondata/view/MaterializedViewTest.scala ## @@ -

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3661: [WIP] Support materialized view

2020-03-30 Thread GitBox
ajantha-bhat commented on a change in pull request #3661: [WIP] Support materialized view URL: https://github.com/apache/carbondata/pull/3661#discussion_r399972261 ## File path: integration/spark/src/test/scala/org/apache/carbondata/view/MaterializedViewTest.scala ## @@ -

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3661: [WIP] Support materialized view

2020-03-30 Thread GitBox
ajantha-bhat commented on a change in pull request #3661: [WIP] Support materialized view URL: https://github.com/apache/carbondata/pull/3661#discussion_r399971835 ## File path: integration/spark/src/test/scala/org/apache/carbondata/view/MaterializedViewTest.scala ## @@ -

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3661: [WIP] Support materialized view

2020-03-30 Thread GitBox
ajantha-bhat commented on a change in pull request #3661: [WIP] Support materialized view URL: https://github.com/apache/carbondata/pull/3661#discussion_r399970121 ## File path: docs/index-developer-guide.md ## @@ -24,11 +24,11 @@ Currently, there are two types of DataMap

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3661: [WIP] Support materialized view

2020-03-30 Thread GitBox
ajantha-bhat commented on a change in pull request #3661: [WIP] Support materialized view URL: https://github.com/apache/carbondata/pull/3661#discussion_r399968880 ## File path: dev/findbugs-exclude.xml ## @@ -59,7 +59,7 @@ - + Review comment: A

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3661: [WIP] Support materialized view

2020-03-30 Thread GitBox
ajantha-bhat commented on a change in pull request #3661: [WIP] Support materialized view URL: https://github.com/apache/carbondata/pull/3661#discussion_r399969838 ## File path: dev/findbugs-exclude.xml ## @@ -59,7 +59,7 @@ - + Review comment: E

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3661: [WIP] Support materialized view

2020-03-30 Thread GitBox
ajantha-bhat commented on a change in pull request #3661: [WIP] Support materialized view URL: https://github.com/apache/carbondata/pull/3661#discussion_r399969838 ## File path: dev/findbugs-exclude.xml ## @@ -59,7 +59,7 @@ - + Review comment: E

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3661: [WIP] Support materialized view

2020-03-30 Thread GitBox
ajantha-bhat commented on a change in pull request #3661: [WIP] Support materialized view URL: https://github.com/apache/carbondata/pull/3661#discussion_r399968880 ## File path: dev/findbugs-exclude.xml ## @@ -59,7 +59,7 @@ - + Review comment: A

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3661: [WIP] Support materialized view

2020-03-30 Thread GitBox
ajantha-bhat commented on a change in pull request #3661: [WIP] Support materialized view URL: https://github.com/apache/carbondata/pull/3661#discussion_r399968880 ## File path: dev/findbugs-exclude.xml ## @@ -59,7 +59,7 @@ - + Review comment: A

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3661: [WIP] Support materialized view

2020-03-30 Thread GitBox
ajantha-bhat commented on a change in pull request #3661: [WIP] Support materialized view URL: https://github.com/apache/carbondata/pull/3661#discussion_r399965545 ## File path: core/src/main/java/org/apache/carbondata/core/datamap/dev/DataMapSyncStatus.java ## @@ -36,7 +