[GitHub] [carbondata] QiangCai commented on pull request #3782: [WIP] Fix the result of inspecting code in Intellij IDEA

2020-06-01 Thread GitBox
QiangCai commented on pull request #3782: URL: https://github.com/apache/carbondata/pull/3782#issuecomment-637256162 @ajantha-bhat Intellij Idea has this function in menu Analyze/inspect code, it will output a report which can be improved. I hope to check all suggestions in the report one

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3776: [CARBONDATA-3834]Segment directory and the segment file in metadata are not created for partitioned table when 'carbon.merge.index.

2020-06-01 Thread GitBox
CarbonDataQA1 commented on pull request #3776: URL: https://github.com/apache/carbondata/pull/3776#issuecomment-637158658 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1396/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3776: [CARBONDATA-3834]Segment directory and the segment file in metadata are not created for partitioned table when 'carbon.merge.index.

2020-06-01 Thread GitBox
CarbonDataQA1 commented on pull request #3776: URL: https://github.com/apache/carbondata/pull/3776#issuecomment-637158541 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3120/

[GitHub] [carbondata] ajantha-bhat commented on pull request #3782: [WIP] Fix the result of inspecting code in Intellij IDEA

2020-06-01 Thread GitBox
ajantha-bhat commented on pull request #3782: URL: https://github.com/apache/carbondata/pull/3782#issuecomment-636989906 @QiangCai : you are going through every file by file and doing it ? big work! This is an automated

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3784: [CARBONDATA-3841] Remove useless string in create and alter command

2020-06-01 Thread GitBox
CarbonDataQA1 commented on pull request #3784: URL: https://github.com/apache/carbondata/pull/3784#issuecomment-636923342 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1395/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3784: [CARBONDATA-3841] Remove useless string in create and alter command

2020-06-01 Thread GitBox
CarbonDataQA1 commented on pull request #3784: URL: https://github.com/apache/carbondata/pull/3784#issuecomment-636923009 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3119/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3784: [CARBONDATA-3841] Remove useless string in create and alter command

2020-06-01 Thread GitBox
CarbonDataQA1 commented on pull request #3784: URL: https://github.com/apache/carbondata/pull/3784#issuecomment-636798214 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3118/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3784: [CARBONDATA-3841] Remove useless string in create and alter command

2020-06-01 Thread GitBox
CarbonDataQA1 commented on pull request #3784: URL: https://github.com/apache/carbondata/pull/3784#issuecomment-636796556 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1394/

[jira] [Updated] (CARBONDATA-3839) Rename file fails in hdfs for FilterFileSystem Object

2020-06-01 Thread Kunal Kapoor (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kunal Kapoor updated CARBONDATA-3839: - Issue Type: Improvement (was: New Feature) > Rename file fails in hdfs for

[jira] [Updated] (CARBONDATA-3816) Support Float and Decimal in the Merge Flow

2020-06-01 Thread Kunal Kapoor (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kunal Kapoor updated CARBONDATA-3816: - Fix Version/s: (was: 2.0.1) 2.1.0 > Support Float and

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3783: [CARBONDATA-3840] Mark features as experimental

2020-06-01 Thread GitBox
CarbonDataQA1 commented on pull request #3783: URL: https://github.com/apache/carbondata/pull/3783#issuecomment-636766357 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3117/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3783: [CARBONDATA-3840] Mark features as experimental

2020-06-01 Thread GitBox
CarbonDataQA1 commented on pull request #3783: URL: https://github.com/apache/carbondata/pull/3783#issuecomment-636766737 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1393/

[GitHub] [carbondata] kevinjmh opened a new pull request #3784: [CARBONDATA-3841] Remove useless string in create and alter command

2020-06-01 Thread GitBox
kevinjmh opened a new pull request #3784: URL: https://github.com/apache/carbondata/pull/3784 ### Why is this PR needed? 1. LoadDataCommand has duplicated info about user input. Since SQL plan is printed in driver log and showed on SparkUI, we want to make it pretty. 2. Some

[jira] [Created] (CARBONDATA-3841) Remove useless string in create and alter command

2020-06-01 Thread Manhua Jiang (Jira)
Manhua Jiang created CARBONDATA-3841: Summary: Remove useless string in create and alter command Key: CARBONDATA-3841 URL: https://issues.apache.org/jira/browse/CARBONDATA-3841 Project: CarbonData

[GitHub] [carbondata] asfgit closed pull request #3783: [CARBONDATA-3840] Mark features as experimental

2020-06-01 Thread GitBox
asfgit closed pull request #3783: URL: https://github.com/apache/carbondata/pull/3783 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [carbondata] jackylk commented on pull request #3783: [CARBONDATA-3840] Mark features as experimental

2020-06-01 Thread GitBox
jackylk commented on pull request #3783: URL: https://github.com/apache/carbondata/pull/3783#issuecomment-636695185 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] kunal642 commented on a change in pull request #3783: [CARBONDATA-3840] Mark features as experimental

2020-06-01 Thread GitBox
kunal642 commented on a change in pull request #3783: URL: https://github.com/apache/carbondata/pull/3783#discussion_r433098465 ## File path: README.md ## @@ -69,6 +69,14 @@ CarbonData is built using Apache Maven, to [build CarbonData](https://github.com * [Carbon as Spark's

[GitHub] [carbondata] jackylk commented on a change in pull request #3783: [CARBONDATA-3840] Mark features as experimental

2020-06-01 Thread GitBox
jackylk commented on a change in pull request #3783: URL: https://github.com/apache/carbondata/pull/3783#discussion_r433095610 ## File path: README.md ## @@ -69,6 +69,14 @@ CarbonData is built using Apache Maven, to [build CarbonData](https://github.com * [Carbon as Spark's

[GitHub] [carbondata] jackylk commented on a change in pull request #3783: [CARBONDATA-3840] Mark features as experimental

2020-06-01 Thread GitBox
jackylk commented on a change in pull request #3783: URL: https://github.com/apache/carbondata/pull/3783#discussion_r433095610 ## File path: README.md ## @@ -69,6 +69,14 @@ CarbonData is built using Apache Maven, to [build CarbonData](https://github.com * [Carbon as Spark's

[GitHub] [carbondata] kunal642 opened a new pull request #3783: [CARBONDATA-3840] Mark features as experimental

2020-06-01 Thread GitBox
kunal642 opened a new pull request #3783: URL: https://github.com/apache/carbondata/pull/3783 ### Why is this PR needed? Mark features as experimental because they are subject to change in future. ### What changes were proposed in this PR? Mark features as experimental

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3773: [CARBONDATA-3830]Presto complex columns read support

2020-06-01 Thread GitBox
Indhumathi27 commented on a change in pull request #3773: URL: https://github.com/apache/carbondata/pull/3773#discussion_r433080176 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/adaptive/AdaptiveFloatingCodec.java ## @@ -247,6 +247,25 @@

[jira] [Created] (CARBONDATA-3840) Mark some features as experimental.

2020-06-01 Thread Kunal Kapoor (Jira)
Kunal Kapoor created CARBONDATA-3840: Summary: Mark some features as experimental. Key: CARBONDATA-3840 URL: https://issues.apache.org/jira/browse/CARBONDATA-3840 Project: CarbonData

[jira] [Assigned] (CARBONDATA-3837) Should fallback to the original plan when MV rewrite throw exception

2020-06-01 Thread David Cai (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Cai reassigned CARBONDATA-3837: - Assignee: David Cai > Should fallback to the original plan when MV rewrite throw

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3782: [WIP] Fix the result of inspecting code in Intellij IDEA

2020-06-01 Thread GitBox
CarbonDataQA1 commented on pull request #3782: URL: https://github.com/apache/carbondata/pull/3782#issuecomment-636662968 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3115/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3782: [WIP] Fix the result of inspecting code in Intellij IDEA

2020-06-01 Thread GitBox
CarbonDataQA1 commented on pull request #3782: URL: https://github.com/apache/carbondata/pull/3782#issuecomment-636662453 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1391/

[GitHub] [carbondata] QiangCai opened a new pull request #3782: [WIP] Fix the result of inspecting code in Intellij IDEA

2020-06-01 Thread GitBox
QiangCai opened a new pull request #3782: URL: https://github.com/apache/carbondata/pull/3782 ### Why is this PR needed? 1. pointless bitwise expression 2. field can be local 3. standard Charset object can be used 4. unecessary conversion to String 5. unecessary interface

[jira] [Resolved] (CARBONDATA-3836) Fix carbon store path & avoid exception when creating new carbon table

2020-06-01 Thread Kunal Kapoor (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kunal Kapoor resolved CARBONDATA-3836. -- Fix Version/s: 2.0.1 Resolution: Fixed > Fix carbon store path & avoid

[jira] [Resolved] (CARBONDATA-3839) Rename file fails in hdfs for FilterFileSystem Object

2020-06-01 Thread Kunal Kapoor (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kunal Kapoor resolved CARBONDATA-3839. -- Fix Version/s: 2.0.1 2.1.0 Resolution: Fixed > Rename

[jira] [Updated] (CARBONDATA-3839) Rename file fails in hdfs for FilterFileSystem Object

2020-06-01 Thread Kunal Kapoor (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kunal Kapoor updated CARBONDATA-3839: - Fix Version/s: (was: 2.1.0) > Rename file fails in hdfs for FilterFileSystem

[GitHub] [carbondata] asfgit closed pull request #3781: [CARBONDATA-3839]Fix rename file failed for FilterFileSystem DFS object

2020-06-01 Thread GitBox
asfgit closed pull request #3781: URL: https://github.com/apache/carbondata/pull/3781 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [carbondata] kunal642 commented on pull request #3781: [CARBONDATA-3839]Fix rename file failed for FilterFileSystem DFS object

2020-06-01 Thread GitBox
kunal642 commented on pull request #3781: URL: https://github.com/apache/carbondata/pull/3781#issuecomment-636648360 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3781: [CARBONDATA-3839]Fix rename file failed for FilterFileSystem DFS object

2020-06-01 Thread GitBox
CarbonDataQA1 commented on pull request #3781: URL: https://github.com/apache/carbondata/pull/3781#issuecomment-636647973 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1390/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3781: [CARBONDATA-3839]Fix rename file failed for FilterFileSystem DFS object

2020-06-01 Thread GitBox
CarbonDataQA1 commented on pull request #3781: URL: https://github.com/apache/carbondata/pull/3781#issuecomment-636645771 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3114/