[GitHub] [carbondata] brijoobopanna commented on pull request #3887: [CARBONDATA-3830] Support Array and Struct of all primitive type reading from presto

2020-08-24 Thread GitBox
brijoobopanna commented on pull request #3887: URL: https://github.com/apache/carbondata/pull/3887#issuecomment-678945401 @kumarvishal09 @QiangCai please help to review this PR This is an automated message from the Apache Git

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3876: TestingCI

2020-08-24 Thread GitBox
CarbonDataQA1 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-678945982 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3843/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3876: TestingCI

2020-08-24 Thread GitBox
CarbonDataQA1 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-678946442 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2102/

[GitHub] [carbondata] marchpure commented on pull request #3887: [CARBONDATA-3830] Support Array and Struct of all primitive type reading from presto

2020-08-24 Thread GitBox
marchpure commented on pull request #3887: URL: https://github.com/apache/carbondata/pull/3887#issuecomment-678949480 > @kumarvishal09 @QiangCai please help to review this PR Why can't I @Kejian-Li? This is an automate

[GitHub] [carbondata] marchpure removed a comment on pull request #3887: [CARBONDATA-3830] Support Array and Struct of all primitive type reading from presto

2020-08-24 Thread GitBox
marchpure removed a comment on pull request #3887: URL: https://github.com/apache/carbondata/pull/3887#issuecomment-678949480 > @kumarvishal09 @QiangCai please help to review this PR Why can't I @Kejian-Li? This is an

[GitHub] [carbondata] marchpure commented on pull request #3887: [CARBONDATA-3830] Support Array and Struct of all primitive type reading from presto

2020-08-24 Thread GitBox
marchpure commented on pull request #3887: URL: https://github.com/apache/carbondata/pull/3887#issuecomment-678949876 > @kumarvishal09 @QiangCai please help to review this PR Add @Kejian-Li to review this PR. This is a

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3862: [CARBONDATA-3933]Fix DDL/DML failures after table is created with column names having special characters like #,\,%

2020-08-24 Thread GitBox
akashrn5 commented on a change in pull request #3862: URL: https://github.com/apache/carbondata/pull/3862#discussion_r475390842 ## File path: integration/spark/src/test/scala/org/apache/spark/carbondata/restructure/AlterTableRevertTestCase.scala ## @@ -30,6 +32,13 @@ import o

[GitHub] [carbondata] Karan980 commented on pull request #3876: TestingCI

2020-08-24 Thread GitBox
Karan980 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-678965944 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3866: [CARBONDATA-3915] Correction in the documentation for spark-shell

2020-08-24 Thread GitBox
CarbonDataQA1 commented on pull request #3866: URL: https://github.com/apache/carbondata/pull/3866#issuecomment-678974202 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2104/

[GitHub] [carbondata] QiangCai commented on a change in pull request #3862: [CARBONDATA-3933]Fix DDL/DML failures after table is created with column names having special characters like #,\,%

2020-08-24 Thread GitBox
QiangCai commented on a change in pull request #3862: URL: https://github.com/apache/carbondata/pull/3862#discussion_r475413812 ## File path: integration/spark/src/test/scala/org/apache/spark/carbondata/restructure/AlterTableRevertTestCase.scala ## @@ -30,6 +32,13 @@ import o

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3866: [CARBONDATA-3915] Correction in the documentation for spark-shell

2020-08-24 Thread GitBox
CarbonDataQA1 commented on pull request #3866: URL: https://github.com/apache/carbondata/pull/3866#issuecomment-678976496 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3845/ -

[jira] [Created] (CARBONDATA-3958) CDC Merge task can't finish

2020-08-24 Thread David Cai (Jira)
David Cai created CARBONDATA-3958: - Summary: CDC Merge task can't finish Key: CARBONDATA-3958 URL: https://issues.apache.org/jira/browse/CARBONDATA-3958 Project: CarbonData Issue Type: Bug

[jira] [Created] (CARBONDATA-3959) In indexserver set executor lRU cache size to 70% of total executor memory

2020-08-24 Thread Karan (Jira)
Karan created CARBONDATA-3959: - Summary: In indexserver set executor lRU cache size to 70% of total executor memory Key: CARBONDATA-3959 URL: https://issues.apache.org/jira/browse/CARBONDATA-3959 Project:

[GitHub] [carbondata] Karan980 commented on pull request #3893: [CARBONDATA-3959] Added new property to set the value of executor LRU cache size to 70% of the total executor memory in IndexServer, if

2020-08-24 Thread GitBox
Karan980 commented on pull request #3893: URL: https://github.com/apache/carbondata/pull/3893#issuecomment-679002255 @Indhumathi27 Done This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [carbondata] QiangCai opened a new pull request #3897: [CARBONDATA-3958] Fix CDC merge tasks can't finish issue

2020-08-24 Thread GitBox
QiangCai opened a new pull request #3897: URL: https://github.com/apache/carbondata/pull/3897 ### Why is this PR needed? CDC merge tasks are blocked when data loading use CarbonTableOutputFormat.getRecordWriter method. Because the poll method of the queue is time out in some cases.

[GitHub] [carbondata] akkio-97 commented on pull request #3866: [CARBONDATA-3915] Correction in the documentation for spark-shell

2020-08-24 Thread GitBox
akkio-97 commented on pull request #3866: URL: https://github.com/apache/carbondata/pull/3866#issuecomment-679015969 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3876: TestingCI

2020-08-24 Thread GitBox
CarbonDataQA1 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-679024682 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3846/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3876: TestingCI

2020-08-24 Thread GitBox
CarbonDataQA1 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-679025574 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2105/

[GitHub] [carbondata] Karan980 commented on pull request #3876: TestingCI

2020-08-24 Thread GitBox
Karan980 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-679027809 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3896: [CARBONDATA-3955] Fix load failures due to daylight saving time changes

2020-08-24 Thread GitBox
VenuReddy2103 commented on a change in pull request #3896: URL: https://github.com/apache/carbondata/pull/3896#discussion_r475494371 ## File path: core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java ## @@ -435,19 +436,48 @@ public static Object getDataDataType

[GitHub] [carbondata] VenuReddy2103 commented on pull request #3896: [CARBONDATA-3955] Fix load failures due to daylight saving time changes

2020-08-24 Thread GitBox
VenuReddy2103 commented on pull request #3896: URL: https://github.com/apache/carbondata/pull/3896#issuecomment-679040734 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [carbondata] kunal642 commented on pull request #3862: [CARBONDATA-3933]Fix DDL/DML failures after table is created with column names having special characters like #,\,%

2020-08-24 Thread GitBox
kunal642 commented on pull request #3862: URL: https://github.com/apache/carbondata/pull/3862#issuecomment-679065415 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3866: [CARBONDATA-3915] Correction in the documentation for spark-shell

2020-08-24 Thread GitBox
CarbonDataQA1 commented on pull request #3866: URL: https://github.com/apache/carbondata/pull/3866#issuecomment-679067484 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3848/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3897: [CARBONDATA-3958] Fix CDC merge tasks can't finish issue

2020-08-24 Thread GitBox
CarbonDataQA1 commented on pull request #3897: URL: https://github.com/apache/carbondata/pull/3897#issuecomment-679068472 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2106/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3897: [CARBONDATA-3958] Fix CDC merge tasks can't finish issue

2020-08-24 Thread GitBox
CarbonDataQA1 commented on pull request #3897: URL: https://github.com/apache/carbondata/pull/3897#issuecomment-679068984 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3847/ -

[GitHub] [carbondata] asfgit closed pull request #3862: [CARBONDATA-3933]Fix DDL/DML failures after table is created with column names having special characters like #,\,%

2020-08-24 Thread GitBox
asfgit closed pull request #3862: URL: https://github.com/apache/carbondata/pull/3862 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Resolved] (CARBONDATA-3933) insert, desc throws error when the column name contains special character

2020-08-24 Thread Kunal Kapoor (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kunal Kapoor resolved CARBONDATA-3933. -- Fix Version/s: 2.1.0 Resolution: Fixed > insert, desc throws error when the

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3866: [CARBONDATA-3915] Correction in the documentation for spark-shell

2020-08-24 Thread GitBox
CarbonDataQA1 commented on pull request #3866: URL: https://github.com/apache/carbondata/pull/3866#issuecomment-679070825 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2107/

[GitHub] [carbondata] kunal642 commented on a change in pull request #3894: [CARBONDATA-3957] Added property to enable disable the repair logic and provide a limit to number of segments in SILoadEvent

2020-08-24 Thread GitBox
kunal642 commented on a change in pull request #3894: URL: https://github.com/apache/carbondata/pull/3894#discussion_r475533562 ## File path: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ## @@ -2262,6 +2262,32 @@ private CarbonCommonConsta

[GitHub] [carbondata] kunal642 commented on a change in pull request #3894: [CARBONDATA-3957] Added property to enable disable the repair logic and provide a limit to number of segments in SILoadEvent

2020-08-24 Thread GitBox
kunal642 commented on a change in pull request #3894: URL: https://github.com/apache/carbondata/pull/3894#discussion_r475533961 ## File path: core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ## @@ -2076,4 +2076,16 @@ public static boolean isAuditEnabled

[GitHub] [carbondata] kunal642 commented on a change in pull request #3894: [CARBONDATA-3957] Added property to enable disable the repair logic and provide a limit to number of segments in SILoadEvent

2020-08-24 Thread GitBox
kunal642 commented on a change in pull request #3894: URL: https://github.com/apache/carbondata/pull/3894#discussion_r475533764 ## File path: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ## @@ -2262,6 +2262,32 @@ private CarbonCommonConsta

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3876: TestingCI

2020-08-24 Thread GitBox
CarbonDataQA1 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-679078760 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3849/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3876: TestingCI

2020-08-24 Thread GitBox
CarbonDataQA1 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-679079380 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2108/

[GitHub] [carbondata] Karan980 commented on pull request #3876: TestingCI

2020-08-24 Thread GitBox
Karan980 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-679080452 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [carbondata] ravipesala commented on pull request #3856: [CARBONDATA-3929]Improve CDC performance

2020-08-24 Thread GitBox
ravipesala commented on pull request #3856: URL: https://github.com/apache/carbondata/pull/3856#issuecomment-679095323 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] ravipesala commented on a change in pull request #3856: [CARBONDATA-3929]Improve CDC performance

2020-08-24 Thread GitBox
ravipesala commented on a change in pull request #3856: URL: https://github.com/apache/carbondata/pull/3856#discussion_r475560861 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/mutation/merge/CarbonMergeDataSetCommand.scala ## @@ -194,29

[GitHub] [carbondata] QiangCai commented on pull request #3897: [CARBONDATA-3958] Fix CDC merge tasks can't finish issue

2020-08-24 Thread GitBox
QiangCai commented on pull request #3897: URL: https://github.com/apache/carbondata/pull/3897#issuecomment-679096749 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [carbondata] ravipesala commented on pull request #3897: [CARBONDATA-3958] Fix CDC merge tasks can't finish issue

2020-08-24 Thread GitBox
ravipesala commented on pull request #3897: URL: https://github.com/apache/carbondata/pull/3897#issuecomment-679098812 LGTM, Anyway we are not using it in CDC as per the PR https://github.com/apache/carbondata/pull/3856. This case not supposed to happen, it means source is not writing

[GitHub] [carbondata] QiangCai commented on pull request #3856: [CARBONDATA-3929]Improve CDC performance

2020-08-24 Thread GitBox
QiangCai commented on pull request #3856: URL: https://github.com/apache/carbondata/pull/3856#issuecomment-679105065 why don't use row_v1 format in the streaming module? This is an automated message from the Apache Git Servic

[GitHub] [carbondata] akashrn5 commented on pull request #3897: [CARBONDATA-3958] Fix CDC merge tasks can't finish issue

2020-08-24 Thread GitBox
akashrn5 commented on pull request #3897: URL: https://github.com/apache/carbondata/pull/3897#issuecomment-679123761 @QiangCai as @ravipesala said since we are not using this, may be once after #3856 is merged, we can check and close this i think. -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3876: TestingCI

2020-08-24 Thread GitBox
CarbonDataQA1 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-679135243 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3850/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3876: TestingCI

2020-08-24 Thread GitBox
CarbonDataQA1 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-679136250 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2109/

[GitHub] [carbondata] Karan-c980 commented on pull request #3876: TestingCI

2020-08-24 Thread GitBox
Karan-c980 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-679141387 retest this please This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3897: [CARBONDATA-3958] Fix CDC merge tasks can't finish issue

2020-08-24 Thread GitBox
CarbonDataQA1 commented on pull request #3897: URL: https://github.com/apache/carbondata/pull/3897#issuecomment-679159237 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2110/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3897: [CARBONDATA-3958] Fix CDC merge tasks can't finish issue

2020-08-24 Thread GitBox
CarbonDataQA1 commented on pull request #3897: URL: https://github.com/apache/carbondata/pull/3897#issuecomment-679159418 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3851/ -

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3896: [CARBONDATA-3955] Fix load failures due to daylight saving time changes

2020-08-24 Thread GitBox
akashrn5 commented on a change in pull request #3896: URL: https://github.com/apache/carbondata/pull/3896#discussion_r475346485 ## File path: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ## @@ -1592,6 +1592,13 @@ private CarbonCommonConsta

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3876: TestingCI

2020-08-24 Thread GitBox
CarbonDataQA1 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-679210475 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2111/

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3896: [CARBONDATA-3955] Fix load failures due to daylight saving time changes

2020-08-24 Thread GitBox
akashrn5 commented on a change in pull request #3896: URL: https://github.com/apache/carbondata/pull/3896#discussion_r475716479 ## File path: core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java ## @@ -435,18 +436,48 @@ public static Object getDataDataTypeForNo

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3876: TestingCI

2020-08-24 Thread GitBox
CarbonDataQA1 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-679216716 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3852/ -

[GitHub] [carbondata] kunal642 commented on pull request #3866: [CARBONDATA-3915] Correction in the documentation for spark-shell

2020-08-24 Thread GitBox
kunal642 commented on pull request #3866: URL: https://github.com/apache/carbondata/pull/3866#issuecomment-679235346 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [carbondata] asfgit closed pull request #3866: [CARBONDATA-3915] Correction in the documentation for spark-shell

2020-08-24 Thread GitBox
asfgit closed pull request #3866: URL: https://github.com/apache/carbondata/pull/3866 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Resolved] (CARBONDATA-3915) Correction in the documentation for spark-shell

2020-08-24 Thread Kunal Kapoor (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kunal Kapoor resolved CARBONDATA-3915. -- Fix Version/s: 2.1.0 Resolution: Fixed > Correction in the documentation fo

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3876: TestingCI

2020-08-24 Thread GitBox
CarbonDataQA1 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-679350328 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2112/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3876: TestingCI

2020-08-24 Thread GitBox
CarbonDataQA1 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-679357060 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3853/ -

[GitHub] [carbondata] QiangCai commented on pull request #3897: [CARBONDATA-3958] Fix CDC merge tasks can't finish issue

2020-08-24 Thread GitBox
QiangCai commented on pull request #3897: URL: https://github.com/apache/carbondata/pull/3897#issuecomment-679445110 @ravipesala @akashrn5 we can merge it also. In the future, other cases can use CarbonTableOutputFormat and this issue will not happen.

[GitHub] [carbondata] xubo245 removed a comment on pull request #3891: [CARBONDATA-3889] Enable scala check style

2020-08-24 Thread GitBox
xubo245 removed a comment on pull request #3891: URL: https://github.com/apache/carbondata/pull/3891#issuecomment-678023289 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] xubo245 commented on pull request #3891: [CARBONDATA-3889] Enable scala check style

2020-08-24 Thread GitBox
xubo245 commented on pull request #3891: URL: https://github.com/apache/carbondata/pull/3891#issuecomment-679459877 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [carbondata] asfgit closed pull request #3891: [CARBONDATA-3889] Enable scala check style

2020-08-24 Thread GitBox
asfgit closed pull request #3891: URL: https://github.com/apache/carbondata/pull/3891 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [carbondata] dependabot[bot] commented on pull request #3447: Bump dep.jackson.version from 2.6.5 to 2.10.1 in /store/sdk

2020-08-24 Thread GitBox
dependabot[bot] commented on pull request #3447: URL: https://github.com/apache/carbondata/pull/3447#issuecomment-679464062 Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot

[GitHub] [carbondata] dependabot[bot] commented on pull request #3456: Bump solr.version from 6.3.0 to 8.3.0 in /datamap/lucene

2020-08-24 Thread GitBox
dependabot[bot] commented on pull request #3456: URL: https://github.com/apache/carbondata/pull/3456#issuecomment-679464079 Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot

[GitHub] [carbondata] Karan-c980 commented on pull request #3876: TestingCI

2020-08-24 Thread GitBox
Karan-c980 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-679683246 retest this please This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3896: [CARBONDATA-3955] Fix load failures due to daylight saving time changes

2020-08-24 Thread GitBox
Indhumathi27 commented on a change in pull request #3896: URL: https://github.com/apache/carbondata/pull/3896#discussion_r476183063 ## File path: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ## @@ -1592,6 +1592,13 @@ private CarbonCommonCo

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3896: [CARBONDATA-3955] Fix load failures due to daylight saving time changes

2020-08-24 Thread GitBox
Indhumathi27 commented on a change in pull request #3896: URL: https://github.com/apache/carbondata/pull/3896#discussion_r476183853 ## File path: core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java ## @@ -435,18 +436,48 @@ public static Object getDataDataTypeF

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3896: [CARBONDATA-3955] Fix load failures due to daylight saving time changes

2020-08-24 Thread GitBox
Indhumathi27 commented on a change in pull request #3896: URL: https://github.com/apache/carbondata/pull/3896#discussion_r476184514 ## File path: core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java ## @@ -435,18 +436,48 @@ public static Object getDataDataTypeF

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3896: [CARBONDATA-3955] Fix load failures due to daylight saving time changes

2020-08-24 Thread GitBox
Indhumathi27 commented on a change in pull request #3896: URL: https://github.com/apache/carbondata/pull/3896#discussion_r476186302 ## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/dataload/TestLoadDataWithDiffTimestampFormat.scala ## @@ -30

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3890: [CARBONDATA-3952] After reset query not hitting MV

2020-08-24 Thread GitBox
Indhumathi27 commented on a change in pull request #3890: URL: https://github.com/apache/carbondata/pull/3890#discussion_r476188040 ## File path: integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/SetParameterTestCase.scala ## @@ -

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3890: [CARBONDATA-3952] After reset query not hitting MV

2020-08-24 Thread GitBox
Indhumathi27 commented on a change in pull request #3890: URL: https://github.com/apache/carbondata/pull/3890#discussion_r476187983 ## File path: integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/SetParameterTestCase.scala ## @@ -

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3873: [CARBONDATA-3956] Reindex command on SI table

2020-08-24 Thread GitBox
Indhumathi27 commented on a change in pull request #3873: URL: https://github.com/apache/carbondata/pull/3873#discussion_r476196350 ## File path: docs/index/secondary-index-guide.md ## @@ -188,4 +188,13 @@ where we have old stores. Syntax ``` REGISTER INDEX TABLE index_n

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #3873: [CARBONDATA-3956] Reindex command on SI table

2020-08-24 Thread GitBox
vikramahuja1001 commented on a change in pull request #3873: URL: https://github.com/apache/carbondata/pull/3873#discussion_r476215511 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/index/IndexRepairCommand.scala ## @@ -0,0 +1,127 @@ +/*

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #3873: [CARBONDATA-3956] Reindex command on SI table

2020-08-24 Thread GitBox
vikramahuja1001 commented on a change in pull request #3873: URL: https://github.com/apache/carbondata/pull/3873#discussion_r476216833 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/index/IndexRepairCommand.scala ## @@ -0,0 +1,127 @@ +/*

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #3873: [CARBONDATA-3956] Reindex command on SI table

2020-08-24 Thread GitBox
vikramahuja1001 commented on a change in pull request #3873: URL: https://github.com/apache/carbondata/pull/3873#discussion_r476217005 ## File path: index/secondary-index/src/test/scala/org/apache/carbondata/spark/testsuite/secondaryindex/TestIndexRepair.scala ## @@ -0,0 +1,20

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #3873: [CARBONDATA-3956] Reindex command on SI table

2020-08-24 Thread GitBox
vikramahuja1001 commented on a change in pull request #3873: URL: https://github.com/apache/carbondata/pull/3873#discussion_r476218914 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/index/IndexRepairCommand.scala ## @@ -0,0 +1,127 @@ +/*

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #3873: [CARBONDATA-3956] Reindex command on SI table

2020-08-24 Thread GitBox
vikramahuja1001 commented on a change in pull request #3873: URL: https://github.com/apache/carbondata/pull/3873#discussion_r476219675 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/index/IndexRepairCommand.scala ## @@ -0,0 +1,127 @@ +/*