[GitHub] [carbondata] Karan980 commented on pull request #3923: [CARBONDATA-3984] 1. Fix compaction issue. 2. Fix longStringColumn validation issue

2020-09-15 Thread GitBox
Karan980 commented on pull request #3923: URL: https://github.com/apache/carbondata/pull/3923#issuecomment-693189676 > @Karan980 the PR title shouldn't be so long, give a small but descriptive title and details you can explain in PR description. Done ---

[GitHub] [carbondata] Karan980 commented on a change in pull request #3923: [CARBONDATA-3984] 1. Fix compaction issue. 2. Fix longStringColumn validation issue

2020-09-15 Thread GitBox
Karan980 commented on a change in pull request #3923: URL: https://github.com/apache/carbondata/pull/3923#discussion_r489180454 ## File path: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ## @@ -3344,6 +3344,9 @@ public int compare(org.apache.carbondata.fo

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3930: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…

2020-09-15 Thread GitBox
CarbonDataQA1 commented on pull request #3930: URL: https://github.com/apache/carbondata/pull/3930#issuecomment-693180722 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4091/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3930: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…

2020-09-15 Thread GitBox
CarbonDataQA1 commented on pull request #3930: URL: https://github.com/apache/carbondata/pull/3930#issuecomment-693178308 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2350/

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3923: [CARBONDATA-3984] 1. Compaction on table having range column after altering datatype from string to long string fails.

2020-09-15 Thread GitBox
akashrn5 commented on a change in pull request #3923: URL: https://github.com/apache/carbondata/pull/3923#discussion_r488807941 ## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/longstring/VarcharDataTypesBasicTestCase.scala ## @@ -29,7 +31,9

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3920: [CARBONDATA-3981] Presto filter check on binary, byte and float datatypes

2020-09-15 Thread GitBox
ajantha-bhat commented on a change in pull request #3920: URL: https://github.com/apache/carbondata/pull/3920#discussion_r489158514 ## File path: integration/presto/src/main/prestosql/org/apache/carbondata/presto/PrestoFilterUtil.java ## @@ -78,16 +78,22 @@ private static Data

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3920: [CARBONDATA-3981] Presto filter check on binary, byte and float datatypes

2020-09-15 Thread GitBox
ajantha-bhat commented on a change in pull request #3920: URL: https://github.com/apache/carbondata/pull/3920#discussion_r489158120 ## File path: integration/presto/src/main/prestosql/org/apache/carbondata/presto/PrestoFilterUtil.java ## @@ -78,16 +78,22 @@ private static Data

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3929: [CARBONDATA-3991] Fix the set modified time function on S3 and Alluxio file system

2020-09-15 Thread GitBox
CarbonDataQA1 commented on pull request #3929: URL: https://github.com/apache/carbondata/pull/3929#issuecomment-693160345 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4090/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3925: [CARBONDATA-3985] Optimize the segment-timestamp file clean up

2020-09-15 Thread GitBox
CarbonDataQA1 commented on pull request #3925: URL: https://github.com/apache/carbondata/pull/3925#issuecomment-693154382 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2349/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3925: [CARBONDATA-3985] Optimize the segment-timestamp file clean up

2020-09-15 Thread GitBox
CarbonDataQA1 commented on pull request #3925: URL: https://github.com/apache/carbondata/pull/3925#issuecomment-693152789 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4089/ -

[GitHub] [carbondata] QiangCai commented on pull request #3930: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…

2020-09-15 Thread GitBox
QiangCai commented on pull request #3930: URL: https://github.com/apache/carbondata/pull/3930#issuecomment-693148903 add to whitelist This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3930: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…

2020-09-15 Thread GitBox
CarbonDataQA1 commented on pull request #3930: URL: https://github.com/apache/carbondata/pull/3930#issuecomment-693134156 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To r

[GitHub] [carbondata] Klaus-xjp opened a new pull request #3930: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…

2020-09-15 Thread GitBox
Klaus-xjp opened a new pull request #3930: URL: https://github.com/apache/carbondata/pull/3930 … file system ###Why is this PR needed? If there are some update or create mv in S3 and Alluxio files ,those operations do not take effect. And the other tenant can't find the changes

[GitHub] [carbondata] Klaus-xjp closed pull request #3929: [CARBONDATA-3991] Fix the set modified time function on S3 and Alluxio file system

2020-09-15 Thread GitBox
Klaus-xjp closed pull request #3929: URL: https://github.com/apache/carbondata/pull/3929 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [carbondata] QiangCai commented on pull request #3929: [CARBONDATA-3991] Fix the set modified time function on S3 and Alluxio file system

2020-09-15 Thread GitBox
QiangCai commented on pull request #3929: URL: https://github.com/apache/carbondata/pull/3929#issuecomment-693131340 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [carbondata] QiangCai commented on pull request #3929: [CARBONDATA-3991] Fix the set modified time function on S3 and Alluxio file system

2020-09-15 Thread GitBox
QiangCai commented on pull request #3929: URL: https://github.com/apache/carbondata/pull/3929#issuecomment-693131254 if the old file exists, how does it work? This is an automated message from the Apache Git Service. To respo

[GitHub] [carbondata] Klaus-xjp opened a new pull request #3929: [CARBONDATA-3991] Fix the modified time failed problem

2020-09-15 Thread GitBox
Klaus-xjp opened a new pull request #3929: URL: https://github.com/apache/carbondata/pull/3929 Why is this PR needed? If there are some update or create mv in S3 and Alluxio files ,those operations do not take effect. And the other tenant can't find the changes in this operation and cau

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3929: [CARBONDATA-3991] Fix the modified time failed problem

2020-09-15 Thread GitBox
CarbonDataQA1 commented on pull request #3929: URL: https://github.com/apache/carbondata/pull/3929#issuecomment-693124094 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To r

[jira] [Created] (CARBONDATA-3991) File system could not set modified time because don't override the settime function

2020-09-15 Thread jingpan xiong (Jira)
jingpan xiong created CARBONDATA-3991: - Summary: File system could not set modified time because don't override the settime function Key: CARBONDATA-3991 URL: https://issues.apache.org/jira/browse/CARBONDATA-3

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3920: [CARBONDATA-3981] Presto filter check on binary, byte and float datatypes

2020-09-15 Thread GitBox
CarbonDataQA1 commented on pull request #3920: URL: https://github.com/apache/carbondata/pull/3920#issuecomment-692853189 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2348/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3920: [CARBONDATA-3981] Presto filter check on binary, byte and float datatypes

2020-09-15 Thread GitBox
CarbonDataQA1 commented on pull request #3920: URL: https://github.com/apache/carbondata/pull/3920#issuecomment-692849005 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4088/ -

[GitHub] [carbondata] akashrn5 commented on pull request #3923: [CARBONDATA-3984] 1. Compaction on table having range column after altering datatype from string to long string fails.

2020-09-15 Thread GitBox
akashrn5 commented on pull request #3923: URL: https://github.com/apache/carbondata/pull/3923#issuecomment-692834883 @Karan980 the PR title shouldn't be so long, give a small but descriptive title and details you can explain in PR description. -

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3923: [CARBONDATA-3984] 1. Compaction on table having range column after altering datatype from string to long string fails.

2020-09-15 Thread GitBox
akashrn5 commented on a change in pull request #3923: URL: https://github.com/apache/carbondata/pull/3923#discussion_r488807808 ## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/longstring/VarcharDataTypesBasicTestCase.scala ## @@ -110,6 +114

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3923: [CARBONDATA-3984] 1. Compaction on table having range column after altering datatype from string to long string fails.

2020-09-15 Thread GitBox
CarbonDataQA1 commented on pull request #3923: URL: https://github.com/apache/carbondata/pull/3923#issuecomment-692832532 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4086/ -

[jira] [Resolved] (CARBONDATA-3986) multiple issues during compaction and concurrent scenarios

2020-09-15 Thread Akash R Nilugal (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash R Nilugal resolved CARBONDATA-3986. - Fix Version/s: 2.1.0 Resolution: Fixed > multiple issues during compa

[GitHub] [carbondata] asfgit closed pull request #3871: [CARBONDATA-3986] Fix multiple issues during compaction and concurrent scenarios

2020-09-15 Thread GitBox
asfgit closed pull request #3871: URL: https://github.com/apache/carbondata/pull/3871 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3923: [CARBONDATA-3984] 1. Compaction on table having range column after altering datatype from string to long string fails.

2020-09-15 Thread GitBox
CarbonDataQA1 commented on pull request #3923: URL: https://github.com/apache/carbondata/pull/3923#issuecomment-692828938 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2346/

[GitHub] [carbondata] akashrn5 commented on pull request #3871: [CARBONDATA-3986] Fix multiple issues during compaction and concurrent scenarios

2020-09-15 Thread GitBox
akashrn5 commented on pull request #3871: URL: https://github.com/apache/carbondata/pull/3871#issuecomment-692826931 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3871: [CARBONDATA-3986] Fix multiple issues during compaction and concurrent scenarios

2020-09-15 Thread GitBox
CarbonDataQA1 commented on pull request #3871: URL: https://github.com/apache/carbondata/pull/3871#issuecomment-692818581 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2345/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3871: [CARBONDATA-3986] Fix multiple issues during compaction and concurrent scenarios

2020-09-15 Thread GitBox
CarbonDataQA1 commented on pull request #3871: URL: https://github.com/apache/carbondata/pull/3871#issuecomment-692817569 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4085/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3920: [CARBONDATA-3981] Presto filter check on binary, byte and float datatypes

2020-09-15 Thread GitBox
CarbonDataQA1 commented on pull request #3920: URL: https://github.com/apache/carbondata/pull/3920#issuecomment-692774538 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2347/

[GitHub] [carbondata] akkio-97 commented on a change in pull request #3920: [CARBONDATA-3981] Presto filter check on binary datatype

2020-09-15 Thread GitBox
akkio-97 commented on a change in pull request #3920: URL: https://github.com/apache/carbondata/pull/3920#discussion_r488734849 ## File path: integration/presto/src/test/scala/org/apache/carbondata/presto/integrationtest/PrestoTestNonTransactionalTableFiles.scala ## @@ -230,6

[GitHub] [carbondata] akkio-97 commented on a change in pull request #3920: [CARBONDATA-3981] Presto filter check on binary datatype

2020-09-15 Thread GitBox
akkio-97 commented on a change in pull request #3920: URL: https://github.com/apache/carbondata/pull/3920#discussion_r488734274 ## File path: integration/presto/src/main/prestosql/org/apache/carbondata/presto/PrestoFilterUtil.java ## @@ -78,6 +78,8 @@ private static DataType

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3923: [CARBONDATA-3984] 1. Compaction on table having range column after altering datatype from string to long string fails.

2020-09-15 Thread GitBox
akashrn5 commented on a change in pull request #3923: URL: https://github.com/apache/carbondata/pull/3923#discussion_r488723181 ## File path: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ## @@ -3344,6 +3344,9 @@ public int compare(org.apache.carbondata.fo

[GitHub] [carbondata] Karan980 commented on a change in pull request #3923: [CARBONDATA-3984] 1. Compaction on table having range column after altering datatype from string to long string fails.

2020-09-15 Thread GitBox
Karan980 commented on a change in pull request #3923: URL: https://github.com/apache/carbondata/pull/3923#discussion_r488712088 ## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/longstring/VarcharDataTypesBasicTestCase.scala ## @@ -110,6 +110

[GitHub] [carbondata] ajantha-bhat commented on pull request #3871: [CARBONDATA-3986] Fix multiple issues during compaction and concurrent scenarios

2020-09-15 Thread GitBox
ajantha-bhat commented on pull request #3871: URL: https://github.com/apache/carbondata/pull/3871#issuecomment-692740141 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3871: [CARBONDATA-3986] Fix multiple issues during compaction and concurrent scenarios

2020-09-15 Thread GitBox
CarbonDataQA1 commented on pull request #3871: URL: https://github.com/apache/carbondata/pull/3871#issuecomment-692739041 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4084/ -

[jira] [Resolved] (CARBONDATA-3983) SI compatability issue

2020-09-15 Thread Akash R Nilugal (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash R Nilugal resolved CARBONDATA-3983. - Fix Version/s: 2.1.0 Resolution: Fixed > SI compatability issue > ---

[GitHub] [carbondata] asfgit closed pull request #3922: [CARBONDATA-3983] SI compatability issue

2020-09-15 Thread GitBox
asfgit closed pull request #3922: URL: https://github.com/apache/carbondata/pull/3922 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3922: [CARBONDATA-3983] SI compatability issue

2020-09-15 Thread GitBox
ShreelekhyaG commented on a change in pull request #3922: URL: https://github.com/apache/carbondata/pull/3922#discussion_r488687445 ## File path: core/src/main/java/org/apache/carbondata/core/scan/expression/conditional/ImplicitExpression.java ## @@ -59,13 +61,23 @@ public Imp

[GitHub] [carbondata] akashrn5 commented on pull request #3922: [CARBONDATA-3983] SI compatability issue

2020-09-15 Thread GitBox
akashrn5 commented on pull request #3922: URL: https://github.com/apache/carbondata/pull/3922#issuecomment-692730001 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3922: [CARBONDATA-3983] SI compatability issue

2020-09-15 Thread GitBox
CarbonDataQA1 commented on pull request #3922: URL: https://github.com/apache/carbondata/pull/3922#issuecomment-692728976 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2343/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3922: [CARBONDATA-3983] SI compatability issue

2020-09-15 Thread GitBox
CarbonDataQA1 commented on pull request #3922: URL: https://github.com/apache/carbondata/pull/3922#issuecomment-692728352 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4083/ -

[jira] [Created] (CARBONDATA-3990) Fix DropCache log error when indexmap is null

2020-09-15 Thread Indhumathi Muthumurugesh (Jira)
Indhumathi Muthumurugesh created CARBONDATA-3990: Summary: Fix DropCache log error when indexmap is null Key: CARBONDATA-3990 URL: https://issues.apache.org/jira/browse/CARBONDATA-3990

[jira] [Resolved] (CARBONDATA-3980) Load fails with aborted exception when Bad records action is unspecified

2020-09-15 Thread Ajantha Bhat (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajantha Bhat resolved CARBONDATA-3980. -- Fix Version/s: 2.1.0 Resolution: Fixed > Load fails with aborted exception

[GitHub] [carbondata] asfgit closed pull request #3919: [CARBONDATA-3980] Load fails with aborted exception when Bad records action is unspecified

2020-09-15 Thread GitBox
asfgit closed pull request #3919: URL: https://github.com/apache/carbondata/pull/3919 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [carbondata] asfgit closed pull request #3921: [CARBONDATA-3928] Removed records from exception message.

2020-09-15 Thread GitBox
asfgit closed pull request #3921: URL: https://github.com/apache/carbondata/pull/3921 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [carbondata] ajantha-bhat commented on pull request #3919: [CARBONDATA-3980] Load fails with aborted exception when Bad records action is unspecified

2020-09-15 Thread GitBox
ajantha-bhat commented on pull request #3919: URL: https://github.com/apache/carbondata/pull/3919#issuecomment-692670191 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3871: [CARBONDATA-3986] Fix multiple issues during compaction and concurrent scenarios

2020-09-15 Thread GitBox
ajantha-bhat commented on a change in pull request #3871: URL: https://github.com/apache/carbondata/pull/3871#discussion_r488608473 ## File path: core/src/main/java/org/apache/carbondata/core/writer/CarbonIndexFileMergeWriter.java ## @@ -233,15 +234,24 @@ public String writeM

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3928: [WIP]Fix DropCache log error when indexmap is null

2020-09-15 Thread GitBox
CarbonDataQA1 commented on pull request #3928: URL: https://github.com/apache/carbondata/pull/3928#issuecomment-692663663 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2341/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3928: [WIP]Fix DropCache log error when indexmap is null

2020-09-15 Thread GitBox
CarbonDataQA1 commented on pull request #3928: URL: https://github.com/apache/carbondata/pull/3928#issuecomment-692661529 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4081/ -

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3919: [CARBONDATA-3980] Load fails with aborted exception when Bad records action is unspecified

2020-09-15 Thread GitBox
ShreelekhyaG commented on a change in pull request #3919: URL: https://github.com/apache/carbondata/pull/3919#discussion_r488595453 ## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/standardpartition/StandardPartitionBadRecordLoggerTest.scala ###

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3919: [CARBONDATA-3980] Load fails with aborted exception when Bad records action is unspecified

2020-09-15 Thread GitBox
CarbonDataQA1 commented on pull request #3919: URL: https://github.com/apache/carbondata/pull/3919#issuecomment-692654382 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2340/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3919: [CARBONDATA-3980] Load fails with aborted exception when Bad records action is unspecified

2020-09-15 Thread GitBox
CarbonDataQA1 commented on pull request #3919: URL: https://github.com/apache/carbondata/pull/3919#issuecomment-692645252 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4080/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3922: [CARBONDATA-3983] SI compatability issue

2020-09-15 Thread GitBox
CarbonDataQA1 commented on pull request #3922: URL: https://github.com/apache/carbondata/pull/3922#issuecomment-692642655 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4079/ -

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3923: [CARBONDATA-3984] 1. Compaction on table having range column after altering datatype from string to long string fails.

2020-09-15 Thread GitBox
akashrn5 commented on a change in pull request #3923: URL: https://github.com/apache/carbondata/pull/3923#discussion_r488574809 ## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/longstring/VarcharDataTypesBasicTestCase.scala ## @@ -110,6 +110

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3922: [CARBONDATA-3983] SI compatability issue

2020-09-15 Thread GitBox
CarbonDataQA1 commented on pull request #3922: URL: https://github.com/apache/carbondata/pull/3922#issuecomment-692638683 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2339/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3920: [CARBONDATA-3981] Presto filter check on binary datatype

2020-09-15 Thread GitBox
CarbonDataQA1 commented on pull request #3920: URL: https://github.com/apache/carbondata/pull/3920#issuecomment-692631719 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4078/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3920: [CARBONDATA-3981] Presto filter check on binary datatype

2020-09-15 Thread GitBox
CarbonDataQA1 commented on pull request #3920: URL: https://github.com/apache/carbondata/pull/3920#issuecomment-692631316 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2338/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3871: [CARBONDATA-3986] Fix multiple issues during compaction and concurrent scenarios

2020-09-15 Thread GitBox
CarbonDataQA1 commented on pull request #3871: URL: https://github.com/apache/carbondata/pull/3871#issuecomment-692629619 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4077/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3923: [CARBONDATA-3984] 1. Compaction on table having range column after altering datatype from string to long string fails.

2020-09-15 Thread GitBox
CarbonDataQA1 commented on pull request #3923: URL: https://github.com/apache/carbondata/pull/3923#issuecomment-692594093 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2336/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3923: [CARBONDATA-3984] 1. Compaction on table having range column after altering datatype from string to long string fails.

2020-09-15 Thread GitBox
CarbonDataQA1 commented on pull request #3923: URL: https://github.com/apache/carbondata/pull/3923#issuecomment-692593886 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4076/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3871: [CARBONDATA-3986] Fix multiple issues during compaction and concurrent scenarios

2020-09-15 Thread GitBox
CarbonDataQA1 commented on pull request #3871: URL: https://github.com/apache/carbondata/pull/3871#issuecomment-692593687 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2337/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3876: TestingCI

2020-09-15 Thread GitBox
CarbonDataQA1 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-692584299 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2335/

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3871: [CARBONDATA-3986] Fix multiple issues during compaction and concurrent scenarios

2020-09-15 Thread GitBox
ajantha-bhat commented on a change in pull request #3871: URL: https://github.com/apache/carbondata/pull/3871#discussion_r488511466 ## File path: processing/src/main/java/org/apache/carbondata/processing/loading/TableProcessingOperations.java ## @@ -64,45 +68,85 @@ public stat

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3876: TestingCI

2020-09-15 Thread GitBox
CarbonDataQA1 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-692581967 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4075/ -

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3922: [CARBONDATA-3983] SI compatability issue

2020-09-15 Thread GitBox
ShreelekhyaG commented on a change in pull request #3922: URL: https://github.com/apache/carbondata/pull/3922#discussion_r488507475 ## File path: core/src/main/java/org/apache/carbondata/core/scan/expression/conditional/ImplicitExpression.java ## @@ -59,13 +60,22 @@ public Imp

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3922: [CARBONDATA-3983] SI compatability issue

2020-09-15 Thread GitBox
akashrn5 commented on a change in pull request #3922: URL: https://github.com/apache/carbondata/pull/3922#discussion_r488507700 ## File path: core/src/main/java/org/apache/carbondata/core/scan/expression/conditional/ImplicitExpression.java ## @@ -59,13 +61,23 @@ public Implici

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3871: [CARBONDATA-3986] Fix multiple issues during compaction and concurrent scenarios

2020-09-15 Thread GitBox
akashrn5 commented on a change in pull request #3871: URL: https://github.com/apache/carbondata/pull/3871#discussion_r488503684 ## File path: core/src/main/java/org/apache/carbondata/core/writer/CarbonIndexFileMergeWriter.java ## @@ -233,15 +234,24 @@ public String writeMerge

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3919: [CARBONDATA-3980] Load fails with aborted exception when Bad records action is unspecified

2020-09-15 Thread GitBox
CarbonDataQA1 commented on pull request #3919: URL: https://github.com/apache/carbondata/pull/3919#issuecomment-692563259 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3928: [WIP]Fix DropCache log error when indexmap is null

2020-09-15 Thread GitBox
CarbonDataQA1 commented on pull request #3928: URL: https://github.com/apache/carbondata/pull/3928#issuecomment-692562664 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4072/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3928: [WIP]Fix DropCache log error when indexmap is null

2020-09-15 Thread GitBox
CarbonDataQA1 commented on pull request #3928: URL: https://github.com/apache/carbondata/pull/3928#issuecomment-692562871 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2333/

[GitHub] [carbondata] marchpure commented on a change in pull request #3917: [CARBONDATA-3978] Clean files refactor and added support for a trash folder where all the carbondata files will be copied t

2020-09-15 Thread GitBox
marchpure commented on a change in pull request #3917: URL: https://github.com/apache/carbondata/pull/3917#discussion_r488464250 ## File path: integration/spark/src/main/scala/org/apache/carbondata/cleanfiles/CleanFilesUtil.scala ## @@ -0,0 +1,259 @@ +/* + * Licensed to the Ap

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3921: [CARBONDATA-3928] Removed records from exception message.

2020-09-15 Thread GitBox
ajantha-bhat commented on a change in pull request #3921: URL: https://github.com/apache/carbondata/pull/3921#discussion_r488463308 ## File path: processing/src/main/java/org/apache/carbondata/processing/loading/converter/impl/RowConverterImpl.java ## @@ -119,10 +118,6 @@ publ

[GitHub] [carbondata] ajantha-bhat commented on pull request #3921: [CARBONDATA-3928] Removed records from exception message.

2020-09-15 Thread GitBox
ajantha-bhat commented on pull request #3921: URL: https://github.com/apache/carbondata/pull/3921#issuecomment-692538365 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [carbondata] nihal0107 commented on a change in pull request #3921: [CARBONDATA-3928] Removed records from exception message.

2020-09-15 Thread GitBox
nihal0107 commented on a change in pull request #3921: URL: https://github.com/apache/carbondata/pull/3921#discussion_r488461592 ## File path: processing/src/main/java/org/apache/carbondata/processing/loading/converter/impl/RowConverterImpl.java ## @@ -119,10 +118,6 @@ public

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3921: [CARBONDATA-3928] Removed records from exception message.

2020-09-15 Thread GitBox
ajantha-bhat commented on a change in pull request #3921: URL: https://github.com/apache/carbondata/pull/3921#discussion_r488454458 ## File path: processing/src/main/java/org/apache/carbondata/processing/loading/converter/impl/RowConverterImpl.java ## @@ -119,10 +118,6 @@ publ

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3919: [CARBONDATA-3980] Load fails with aborted exception when Bad records action is unspecified

2020-09-15 Thread GitBox
ajantha-bhat commented on a change in pull request #3919: URL: https://github.com/apache/carbondata/pull/3919#discussion_r488449175 ## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/standardpartition/StandardPartitionBadRecordLoggerTest.scala ###

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3919: [CARBONDATA-3980] Load fails with aborted exception when Bad records action is unspecified

2020-09-15 Thread GitBox
ajantha-bhat commented on a change in pull request #3919: URL: https://github.com/apache/carbondata/pull/3919#discussion_r488449347 ## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/standardpartition/StandardPartitionBadRecordLoggerTest.scala ###

[GitHub] [carbondata] jxxfxkp commented on pull request #3662: [TEMP] support prestosql 330 in carbon

2020-09-15 Thread GitBox
jxxfxkp commented on pull request #3662: URL: https://github.com/apache/carbondata/pull/3662#issuecomment-692525522 I 'm sure to cherry-pick this PR. Some Classes cannot find symbol (OrcFileWriterConfig->OrcWriterConfig,io.prestosql.plugin.hive->io.prestosql.plugin.hive.orc ...) ,Although

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3871: [CARBONDATA-3986] Fix multiple issues during compaction and concurrent scenarios

2020-09-15 Thread GitBox
ajantha-bhat commented on a change in pull request #3871: URL: https://github.com/apache/carbondata/pull/3871#discussion_r488444308 ## File path: processing/src/main/java/org/apache/carbondata/processing/loading/TableProcessingOperations.java ## @@ -64,45 +68,89 @@ public stat

[GitHub] [carbondata] Karan980 commented on pull request #3876: TestingCI

2020-09-15 Thread GitBox
Karan980 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-692516342 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea