Kejian-Li commented on a change in pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#discussion_r495430881
##
File path:
integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/iud/TestInsertAndOtherCommandConcurrent.scala
##
@@ -18,45 +18,
Kejian-Li commented on a change in pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#discussion_r495431398
##
File path:
integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/iud/TestInsertAndOtherCommandConcurrent.scala
##
@@ -18,34 +18,
Kejian-Li commented on a change in pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#discussion_r495431801
##
File path:
integration/spark/src/test/scala/org/apache/carbondata/view/timeseries/TestCreateMVWithTimeSeries.scala
##
@@ -33,17 +34,30 @@ class T
Kejian-Li commented on a change in pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#discussion_r495432034
##
File path:
integration/spark/src/test/scala/org/apache/carbondata/view/timeseries/TestCreateMVWithTimeSeries.scala
##
@@ -33,17 +34,30 @@ class T
Kejian-Li commented on a change in pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#discussion_r495432401
##
File path:
integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/iud/UpdateCarbonTableTestCase.scala
##
@@ -794,7 +795,31 @@ cla
Kejian-Li commented on a change in pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#discussion_r495432417
##
File path:
integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/iud/DeleteCarbonTableTestCase.scala
##
@@ -322,7 +321,32 @@ cla
marchpure commented on a change in pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#discussion_r495440288
##
File path:
integration/spark/src/test/scala/org/apache/carbondata/view/timeseries/TestCreateMVWithTimeSeries.scala
##
@@ -165,20 +180,32 @@ class
marchpure commented on a change in pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#discussion_r495441113
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/events/DeleteFromTableEventListener.scala
##
@@ -53,6 +53,12 @@ c
CarbonDataQA1 commented on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-699485704
Build Failed with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2483/
CarbonDataQA1 commented on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-699485934
Build Failed with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4227/
-
Klaus-xjp commented on a change in pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#discussion_r495454501
##
File path:
integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/iud/DeleteCarbonTableTestCase.scala
##
@@ -343,6 +342,31 @@ cla
Xingjun Hao created CARBONDATA-4014:
---
Summary: Support Change Column Comment
Key: CARBONDATA-4014
URL: https://issues.apache.org/jira/browse/CARBONDATA-4014
Project: CarbonData
Issue Type:
marchpure opened a new pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960
### Why is this PR needed?
Now, we support add column comment in "CREATE TABLE" and "ADD COLUMN". but
do not support alter comment of the column, which shall be support in 'CHANGE
COLUMN'
CarbonDataQA1 commented on pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#issuecomment-699526051
Build Failed with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4228/
-
CarbonDataQA1 commented on pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#issuecomment-699526651
Build Failed with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2484/
CarbonDataQA1 commented on pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#issuecomment-699538898
Build Failed with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4229/
-
CarbonDataQA1 commented on pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#issuecomment-699539414
Build Failed with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2485/
Kejian-Li commented on a change in pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#discussion_r495512523
##
File path:
integration/spark/src/test/scala/org/apache/carbondata/view/timeseries/TestCreateMVWithTimeSeries.scala
##
@@ -165,20 +180,32 @@ class
CarbonDataQA1 commented on pull request #3934:
URL: https://github.com/apache/carbondata/pull/3934#issuecomment-699575770
Build Failed with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2487/
CarbonDataQA1 commented on pull request #3934:
URL: https://github.com/apache/carbondata/pull/3934#issuecomment-699575847
Build Failed with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4231/
-
Kejian-Li commented on a change in pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#discussion_r495520319
##
File path:
integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/iud/TestInsertAndOtherCommandConcurrent.scala
##
@@ -18,45 +18,
Kejian-Li commented on a change in pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#discussion_r495520426
##
File path:
integration/spark/src/test/scala/org/apache/carbondata/view/timeseries/TestCreateMVWithTimeSeries.scala
##
@@ -167,18 +182,24 @@ class
Kejian-Li commented on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-699578575
> Consider a scenario that the user want to insert data and then update the
table, the dml commands are sent one by one in time series, but the 2nd(update)
cmd is sent by a
marchpure commented on a change in pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#discussion_r495521478
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonDropTableCommand.scala
##
@@ -82,8 +82,9 @@ case c
CarbonDataQA1 commented on pull request #3934:
URL: https://github.com/apache/carbondata/pull/3934#issuecomment-699578946
Build Failed with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2490/
Kejian-Li commented on a change in pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#discussion_r495521844
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonDropTableCommand.scala
##
@@ -82,8 +82,9 @@ case c
CarbonDataQA1 commented on pull request #3934:
URL: https://github.com/apache/carbondata/pull/3934#issuecomment-699579025
Build Failed with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4234/
-
CarbonDataQA1 commented on pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#issuecomment-699579525
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4230/
-
CarbonDataQA1 commented on pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#issuecomment-699580135
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2486/
Klaus-xjp commented on a change in pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#discussion_r495521329
##
File path:
integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/iud/DeleteCarbonTableTestCase.scala
##
@@ -26,15 +26,14 @@ impo
Kejian-Li commented on a change in pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#discussion_r495524053
##
File path:
integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/iud/DeleteCarbonTableTestCase.scala
##
@@ -26,15 +26,14 @@ impo
CarbonDataQA1 commented on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-699585268
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4233/
-
CarbonDataQA1 commented on pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#issuecomment-699585500
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4232/
-
CarbonDataQA1 commented on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-699585741
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2489/
CarbonDataQA1 commented on pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#issuecomment-699585739
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2488/
CarbonDataQA1 commented on pull request #3934:
URL: https://github.com/apache/carbondata/pull/3934#issuecomment-699587732
Build Failed with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4237/
-
CarbonDataQA1 commented on pull request #3934:
URL: https://github.com/apache/carbondata/pull/3934#issuecomment-699587843
Build Failed with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2493/
CarbonDataQA1 commented on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-699588047
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2492/
CarbonDataQA1 commented on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-699588340
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4236/
-
Klaus-xjp commented on pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#issuecomment-699594304
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Kejian-Li commented on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-699594833
@Zhangshunyu please help review this PR
This is an automated message from the Apache Git Service.
To respon
Zhangshunyu commented on a change in pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#discussion_r495537900
##
File path:
core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentStatusManager.java
##
@@ -874,9 +874,9 @@ private ValidAndInvalid
42 matches
Mail list logo